Re: [PATCH 2/2] [media] vb2: Add support for use_dma_bidirectional queue flag

2016-10-19 Thread Sakari Ailus
On Tue, Oct 18, 2016 at 06:08:53PM +0200, Thierry Escande wrote: > >#define vb2_dma_dir(q) \ ^ VB2_DMA_DIR(), as most of our other macros use capitals as well. -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk

Re: [PATCH 2/2] [media] vb2: Add support for use_dma_bidirectional queue flag

2016-10-19 Thread Sakari Ailus
On Tue, Oct 18, 2016 at 06:08:53PM +0200, Thierry Escande wrote: > >#define vb2_dma_dir(q) \ ^ VB2_DMA_DIR(), as most of our other macros use capitals as well. -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk

Re: [PATCH 2/2] [media] vb2: Add support for use_dma_bidirectional queue flag

2016-10-18 Thread Thierry Escande
Hi Sakari, On 17/10/2016 12:06, Sakari Ailus wrote: Hi Thierry, Thanks for the set. A few comments below. On Fri, Oct 14, 2016 at 02:08:14PM +0200, Thierry Escande wrote: From: Pawel Osciak When this flag is set for CAPTURE queues by the driver on calling

Re: [PATCH 2/2] [media] vb2: Add support for use_dma_bidirectional queue flag

2016-10-18 Thread Thierry Escande
Hi Sakari, On 17/10/2016 12:06, Sakari Ailus wrote: Hi Thierry, Thanks for the set. A few comments below. On Fri, Oct 14, 2016 at 02:08:14PM +0200, Thierry Escande wrote: From: Pawel Osciak When this flag is set for CAPTURE queues by the driver on calling vb2_queue_init(), it forces the

Re: [PATCH 2/2] [media] vb2: Add support for use_dma_bidirectional queue flag

2016-10-17 Thread Sakari Ailus
Hi Thierry, Thanks for the set. A few comments below. On Fri, Oct 14, 2016 at 02:08:14PM +0200, Thierry Escande wrote: > From: Pawel Osciak > > When this flag is set for CAPTURE queues by the driver on calling > vb2_queue_init(), it forces the buffers on the queue to be >

Re: [PATCH 2/2] [media] vb2: Add support for use_dma_bidirectional queue flag

2016-10-17 Thread Sakari Ailus
Hi Thierry, Thanks for the set. A few comments below. On Fri, Oct 14, 2016 at 02:08:14PM +0200, Thierry Escande wrote: > From: Pawel Osciak > > When this flag is set for CAPTURE queues by the driver on calling > vb2_queue_init(), it forces the buffers on the queue to be > allocated/mapped with

[PATCH 2/2] [media] vb2: Add support for use_dma_bidirectional queue flag

2016-10-14 Thread Thierry Escande
From: Pawel Osciak When this flag is set for CAPTURE queues by the driver on calling vb2_queue_init(), it forces the buffers on the queue to be allocated/mapped with DMA_BIDIRECTIONAL direction flag, instead of DMA_FROM_DEVICE. This allows the device not only to write to

[PATCH 2/2] [media] vb2: Add support for use_dma_bidirectional queue flag

2016-10-14 Thread Thierry Escande
From: Pawel Osciak When this flag is set for CAPTURE queues by the driver on calling vb2_queue_init(), it forces the buffers on the queue to be allocated/mapped with DMA_BIDIRECTIONAL direction flag, instead of DMA_FROM_DEVICE. This allows the device not only to write to the buffers, but also