Re: [PATCH 2/2] printk: Add boottime and real timestamps

2017-07-28 Thread Thomas Gleixner
On Fri, 28 Jul 2017, Prarit Bhargava wrote: > On 07/25/2017 09:00 AM, Peter Zijlstra wrote: > Thanks for the above change. I can see that makes the code simpler. > > > Although I must strongly discourage using REALTIME, DST will make > > untangling your logs an absolute nightmare. I would simply

Re: [PATCH 2/2] printk: Add boottime and real timestamps

2017-07-28 Thread Thomas Gleixner
On Fri, 28 Jul 2017, Prarit Bhargava wrote: > On 07/25/2017 09:00 AM, Peter Zijlstra wrote: > Thanks for the above change. I can see that makes the code simpler. > > > Although I must strongly discourage using REALTIME, DST will make > > untangling your logs an absolute nightmare. I would simply

Re: [PATCH 2/2] printk: Add boottime and real timestamps

2017-07-28 Thread Prarit Bhargava
On 07/25/2017 09:00 AM, Peter Zijlstra wrote: > On Tue, Jul 25, 2017 at 08:17:27AM -0400, Prarit Bhargava wrote: >> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug >> index 5b1662ec546f..6cd38a25f8ea 100644 >> --- a/lib/Kconfig.debug >> +++ b/lib/Kconfig.debug >> @@ -1,8 +1,8 @@ >> menu

Re: [PATCH 2/2] printk: Add boottime and real timestamps

2017-07-28 Thread Prarit Bhargava
On 07/25/2017 09:00 AM, Peter Zijlstra wrote: > On Tue, Jul 25, 2017 at 08:17:27AM -0400, Prarit Bhargava wrote: >> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug >> index 5b1662ec546f..6cd38a25f8ea 100644 >> --- a/lib/Kconfig.debug >> +++ b/lib/Kconfig.debug >> @@ -1,8 +1,8 @@ >> menu

Re: [PATCH 2/2] printk: Add boottime and real timestamps

2017-07-26 Thread kbuild test robot
Hi Prarit, [auto build test ERROR on linus/master] [also build test ERROR on v4.13-rc2] [cannot apply to next-20170726] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 2/2] printk: Add boottime and real timestamps

2017-07-26 Thread kbuild test robot
Hi Prarit, [auto build test ERROR on linus/master] [also build test ERROR on v4.13-rc2] [cannot apply to next-20170726] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 2/2] printk: Add boottime and real timestamps

2017-07-25 Thread Mark Salyzyn
On 07/25/2017 06:00 AM, Peter Zijlstra wrote: On Tue, Jul 25, 2017 at 08:17:27AM -0400, Prarit Bhargava wrote: diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 5b1662ec546f..6cd38a25f8ea 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1,8 +1,8 @@ menu "printk and dmesg

Re: [PATCH 2/2] printk: Add boottime and real timestamps

2017-07-25 Thread Mark Salyzyn
On 07/25/2017 06:00 AM, Peter Zijlstra wrote: On Tue, Jul 25, 2017 at 08:17:27AM -0400, Prarit Bhargava wrote: diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 5b1662ec546f..6cd38a25f8ea 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1,8 +1,8 @@ menu "printk and dmesg

Re: [PATCH 2/2] printk: Add boottime and real timestamps

2017-07-25 Thread Peter Zijlstra
On Tue, Jul 25, 2017 at 08:17:27AM -0400, Prarit Bhargava wrote: > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 5b1662ec546f..6cd38a25f8ea 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1,8 +1,8 @@ > menu "printk and dmesg options" > > config PRINTK_TIME > -

Re: [PATCH 2/2] printk: Add boottime and real timestamps

2017-07-25 Thread Peter Zijlstra
On Tue, Jul 25, 2017 at 08:17:27AM -0400, Prarit Bhargava wrote: > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 5b1662ec546f..6cd38a25f8ea 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1,8 +1,8 @@ > menu "printk and dmesg options" > > config PRINTK_TIME > -

[PATCH 2/2] printk: Add boottime and real timestamps

2017-07-25 Thread Prarit Bhargava
printk.time=1/CONFIG_PRINTK_TIME=Y timestamps printks with an unmodified hardware clock timestamp. This clock loses time each day making it difficult to determine when an issue has occurred in the kernel log. Modify printk.time to output local, monotonic, or a real timestamp. Modify the output

[PATCH 2/2] printk: Add boottime and real timestamps

2017-07-25 Thread Prarit Bhargava
printk.time=1/CONFIG_PRINTK_TIME=Y timestamps printks with an unmodified hardware clock timestamp. This clock loses time each day making it difficult to determine when an issue has occurred in the kernel log. Modify printk.time to output local, monotonic, or a real timestamp. Modify the output