Re: [PATCH 2/2] zram: gather statistics in a unique file

2013-02-11 Thread Nitin Gupta
On 02/11/2013 10:16 AM, Greg Kroah-Hartman wrote: On Mon, Feb 11, 2013 at 10:07:45AM -0800, Davidlohr Bueso wrote: On Sun, 2013-02-10 at 21:41 -0800, Greg Kroah-Hartman wrote: On Sun, Feb 10, 2013 at 08:29:06PM -0800, Davidlohr Bueso wrote: Instead of having one sysfs file per zram statistic,

Re: [PATCH 2/2] zram: gather statistics in a unique file

2013-02-11 Thread Greg Kroah-Hartman
On Mon, Feb 11, 2013 at 10:07:45AM -0800, Davidlohr Bueso wrote: > On Sun, 2013-02-10 at 21:41 -0800, Greg Kroah-Hartman wrote: > > On Sun, Feb 10, 2013 at 08:29:06PM -0800, Davidlohr Bueso wrote: > > > Instead of having one sysfs file per zram statistic, group them all > > > in a single,

Re: [PATCH 2/2] zram: gather statistics in a unique file

2013-02-11 Thread Davidlohr Bueso
On Sun, 2013-02-10 at 21:41 -0800, Greg Kroah-Hartman wrote: > On Sun, Feb 10, 2013 at 08:29:06PM -0800, Davidlohr Bueso wrote: > > Instead of having one sysfs file per zram statistic, group them all > > in a single, reader-friendly, 'statistics' file. This not only reduces > > code but is also

Re: [PATCH 2/2] zram: gather statistics in a unique file

2013-02-11 Thread Davidlohr Bueso
On Sun, 2013-02-10 at 21:41 -0800, Greg Kroah-Hartman wrote: On Sun, Feb 10, 2013 at 08:29:06PM -0800, Davidlohr Bueso wrote: Instead of having one sysfs file per zram statistic, group them all in a single, reader-friendly, 'statistics' file. This not only reduces code but is also makes it

Re: [PATCH 2/2] zram: gather statistics in a unique file

2013-02-11 Thread Greg Kroah-Hartman
On Mon, Feb 11, 2013 at 10:07:45AM -0800, Davidlohr Bueso wrote: On Sun, 2013-02-10 at 21:41 -0800, Greg Kroah-Hartman wrote: On Sun, Feb 10, 2013 at 08:29:06PM -0800, Davidlohr Bueso wrote: Instead of having one sysfs file per zram statistic, group them all in a single, reader-friendly,

Re: [PATCH 2/2] zram: gather statistics in a unique file

2013-02-11 Thread Nitin Gupta
On 02/11/2013 10:16 AM, Greg Kroah-Hartman wrote: On Mon, Feb 11, 2013 at 10:07:45AM -0800, Davidlohr Bueso wrote: On Sun, 2013-02-10 at 21:41 -0800, Greg Kroah-Hartman wrote: On Sun, Feb 10, 2013 at 08:29:06PM -0800, Davidlohr Bueso wrote: Instead of having one sysfs file per zram statistic,

Re: [PATCH 2/2] zram: gather statistics in a unique file

2013-02-10 Thread Greg Kroah-Hartman
On Sun, Feb 10, 2013 at 08:29:06PM -0800, Davidlohr Bueso wrote: > Instead of having one sysfs file per zram statistic, group them all > in a single, reader-friendly, 'statistics' file. This not only reduces > code but is also makes it easier to visualize. The new file looks like: > > Number of

Re: [PATCH 2/2] zram: gather statistics in a unique file

2013-02-10 Thread Davidlohr Bueso
Sorry, I forgot to include the updated ABI changes with this patch. Sending v2. On Sun, 2013-02-10 at 20:29 -0800, Davidlohr Bueso wrote: > Instead of having one sysfs file per zram statistic, group them all > in a single, reader-friendly, 'statistics' file. This not only reduces > code but is

[PATCH 2/2] zram: gather statistics in a unique file

2013-02-10 Thread Davidlohr Bueso
Instead of having one sysfs file per zram statistic, group them all in a single, reader-friendly, 'statistics' file. This not only reduces code but is also makes it easier to visualize. The new file looks like: Number of reads:24 Number of writes: 1055 Invalid IO: 0

[PATCH 2/2] zram: gather statistics in a unique file

2013-02-10 Thread Davidlohr Bueso
Instead of having one sysfs file per zram statistic, group them all in a single, reader-friendly, 'statistics' file. This not only reduces code but is also makes it easier to visualize. The new file looks like: Number of reads:24 Number of writes: 1055 Invalid IO: 0

Re: [PATCH 2/2] zram: gather statistics in a unique file

2013-02-10 Thread Davidlohr Bueso
Sorry, I forgot to include the updated ABI changes with this patch. Sending v2. On Sun, 2013-02-10 at 20:29 -0800, Davidlohr Bueso wrote: Instead of having one sysfs file per zram statistic, group them all in a single, reader-friendly, 'statistics' file. This not only reduces code but is also

Re: [PATCH 2/2] zram: gather statistics in a unique file

2013-02-10 Thread Greg Kroah-Hartman
On Sun, Feb 10, 2013 at 08:29:06PM -0800, Davidlohr Bueso wrote: Instead of having one sysfs file per zram statistic, group them all in a single, reader-friendly, 'statistics' file. This not only reduces code but is also makes it easier to visualize. The new file looks like: Number of reads: