Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-11-14 Thread Linus Walleij
On Wed, Nov 14, 2012 at 2:18 PM, Lee Jones wrote: > On Thu, 25 Oct 2012, Linus Walleij wrote: > >> On Thu, Oct 25, 2012 at 5:51 PM, Lee Jones wrote: >> > On Thu, 25 Oct 2012, Linus Walleij wrote: >> >> >> Probably some driver is needing a clk_get() or a clk_get_sys() is >> >> needs to be added

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-11-14 Thread Lee Jones
On Thu, 25 Oct 2012, Linus Walleij wrote: > On Thu, Oct 25, 2012 at 5:51 PM, Lee Jones wrote: > > On Thu, 25 Oct 2012, Linus Walleij wrote: > > >> Probably some driver is needing a clk_get() or a clk_get_sys() is > >> needs to be added somewhere to bring up some vital cluster, > >> or there may

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-11-14 Thread Lee Jones
On Thu, 25 Oct 2012, Linus Walleij wrote: On Thu, Oct 25, 2012 at 5:51 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 25 Oct 2012, Linus Walleij wrote: Probably some driver is needing a clk_get() or a clk_get_sys() is needs to be added somewhere to bring up some vital cluster, or

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-11-14 Thread Linus Walleij
On Wed, Nov 14, 2012 at 2:18 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 25 Oct 2012, Linus Walleij wrote: On Thu, Oct 25, 2012 at 5:51 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 25 Oct 2012, Linus Walleij wrote: Probably some driver is needing a clk_get() or a clk_get_sys()

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Linus Walleij
On Thu, Oct 25, 2012 at 5:51 PM, Lee Jones wrote: > On Thu, 25 Oct 2012, Linus Walleij wrote: >> Probably some driver is needing a clk_get() or a clk_get_sys() is >> needs to be added somewhere to bring up some vital cluster, >> or there may be some out-of-tree driver needed to bring up the >>

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Lee Jones
On Thu, 25 Oct 2012, Linus Walleij wrote: > On Thu, Oct 25, 2012 at 2:41 PM, Linus Walleij > wrote: > > On Wed, Oct 24, 2012 at 4:45 PM, Lee Jones wrote: > > > >> The clock framework has changed somewhat and it's now better to > >> invoke clock_prepare_enable() and clk_disable_unprepare()

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Linus Walleij
On Thu, Oct 25, 2012 at 2:41 PM, Linus Walleij wrote: > On Wed, Oct 24, 2012 at 4:45 PM, Lee Jones wrote: > >> The clock framework has changed somewhat and it's now better to >> invoke clock_prepare_enable() and clk_disable_unprepare() rather >> than the legacy clk_enable() and clk_disable()

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Lee Jones
On Thu, 25 Oct 2012, Linus Walleij wrote: > On Wed, Oct 24, 2012 at 4:45 PM, Lee Jones wrote: > > > The clock framework has changed somewhat and it's now better to > > invoke clock_prepare_enable() and clk_disable_unprepare() rather > > than the legacy clk_enable() and clk_disable() calls. This

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Linus Walleij
On Wed, Oct 24, 2012 at 4:45 PM, Lee Jones wrote: > The clock framework has changed somewhat and it's now better to > invoke clock_prepare_enable() and clk_disable_unprepare() rather > than the legacy clk_enable() and clk_disable() calls. This patch > converts the Nomadik Pin Control driver to

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Linus Walleij
On Thu, Oct 25, 2012 at 11:29 AM, Ulf Hansson wrote: > Depending on clock type, a clk_disable is actually not going to "gate" > the clock, that might happen only in unprepare. This depends on if the > clock is a fast or slow clock. Hm thats interesting. Now I need to drill down into this. So

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Linus Walleij
On Thu, Oct 25, 2012 at 10:23 AM, Lee Jones wrote: > On Thu, 25 Oct 2012, Linus Walleij wrote: >> >> Yeah drop it for now. > > Actually, a quick question before I do: > > If it's better/faster to prepare the clock and keep it prepared > while you do clk_enable/clk_disable, It is generally faster

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Lee Jones
On Thu, 25 Oct 2012, Ulf Hansson wrote: > On 25 October 2012 10:23, Lee Jones wrote: > > On Thu, 25 Oct 2012, Linus Walleij wrote: > > > >> On 10/25/2012 09:31 AM, Lee Jones wrote: > >> > > >> >This certainly doesn't fix the bug we spoke about. I believe Ulf > >> >is still working on that one. >

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Ulf Hansson
On 25 October 2012 10:23, Lee Jones wrote: > On Thu, 25 Oct 2012, Linus Walleij wrote: > >> On 10/25/2012 09:31 AM, Lee Jones wrote: >> > >> >This certainly doesn't fix the bug we spoke about. I believe Ulf >> >is still working on that one. >> > >> >So do you want me to remove this patch? >> > >>

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Lee Jones
On Thu, 25 Oct 2012, Linus Walleij wrote: > On 10/25/2012 09:31 AM, Lee Jones wrote: > > > >This certainly doesn't fix the bug we spoke about. I believe Ulf > >is still working on that one. > > > >So do you want me to remove this patch? > > > > Yeah drop it for now. Actually, a quick question

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Linus Walleij
On 10/25/2012 09:31 AM, Lee Jones wrote: This certainly doesn't fix the bug we spoke about. I believe Ulf is still working on that one. So do you want me to remove this patch? Yeah drop it for now. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Lee Jones
On Wed, 24 Oct 2012, Linus Walleij wrote: > On Wed, Oct 24, 2012 at 4:45 PM, Lee Jones wrote: > > > The clock framework has changed somewhat and it's now better to > > invoke clock_prepare_enable() and clk_disable_unprepare() rather > > than the legacy clk_enable() and clk_disable() calls. This

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Lee Jones
On Wed, 24 Oct 2012, Linus Walleij wrote: On Wed, Oct 24, 2012 at 4:45 PM, Lee Jones lee.jo...@linaro.org wrote: The clock framework has changed somewhat and it's now better to invoke clock_prepare_enable() and clk_disable_unprepare() rather than the legacy clk_enable() and clk_disable()

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Linus Walleij
On 10/25/2012 09:31 AM, Lee Jones wrote: This certainly doesn't fix the bug we spoke about. I believe Ulf is still working on that one. So do you want me to remove this patch? Yeah drop it for now. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Lee Jones
On Thu, 25 Oct 2012, Linus Walleij wrote: On 10/25/2012 09:31 AM, Lee Jones wrote: This certainly doesn't fix the bug we spoke about. I believe Ulf is still working on that one. So do you want me to remove this patch? Yeah drop it for now. Actually, a quick question before I do: If

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Ulf Hansson
On 25 October 2012 10:23, Lee Jones lee.jo...@linaro.org wrote: On Thu, 25 Oct 2012, Linus Walleij wrote: On 10/25/2012 09:31 AM, Lee Jones wrote: This certainly doesn't fix the bug we spoke about. I believe Ulf is still working on that one. So do you want me to remove this patch?

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Lee Jones
On Thu, 25 Oct 2012, Ulf Hansson wrote: On 25 October 2012 10:23, Lee Jones lee.jo...@linaro.org wrote: On Thu, 25 Oct 2012, Linus Walleij wrote: On 10/25/2012 09:31 AM, Lee Jones wrote: This certainly doesn't fix the bug we spoke about. I believe Ulf is still working on that one.

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Linus Walleij
On Thu, Oct 25, 2012 at 10:23 AM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 25 Oct 2012, Linus Walleij wrote: Yeah drop it for now. Actually, a quick question before I do: If it's better/faster to prepare the clock and keep it prepared while you do clk_enable/clk_disable, It is

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Linus Walleij
On Thu, Oct 25, 2012 at 11:29 AM, Ulf Hansson ulf.hans...@linaro.org wrote: Depending on clock type, a clk_disable is actually not going to gate the clock, that might happen only in unprepare. This depends on if the clock is a fast or slow clock. Hm thats interesting. Now I need to drill down

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Linus Walleij
On Wed, Oct 24, 2012 at 4:45 PM, Lee Jones lee.jo...@linaro.org wrote: The clock framework has changed somewhat and it's now better to invoke clock_prepare_enable() and clk_disable_unprepare() rather than the legacy clk_enable() and clk_disable() calls. This patch converts the Nomadik Pin

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Lee Jones
On Thu, 25 Oct 2012, Linus Walleij wrote: On Wed, Oct 24, 2012 at 4:45 PM, Lee Jones lee.jo...@linaro.org wrote: The clock framework has changed somewhat and it's now better to invoke clock_prepare_enable() and clk_disable_unprepare() rather than the legacy clk_enable() and clk_disable()

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Linus Walleij
On Thu, Oct 25, 2012 at 2:41 PM, Linus Walleij linus.wall...@linaro.org wrote: On Wed, Oct 24, 2012 at 4:45 PM, Lee Jones lee.jo...@linaro.org wrote: The clock framework has changed somewhat and it's now better to invoke clock_prepare_enable() and clk_disable_unprepare() rather than the

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Lee Jones
On Thu, 25 Oct 2012, Linus Walleij wrote: On Thu, Oct 25, 2012 at 2:41 PM, Linus Walleij linus.wall...@linaro.org wrote: On Wed, Oct 24, 2012 at 4:45 PM, Lee Jones lee.jo...@linaro.org wrote: The clock framework has changed somewhat and it's now better to invoke clock_prepare_enable()

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-25 Thread Linus Walleij
On Thu, Oct 25, 2012 at 5:51 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 25 Oct 2012, Linus Walleij wrote: Probably some driver is needing a clk_get() or a clk_get_sys() is needs to be added somewhere to bring up some vital cluster, or there may be some out-of-tree driver needed to

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-24 Thread Linus Walleij
On Wed, Oct 24, 2012 at 4:45 PM, Lee Jones wrote: > The clock framework has changed somewhat and it's now better to > invoke clock_prepare_enable() and clk_disable_unprepare() rather > than the legacy clk_enable() and clk_disable() calls. This patch > converts the Nomadik Pin Control driver to

[PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-24 Thread Lee Jones
The clock framework has changed somewhat and it's now better to invoke clock_prepare_enable() and clk_disable_unprepare() rather than the legacy clk_enable() and clk_disable() calls. This patch converts the Nomadik Pin Control driver to the new framework. Signed-off-by: Lee Jones ---

[PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-24 Thread Lee Jones
The clock framework has changed somewhat and it's now better to invoke clock_prepare_enable() and clk_disable_unprepare() rather than the legacy clk_enable() and clk_disable() calls. This patch converts the Nomadik Pin Control driver to the new framework. Signed-off-by: Lee Jones

Re: [PATCH 2/6] pinctrl: Update clock handling for the pinctrl-nomadik GPIO driver

2012-10-24 Thread Linus Walleij
On Wed, Oct 24, 2012 at 4:45 PM, Lee Jones lee.jo...@linaro.org wrote: The clock framework has changed somewhat and it's now better to invoke clock_prepare_enable() and clk_disable_unprepare() rather than the legacy clk_enable() and clk_disable() calls. This patch converts the Nomadik Pin