Re: [PATCH 3/6 v14] gpio: Add userland device interface to block GPIO

2013-01-24 Thread Alexander Stein
On Tuesday 22 January 2013 13:06:41, Roland Stigge wrote: > This patch adds a character device interface to the block GPIO system. > > Signed-off-by: Roland Stigge > --- > Documentation/ABI/testing/dev-gpioblock | 34 > drivers/gpio/gpiolib.c | 225 >

Re: [PATCH 3/6 v14] gpio: Add userland device interface to block GPIO

2013-01-24 Thread Alexander Stein
On Tuesday 22 January 2013 13:06:41, Roland Stigge wrote: This patch adds a character device interface to the block GPIO system. Signed-off-by: Roland Stigge sti...@antcom.de --- Documentation/ABI/testing/dev-gpioblock | 34 drivers/gpio/gpiolib.c | 225

Re: [PATCH 3/6 v14] gpio: Add userland device interface to block GPIO

2013-01-23 Thread Roland Stigge
On 23/01/13 02:03, Jonathan Corbet wrote: > On Tue, 22 Jan 2013 13:06:41 +0100 > Roland Stigge wrote: > >> This patch adds a character device interface to the block GPIO system. > > So I was looking at this, and a couple of things caught my eye... Good points you mentioned. Will address them

Re: [PATCH 3/6 v14] gpio: Add userland device interface to block GPIO

2013-01-23 Thread Roland Stigge
On 23/01/13 02:03, Jonathan Corbet wrote: On Tue, 22 Jan 2013 13:06:41 +0100 Roland Stigge sti...@antcom.de wrote: This patch adds a character device interface to the block GPIO system. So I was looking at this, and a couple of things caught my eye... Good points you mentioned. Will

Re: [PATCH 3/6 v14] gpio: Add userland device interface to block GPIO

2013-01-22 Thread Jonathan Corbet
On Tue, 22 Jan 2013 13:06:41 +0100 Roland Stigge wrote: > This patch adds a character device interface to the block GPIO system. So I was looking at this, and a couple of things caught my eye... > +static int gpio_block_fop_open(struct inode *in, struct file *f) > +{ > + int i; > +

[PATCH 3/6 v14] gpio: Add userland device interface to block GPIO

2013-01-22 Thread Roland Stigge
This patch adds a character device interface to the block GPIO system. Signed-off-by: Roland Stigge --- Documentation/ABI/testing/dev-gpioblock | 34 drivers/gpio/gpiolib.c | 225 +++- include/linux/gpio.h| 13 + 3 files

[PATCH 3/6 v14] gpio: Add userland device interface to block GPIO

2013-01-22 Thread Roland Stigge
This patch adds a character device interface to the block GPIO system. Signed-off-by: Roland Stigge sti...@antcom.de --- Documentation/ABI/testing/dev-gpioblock | 34 drivers/gpio/gpiolib.c | 225 +++- include/linux/gpio.h|

Re: [PATCH 3/6 v14] gpio: Add userland device interface to block GPIO

2013-01-22 Thread Jonathan Corbet
On Tue, 22 Jan 2013 13:06:41 +0100 Roland Stigge sti...@antcom.de wrote: This patch adds a character device interface to the block GPIO system. So I was looking at this, and a couple of things caught my eye... +static int gpio_block_fop_open(struct inode *in, struct file *f) +{ + int i;