Re: [PATCH 4/8] dmaengine: ste_dma40: Do not configure channels during an channel allocation

2013-04-14 Thread Rabin Vincent
2013/4/12 Lee Jones : > So I need to devise another way, as this function cannot be called > here either. Using the dmaengine API, allocating a channel and > configuring it are to be completed using different calls. Using the > API correctly, there is no way the driver can setup the channel > with

Re: [PATCH 4/8] dmaengine: ste_dma40: Do not configure channels during an channel allocation

2013-04-14 Thread Rabin Vincent
2013/4/12 Lee Jones lee.jo...@linaro.org: So I need to devise another way, as this function cannot be called here either. Using the dmaengine API, allocating a channel and configuring it are to be completed using different calls. Using the API correctly, there is no way the driver can setup

Re: [PATCH 4/8] dmaengine: ste_dma40: Do not configure channels during an channel allocation

2013-04-12 Thread Lee Jones
On Fri, 12 Apr 2013, Rabin Vincent wrote: > 2013/4/9 Lee Jones : > > diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c > > index 2a0a9d4..9e423ad 100644 > > --- a/drivers/dma/ste_dma40.c > > +++ b/drivers/dma/ste_dma40.c > > @@ -2463,16 +2463,10 @@ static int

Re: [PATCH 4/8] dmaengine: ste_dma40: Do not configure channels during an channel allocation

2013-04-12 Thread Rabin Vincent
2013/4/9 Lee Jones : > diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c > index 2a0a9d4..9e423ad 100644 > --- a/drivers/dma/ste_dma40.c > +++ b/drivers/dma/ste_dma40.c > @@ -2463,16 +2463,10 @@ static int d40_alloc_chan_resources(struct dma_chan > *chan) > } > >

Re: [PATCH 4/8] dmaengine: ste_dma40: Do not configure channels during an channel allocation

2013-04-12 Thread Rabin Vincent
2013/4/9 Lee Jones lee.jo...@linaro.org: diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c index 2a0a9d4..9e423ad 100644 --- a/drivers/dma/ste_dma40.c +++ b/drivers/dma/ste_dma40.c @@ -2463,16 +2463,10 @@ static int d40_alloc_chan_resources(struct dma_chan *chan) }

Re: [PATCH 4/8] dmaengine: ste_dma40: Do not configure channels during an channel allocation

2013-04-12 Thread Lee Jones
On Fri, 12 Apr 2013, Rabin Vincent wrote: 2013/4/9 Lee Jones lee.jo...@linaro.org: diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c index 2a0a9d4..9e423ad 100644 --- a/drivers/dma/ste_dma40.c +++ b/drivers/dma/ste_dma40.c @@ -2463,16 +2463,10 @@ static int

[PATCH 4/8] dmaengine: ste_dma40: Do not configure channels during an channel allocation

2013-04-09 Thread Lee Jones
According to the DMA documentation allocating a channel and configuring it are two separate actions. By removing the configuration code from the channel allocation path we lighten the burden on the information required to successfully allocate a channel. Cc: Vinod Koul Cc: Dan Williams Cc: Per

[PATCH 4/8] dmaengine: ste_dma40: Do not configure channels during an channel allocation

2013-04-09 Thread Lee Jones
According to the DMA documentation allocating a channel and configuring it are two separate actions. By removing the configuration code from the channel allocation path we lighten the burden on the information required to successfully allocate a channel. Cc: Vinod Koul vinod.k...@intel.com Cc: