Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-23 Thread Linus Walleij
On Tue, Apr 22, 2014 at 5:56 PM, Antoine Ténart wrote: > On Tue, Apr 22, 2014 at 02:52:10PM +0200, Linus Walleij wrote: >> On Fri, Apr 11, 2014 at 3:35 PM, Sebastian Hesselbarth >> wrote: >> > On 04/11/2014 02:37 PM, Antoine Ténart wrote: >> >> On Fri, Apr 11, 2014 at 11:03:48AM +0200, Sebastian

Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-23 Thread Linus Walleij
On Tue, Apr 22, 2014 at 5:56 PM, Antoine Ténart antoine.ten...@free-electrons.com wrote: On Tue, Apr 22, 2014 at 02:52:10PM +0200, Linus Walleij wrote: On Fri, Apr 11, 2014 at 3:35 PM, Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: On 04/11/2014 02:37 PM, Antoine Ténart wrote:

Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-22 Thread Antoine Ténart
Linus, On Tue, Apr 22, 2014 at 02:52:10PM +0200, Linus Walleij wrote: > On Fri, Apr 11, 2014 at 3:35 PM, Sebastian Hesselbarth > wrote: > > On 04/11/2014 02:37 PM, Antoine Ténart wrote: > >> On Fri, Apr 11, 2014 at 11:03:48AM +0200, Sebastian Hesselbarth wrote: > >>> On 04/10/2014 03:07 PM,

Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-22 Thread Linus Walleij
On Fri, Apr 11, 2014 at 3:35 PM, Sebastian Hesselbarth wrote: > On 04/11/2014 02:37 PM, Antoine Ténart wrote: >> On Fri, Apr 11, 2014 at 11:03:48AM +0200, Sebastian Hesselbarth wrote: >>> On 04/10/2014 03:07 PM, Antoine Ténart wrote: >>> Having said that, the above assumes that each function is

Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-22 Thread Linus Walleij
On Fri, Apr 11, 2014 at 3:35 PM, Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: On 04/11/2014 02:37 PM, Antoine Ténart wrote: On Fri, Apr 11, 2014 at 11:03:48AM +0200, Sebastian Hesselbarth wrote: On 04/10/2014 03:07 PM, Antoine Ténart wrote: Having said that, the above assumes

Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-22 Thread Antoine Ténart
Linus, On Tue, Apr 22, 2014 at 02:52:10PM +0200, Linus Walleij wrote: On Fri, Apr 11, 2014 at 3:35 PM, Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: On 04/11/2014 02:37 PM, Antoine Ténart wrote: On Fri, Apr 11, 2014 at 11:03:48AM +0200, Sebastian Hesselbarth wrote: On

Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-11 Thread Sebastian Hesselbarth
On 04/11/2014 02:37 PM, Antoine Ténart wrote: On Fri, Apr 11, 2014 at 11:03:48AM +0200, Sebastian Hesselbarth wrote: On 04/10/2014 03:07 PM, Antoine Ténart wrote: The Marvell Berlin boards have a group based pinmuxing mechanism. This driver adds the support for the BG2CD, BG2 and BG2Q. We

Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-11 Thread Antoine Ténart
Sebastian, On Fri, Apr 11, 2014 at 11:03:48AM +0200, Sebastian Hesselbarth wrote: > On 04/10/2014 03:07 PM, Antoine Ténart wrote: > >The Marvell Berlin boards have a group based pinmuxing mechanism. This > >driver adds the support for the BG2CD, BG2 and BG2Q. We actually do not > >need any

Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-11 Thread Antoine Ténart
Jisheng, On Fri, Apr 11, 2014 at 04:27:16PM +0800, Jisheng Zhang wrote: > Hi Antoine, > > On Fri, 11 Apr 2014 01:18:39 -0700 > Antoine Ténart wrote: > > > Hi Jisheng, > > > > On Fri, Apr 11, 2014 at 02:44:31PM +0800, Jisheng Zhang wrote: > > > On Thu, 10 Apr 2014 06:07:51 -0700 > > > Antoine

Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-11 Thread Sebastian Hesselbarth
On 04/10/2014 03:07 PM, Antoine Ténart wrote: The Marvell Berlin boards have a group based pinmuxing mechanism. This driver adds the support for the BG2CD, BG2 and BG2Q. We actually do not need any information about the pins here and only have the definition of the groups. Antoine, as always,

Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-11 Thread Jisheng Zhang
Hi Antoine, On Fri, 11 Apr 2014 01:18:39 -0700 Antoine Ténart wrote: > Hi Jisheng, > > On Fri, Apr 11, 2014 at 02:44:31PM +0800, Jisheng Zhang wrote: > > On Thu, 10 Apr 2014 06:07:51 -0700 > > Antoine Ténart wrote: > > > > ... > > > +static int berlin_pinmux_enable(struct pinctrl_dev

Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-11 Thread Antoine Ténart
Hi Jisheng, On Fri, Apr 11, 2014 at 02:44:31PM +0800, Jisheng Zhang wrote: > On Thu, 10 Apr 2014 06:07:51 -0700 > Antoine Ténart wrote: > > ... > > +static int berlin_pinmux_enable(struct pinctrl_dev *pctrl_dev, > > + unsigned function, > > +

Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-11 Thread Jisheng Zhang
Hi Antoine, On Thu, 10 Apr 2014 06:07:51 -0700 Antoine Ténart wrote: ... > +static int berlin_pinmux_enable(struct pinctrl_dev *pctrl_dev, > + unsigned function, > + unsigned group) > +{ > + struct berlin_pinctrl *pctrl =

Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-11 Thread Jisheng Zhang
Hi Antoine, On Thu, 10 Apr 2014 06:07:51 -0700 Antoine Ténart antoine.ten...@free-electrons.com wrote: ... +static int berlin_pinmux_enable(struct pinctrl_dev *pctrl_dev, + unsigned function, + unsigned group) +{ + struct

Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-11 Thread Antoine Ténart
Hi Jisheng, On Fri, Apr 11, 2014 at 02:44:31PM +0800, Jisheng Zhang wrote: On Thu, 10 Apr 2014 06:07:51 -0700 Antoine Ténart antoine.ten...@free-electrons.com wrote: ... +static int berlin_pinmux_enable(struct pinctrl_dev *pctrl_dev, + unsigned function, +

Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-11 Thread Jisheng Zhang
Hi Antoine, On Fri, 11 Apr 2014 01:18:39 -0700 Antoine Ténart antoine.ten...@free-electrons.com wrote: Hi Jisheng, On Fri, Apr 11, 2014 at 02:44:31PM +0800, Jisheng Zhang wrote: On Thu, 10 Apr 2014 06:07:51 -0700 Antoine Ténart antoine.ten...@free-electrons.com wrote: ... +static

Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-11 Thread Sebastian Hesselbarth
On 04/10/2014 03:07 PM, Antoine Ténart wrote: The Marvell Berlin boards have a group based pinmuxing mechanism. This driver adds the support for the BG2CD, BG2 and BG2Q. We actually do not need any information about the pins here and only have the definition of the groups. Antoine, as always,

Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-11 Thread Antoine Ténart
Jisheng, On Fri, Apr 11, 2014 at 04:27:16PM +0800, Jisheng Zhang wrote: Hi Antoine, On Fri, 11 Apr 2014 01:18:39 -0700 Antoine Ténart antoine.ten...@free-electrons.com wrote: Hi Jisheng, On Fri, Apr 11, 2014 at 02:44:31PM +0800, Jisheng Zhang wrote: On Thu, 10 Apr 2014 06:07:51

Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-11 Thread Antoine Ténart
Sebastian, On Fri, Apr 11, 2014 at 11:03:48AM +0200, Sebastian Hesselbarth wrote: On 04/10/2014 03:07 PM, Antoine Ténart wrote: The Marvell Berlin boards have a group based pinmuxing mechanism. This driver adds the support for the BG2CD, BG2 and BG2Q. We actually do not need any information

Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-11 Thread Sebastian Hesselbarth
On 04/11/2014 02:37 PM, Antoine Ténart wrote: On Fri, Apr 11, 2014 at 11:03:48AM +0200, Sebastian Hesselbarth wrote: On 04/10/2014 03:07 PM, Antoine Ténart wrote: The Marvell Berlin boards have a group based pinmuxing mechanism. This driver adds the support for the BG2CD, BG2 and BG2Q. We

[PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-10 Thread Antoine Ténart
The Marvell Berlin boards have a group based pinmuxing mechanism. This driver adds the support for the BG2CD, BG2 and BG2Q. We actually do not need any information about the pins here and only have the definition of the groups. Let's take the example of the uart0 pinmuxing on the BG2Q. Balls BK4

[PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs

2014-04-10 Thread Antoine Ténart
The Marvell Berlin boards have a group based pinmuxing mechanism. This driver adds the support for the BG2CD, BG2 and BG2Q. We actually do not need any information about the pins here and only have the definition of the groups. Let's take the example of the uart0 pinmuxing on the BG2Q. Balls BK4