Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-08-16 Thread Viresh Kumar
On 16-08-17, 12:42, Leonard Crestez wrote: > I reported the initial issue but did not have the time to do a more > thorough investigation, this is more complicated than it seems. I said > this before but maybe it got lost: > > I don't think the odd behavior I noticed justifies keeping the patch >

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-08-16 Thread Viresh Kumar
On 16-08-17, 12:42, Leonard Crestez wrote: > I reported the initial issue but did not have the time to do a more > thorough investigation, this is more complicated than it seems. I said > this before but maybe it got lost: > > I don't think the odd behavior I noticed justifies keeping the patch >

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-08-16 Thread Leonard Crestez
On Wed, 2017-08-16 at 12:04 +0530, Viresh Kumar wrote: > On 28-07-17, 10:58, Viresh Kumar wrote: > > > > At this point I really feel that this is a hardware specific problem > > and it was working by chance until now. And I am not sure if we > > shouldn't be stopping this patch from getting

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-08-16 Thread Leonard Crestez
On Wed, 2017-08-16 at 12:04 +0530, Viresh Kumar wrote: > On 28-07-17, 10:58, Viresh Kumar wrote: > > > > At this point I really feel that this is a hardware specific problem > > and it was working by chance until now. And I am not sure if we > > shouldn't be stopping this patch from getting

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-08-16 Thread Viresh Kumar
On 28-07-17, 10:58, Viresh Kumar wrote: > At this point I really feel that this is a hardware specific problem > and it was working by chance until now. And I am not sure if we > shouldn't be stopping this patch from getting merged just because of > that. > > At least you can teach your

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-08-16 Thread Viresh Kumar
On 28-07-17, 10:58, Viresh Kumar wrote: > At this point I really feel that this is a hardware specific problem > and it was working by chance until now. And I am not sure if we > shouldn't be stopping this patch from getting merged just because of > that. > > At least you can teach your

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-08-01 Thread Viresh Kumar
On 01-08-17, 20:48, Leonard Crestez wrote: > > > I found this by enabling the power:cpu_frequency tracepoint event and > > > checking for deltas with a script. Enabling CPU_FREQ_STAT show this: > > > > > > time_in_state: > > > > > > 396000 1609 > > So we still stay at the lowest frequency most

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-08-01 Thread Viresh Kumar
On 01-08-17, 20:48, Leonard Crestez wrote: > > > I found this by enabling the power:cpu_frequency tracepoint event and > > > checking for deltas with a script. Enabling CPU_FREQ_STAT show this: > > > > > > time_in_state: > > > > > > 396000 1609 > > So we still stay at the lowest frequency most

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-08-01 Thread Leonard Crestez
On Fri, 2017-07-28 at 10:58 +0530, Viresh Kumar wrote: > On 27-07-17, 19:54, Leonard Crestez wrote: > > On Wed, 2017-07-26 at 11:36 +0530, Viresh Kumar wrote: > > > Without this patch the sampling rate of ondemand governor will be 109 > > > ms. And after this patch it would be capped at 10 ms. Why

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-08-01 Thread Leonard Crestez
On Fri, 2017-07-28 at 10:58 +0530, Viresh Kumar wrote: > On 27-07-17, 19:54, Leonard Crestez wrote: > > On Wed, 2017-07-26 at 11:36 +0530, Viresh Kumar wrote: > > > Without this patch the sampling rate of ondemand governor will be 109 > > > ms. And after this patch it would be capped at 10 ms. Why

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-07-27 Thread Viresh Kumar
+ IMX maintainers. On 27-07-17, 19:54, Leonard Crestez wrote: > On Wed, 2017-07-26 at 11:36 +0530, Viresh Kumar wrote: > > - Find how much time does it really take to change the frequency of > >   the CPU. I don't really thing 109 us is the right transition > >   latency. Use attached patch for

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-07-27 Thread Viresh Kumar
+ IMX maintainers. On 27-07-17, 19:54, Leonard Crestez wrote: > On Wed, 2017-07-26 at 11:36 +0530, Viresh Kumar wrote: > > - Find how much time does it really take to change the frequency of > >   the CPU. I don't really thing 109 us is the right transition > >   latency. Use attached patch for

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-07-27 Thread Leonard Crestez
On Wed, 2017-07-26 at 11:36 +0530, Viresh Kumar wrote: > On 25-07-17, 14:54, Leonard Crestez wrote: > > This patch made it's way into linux-next and it seems to cause imx socs > > to almost always hang around their max frequency with the ondemand > > governor, even when almost completely idle.

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-07-27 Thread Leonard Crestez
On Wed, 2017-07-26 at 11:36 +0530, Viresh Kumar wrote: > On 25-07-17, 14:54, Leonard Crestez wrote: > > This patch made it's way into linux-next and it seems to cause imx socs > > to almost always hang around their max frequency with the ondemand > > governor, even when almost completely idle.

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-07-26 Thread Viresh Kumar
On 25-07-17, 14:54, Leonard Crestez wrote: Thanks for reporting Leonard, really appreciate it. > This patch made it's way into linux-next and it seems to cause imx socs > to almost always hang around their max frequency with the ondemand > governor, even when almost completely idle. The lowest

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-07-26 Thread Viresh Kumar
On 25-07-17, 14:54, Leonard Crestez wrote: Thanks for reporting Leonard, really appreciate it. > This patch made it's way into linux-next and it seems to cause imx socs > to almost always hang around their max frequency with the ondemand > governor, even when almost completely idle. The lowest

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-07-25 Thread Rafael J. Wysocki
On Tuesday, July 25, 2017 02:54:46 PM Leonard Crestez wrote: > On Wed, 2017-07-19 at 15:42 +0530, Viresh Kumar wrote: > > If transition_delay_us isn't defined by the cpufreq driver, the default > > value of transition delay (time after which the cpufreq governor will > > try updating the frequency

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-07-25 Thread Rafael J. Wysocki
On Tuesday, July 25, 2017 02:54:46 PM Leonard Crestez wrote: > On Wed, 2017-07-19 at 15:42 +0530, Viresh Kumar wrote: > > If transition_delay_us isn't defined by the cpufreq driver, the default > > value of transition delay (time after which the cpufreq governor will > > try updating the frequency

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-07-25 Thread Leonard Crestez
On Wed, 2017-07-19 at 15:42 +0530, Viresh Kumar wrote: > If transition_delay_us isn't defined by the cpufreq driver, the default > value of transition delay (time after which the cpufreq governor will > try updating the frequency again) is currently calculated by multiplying > transition_latency

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-07-25 Thread Leonard Crestez
On Wed, 2017-07-19 at 15:42 +0530, Viresh Kumar wrote: > If transition_delay_us isn't defined by the cpufreq driver, the default > value of transition delay (time after which the cpufreq governor will > try updating the frequency again) is currently calculated by multiplying > transition_latency

[PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-07-19 Thread Viresh Kumar
If transition_delay_us isn't defined by the cpufreq driver, the default value of transition delay (time after which the cpufreq governor will try updating the frequency again) is currently calculated by multiplying transition_latency (nsec) with LATENCY_MULTIPLIER (1000) and then converting this

[PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

2017-07-19 Thread Viresh Kumar
If transition_delay_us isn't defined by the cpufreq driver, the default value of transition delay (time after which the cpufreq governor will try updating the frequency again) is currently calculated by multiplying transition_latency (nsec) with LATENCY_MULTIPLIER (1000) and then converting this