Re: [PATCH V4 REPOST 2/2] kbuild: run the pre-processor on *.dts files

2012-10-27 Thread Stephen Warren
On 10/27/2012 07:06 PM, Rob Herring wrote: > Mark Brown wrote: > > On Fri, Oct 26, 2012 at 02:57:50PM -0500, Rob Herring wrote: > > Like I said previously, I think we first need guidelines on what > is and > isn't acceptable use of C preprocessor in dts files. > >

Re: [PATCH V4 REPOST 2/2] kbuild: run the pre-processor on *.dts files

2012-10-27 Thread Mark Brown
On Fri, Oct 26, 2012 at 02:57:50PM -0500, Rob Herring wrote: > Like I said previously, I think we first need guidelines on what is and > isn't acceptable use of C preprocessor in dts files. Didn't we already say that it was just the same rules as for things tht get included in .S files? Besides

Re: [PATCH V4 REPOST 2/2] kbuild: run the pre-processor on *.dts files

2012-10-27 Thread Mark Brown
On Fri, Oct 26, 2012 at 02:57:50PM -0500, Rob Herring wrote: Like I said previously, I think we first need guidelines on what is and isn't acceptable use of C preprocessor in dts files. Didn't we already say that it was just the same rules as for things tht get included in .S files? Besides

Re: [PATCH V4 REPOST 2/2] kbuild: run the pre-processor on *.dts files

2012-10-27 Thread Stephen Warren
On 10/27/2012 07:06 PM, Rob Herring wrote: Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Fri, Oct 26, 2012 at 02:57:50PM -0500, Rob Herring wrote: Like I said previously, I think we first need guidelines on what is and isn't acceptable use of C

Re: [PATCH V4 REPOST 2/2] kbuild: run the pre-processor on *.dts files

2012-10-26 Thread Rob Herring
On 10/26/2012 02:29 PM, Stephen Warren wrote: > From: Stephen Warren > > Modify cmd_dtc to run the C pre-processor on the input .dts file before > passing it to dtc for final compilation. This allows the use of #define > and #include within the .dts file. While this change is small the

[PATCH V4 REPOST 2/2] kbuild: run the pre-processor on *.dts files

2012-10-26 Thread Stephen Warren
From: Stephen Warren Modify cmd_dtc to run the C pre-processor on the input .dts file before passing it to dtc for final compilation. This allows the use of #define and #include within the .dts file. Signed-off-by: Stephen Warren --- v4: * Use -x assembler-with-cpp so pre-defined macros are

[PATCH V4 REPOST 2/2] kbuild: run the pre-processor on *.dts files

2012-10-26 Thread Stephen Warren
From: Stephen Warren swar...@nvidia.com Modify cmd_dtc to run the C pre-processor on the input .dts file before passing it to dtc for final compilation. This allows the use of #define and #include within the .dts file. Signed-off-by: Stephen Warren swar...@nvidia.com --- v4: * Use -x

Re: [PATCH V4 REPOST 2/2] kbuild: run the pre-processor on *.dts files

2012-10-26 Thread Rob Herring
On 10/26/2012 02:29 PM, Stephen Warren wrote: From: Stephen Warren swar...@nvidia.com Modify cmd_dtc to run the C pre-processor on the input .dts file before passing it to dtc for final compilation. This allows the use of #define and #include within the .dts file. While this change is small