Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-05-29 Thread Andrew Lunn
> I want to see each ports behind the bridge as independent ethernet > devices. If I understand RTFM only devlink may expose this > configuration. DSA and switchdev in general gives you a linux interface per user switch port. So you can see each interface, get stats, ethtools, mii-tool, etc per

Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-05-29 Thread Andrew Lunn
> I want to see each ports behind the bridge as independent ethernet > devices. If I understand RTFM only devlink may expose this > configuration. DSA and switchdev in general gives you a linux interface per user switch port. So you can see each interface, get stats, ethtools, mii-tool, etc per

Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-05-29 Thread Andrey Melnikov
2017-05-26 8:54 GMT+03:00 Florian Fainelli : > On May 24, 2017 4:17:39 AM PDT, "Andrey Jr. Melnikov" > wrote: >>In gmane.linux.kernel sean.w...@mediatek.com wrote: >>> From: Sean Wang >> >>> MT7530 is a 7-ports Gigabit Ethernet

Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-05-29 Thread Andrey Melnikov
2017-05-26 8:54 GMT+03:00 Florian Fainelli : > On May 24, 2017 4:17:39 AM PDT, "Andrey Jr. Melnikov" > wrote: >>In gmane.linux.kernel sean.w...@mediatek.com wrote: >>> From: Sean Wang >> >>> MT7530 is a 7-ports Gigabit Ethernet Switch that could be found on >>> Mediatek router platforms such as

Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-05-25 Thread Florian Fainelli
On May 24, 2017 4:17:39 AM PDT, "Andrey Jr. Melnikov" wrote: >In gmane.linux.kernel sean.w...@mediatek.com wrote: >> From: Sean Wang > >> MT7530 is a 7-ports Gigabit Ethernet Switch that could be found on >> Mediatek router platforms such as MT7623A

Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-05-25 Thread Florian Fainelli
On May 24, 2017 4:17:39 AM PDT, "Andrey Jr. Melnikov" wrote: >In gmane.linux.kernel sean.w...@mediatek.com wrote: >> From: Sean Wang > >> MT7530 is a 7-ports Gigabit Ethernet Switch that could be found on >> Mediatek router platforms such as MT7623A or MT7623N platform which >> includes 7-port

Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-05-24 Thread Andrey Melnikov
2017-05-24 16:20 GMT+03:00 Andrew Lunn : >> What about JUMBO frames and large MTU support? devlink support? > > To get the driver merged, it is better to start small, a minimal set > of features. Other features can be added later. If these features are > important to you, please

Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-05-24 Thread Andrey Melnikov
2017-05-24 16:20 GMT+03:00 Andrew Lunn : >> What about JUMBO frames and large MTU support? devlink support? > > To get the driver merged, it is better to start small, a minimal set > of features. Other features can be added later. If these features are > important to you, please feel free to

Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-05-24 Thread Andrew Lunn
> What about JUMBO frames and large MTU support? devlink support? To get the driver merged, it is better to start small, a minimal set of features. Other features can be added later. If these features are important to you, please feel free to submit patches. Andrew

Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-05-24 Thread Andrew Lunn
> What about JUMBO frames and large MTU support? devlink support? To get the driver merged, it is better to start small, a minimal set of features. Other features can be added later. If these features are important to you, please feel free to submit patches. Andrew

Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-05-24 Thread Andrey Jr. Melnikov
In gmane.linux.kernel sean.w...@mediatek.com wrote: > From: Sean Wang > MT7530 is a 7-ports Gigabit Ethernet Switch that could be found on > Mediatek router platforms such as MT7623A or MT7623N platform which > includes 7-port Gigabit Ethernet MAC and 5-port Gigabit

Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-05-24 Thread Andrey Jr. Melnikov
In gmane.linux.kernel sean.w...@mediatek.com wrote: > From: Sean Wang > MT7530 is a 7-ports Gigabit Ethernet Switch that could be found on > Mediatek router platforms such as MT7623A or MT7623N platform which > includes 7-port Gigabit Ethernet MAC and 5-port Gigabit Ethernet PHY. > Among these

Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-04-02 Thread kbuild test robot
Hi Sean, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/sean-wang-mediatek-com/net-next-dsa-add-Mediatek-MT7530-support/20170330-135532 config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 4.9.0 reproduce: wget

Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-04-02 Thread kbuild test robot
Hi Sean, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/sean-wang-mediatek-com/net-next-dsa-add-Mediatek-MT7530-support/20170330-135532 config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 4.9.0 reproduce: wget

Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-04-02 Thread kbuild test robot
Hi Sean, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/sean-wang-mediatek-com/net-next-dsa-add-Mediatek-MT7530-support/20170330-135532 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705

Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-04-02 Thread kbuild test robot
Hi Sean, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/sean-wang-mediatek-com/net-next-dsa-add-Mediatek-MT7530-support/20170330-135532 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705

Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-03-29 Thread Andrew Lunn
> +static struct mt7530_priv *lpriv; Hi Sean Why do you need this global variable? What if somebody has two switches connected? > +static void mt7530_port_disable(struct dsa_switch *ds, int port, > + struct phy_device *phy); > +static int

Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-03-29 Thread Andrew Lunn
> +static struct mt7530_priv *lpriv; Hi Sean Why do you need this global variable? What if somebody has two switches connected? > +static void mt7530_port_disable(struct dsa_switch *ds, int port, > + struct phy_device *phy); > +static int

[PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-03-29 Thread sean.wang
From: Sean Wang MT7530 is a 7-ports Gigabit Ethernet Switch that could be found on Mediatek router platforms such as MT7623A or MT7623N platform which includes 7-port Gigabit Ethernet MAC and 5-port Gigabit Ethernet PHY. Among these ports, The port from 0 to 4 are the

[PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-03-29 Thread sean.wang
From: Sean Wang MT7530 is a 7-ports Gigabit Ethernet Switch that could be found on Mediatek router platforms such as MT7623A or MT7623N platform which includes 7-port Gigabit Ethernet MAC and 5-port Gigabit Ethernet PHY. Among these ports, The port from 0 to 4 are the user ports connecting with