Re: [PATCH v11] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2014-02-24 Thread delicious quinoa
On Mon, Feb 24, 2014 at 6:20 AM, Linus Walleij wrote: > On Wed, Feb 12, 2014 at 5:17 PM, delicious quinoa > wrote: > >> I am wondering about the change in usage of >> irq_find_mapping/irq_create_mapping. It seems like all the GPIO >> drivers that use irq domains do it the way I was doing it > >

Re: [PATCH v11] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2014-02-24 Thread Linus Walleij
On Wed, Feb 12, 2014 at 5:17 PM, delicious quinoa wrote: > I am wondering about the change in usage of > irq_find_mapping/irq_create_mapping. It seems like all the GPIO > drivers that use irq domains do it the way I was doing it It is a well known problems that the kernel contain many bad

Re: [PATCH v11] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2014-02-24 Thread Linus Walleij
On Wed, Feb 12, 2014 at 5:17 PM, delicious quinoa delicious.qui...@gmail.com wrote: I am wondering about the change in usage of irq_find_mapping/irq_create_mapping. It seems like all the GPIO drivers that use irq domains do it the way I was doing it It is a well known problems that the

Re: [PATCH v11] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2014-02-24 Thread delicious quinoa
On Mon, Feb 24, 2014 at 6:20 AM, Linus Walleij linus.wall...@linaro.org wrote: On Wed, Feb 12, 2014 at 5:17 PM, delicious quinoa delicious.qui...@gmail.com wrote: I am wondering about the change in usage of irq_find_mapping/irq_create_mapping. It seems like all the GPIO drivers that use irq

Re: [PATCH v11] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2014-02-12 Thread delicious quinoa
On Mon, Feb 10, 2014 at 5:06 AM, Linus Walleij wrote: > Hi Alan, this is starting to look good. I's like an ACK from a DT > maintainer on the bindings but can't see anything really controversial > about them. > > On Thu, Feb 6, 2014 at 11:06 PM, Alan Tull wrote: > >> +static int

Re: [PATCH v11] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2014-02-12 Thread delicious quinoa
On Mon, Feb 10, 2014 at 5:06 AM, Linus Walleij linus.wall...@linaro.org wrote: Hi Alan, this is starting to look good. I's like an ACK from a DT maintainer on the bindings but can't see anything really controversial about them. On Thu, Feb 6, 2014 at 11:06 PM, Alan Tull

Re: [PATCH v11] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2014-02-10 Thread Linus Walleij
Hi Alan, this is starting to look good. I's like an ACK from a DT maintainer on the bindings but can't see anything really controversial about them. On Thu, Feb 6, 2014 at 11:06 PM, Alan Tull wrote: > +static int dwapb_gpio_to_irq(struct gpio_chip *gc, unsigned offset) > +{ > + struct

Re: [PATCH v11] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2014-02-10 Thread Linus Walleij
Hi Alan, this is starting to look good. I's like an ACK from a DT maintainer on the bindings but can't see anything really controversial about them. On Thu, Feb 6, 2014 at 11:06 PM, Alan Tull delicious.qui...@gmail.com wrote: +static int dwapb_gpio_to_irq(struct gpio_chip *gc, unsigned offset)

[PATCH v11] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2014-02-06 Thread Alan Tull
From: Jamie Iles The Synopsys DesignWare block is used in some ARM devices (picoxcell) and can be configured to provide multiple banks of GPIO pins. Signed-off-by: Jamie Iles Signed-off-by: Alan Tull Reviewed-by: Sebastian Hesselbarth v11: - Use NULL when checking existence of 'interrupts'

[PATCH v11] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2014-02-06 Thread Alan Tull
From: Jamie Iles ja...@jamieiles.com The Synopsys DesignWare block is used in some ARM devices (picoxcell) and can be configured to provide multiple banks of GPIO pins. Signed-off-by: Jamie Iles ja...@jamieiles.com Signed-off-by: Alan Tull at...@altera.com Reviewed-by: Sebastian Hesselbarth