Re: [PATCH v2 10/14] dma: edma: Simplify direction configuration in edma_config_pset()

2014-04-11 Thread Joel Fernandes
On 04/11/2014 01:39 AM, Peter Ujfalusi wrote: > On 04/11/2014 01:40 AM, Joel Fernandes wrote: >> On 04/01/2014 08:06 AM, Peter Ujfalusi wrote: >>> We only support DEV_TO_MEM or MEM_TO_DEV directions with edma driver and the >>> check for the direction has been already done in the function calling

Re: [PATCH v2 10/14] dma: edma: Simplify direction configuration in edma_config_pset()

2014-04-11 Thread Peter Ujfalusi
On 04/11/2014 01:40 AM, Joel Fernandes wrote: > On 04/01/2014 08:06 AM, Peter Ujfalusi wrote: >> We only support DEV_TO_MEM or MEM_TO_DEV directions with edma driver and the >> check for the direction has been already done in the function calling >> edma_config_pset(). >> The error reporting is

Re: [PATCH v2 10/14] dma: edma: Simplify direction configuration in edma_config_pset()

2014-04-11 Thread Peter Ujfalusi
On 04/11/2014 01:40 AM, Joel Fernandes wrote: On 04/01/2014 08:06 AM, Peter Ujfalusi wrote: We only support DEV_TO_MEM or MEM_TO_DEV directions with edma driver and the check for the direction has been already done in the function calling edma_config_pset(). The error reporting is redundant

Re: [PATCH v2 10/14] dma: edma: Simplify direction configuration in edma_config_pset()

2014-04-11 Thread Joel Fernandes
On 04/11/2014 01:39 AM, Peter Ujfalusi wrote: On 04/11/2014 01:40 AM, Joel Fernandes wrote: On 04/01/2014 08:06 AM, Peter Ujfalusi wrote: We only support DEV_TO_MEM or MEM_TO_DEV directions with edma driver and the check for the direction has been already done in the function calling

Re: [PATCH v2 10/14] dma: edma: Simplify direction configuration in edma_config_pset()

2014-04-10 Thread Joel Fernandes
On 04/01/2014 08:06 AM, Peter Ujfalusi wrote: > We only support DEV_TO_MEM or MEM_TO_DEV directions with edma driver and the > check for the direction has been already done in the function calling > edma_config_pset(). > The error reporting is redundant and also the "else if ()" can be removed. >

Re: [PATCH v2 10/14] dma: edma: Simplify direction configuration in edma_config_pset()

2014-04-10 Thread Joel Fernandes
On 04/01/2014 08:06 AM, Peter Ujfalusi wrote: We only support DEV_TO_MEM or MEM_TO_DEV directions with edma driver and the check for the direction has been already done in the function calling edma_config_pset(). The error reporting is redundant and also the else if () can be removed. NAK.

[PATCH v2 10/14] dma: edma: Simplify direction configuration in edma_config_pset()

2014-04-01 Thread Peter Ujfalusi
We only support DEV_TO_MEM or MEM_TO_DEV directions with edma driver and the check for the direction has been already done in the function calling edma_config_pset(). The error reporting is redundant and also the "else if ()" can be removed. Signed-off-by: Peter Ujfalusi --- drivers/dma/edma.c

[PATCH v2 10/14] dma: edma: Simplify direction configuration in edma_config_pset()

2014-04-01 Thread Peter Ujfalusi
We only support DEV_TO_MEM or MEM_TO_DEV directions with edma driver and the check for the direction has been already done in the function calling edma_config_pset(). The error reporting is redundant and also the else if () can be removed. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com ---