Re: [PATCH v2 2/2] ASoC: rockchip: separate pinctrl pins from each other

2017-08-22 Thread Rob Herring
On Mon, Aug 21, 2017 at 04:25:07PM +0800, Sugar Zhang wrote: > pdm sdi0~3 pins are optional, for example, if 4ch required, > only sdi0~1 need to be enabled. > > Signed-off-by: Sugar Zhang > --- > > Changes in v2: None > >

Re: [PATCH v2 2/2] ASoC: rockchip: separate pinctrl pins from each other

2017-08-22 Thread Rob Herring
On Mon, Aug 21, 2017 at 04:25:07PM +0800, Sugar Zhang wrote: > pdm sdi0~3 pins are optional, for example, if 4ch required, > only sdi0~1 need to be enabled. > > Signed-off-by: Sugar Zhang > --- > > Changes in v2: None > > Documentation/devicetree/bindings/sound/rockchip,pdm.txt | 7 +-- >

Re: [PATCH v2 2/2] ASoC: rockchip: separate pinctrl pins from each other

2017-08-22 Thread Heiko Stuebner
Am Montag, 21. August 2017, 16:25:07 CEST schrieb Sugar Zhang: > pdm sdi0~3 pins are optional, for example, if 4ch required, > only sdi0~1 need to be enabled. > > Signed-off-by: Sugar Zhang Reviewed-by: Heiko Stuebner But you might want to adapt

Re: [PATCH v2 2/2] ASoC: rockchip: separate pinctrl pins from each other

2017-08-22 Thread Heiko Stuebner
Am Montag, 21. August 2017, 16:25:07 CEST schrieb Sugar Zhang: > pdm sdi0~3 pins are optional, for example, if 4ch required, > only sdi0~1 need to be enabled. > > Signed-off-by: Sugar Zhang Reviewed-by: Heiko Stuebner But you might want to adapt the subject a bit and include that you're

[PATCH v2 2/2] ASoC: rockchip: separate pinctrl pins from each other

2017-08-21 Thread Sugar Zhang
pdm sdi0~3 pins are optional, for example, if 4ch required, only sdi0~1 need to be enabled. Signed-off-by: Sugar Zhang --- Changes in v2: None Documentation/devicetree/bindings/sound/rockchip,pdm.txt | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-)

[PATCH v2 2/2] ASoC: rockchip: separate pinctrl pins from each other

2017-08-21 Thread Sugar Zhang
pdm sdi0~3 pins are optional, for example, if 4ch required, only sdi0~1 need to be enabled. Signed-off-by: Sugar Zhang --- Changes in v2: None Documentation/devicetree/bindings/sound/rockchip,pdm.txt | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git