Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2014-01-20 Thread Sebastian Reichel
On Mon, Jan 20, 2014 at 10:21:29AM +, Russell King - ARM Linux wrote: > And another one using that evil mail-followup-to header: > > Mail-Followup-To: Pali Rohár , > Anton Vorontsov , > Michael Trimarchi , > David Woodhouse , > Tony Lindgren , > Russell

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2014-01-20 Thread Russell King - ARM Linux
And another one using that evil mail-followup-to header: Mail-Followup-To: Pali Rohár , Anton Vorontsov , Michael Trimarchi , David Woodhouse , Tony Lindgren , Russell King , linux-kernel@vger.kernel.org, Linux OMAP Mailing List ,

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2014-01-20 Thread Russell King - ARM Linux
And another one using that evil mail-followup-to header: Mail-Followup-To: Pali Rohár pali.ro...@gmail.com, Anton Vorontsov an...@enomsg.org, Michael Trimarchi mich...@amarulasolutions.com, David Woodhouse dw...@infradead.org, Tony Lindgren t...@atomide.com,

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2014-01-20 Thread Sebastian Reichel
On Mon, Jan 20, 2014 at 10:21:29AM +, Russell King - ARM Linux wrote: And another one using that evil mail-followup-to header: Mail-Followup-To: Pali Rohár pali.ro...@gmail.com, Anton Vorontsov an...@enomsg.org, Michael Trimarchi mich...@amarulasolutions.com,

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2014-01-19 Thread Michael Trimarchi
Hi On Sun, Jan 19, 2014 at 9:54 PM, Sebastian Reichel wrote: > On Mon, Dec 02, 2013 at 02:45:06AM +0100, Michael Trimarchi wrote: >> On Mon, Dec 2, 2013 at 1:24 AM, Anton Vorontsov wrote: >> > On Mon, Dec 02, 2013 at 01:02:40AM +0100, Michael Trimarchi wrote: >> >> On Sun, Dec 1, 2013 at 11:37

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2014-01-19 Thread Sebastian Reichel
On Mon, Dec 02, 2013 at 02:45:06AM +0100, Michael Trimarchi wrote: > On Mon, Dec 2, 2013 at 1:24 AM, Anton Vorontsov wrote: > > On Mon, Dec 02, 2013 at 01:02:40AM +0100, Michael Trimarchi wrote: > >> On Sun, Dec 1, 2013 at 11:37 PM, Anton Vorontsov wrote: > >> > On Mon, Nov 25, 2013 at

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2014-01-19 Thread Sebastian Reichel
On Mon, Dec 02, 2013 at 02:45:06AM +0100, Michael Trimarchi wrote: On Mon, Dec 2, 2013 at 1:24 AM, Anton Vorontsov an...@enomsg.org wrote: On Mon, Dec 02, 2013 at 01:02:40AM +0100, Michael Trimarchi wrote: On Sun, Dec 1, 2013 at 11:37 PM, Anton Vorontsov an...@enomsg.org wrote: On Mon, Nov

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2014-01-19 Thread Michael Trimarchi
Hi On Sun, Jan 19, 2014 at 9:54 PM, Sebastian Reichel s...@ring0.de wrote: On Mon, Dec 02, 2013 at 02:45:06AM +0100, Michael Trimarchi wrote: On Mon, Dec 2, 2013 at 1:24 AM, Anton Vorontsov an...@enomsg.org wrote: On Mon, Dec 02, 2013 at 01:02:40AM +0100, Michael Trimarchi wrote: On Sun,

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-12-23 Thread Anton Vorontsov
On Tue, Nov 19, 2013 at 02:24:16PM +0100, Pavel Machek wrote: > On Tue 2013-11-19 11:18:04, Pali Rohár wrote: > > This patch removing set_mode_hook function from board data and replacing it > > with > > new string variable of notifier power supply device. After this change it is > > possible to

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-12-23 Thread Anton Vorontsov
On Tue, Nov 19, 2013 at 02:24:16PM +0100, Pavel Machek wrote: On Tue 2013-11-19 11:18:04, Pali Rohár wrote: This patch removing set_mode_hook function from board data and replacing it with new string variable of notifier power supply device. After this change it is possible to add DT

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-12-06 Thread Pali Rohár
On Tuesday 19 November 2013 11:18:04 Pali Rohár wrote: > This patch removing set_mode_hook function from board data and > replacing it with new string variable of notifier power > supply device. After this change it is possible to add DT > support because driver does not need specific board

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-12-06 Thread Pali Rohár
On Tuesday 19 November 2013 11:18:04 Pali Rohár wrote: This patch removing set_mode_hook function from board data and replacing it with new string variable of notifier power supply device. After this change it is possible to add DT support because driver does not need specific board function

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-12-01 Thread Michael Trimarchi
Hi On Mon, Dec 2, 2013 at 1:24 AM, Anton Vorontsov wrote: > On Mon, Dec 02, 2013 at 01:02:40AM +0100, Michael Trimarchi wrote: >> On Sun, Dec 1, 2013 at 11:37 PM, Anton Vorontsov wrote: >> > On Mon, Nov 25, 2013 at 08:16:34PM +0100, Michael Trimarchi wrote: >> > ... >> >> >> So you can read

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-12-01 Thread Anton Vorontsov
On Mon, Dec 02, 2013 at 01:02:40AM +0100, Michael Trimarchi wrote: > On Sun, Dec 1, 2013 at 11:37 PM, Anton Vorontsov wrote: > > On Mon, Nov 25, 2013 at 08:16:34PM +0100, Michael Trimarchi wrote: > > ... > >> >> So you can read this value without any type of synchronization > >> >> with the

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-12-01 Thread Michael Trimarchi
Hi Anton On Sun, Dec 1, 2013 at 11:37 PM, Anton Vorontsov wrote: > On Mon, Nov 25, 2013 at 08:16:34PM +0100, Michael Trimarchi wrote: > ... >> >> So you can read this value without any type of synchronization >> >> with the power_supply_core >> >> and sysfs implementation? > ... >>

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-12-01 Thread Anton Vorontsov
On Mon, Nov 25, 2013 at 08:16:34PM +0100, Michael Trimarchi wrote: ... > >> So you can read this value without any type of synchronization > >> with the power_supply_core > >> and sysfs implementation? ... > https://lists.ubuntu.com/archives/kernel-team/2013-January/025206.html > > I found and

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-12-01 Thread Anton Vorontsov
On Mon, Nov 25, 2013 at 08:16:34PM +0100, Michael Trimarchi wrote: ... So you can read this value without any type of synchronization with the power_supply_core and sysfs implementation? ... https://lists.ubuntu.com/archives/kernel-team/2013-January/025206.html I found and equivalent

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-12-01 Thread Michael Trimarchi
Hi Anton On Sun, Dec 1, 2013 at 11:37 PM, Anton Vorontsov an...@enomsg.org wrote: On Mon, Nov 25, 2013 at 08:16:34PM +0100, Michael Trimarchi wrote: ... So you can read this value without any type of synchronization with the power_supply_core and sysfs implementation? ...

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-12-01 Thread Anton Vorontsov
On Mon, Dec 02, 2013 at 01:02:40AM +0100, Michael Trimarchi wrote: On Sun, Dec 1, 2013 at 11:37 PM, Anton Vorontsov an...@enomsg.org wrote: On Mon, Nov 25, 2013 at 08:16:34PM +0100, Michael Trimarchi wrote: ... So you can read this value without any type of synchronization with the

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-12-01 Thread Michael Trimarchi
Hi On Mon, Dec 2, 2013 at 1:24 AM, Anton Vorontsov an...@enomsg.org wrote: On Mon, Dec 02, 2013 at 01:02:40AM +0100, Michael Trimarchi wrote: On Sun, Dec 1, 2013 at 11:37 PM, Anton Vorontsov an...@enomsg.org wrote: On Mon, Nov 25, 2013 at 08:16:34PM +0100, Michael Trimarchi wrote: ... So

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-27 Thread Pali Rohár
On Thursday 28 November 2013 01:25:50 Sebastian Reichel wrote: > On Wed, Nov 27, 2013 at 10:16:47PM +0100, Pali Rohár wrote: > > On Monday 25 November 2013 22:50:01 Sebastian Reichel wrote: > > > > 2 seems more generic to me, but as rx51-battery is > > > > missing the functionality to send events

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-27 Thread Sebastian Reichel
On Wed, Nov 27, 2013 at 10:16:47PM +0100, Pali Rohár wrote: > On Monday 25 November 2013 22:50:01 Sebastian Reichel wrote: > > > 2 seems more generic to me, but as rx51-battery is missing > > > the functionality to send events on temperature change, I > > > guess 1 will be easier to implement. > >

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-27 Thread Pali Rohár
On Monday 25 November 2013 22:50:01 Sebastian Reichel wrote: > > 2 seems more generic to me, but as rx51-battery is missing > > the functionality to send events on temperature change, I > > guess 1 will be easier to implement. > > The temperature must be polled anyway, if the ADC does not >

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-27 Thread Pali Rohár
On Monday 25 November 2013 22:50:01 Sebastian Reichel wrote: 2 seems more generic to me, but as rx51-battery is missing the functionality to send events on temperature change, I guess 1 will be easier to implement. The temperature must be polled anyway, if the ADC does not support

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-27 Thread Sebastian Reichel
On Wed, Nov 27, 2013 at 10:16:47PM +0100, Pali Rohár wrote: On Monday 25 November 2013 22:50:01 Sebastian Reichel wrote: 2 seems more generic to me, but as rx51-battery is missing the functionality to send events on temperature change, I guess 1 will be easier to implement. The

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-27 Thread Pali Rohár
On Thursday 28 November 2013 01:25:50 Sebastian Reichel wrote: On Wed, Nov 27, 2013 at 10:16:47PM +0100, Pali Rohár wrote: On Monday 25 November 2013 22:50:01 Sebastian Reichel wrote: 2 seems more generic to me, but as rx51-battery is missing the functionality to send events on

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-25 Thread Sebastian Reichel
Hi, On Mon, Nov 25, 2013 at 08:32:46PM +0200, Ивайло Димитров wrote: > So, AIUI there are 2 options: > > 1. charger driver polls the battery driver every n (60?) seconds. > 2. battery driver sends PSY_EVENT_PROP_CHANGED on every degree >up or down. > > In both cases if the temperature is

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-25 Thread Michael Trimarchi
Hi On Sun, Nov 24, 2013 at 8:01 PM, Pali Rohár wrote: > On Sunday 24 November 2013 18:18:03 Michael Trimarchi wrote: >> Hi >> >> On Tue, Nov 19, 2013 at 11:18 AM, Pali Rohár > wrote: >> > This patch removing set_mode_hook function from board data >> > and replacing it with new string variable

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-25 Thread Pali Rohár
On Monday 25 November 2013 16:18:39 Pavel Machek wrote: > On Mon 2013-11-25 15:10:00, Pali Rohár wrote: > > On Monday 25 November 2013 15:01:27 Pavel Machek wrote: > > > Where can I get dsme sources? > > > > > > Pavel > > > > dsme

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-25 Thread Ивайло Димитров
> Оригинално писмо >От: Sebastian Reichel >Относно: Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode >До: Ивайло Димитров >Изпратено на: Понеделник, 2013, Ноември 25 19:14:21 EET > > >On Mon, Nov 25, 2013 at 07:01:54P

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-25 Thread Sebastian Reichel
On Mon, Nov 25, 2013 at 07:01:54PM +0200, Ивайло Димитров wrote: >> Now.. Imagine phone left in car in charger (on sun). Likely >> temperature will reach high values, kernel is charging, dsme will >> reboot the system, but kernel will start charging again, dsme will >> reboot again, ... >> >> And

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-25 Thread Ивайло Димитров
> Оригинално писмо >От: Pavel Machek >Относно: Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode >До: Pali Rohár >Изпратено на: Понеделник, 2013, Ноември 25 17:18:39 EET > > >On Mon 2013-11-25 15:10:00, Pali Rohár

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-25 Thread Pavel Machek
On Mon 2013-11-25 15:10:00, Pali Rohár wrote: > On Monday 25 November 2013 15:01:27 Pavel Machek wrote: > > Where can I get dsme sources? > > Pavel > > dsme daemon: https://gitorious.org/community-ssu/dsme > dsme thermal plugin:

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-25 Thread Pali Rohár
On Monday 25 November 2013 15:01:27 Pavel Machek wrote: > Where can I get dsme sources? > Pavel dsme daemon: https://gitorious.org/community-ssu/dsme dsme thermal plugin:

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-25 Thread Pavel Machek
Hi! On Sun 2013-11-24 20:41:46, Pali Rohár wrote: > On Sunday 24 November 2013 20:26:09 Sebastian Reichel wrote: > > On Sun, Nov 24, 2013 at 08:01:16PM +0100, Pali Rohár wrote: > > > Currently on Maemo 5 this is handled in userspace (with open > > > source dsme daemon). > > > > I assume it

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-25 Thread Pavel Machek
Hi! On Sun 2013-11-24 20:41:46, Pali Rohár wrote: On Sunday 24 November 2013 20:26:09 Sebastian Reichel wrote: On Sun, Nov 24, 2013 at 08:01:16PM +0100, Pali Rohár wrote: Currently on Maemo 5 this is handled in userspace (with open source dsme daemon). I assume it currently also

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-25 Thread Pali Rohár
On Monday 25 November 2013 15:01:27 Pavel Machek wrote: Where can I get dsme sources? Pavel dsme daemon: https://gitorious.org/community-ssu/dsme dsme thermal plugin:

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-25 Thread Pavel Machek
On Mon 2013-11-25 15:10:00, Pali Rohár wrote: On Monday 25 November 2013 15:01:27 Pavel Machek wrote: Where can I get dsme sources? Pavel dsme daemon: https://gitorious.org/community-ssu/dsme dsme thermal plugin:

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-25 Thread Ивайло Димитров
Оригинално писмо От: Pavel Machek Относно: Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode До: Pali Rohár Изпратено на: Понеделник, 2013, Ноември 25 17:18:39 EET On Mon 2013-11-25 15:10:00, Pali Rohár wrote: On Monday 25 November

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-25 Thread Sebastian Reichel
On Mon, Nov 25, 2013 at 07:01:54PM +0200, Ивайло Димитров wrote: Now.. Imagine phone left in car in charger (on sun). Likely temperature will reach high values, kernel is charging, dsme will reboot the system, but kernel will start charging again, dsme will reboot again, ... And it is not

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-25 Thread Ивайло Димитров
Оригинално писмо От: Sebastian Reichel Относно: Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode До: Ивайло Димитров Изпратено на: Понеделник, 2013, Ноември 25 19:14:21 EET On Mon, Nov 25, 2013 at 07:01:54PM +0200, Ивайло Димитров wrote

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-25 Thread Pali Rohár
On Monday 25 November 2013 16:18:39 Pavel Machek wrote: On Mon 2013-11-25 15:10:00, Pali Rohár wrote: On Monday 25 November 2013 15:01:27 Pavel Machek wrote: Where can I get dsme sources? Pavel dsme daemon:

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-25 Thread Michael Trimarchi
Hi On Sun, Nov 24, 2013 at 8:01 PM, Pali Rohár pali.ro...@gmail.com wrote: On Sunday 24 November 2013 18:18:03 Michael Trimarchi wrote: Hi On Tue, Nov 19, 2013 at 11:18 AM, Pali Rohár pali.ro...@gmail.com wrote: This patch removing set_mode_hook function from board data and replacing it

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-25 Thread Sebastian Reichel
Hi, On Mon, Nov 25, 2013 at 08:32:46PM +0200, Ивайло Димитров wrote: So, AIUI there are 2 options: 1. charger driver polls the battery driver every n (60?) seconds. 2. battery driver sends PSY_EVENT_PROP_CHANGED on every degree up or down. In both cases if the temperature is outside

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-24 Thread Sebastian Reichel
On Sun, Nov 24, 2013 at 08:41:46PM +0100, Pali Rohár wrote: > On Sunday 24 November 2013 20:26:09 Sebastian Reichel wrote: > > On Sun, Nov 24, 2013 at 08:01:16PM +0100, Pali Rohár wrote: > > > Currently on Maemo 5 this is handled in userspace (with open > > > source dsme daemon). > > > > I assume

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-24 Thread Pali Rohár
On Sunday 24 November 2013 20:26:09 Sebastian Reichel wrote: > On Sun, Nov 24, 2013 at 08:01:16PM +0100, Pali Rohár wrote: > > Currently on Maemo 5 this is handled in userspace (with open > > source dsme daemon). > > I assume it currently also takes care of the bq2415x watchdog? > That means if

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-24 Thread Sebastian Reichel
On Sun, Nov 24, 2013 at 08:01:16PM +0100, Pali Rohár wrote: > > I'm wondering if the watchdog thread should check some values, > > like e.g. battery temperature. It should stop charging the > > battery if some critical battery temperature threshold is > > reached. > > For checking battery

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-24 Thread Pali Rohár
On Sunday 24 November 2013 18:18:03 Michael Trimarchi wrote: > Hi > > On Tue, Nov 19, 2013 at 11:18 AM, Pali Rohár wrote: > > This patch removing set_mode_hook function from board data > > and replacing it with new string variable of notifier power > > supply device. After this change it is

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-24 Thread Pali Rohár
On Sunday 24 November 2013 18:00:00 Sebastian Reichel wrote: > Hi, > > On Tue, Nov 19, 2013 at 11:18:04AM +0100, Pali Rohár wrote: > > This patch removing set_mode_hook function from board data > > and replacing it with new string variable of notifier power > > supply device. After this change it

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-24 Thread Michael Trimarchi
Hi On Tue, Nov 19, 2013 at 11:18 AM, Pali Rohár wrote: > This patch removing set_mode_hook function from board data and replacing it > with > new string variable of notifier power supply device. After this change it is > possible to add DT support because driver does not need specific board >

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-24 Thread Sebastian Reichel
Hi, On Tue, Nov 19, 2013 at 11:18:04AM +0100, Pali Rohár wrote: > This patch removing set_mode_hook function from board data and replacing it > with > new string variable of notifier power supply device. After this change it is > possible to add DT support because driver does not need specific

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-24 Thread Sebastian Reichel
Hi, On Tue, Nov 19, 2013 at 11:18:04AM +0100, Pali Rohár wrote: This patch removing set_mode_hook function from board data and replacing it with new string variable of notifier power supply device. After this change it is possible to add DT support because driver does not need specific board

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-24 Thread Michael Trimarchi
Hi On Tue, Nov 19, 2013 at 11:18 AM, Pali Rohár pali.ro...@gmail.com wrote: This patch removing set_mode_hook function from board data and replacing it with new string variable of notifier power supply device. After this change it is possible to add DT support because driver does not need

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-24 Thread Pali Rohár
On Sunday 24 November 2013 18:00:00 Sebastian Reichel wrote: Hi, On Tue, Nov 19, 2013 at 11:18:04AM +0100, Pali Rohár wrote: This patch removing set_mode_hook function from board data and replacing it with new string variable of notifier power supply device. After this change it is

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-24 Thread Pali Rohár
On Sunday 24 November 2013 18:18:03 Michael Trimarchi wrote: Hi On Tue, Nov 19, 2013 at 11:18 AM, Pali Rohár pali.ro...@gmail.com wrote: This patch removing set_mode_hook function from board data and replacing it with new string variable of notifier power supply device. After this

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-24 Thread Sebastian Reichel
On Sun, Nov 24, 2013 at 08:01:16PM +0100, Pali Rohár wrote: I'm wondering if the watchdog thread should check some values, like e.g. battery temperature. It should stop charging the battery if some critical battery temperature threshold is reached. For checking battery temperature is

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-24 Thread Pali Rohár
On Sunday 24 November 2013 20:26:09 Sebastian Reichel wrote: On Sun, Nov 24, 2013 at 08:01:16PM +0100, Pali Rohár wrote: Currently on Maemo 5 this is handled in userspace (with open source dsme daemon). I assume it currently also takes care of the bq2415x watchdog? That means if the

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-24 Thread Sebastian Reichel
On Sun, Nov 24, 2013 at 08:41:46PM +0100, Pali Rohár wrote: On Sunday 24 November 2013 20:26:09 Sebastian Reichel wrote: On Sun, Nov 24, 2013 at 08:01:16PM +0100, Pali Rohár wrote: Currently on Maemo 5 this is handled in userspace (with open source dsme daemon). I assume it currently

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-19 Thread Pavel Machek
On Tue 2013-11-19 11:18:04, Pali Rohár wrote: > This patch removing set_mode_hook function from board data and replacing it > with > new string variable of notifier power supply device. After this change it is > possible to add DT support because driver does not need specific board > function >

[PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-19 Thread Pali Rohár
This patch removing set_mode_hook function from board data and replacing it with new string variable of notifier power supply device. After this change it is possible to add DT support because driver does not need specific board function anymore. Only static data and name of power supply device is

[PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-19 Thread Pali Rohár
This patch removing set_mode_hook function from board data and replacing it with new string variable of notifier power supply device. After this change it is possible to add DT support because driver does not need specific board function anymore. Only static data and name of power supply device is

Re: [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode

2013-11-19 Thread Pavel Machek
On Tue 2013-11-19 11:18:04, Pali Rohár wrote: This patch removing set_mode_hook function from board data and replacing it with new string variable of notifier power supply device. After this change it is possible to add DT support because driver does not need specific board function