Re: [PATCH v3 03/12] cpuset: update cs->effective_{cpus,mems} when config changes

2014-07-09 Thread Tejun Heo
On Wed, Jul 09, 2014 at 04:47:29PM +0800, Li Zefan wrote: > +static void update_cpumasks_hier(struct cpuset *cs, struct cpumask *new_cpus) Let's please use a variable name which clearly indicates that it's a temp place. Something like @cpus_buf? Ditto with mems. Thanks. -- tejun -- To

[PATCH v3 03/12] cpuset: update cs->effective_{cpus,mems} when config changes

2014-07-09 Thread Li Zefan
We're going to have separate user-configured masks and effective ones. Eventually configured masks can only be changed by writing cpuset.cpus and cpuset.mems, and they won't be restricted by parent cpuset. While effective masks reflect cpu/memory hotplug and hierachical restriction, and these are

[PATCH v3 03/12] cpuset: update cs-effective_{cpus,mems} when config changes

2014-07-09 Thread Li Zefan
We're going to have separate user-configured masks and effective ones. Eventually configured masks can only be changed by writing cpuset.cpus and cpuset.mems, and they won't be restricted by parent cpuset. While effective masks reflect cpu/memory hotplug and hierachical restriction, and these are

Re: [PATCH v3 03/12] cpuset: update cs-effective_{cpus,mems} when config changes

2014-07-09 Thread Tejun Heo
On Wed, Jul 09, 2014 at 04:47:29PM +0800, Li Zefan wrote: +static void update_cpumasks_hier(struct cpuset *cs, struct cpumask *new_cpus) Let's please use a variable name which clearly indicates that it's a temp place. Something like @cpus_buf? Ditto with mems. Thanks. -- tejun -- To