Re: [PATCH v3 1/7] staging: lustre: lclient: glimpse.c fixing coding style issues

2014-06-16 Thread Anil Shashikumar Belur
> - result = +1; + result = + 1; > This looks wrong. > Here +1 is apparently meant as +1 (compare to -1) to underscore it's positive > nature. > If you wanted to drop the +, that'd be fine, I guess, but in your version it > looks outright wrong to me (I tested and it compiles, though). > > Bye,

Re: [PATCH v3 1/7] staging: lustre: lclient: glimpse.c fixing coding style issues

2014-06-16 Thread Anil Shashikumar Belur
- result = +1; + result = + 1; This looks wrong. Here +1 is apparently meant as +1 (compare to -1) to underscore it's positive nature. If you wanted to drop the +, that'd be fine, I guess, but in your version it looks outright wrong to me (I tested and it compiles, though). Bye,

Re: [PATCH v3 1/7] staging: lustre: lclient: glimpse.c fixing coding style issues

2014-06-15 Thread Drokin, Oleg
Hello! On Jun 16, 2014, at 12:28 AM, Anil Belur wrote: > From: Anil Belur > > Fixed "ERROR: need consistent spacing around '+' (ctx:WxV)" > > Signed-off-by: Anil Belur > --- > drivers/staging/lustre/lustre/lclient/glimpse.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

[PATCH v3 1/7] staging: lustre: lclient: glimpse.c fixing coding style issues

2014-06-15 Thread Anil Belur
From: Anil Belur Fixed "ERROR: need consistent spacing around '+' (ctx:WxV)" Signed-off-by: Anil Belur --- drivers/staging/lustre/lustre/lclient/glimpse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/lclient/glimpse.c

[PATCH v3 1/7] staging: lustre: lclient: glimpse.c fixing coding style issues

2014-06-15 Thread Anil Belur
From: Anil Belur ask...@gmail.com Fixed ERROR: need consistent spacing around '+' (ctx:WxV) Signed-off-by: Anil Belur ask...@gmail.com --- drivers/staging/lustre/lustre/lclient/glimpse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v3 1/7] staging: lustre: lclient: glimpse.c fixing coding style issues

2014-06-15 Thread Drokin, Oleg
Hello! On Jun 16, 2014, at 12:28 AM, Anil Belur wrote: From: Anil Belur ask...@gmail.com Fixed ERROR: need consistent spacing around '+' (ctx:WxV) Signed-off-by: Anil Belur ask...@gmail.com --- drivers/staging/lustre/lustre/lclient/glimpse.c | 2 +- 1 file changed, 1 insertion(+), 1