Re: [PATCH v4] Revert "f2fs crypto: avoid unneeded memory allocation in ->readdir"

On 2018/3/1 10:50, Jaegeuk Kim wrote: > On 02/28, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2018/2/28 13:48, Jaegeuk Kim wrote: >>> Hi Yunlong, >>> >>> As Eric pointed out, how do you think using nohighmem for directory likewise >> >> I'd like to ask, at the beginning, why we choose to use highmem

Re: [PATCH v4] Revert "f2fs crypto: avoid unneeded memory allocation in ->readdir"

On 2018/3/1 10:50, Jaegeuk Kim wrote: > On 02/28, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2018/2/28 13:48, Jaegeuk Kim wrote: >>> Hi Yunlong, >>> >>> As Eric pointed out, how do you think using nohighmem for directory likewise >> >> I'd like to ask, at the beginning, why we choose to use highmem

Re: [PATCH v4] Revert "f2fs crypto: avoid unneeded memory allocation in ->readdir"

On 02/28, Chao Yu wrote: > Hi Jaegeuk, > > On 2018/2/28 13:48, Jaegeuk Kim wrote: > > Hi Yunlong, > > > > As Eric pointed out, how do you think using nohighmem for directory likewise > > I'd like to ask, at the beginning, why we choose to use highmem for dentry > page? > any history reason

Re: [PATCH v4] Revert "f2fs crypto: avoid unneeded memory allocation in ->readdir"

On 02/28, Chao Yu wrote: > Hi Jaegeuk, > > On 2018/2/28 13:48, Jaegeuk Kim wrote: > > Hi Yunlong, > > > > As Eric pointed out, how do you think using nohighmem for directory likewise > > I'd like to ask, at the beginning, why we choose to use highmem for dentry > page? > any history reason

Re: [PATCH v4] Revert "f2fs crypto: avoid unneeded memory allocation in ->readdir"

On 2018/2/28 13:48, Jaegeuk Kim wrote: Hi Yunlong, As Eric pointed out, how do you think using nohighmem for directory likewise ext4, which looks like more efficient? OK, I have sent out another patch like this. Actually, we don't need to do this in most of recent kernels, right? Why? I

Re: [PATCH v4] Revert "f2fs crypto: avoid unneeded memory allocation in ->readdir"

On 2018/2/28 13:48, Jaegeuk Kim wrote: Hi Yunlong, As Eric pointed out, how do you think using nohighmem for directory likewise ext4, which looks like more efficient? OK, I have sent out another patch like this. Actually, we don't need to do this in most of recent kernels, right? Why? I

Re: [PATCH v4] Revert "f2fs crypto: avoid unneeded memory allocation in ->readdir"

Hi Jaegeuk, On 2018/2/28 13:48, Jaegeuk Kim wrote: > Hi Yunlong, > > As Eric pointed out, how do you think using nohighmem for directory likewise I'd like to ask, at the beginning, why we choose to use highmem for dentry page? any history reason there? > ext4, which looks like more efficient?

Re: [PATCH v4] Revert "f2fs crypto: avoid unneeded memory allocation in ->readdir"

Hi Jaegeuk, On 2018/2/28 13:48, Jaegeuk Kim wrote: > Hi Yunlong, > > As Eric pointed out, how do you think using nohighmem for directory likewise I'd like to ask, at the beginning, why we choose to use highmem for dentry page? any history reason there? > ext4, which looks like more efficient?

Re: [PATCH v4] Revert "f2fs crypto: avoid unneeded memory allocation in ->readdir"

Hi Yunlong, As Eric pointed out, how do you think using nohighmem for directory likewise ext4, which looks like more efficient? Actually, we don't need to do this in most of recent kernels, right? Thanks, On 02/28, Yunlong Song wrote: > This reverts commit

Re: [PATCH v4] Revert "f2fs crypto: avoid unneeded memory allocation in ->readdir"

Hi Yunlong, As Eric pointed out, how do you think using nohighmem for directory likewise ext4, which looks like more efficient? Actually, we don't need to do this in most of recent kernels, right? Thanks, On 02/28, Yunlong Song wrote: > This reverts commit

[PATCH v4] Revert "f2fs crypto: avoid unneeded memory allocation in ->readdir"

This reverts commit e06f86e61d7a67fe6e826010f57aa39c674f4b1b. Conflicts: fs/f2fs/dir.c In some platforms (such as arm), high memory is used, then the decrypting filename will cause panic, the reason see commit 569cf1876a32e574ba8a7fb825cd91bafd003882 ("f2fs crypto: allocate buffer for

[PATCH v4] Revert "f2fs crypto: avoid unneeded memory allocation in ->readdir"

This reverts commit e06f86e61d7a67fe6e826010f57aa39c674f4b1b. Conflicts: fs/f2fs/dir.c In some platforms (such as arm), high memory is used, then the decrypting filename will cause panic, the reason see commit 569cf1876a32e574ba8a7fb825cd91bafd003882 ("f2fs crypto: allocate buffer for