On Thu, Sep 25, 2014 at 2:54 AM, Mark yao wrote:
> Hi, Daniel
> this version is old, newest is v5. and I remove uapi at v5.
> you can see v5 patch at:
> https://lkml.org/lkml/2014/9/23/1061
> thanks
>
> This version doesn't seem to be cc'ed to dri-devel, at least it didn't
> yet show up. Can you
On Thu, Sep 25, 2014 at 2:54 AM, Mark yao mark@rock-chips.com wrote:
Hi, Daniel
this version is old, newest is v5. and I remove uapi at v5.
you can see v5 patch at:
https://lkml.org/lkml/2014/9/23/1061
thanks
This version doesn't seem to be cc'ed to dri-devel, at least it didn't
yet
On Wed, Sep 24, 2014 at 11:31 AM, Mark yao wrote:
> On 2014年09月24日 16:20, Daniel Vetter wrote:
>>
>> On Mon, Sep 22, 2014 at 06:48:54PM +0800, Mark yao wrote:
>>>
>>> This patch adds the basic structure of a DRM Driver for Rockchip Socs.
>>>
>>> Signed-off-by: Mark yao
>>> ---
>>> Changes in v2:
On 2014年09月24日 16:20, Daniel Vetter wrote:
On Mon, Sep 22, 2014 at 06:48:54PM +0800, Mark yao wrote:
This patch adds the basic structure of a DRM Driver for Rockchip Socs.
Signed-off-by: Mark yao
---
Changes in v2:
- use the component framework to defer main drm driver probe
until all VOP
On Mon, Sep 22, 2014 at 06:48:54PM +0800, Mark yao wrote:
> This patch adds the basic structure of a DRM Driver for Rockchip Socs.
>
> Signed-off-by: Mark yao
> ---
> Changes in v2:
> - use the component framework to defer main drm driver probe
> until all VOP devices have been probed.
> - use
On Mon, Sep 22, 2014 at 06:48:54PM +0800, Mark yao wrote:
This patch adds the basic structure of a DRM Driver for Rockchip Socs.
Signed-off-by: Mark yao mark@rock-chips.com
---
Changes in v2:
- use the component framework to defer main drm driver probe
until all VOP devices have been
On 2014年09月24日 16:20, Daniel Vetter wrote:
On Mon, Sep 22, 2014 at 06:48:54PM +0800, Mark yao wrote:
This patch adds the basic structure of a DRM Driver for Rockchip Socs.
Signed-off-by: Mark yao mark@rock-chips.com
---
Changes in v2:
- use the component framework to defer main drm driver
On Wed, Sep 24, 2014 at 11:31 AM, Mark yao mark@rock-chips.com wrote:
On 2014年09月24日 16:20, Daniel Vetter wrote:
On Mon, Sep 22, 2014 at 06:48:54PM +0800, Mark yao wrote:
This patch adds the basic structure of a DRM Driver for Rockchip Socs.
Signed-off-by: Mark yao
On Tuesday 23 September 2014 15:09:37 Mark yao wrote:
> On 2014年09月22日 23:54, Arnd Bergmann wrote:
> > On Monday 22 September 2014 17:15:06 Boris BREZILLON wrote:
> +
> + /* TODO(djkurtz): fetch the mapping start/size from somewhere */
> + mapping =
On 2014年09月22日 23:54, Arnd Bergmann wrote:
On Monday 22 September 2014 17:15:06 Boris BREZILLON wrote:
+
+ /* TODO(djkurtz): fetch the mapping start/size from somewhere */
+ mapping = arm_iommu_create_mapping(_bus_type, 0x1000,
+ SZ_1G);
+ if
On 2014年09月22日 22:43, Arnd Bergmann wrote:
On Monday 22 September 2014 18:48:54 Mark yao wrote:
diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
new file mode 100644
index 000..7146c80
--- /dev/null
+++ b/drivers/gpu/drm/rockchip/Kconfig
@@ -0,0 +1,19 @@
On 2014年09月23日 03:10, Rob Clark wrote:
Ok, couple more small comments.. this time I actually had time to go
through the entire patch, not just the uapi
On Mon, Sep 22, 2014 at 6:48 AM, Mark yao wrote:
This patch adds the basic structure of a DRM Driver for Rockchip Socs.
Signed-off-by: Mark
On 2014年09月22日 21:24, Boris BREZILLON wrote:
Hi Mark,
You'll find some comments inline.
Anyway, I wouldn't call it a review (your driver is using some concepts
I'm not used to, like IOMMUs) but rather a collection of nitpicks :-).
I haven't been through the whole driver yet, but I'll get back
On 2014年09月22日 21:24, Boris BREZILLON wrote:
Hi Mark,
You'll find some comments inline.
Anyway, I wouldn't call it a review (your driver is using some concepts
I'm not used to, like IOMMUs) but rather a collection of nitpicks :-).
I haven't been through the whole driver yet, but I'll get back
On 2014年09月23日 03:10, Rob Clark wrote:
Ok, couple more small comments.. this time I actually had time to go
through the entire patch, not just the uapi
On Mon, Sep 22, 2014 at 6:48 AM, Mark yao mark@rock-chips.com wrote:
This patch adds the basic structure of a DRM Driver for Rockchip
On 2014年09月22日 22:43, Arnd Bergmann wrote:
On Monday 22 September 2014 18:48:54 Mark yao wrote:
diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
new file mode 100644
index 000..7146c80
--- /dev/null
+++ b/drivers/gpu/drm/rockchip/Kconfig
@@ -0,0 +1,19 @@
On 2014年09月22日 23:54, Arnd Bergmann wrote:
On Monday 22 September 2014 17:15:06 Boris BREZILLON wrote:
+
+ /* TODO(djkurtz): fetch the mapping start/size from somewhere */
+ mapping = arm_iommu_create_mapping(platform_bus_type, 0x1000,
+ SZ_1G);
+
On Tuesday 23 September 2014 15:09:37 Mark yao wrote:
On 2014年09月22日 23:54, Arnd Bergmann wrote:
On Monday 22 September 2014 17:15:06 Boris BREZILLON wrote:
+
+ /* TODO(djkurtz): fetch the mapping start/size from somewhere */
+ mapping = arm_iommu_create_mapping(platform_bus_type,
Ok, couple more small comments.. this time I actually had time to go
through the entire patch, not just the uapi
On Mon, Sep 22, 2014 at 6:48 AM, Mark yao wrote:
> This patch adds the basic structure of a DRM Driver for Rockchip Socs.
>
> Signed-off-by: Mark yao
> ---
> Changes in v2:
> - use
On Monday 22 September 2014 17:15:06 Boris BREZILLON wrote:
> > > +
> > > + /* TODO(djkurtz): fetch the mapping start/size from somewhere */
> > > + mapping = arm_iommu_create_mapping(_bus_type, 0x1000,
> > > + SZ_1G);
> > > + if (IS_ERR(mapping)) {
>
On Mon, 22 Sep 2014 16:43:31 +0200
Arnd Bergmann wrote:
> On Monday 22 September 2014 18:48:54 Mark yao wrote:
> > diff --git a/drivers/gpu/drm/rockchip/Kconfig
> > b/drivers/gpu/drm/rockchip/Kconfig
> > new file mode 100644
> > index 000..7146c80
> > --- /dev/null
> > +++
On Monday 22 September 2014 18:48:54 Mark yao wrote:
> diff --git a/drivers/gpu/drm/rockchip/Kconfig
> b/drivers/gpu/drm/rockchip/Kconfig
> new file mode 100644
> index 000..7146c80
> --- /dev/null
> +++ b/drivers/gpu/drm/rockchip/Kconfig
> @@ -0,0 +1,19 @@
> +config DRM_ROCKCHIP
> +
Hi Mark,
You'll find some comments inline.
Anyway, I wouldn't call it a review (your driver is using some concepts
I'm not used to, like IOMMUs) but rather a collection of nitpicks :-).
I haven't been through the whole driver yet, but I'll get back to it
soon ;-).
And remember this is a 2 way
This patch adds the basic structure of a DRM Driver for Rockchip Socs.
Signed-off-by: Mark yao
---
Changes in v2:
- use the component framework to defer main drm driver probe
until all VOP devices have been probed.
- use dma-mapping API with ARM_DMA_USE_IOMMU, create dma mapping by
master
This patch adds the basic structure of a DRM Driver for Rockchip Socs.
Signed-off-by: Mark yao mark@rock-chips.com
---
Changes in v2:
- use the component framework to defer main drm driver probe
until all VOP devices have been probed.
- use dma-mapping API with ARM_DMA_USE_IOMMU, create dma
Hi Mark,
You'll find some comments inline.
Anyway, I wouldn't call it a review (your driver is using some concepts
I'm not used to, like IOMMUs) but rather a collection of nitpicks :-).
I haven't been through the whole driver yet, but I'll get back to it
soon ;-).
And remember this is a 2 way
On Monday 22 September 2014 18:48:54 Mark yao wrote:
diff --git a/drivers/gpu/drm/rockchip/Kconfig
b/drivers/gpu/drm/rockchip/Kconfig
new file mode 100644
index 000..7146c80
--- /dev/null
+++ b/drivers/gpu/drm/rockchip/Kconfig
@@ -0,0 +1,19 @@
+config DRM_ROCKCHIP
+ tristate DRM
On Mon, 22 Sep 2014 16:43:31 +0200
Arnd Bergmann a...@arndb.de wrote:
On Monday 22 September 2014 18:48:54 Mark yao wrote:
diff --git a/drivers/gpu/drm/rockchip/Kconfig
b/drivers/gpu/drm/rockchip/Kconfig
new file mode 100644
index 000..7146c80
--- /dev/null
+++
On Monday 22 September 2014 17:15:06 Boris BREZILLON wrote:
+
+ /* TODO(djkurtz): fetch the mapping start/size from somewhere */
+ mapping = arm_iommu_create_mapping(platform_bus_type, 0x1000,
+ SZ_1G);
+ if (IS_ERR(mapping)) {
+
Ok, couple more small comments.. this time I actually had time to go
through the entire patch, not just the uapi
On Mon, Sep 22, 2014 at 6:48 AM, Mark yao mark@rock-chips.com wrote:
This patch adds the basic structure of a DRM Driver for Rockchip Socs.
Signed-off-by: Mark yao
30 matches
Mail list logo
