Re: [PATCH v4 2/2] PCI: Add tango PCIe host bridge support

2017-05-25 Thread Marc Zyngier
On 25/05/17 13:41, Mason wrote: > On 25/05/2017 14:23, Marc Zyngier wrote: >> On 25/05/17 13:00, Mason wrote: >>> On 25/05/2017 10:48, Marc Zyngier wrote: Please have some defines for these magic values. >>> >>> Typical driver do >>> #define MUX_OFFSET 0x48 >>> and then access the register's

Re: [PATCH v4 2/2] PCI: Add tango PCIe host bridge support

2017-05-25 Thread Marc Zyngier
On 25/05/17 13:41, Mason wrote: > On 25/05/2017 14:23, Marc Zyngier wrote: >> On 25/05/17 13:00, Mason wrote: >>> On 25/05/2017 10:48, Marc Zyngier wrote: Please have some defines for these magic values. >>> >>> Typical driver do >>> #define MUX_OFFSET 0x48 >>> and then access the register's

Re: [PATCH v4 2/2] PCI: Add tango PCIe host bridge support

2017-05-25 Thread Mason
On 25/05/2017 14:23, Marc Zyngier wrote: > On 25/05/17 13:00, Mason wrote: >> On 25/05/2017 10:48, Marc Zyngier wrote: >>> Please have some defines for these magic values. >> >> Typical driver do >> #define MUX_OFFSET 0x48 >> and then access the register's value through >> readl_relaxed(pcie->base

Re: [PATCH v4 2/2] PCI: Add tango PCIe host bridge support

2017-05-25 Thread Mason
On 25/05/2017 14:23, Marc Zyngier wrote: > On 25/05/17 13:00, Mason wrote: >> On 25/05/2017 10:48, Marc Zyngier wrote: >>> Please have some defines for these magic values. >> >> Typical driver do >> #define MUX_OFFSET 0x48 >> and then access the register's value through >> readl_relaxed(pcie->base

Re: [PATCH v4 2/2] PCI: Add tango PCIe host bridge support

2017-05-25 Thread Marc Zyngier
On 25/05/17 13:00, Mason wrote: > On 25/05/2017 10:48, Marc Zyngier wrote: > >> On 20/04/17 15:31, Marc Gonzalez wrote: >> >>> This driver is required to work around several hardware bugs in the >>> PCIe controller. >>> >>> NB: Revision 1 does not support legacy interrupts, or IO space. >>> >>>

Re: [PATCH v4 2/2] PCI: Add tango PCIe host bridge support

2017-05-25 Thread Marc Zyngier
On 25/05/17 13:00, Mason wrote: > On 25/05/2017 10:48, Marc Zyngier wrote: > >> On 20/04/17 15:31, Marc Gonzalez wrote: >> >>> This driver is required to work around several hardware bugs in the >>> PCIe controller. >>> >>> NB: Revision 1 does not support legacy interrupts, or IO space. >>> >>>

Re: [PATCH v4 2/2] PCI: Add tango PCIe host bridge support

2017-05-25 Thread Mason
On 25/05/2017 10:48, Marc Zyngier wrote: > On 20/04/17 15:31, Marc Gonzalez wrote: > >> This driver is required to work around several hardware bugs in the >> PCIe controller. >> >> NB: Revision 1 does not support legacy interrupts, or IO space. >> >> Signed-off-by: Marc Gonzalez

Re: [PATCH v4 2/2] PCI: Add tango PCIe host bridge support

2017-05-25 Thread Mason
On 25/05/2017 10:48, Marc Zyngier wrote: > On 20/04/17 15:31, Marc Gonzalez wrote: > >> This driver is required to work around several hardware bugs in the >> PCIe controller. >> >> NB: Revision 1 does not support legacy interrupts, or IO space. >> >> Signed-off-by: Marc Gonzalez >> --- >>

Re: [PATCH v4 2/2] PCI: Add tango PCIe host bridge support

2017-05-25 Thread Marc Zyngier
On 20/04/17 15:31, Marc Gonzalez wrote: > This driver is required to work around several hardware bugs in the > PCIe controller. > > NB: Revision 1 does not support legacy interrupts, or IO space. > > Signed-off-by: Marc Gonzalez > --- >

Re: [PATCH v4 2/2] PCI: Add tango PCIe host bridge support

2017-05-25 Thread Marc Zyngier
On 20/04/17 15:31, Marc Gonzalez wrote: > This driver is required to work around several hardware bugs in the > PCIe controller. > > NB: Revision 1 does not support legacy interrupts, or IO space. > > Signed-off-by: Marc Gonzalez > --- > Documentation/devicetree/bindings/pci/tango-pcie.txt |

Re: [PATCH v4 2/2] PCI: Add tango PCIe host bridge support

2017-05-23 Thread Mason
On 23/05/2017 20:35, Bjorn Helgaas wrote: > On Tue, May 23, 2017 at 07:43:16PM +0200, Mason wrote: >> On 23/05/2017 19:24, Bjorn Helgaas wrote: >>> On Thu, Apr 20, 2017 at 04:31:25PM +0200, Marc Gonzalez wrote: This driver is required to work around several hardware bugs in the PCIe

Re: [PATCH v4 2/2] PCI: Add tango PCIe host bridge support

2017-05-23 Thread Mason
On 23/05/2017 20:35, Bjorn Helgaas wrote: > On Tue, May 23, 2017 at 07:43:16PM +0200, Mason wrote: >> On 23/05/2017 19:24, Bjorn Helgaas wrote: >>> On Thu, Apr 20, 2017 at 04:31:25PM +0200, Marc Gonzalez wrote: This driver is required to work around several hardware bugs in the PCIe

Re: [PATCH v4 2/2] PCI: Add tango PCIe host bridge support

2017-05-23 Thread Bjorn Helgaas
On Tue, May 23, 2017 at 07:43:16PM +0200, Mason wrote: > On 23/05/2017 19:24, Bjorn Helgaas wrote: > > On Thu, Apr 20, 2017 at 04:31:25PM +0200, Marc Gonzalez wrote: > >> This driver is required to work around several hardware bugs in the > >> PCIe controller. > >> > >> NB: Revision 1 does not

Re: [PATCH v4 2/2] PCI: Add tango PCIe host bridge support

2017-05-23 Thread Bjorn Helgaas
On Tue, May 23, 2017 at 07:43:16PM +0200, Mason wrote: > On 23/05/2017 19:24, Bjorn Helgaas wrote: > > On Thu, Apr 20, 2017 at 04:31:25PM +0200, Marc Gonzalez wrote: > >> This driver is required to work around several hardware bugs in the > >> PCIe controller. > >> > >> NB: Revision 1 does not

Re: [PATCH v4 2/2] PCI: Add tango PCIe host bridge support

2017-05-23 Thread Mason
On 23/05/2017 19:24, Bjorn Helgaas wrote: > On Thu, Apr 20, 2017 at 04:31:25PM +0200, Marc Gonzalez wrote: >> This driver is required to work around several hardware bugs in the >> PCIe controller. >> >> NB: Revision 1 does not support legacy interrupts, or IO space. >> >> Signed-off-by: Marc

Re: [PATCH v4 2/2] PCI: Add tango PCIe host bridge support

2017-05-23 Thread Mason
On 23/05/2017 19:24, Bjorn Helgaas wrote: > On Thu, Apr 20, 2017 at 04:31:25PM +0200, Marc Gonzalez wrote: >> This driver is required to work around several hardware bugs in the >> PCIe controller. >> >> NB: Revision 1 does not support legacy interrupts, or IO space. >> >> Signed-off-by: Marc

Re: [PATCH v4 2/2] PCI: Add tango PCIe host bridge support

2017-05-23 Thread Bjorn Helgaas
On Thu, Apr 20, 2017 at 04:31:25PM +0200, Marc Gonzalez wrote: > This driver is required to work around several hardware bugs in the > PCIe controller. > > NB: Revision 1 does not support legacy interrupts, or IO space. > > Signed-off-by: Marc Gonzalez > --- >

Re: [PATCH v4 2/2] PCI: Add tango PCIe host bridge support

2017-05-23 Thread Bjorn Helgaas
On Thu, Apr 20, 2017 at 04:31:25PM +0200, Marc Gonzalez wrote: > This driver is required to work around several hardware bugs in the > PCIe controller. > > NB: Revision 1 does not support legacy interrupts, or IO space. > > Signed-off-by: Marc Gonzalez > --- >

[PATCH v4 2/2] PCI: Add tango PCIe host bridge support

2017-04-20 Thread Marc Gonzalez
This driver is required to work around several hardware bugs in the PCIe controller. NB: Revision 1 does not support legacy interrupts, or IO space. Signed-off-by: Marc Gonzalez --- Documentation/devicetree/bindings/pci/tango-pcie.txt | 32

[PATCH v4 2/2] PCI: Add tango PCIe host bridge support

2017-04-20 Thread Marc Gonzalez
This driver is required to work around several hardware bugs in the PCIe controller. NB: Revision 1 does not support legacy interrupts, or IO space. Signed-off-by: Marc Gonzalez --- Documentation/devicetree/bindings/pci/tango-pcie.txt | 32 drivers/pci/host/Kconfig