Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2016-01-05 Thread Rob Herring
+Greg H On Tue, Jan 5, 2016 at 7:06 PM, Kees Cook wrote: > [fixing devicetree mailing list] > > On Tue, Jan 5, 2016 at 5:04 PM, Kees Cook wrote: >> [thread necromancy, if you don't have the thread locally, it's here: >> https://patchwork.kernel.org/patch/1426261/] >> >> We still need to solve

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2016-01-05 Thread Kees Cook
[fixing devicetree mailing list] On Tue, Jan 5, 2016 at 5:04 PM, Kees Cook wrote: > [thread necromancy, if you don't have the thread locally, it's here: > https://patchwork.kernel.org/patch/1426261/] > > We still need to solve this, and John pinged me about it today. Where > does this stand? > >

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2016-01-05 Thread Kees Cook
[thread necromancy, if you don't have the thread locally, it's here: https://patchwork.kernel.org/patch/1426261/] We still need to solve this, and John pinged me about it today. Where does this stand? -Kees On Sun, Apr 14, 2013 at 7:24 AM, Anton Vorontsov wrote: > On Mon, Apr 08, 2013 at

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2016-01-05 Thread Kees Cook
[fixing devicetree mailing list] On Tue, Jan 5, 2016 at 5:04 PM, Kees Cook wrote: > [thread necromancy, if you don't have the thread locally, it's here: > https://patchwork.kernel.org/patch/1426261/] > > We still need to solve this, and John pinged me about it today. Where

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2016-01-05 Thread Kees Cook
[thread necromancy, if you don't have the thread locally, it's here: https://patchwork.kernel.org/patch/1426261/] We still need to solve this, and John pinged me about it today. Where does this stand? -Kees On Sun, Apr 14, 2013 at 7:24 AM, Anton Vorontsov wrote: > On Mon,

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2016-01-05 Thread Rob Herring
+Greg H On Tue, Jan 5, 2016 at 7:06 PM, Kees Cook wrote: > [fixing devicetree mailing list] > > On Tue, Jan 5, 2016 at 5:04 PM, Kees Cook wrote: >> [thread necromancy, if you don't have the thread locally, it's here: >>

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2013-04-14 Thread Anton Vorontsov
On Mon, Apr 08, 2013 at 12:54:01PM -0700, Bryan Freed wrote: [...] > And as a more general question, why should we try not to put > configuration in the device tree? It seems like a great (and > portable) place to put this stuff. > It certainly seems better to have it there than hardwired in the

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2013-04-14 Thread Anton Vorontsov
On Mon, Apr 08, 2013 at 12:54:01PM -0700, Bryan Freed wrote: [...] And as a more general question, why should we try not to put configuration in the device tree? It seems like a great (and portable) place to put this stuff. It certainly seems better to have it there than hardwired in the

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2013-04-08 Thread Rob Herring
On 04/08/2013 02:54 PM, Bryan Freed wrote: > Sorry for dropping the ball on this one, Anton. > > Thank you for your feedback and modifications in the code. > I gotta ask, however, why do you completely remove key ramoops fields > like record_size and ftrace_size? > > From your 9/7/2012 comments

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2013-04-08 Thread Bryan Freed
Sorry for dropping the ball on this one, Anton. Thank you for your feedback and modifications in the code. I gotta ask, however, why do you completely remove key ramoops fields like record_size and ftrace_size? >From your 9/7/2012 comments (again, sorry for the delay in getting back to >you): >

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2013-04-08 Thread Bryan Freed
Sorry for dropping the ball on this one, Anton. Thank you for your feedback and modifications in the code. I gotta ask, however, why do you completely remove key ramoops fields like record_size and ftrace_size? From your 9/7/2012 comments (again, sorry for the delay in getting back to you):

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2013-04-08 Thread Rob Herring
On 04/08/2013 02:54 PM, Bryan Freed wrote: Sorry for dropping the ball on this one, Anton. Thank you for your feedback and modifications in the code. I gotta ask, however, why do you completely remove key ramoops fields like record_size and ftrace_size? From your 9/7/2012 comments (again,

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2013-04-07 Thread Anton Vorontsov
On Thu, Apr 04, 2013 at 09:03:47PM -0500, Rob Herring wrote: > On Mon, Sep 17, 2012 at 1:23 AM, Anton Vorontsov > wrote: > > On Fri, Sep 07, 2012 at 10:29:10PM -0700, Anton Vorontsov wrote: > >> On Fri, Sep 07, 2012 at 11:29:36AM -0700, Bryan Freed wrote: > >> > When called with a non-zero

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2013-04-07 Thread Anton Vorontsov
On Thu, Apr 04, 2013 at 09:03:47PM -0500, Rob Herring wrote: On Mon, Sep 17, 2012 at 1:23 AM, Anton Vorontsov cbouatmai...@gmail.com wrote: On Fri, Sep 07, 2012 at 10:29:10PM -0700, Anton Vorontsov wrote: On Fri, Sep 07, 2012 at 11:29:36AM -0700, Bryan Freed wrote: When called with a

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2013-04-04 Thread Rob Herring
On Mon, Sep 17, 2012 at 1:23 AM, Anton Vorontsov wrote: > On Fri, Sep 07, 2012 at 10:29:10PM -0700, Anton Vorontsov wrote: >> On Fri, Sep 07, 2012 at 11:29:36AM -0700, Bryan Freed wrote: >> > When called with a non-zero of_node, fill out a new ramoops_platform_data >> > with data from the

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2013-04-04 Thread Rob Herring
On Mon, Sep 17, 2012 at 1:23 AM, Anton Vorontsov cbouatmai...@gmail.com wrote: On Fri, Sep 07, 2012 at 10:29:10PM -0700, Anton Vorontsov wrote: On Fri, Sep 07, 2012 at 11:29:36AM -0700, Bryan Freed wrote: When called with a non-zero of_node, fill out a new ramoops_platform_data with data

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2012-09-17 Thread Anton Vorontsov
On Fri, Sep 07, 2012 at 10:29:10PM -0700, Anton Vorontsov wrote: > On Fri, Sep 07, 2012 at 11:29:36AM -0700, Bryan Freed wrote: > > When called with a non-zero of_node, fill out a new ramoops_platform_data > > with data from the specified Flattened Device Tree node. > > Update ramoops

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2012-09-17 Thread Anton Vorontsov
On Fri, Sep 07, 2012 at 10:29:10PM -0700, Anton Vorontsov wrote: On Fri, Sep 07, 2012 at 11:29:36AM -0700, Bryan Freed wrote: When called with a non-zero of_node, fill out a new ramoops_platform_data with data from the specified Flattened Device Tree node. Update ramoops documentation with

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2012-09-08 Thread Marco Stornelli
Il 08/09/2012 10:06, Anton Vorontsov ha scritto: On Sat, Sep 08, 2012 at 09:23:40AM +0200, Marco Stornelli wrote: [...] + pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); + if (pdata == NULL) I wonder why people prefer to not write !pdata, which is more natural when reading the

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2012-09-08 Thread Anton Vorontsov
On Sat, Sep 08, 2012 at 09:23:40AM +0200, Marco Stornelli wrote: [...] > >>+ pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); > >>+ if (pdata == NULL) > > > >I wonder why people prefer to not write !pdata, which is more natural > >when reading the code.. :-) > > I think it's the same

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2012-09-08 Thread Marco Stornelli
Il 08/09/2012 07:29, Anton Vorontsov ha scritto: On Fri, Sep 07, 2012 at 11:29:36AM -0700, Bryan Freed wrote: When called with a non-zero of_node, fill out a new ramoops_platform_data with data from the specified Flattened Device Tree node. Update ramoops documentation with the new FDT

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2012-09-08 Thread Marco Stornelli
Il 08/09/2012 07:29, Anton Vorontsov ha scritto: On Fri, Sep 07, 2012 at 11:29:36AM -0700, Bryan Freed wrote: When called with a non-zero of_node, fill out a new ramoops_platform_data with data from the specified Flattened Device Tree node. Update ramoops documentation with the new FDT

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2012-09-08 Thread Anton Vorontsov
On Sat, Sep 08, 2012 at 09:23:40AM +0200, Marco Stornelli wrote: [...] + pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); + if (pdata == NULL) I wonder why people prefer to not write !pdata, which is more natural when reading the code.. :-) I think it's the same for sizeof, it's

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2012-09-08 Thread Marco Stornelli
Il 08/09/2012 10:06, Anton Vorontsov ha scritto: On Sat, Sep 08, 2012 at 09:23:40AM +0200, Marco Stornelli wrote: [...] + pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); + if (pdata == NULL) I wonder why people prefer to not write !pdata, which is more natural when reading the

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2012-09-07 Thread Anton Vorontsov
On Fri, Sep 07, 2012 at 11:29:36AM -0700, Bryan Freed wrote: > When called with a non-zero of_node, fill out a new ramoops_platform_data > with data from the specified Flattened Device Tree node. > Update ramoops documentation with the new FDT interface. > Update devicetree/binding documentation

[PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2012-09-07 Thread Bryan Freed
When called with a non-zero of_node, fill out a new ramoops_platform_data with data from the specified Flattened Device Tree node. Update ramoops documentation with the new FDT interface. Update devicetree/binding documentation with pstore/ramoops.txt. --- I did not see any tree activity since I

[PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2012-09-07 Thread Bryan Freed
When called with a non-zero of_node, fill out a new ramoops_platform_data with data from the specified Flattened Device Tree node. Update ramoops documentation with the new FDT interface. Update devicetree/binding documentation with pstore/ramoops.txt. --- I did not see any tree activity since I

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2012-09-07 Thread Anton Vorontsov
On Fri, Sep 07, 2012 at 11:29:36AM -0700, Bryan Freed wrote: When called with a non-zero of_node, fill out a new ramoops_platform_data with data from the specified Flattened Device Tree node. Update ramoops documentation with the new FDT interface. Update devicetree/binding documentation with