Re: [PATCH v6 0/7] ARM: kprobes: enable OPTPROBES for ARM 32.

2014-10-28 Thread Jon Medhurst (Tixy)
On Mon, 2014-10-27 at 17:17 +, Jon Medhurst (Tixy) wrote: [...] > The decode table could possibly incorporate patterns to > cover instructions types that you split up in PATCH 1, e.g. so we > might not need separate PROBES_STORE and PROBES_STORE_EXTRA ( Sorry, I got that a bit wrong, the

Re: [PATCH v6 0/7] ARM: kprobes: enable OPTPROBES for ARM 32.

2014-10-28 Thread Jon Medhurst (Tixy)
On Mon, 2014-10-27 at 17:17 +, Jon Medhurst (Tixy) wrote: [...] The decode table could possibly incorporate patterns to cover instructions types that you split up in PATCH 1, e.g. so we might not need separate PROBES_STORE and PROBES_STORE_EXTRA ( Sorry, I got that a bit wrong, the first

Re: [PATCH v6 0/7] ARM: kprobes: enable OPTPROBES for ARM 32.

2014-10-27 Thread Jon Medhurst (Tixy)
On Sat, 2014-10-25 at 17:49 +0800, Wang Nan wrote: [...] > Anyway, I have done the separation. Please refer to: > > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/297031.html > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/297036.html > > There is a big

Re: [PATCH v6 0/7] ARM: kprobes: enable OPTPROBES for ARM 32.

2014-10-27 Thread Jon Medhurst (Tixy)
On Sat, 2014-10-25 at 17:49 +0800, Wang Nan wrote: [...] Anyway, I have done the separation. Please refer to: http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/297031.html http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/297036.html There is a big change

Re: [PATCH v6 0/7] ARM: kprobes: enable OPTPROBES for ARM 32.

2014-10-25 Thread Wang Nan
On 2014/10/24 17:02, Jon Medhurst (Tixy) wrote: > On Fri, 2014-10-24 at 09:52 +0900, Masami Hiramatsu wrote: >> (2014/10/22 20:31), Wang Nan wrote: >>> Previous 5 version of ARM OPTPROBES patches are unable to deal with >>> stack storing instructions correctly. V5 patches disallow optimizing >>>

Re: [PATCH v6 0/7] ARM: kprobes: enable OPTPROBES for ARM 32.

2014-10-25 Thread Wang Nan
On 2014/10/24 17:02, Jon Medhurst (Tixy) wrote: On Fri, 2014-10-24 at 09:52 +0900, Masami Hiramatsu wrote: (2014/10/22 20:31), Wang Nan wrote: Previous 5 version of ARM OPTPROBES patches are unable to deal with stack storing instructions correctly. V5 patches disallow optimizing every

Re: [PATCH v6 0/7] ARM: kprobes: enable OPTPROBES for ARM 32.

2014-10-24 Thread Jon Medhurst (Tixy)
On Fri, 2014-10-24 at 09:52 +0900, Masami Hiramatsu wrote: > (2014/10/22 20:31), Wang Nan wrote: > > Previous 5 version of ARM OPTPROBES patches are unable to deal with > > stack storing instructions correctly. V5 patches disallow optimizing > > every protential stack store instructions based on

Re: [PATCH v6 0/7] ARM: kprobes: enable OPTPROBES for ARM 32.

2014-10-24 Thread Jon Medhurst (Tixy)
On Fri, 2014-10-24 at 09:52 +0900, Masami Hiramatsu wrote: (2014/10/22 20:31), Wang Nan wrote: Previous 5 version of ARM OPTPROBES patches are unable to deal with stack storing instructions correctly. V5 patches disallow optimizing every protential stack store instructions based on

Re: [PATCH v6 0/7] ARM: kprobes: enable OPTPROBES for ARM 32.

2014-10-23 Thread Masami Hiramatsu
(2014/10/22 20:31), Wang Nan wrote: > Previous 5 version of ARM OPTPROBES patches are unable to deal with > stack storing instructions correctly. V5 patches disallow optimizing > every protential stack store instructions based on pessimistic > assumption. Which, as Tixy comments, 'excludes the

Re: [PATCH v6 0/7] ARM: kprobes: enable OPTPROBES for ARM 32.

2014-10-23 Thread Masami Hiramatsu
(2014/10/22 20:31), Wang Nan wrote: Previous 5 version of ARM OPTPROBES patches are unable to deal with stack storing instructions correctly. V5 patches disallow optimizing every protential stack store instructions based on pessimistic assumption. Which, as Tixy comments, 'excludes the main

[PATCH v6 0/7] ARM: kprobes: enable OPTPROBES for ARM 32.

2014-10-22 Thread Wang Nan
Previous 5 version of ARM OPTPROBES patches are unable to deal with stack storing instructions correctly. V5 patches disallow optimizing every protential stack store instructions based on pessimistic assumption. Which, as Tixy comments, 'excludes the main use of kprobes'.

[PATCH v6 0/7] ARM: kprobes: enable OPTPROBES for ARM 32.

2014-10-22 Thread Wang Nan
Previous 5 version of ARM OPTPROBES patches are unable to deal with stack storing instructions correctly. V5 patches disallow optimizing every protential stack store instructions based on pessimistic assumption. Which, as Tixy comments, 'excludes the main use of kprobes'.