Re: [PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

2013-02-06 Thread Federico Vaga
Hi Hans, thank you very much for your review and your patience. > OK, I'm going to give this my Acked-by, but I really wish you would > have split this up into smaller changes. It's hard to review since > you have made so many changes in this one patch. Even though I'm > giving my ack, Mauro

Re: [PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

2013-02-06 Thread Hans Verkuil
Hi Federico, OK, I'm going to give this my Acked-by, but I really wish you would have split this up into smaller changes. It's hard to review since you have made so many changes in this one patch. Even though I'm giving my ack, Mauro might decide against it, so if you have time to spread out the

Re: [PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

2013-02-06 Thread Hans Verkuil
Hi Federico, OK, I'm going to give this my Acked-by, but I really wish you would have split this up into smaller changes. It's hard to review since you have made so many changes in this one patch. Even though I'm giving my ack, Mauro might decide against it, so if you have time to spread out the

Re: [PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

2013-02-06 Thread Federico Vaga
Hi Hans, thank you very much for your review and your patience. OK, I'm going to give this my Acked-by, but I really wish you would have split this up into smaller changes. It's hard to review since you have made so many changes in this one patch. Even though I'm giving my ack, Mauro might

[PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

2013-02-05 Thread Federico Vaga
This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180). Finally the driver does not implement custom file operation but it uses the generic

[PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

2013-02-05 Thread Federico Vaga
This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180). Finally the driver does not implement custom file operation but it uses the generic

Re: [PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

2013-02-04 Thread Hans Verkuil
On Wed January 23 2013 15:07:06 Federico Vaga wrote: > This patch re-write the driver and use the videobuf2 > interface instead of the old videobuf. Moreover, it uses also > the control framework which allows the driver to inherit > controls from its subdevice (ADV7180). Finally the driver does

Re: [PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

2013-02-04 Thread Hans Verkuil
On Wed January 23 2013 15:07:06 Federico Vaga wrote: This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180). Finally the driver does not

[PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

2013-01-23 Thread Federico Vaga
This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180). Finally the driver does not implement custom file operation but it uses the generic

[PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

2013-01-23 Thread Federico Vaga
This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180). Finally the driver does not implement custom file operation but it uses the generic