Re: [PATCH v8] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2013-12-05 Thread delicious quinoa
On Thu, Dec 5, 2013 at 4:53 PM, delicious quinoa wrote: > On Thu, Dec 5, 2013 at 10:54 AM, Jamie Iles wrote: >> Hi Alan, >> >> One minor comment below, otherwise looks great! >> >> Signed-off-by: Jamie Iles >> >> Thanks, >> >> Jamie >> >> On Tue, Dec 03, 2013 at 10:41:16AM -0600, Alan Tull

Re: [PATCH v8] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2013-12-05 Thread delicious quinoa
On Wed, Dec 4, 2013 at 5:56 AM, Mark Rutland wrote: > On Tue, Dec 03, 2013 at 04:41:16PM +, Alan Tull wrote: >> From: Jamie Iles >> >> The Synopsys DesignWare block is used in some ARM devices (picoxcell) >> and can be configured to provide multiple banks of GPIO pins. >> >> Signed-off-by:

Re: [PATCH v8] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2013-12-05 Thread delicious quinoa
On Thu, Dec 5, 2013 at 10:54 AM, Jamie Iles wrote: > Hi Alan, > > One minor comment below, otherwise looks great! > > Signed-off-by: Jamie Iles > > Thanks, > > Jamie > > On Tue, Dec 03, 2013 at 10:41:16AM -0600, Alan Tull wrote: >> diff --git a/drivers/gpio/gpio-dwapb.c

Re: [PATCH v8] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2013-12-05 Thread Jamie Iles
Hi Alan, One minor comment below, otherwise looks great! Signed-off-by: Jamie Iles Thanks, Jamie On Tue, Dec 03, 2013 at 10:41:16AM -0600, Alan Tull wrote: > diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c > new file mode 100644 > index 000..e6dc61f > --- /dev/null >

Re: [PATCH v8] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2013-12-05 Thread Jamie Iles
Hi Alan, One minor comment below, otherwise looks great! Signed-off-by: Jamie Iles ja...@jamieiles.com Thanks, Jamie On Tue, Dec 03, 2013 at 10:41:16AM -0600, Alan Tull wrote: diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c new file mode 100644 index 000..e6dc61f

Re: [PATCH v8] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2013-12-05 Thread delicious quinoa
On Thu, Dec 5, 2013 at 10:54 AM, Jamie Iles ja...@jamieiles.com wrote: Hi Alan, One minor comment below, otherwise looks great! Signed-off-by: Jamie Iles ja...@jamieiles.com Thanks, Jamie On Tue, Dec 03, 2013 at 10:41:16AM -0600, Alan Tull wrote: diff --git a/drivers/gpio/gpio-dwapb.c

Re: [PATCH v8] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2013-12-05 Thread delicious quinoa
On Wed, Dec 4, 2013 at 5:56 AM, Mark Rutland mark.rutl...@arm.com wrote: On Tue, Dec 03, 2013 at 04:41:16PM +, Alan Tull wrote: From: Jamie Iles ja...@jamieiles.com The Synopsys DesignWare block is used in some ARM devices (picoxcell) and can be configured to provide multiple banks of

Re: [PATCH v8] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2013-12-05 Thread delicious quinoa
On Thu, Dec 5, 2013 at 4:53 PM, delicious quinoa delicious.qui...@gmail.com wrote: On Thu, Dec 5, 2013 at 10:54 AM, Jamie Iles ja...@jamieiles.com wrote: Hi Alan, One minor comment below, otherwise looks great! Signed-off-by: Jamie Iles ja...@jamieiles.com Thanks, Jamie On Tue, Dec 03,

Re: [PATCH v8] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2013-12-04 Thread Mark Rutland
On Tue, Dec 03, 2013 at 04:41:16PM +, Alan Tull wrote: > From: Jamie Iles > > The Synopsys DesignWare block is used in some ARM devices (picoxcell) > and can be configured to provide multiple banks of GPIO pins. > > Signed-off-by: Alan Tull > Reviewed-by: Sebastian Hesselbarth > > v8:

Re: [PATCH v8] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2013-12-04 Thread Mark Rutland
On Tue, Dec 03, 2013 at 04:41:16PM +, Alan Tull wrote: From: Jamie Iles ja...@jamieiles.com The Synopsys DesignWare block is used in some ARM devices (picoxcell) and can be configured to provide multiple banks of GPIO pins. Signed-off-by: Alan Tull at...@altera.com Reviewed-by:

[PATCH v8] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2013-12-03 Thread Alan Tull
From: Jamie Iles The Synopsys DesignWare block is used in some ARM devices (picoxcell) and can be configured to provide multiple banks of GPIO pins. Signed-off-by: Alan Tull Reviewed-by: Sebastian Hesselbarth v8: - remove socfpga.dtsi changes - minor cleanup in devicetree

[PATCH v8] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2013-12-03 Thread Alan Tull
From: Jamie Iles ja...@jamieiles.com The Synopsys DesignWare block is used in some ARM devices (picoxcell) and can be configured to provide multiple banks of GPIO pins. Signed-off-by: Alan Tull at...@altera.com Reviewed-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com v8: - remove