Re: [PATCHv2 00/18] perf tools: Factor ordered samples queue

2014-06-20 Thread Jiri Olsa
On Thu, Jun 19, 2014 at 11:54:40AM -0600, David Ahern wrote: > On 6/19/14, 4:34 AM, Jiri Olsa wrote: > >>I've skimmed through the patches. What happens if you are in the middle of a > >>round and the max queue size is reached? > > > >half of the queue (time half) is flushed to make some free space

Re: [PATCHv2 00/18] perf tools: Factor ordered samples queue

2014-06-20 Thread Jiri Olsa
On Thu, Jun 19, 2014 at 11:54:40AM -0600, David Ahern wrote: On 6/19/14, 4:34 AM, Jiri Olsa wrote: I've skimmed through the patches. What happens if you are in the middle of a round and the max queue size is reached? half of the queue (time half) is flushed to make some free space right,

Re: [PATCHv2 00/18] perf tools: Factor ordered samples queue

2014-06-19 Thread David Ahern
On 6/19/14, 4:34 AM, Jiri Olsa wrote: I've skimmed through the patches. What happens if you are in the middle of a round and the max queue size is reached? half of the queue (time half) is flushed to make some free space right, I believe there will be scenarios where that will cause failures

Re: [PATCHv2 00/18] perf tools: Factor ordered samples queue

2014-06-19 Thread Jiri Olsa
On Wed, Jun 18, 2014 at 01:44:46PM -0600, David Ahern wrote: SNIP > > > >Also now we have one of our big memory spender under control > >and the ordered events queue code is put in separated object > >with clear interface ready to be used by another command > >like script. > > > >Also reachable

Re: [PATCHv2 00/18] perf tools: Factor ordered samples queue

2014-06-19 Thread Jiri Olsa
On Wed, Jun 18, 2014 at 01:44:46PM -0600, David Ahern wrote: SNIP Also now we have one of our big memory spender under control and the ordered events queue code is put in separated object with clear interface ready to be used by another command like script. Also reachable in here:

Re: [PATCHv2 00/18] perf tools: Factor ordered samples queue

2014-06-19 Thread David Ahern
On 6/19/14, 4:34 AM, Jiri Olsa wrote: I've skimmed through the patches. What happens if you are in the middle of a round and the max queue size is reached? half of the queue (time half) is flushed to make some free space right, I believe there will be scenarios where that will cause failures

Re: [PATCHv2 00/18] perf tools: Factor ordered samples queue

2014-06-18 Thread David Ahern
On 6/18/14, 8:58 AM, Jiri Olsa wrote: hi, this patchset factors session's ordered samples queue, and allows to limit the size of this queue. v2 changes: - several small changes for review comments (Namhyung) The report command queues events till any of following conditions is reached: -

[PATCHv2 00/18] perf tools: Factor ordered samples queue

2014-06-18 Thread Jiri Olsa
hi, this patchset factors session's ordered samples queue, and allows to limit the size of this queue. v2 changes: - several small changes for review comments (Namhyung) The report command queues events till any of following conditions is reached: - PERF_RECORD_FINISHED_ROUND event is

[PATCHv2 00/18] perf tools: Factor ordered samples queue

2014-06-18 Thread Jiri Olsa
hi, this patchset factors session's ordered samples queue, and allows to limit the size of this queue. v2 changes: - several small changes for review comments (Namhyung) The report command queues events till any of following conditions is reached: - PERF_RECORD_FINISHED_ROUND event is

Re: [PATCHv2 00/18] perf tools: Factor ordered samples queue

2014-06-18 Thread David Ahern
On 6/18/14, 8:58 AM, Jiri Olsa wrote: hi, this patchset factors session's ordered samples queue, and allows to limit the size of this queue. v2 changes: - several small changes for review comments (Namhyung) The report command queues events till any of following conditions is reached: -