Re: [Query]: sched/fair: prio_changed_fair()

2012-11-06 Thread Viresh Kumar
On 7 November 2012 13:26, Michael Wang wrote: > It's the user nice value I suppose, so it should be reversed when we are > talking about weight. Ahh.. I knew it .. How can i miss it. Sorry for the noise :( -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [Query]: sched/fair: prio_changed_fair()

2012-11-06 Thread Michael Wang
On 11/07/2012 03:49 PM, Viresh Kumar wrote: Hi, Viresh > Hi Ingo/Peter, > > I am trying to understand the complex scheduler code and just found > something incorrect (maybe i am not reading it well): > > File: kernel/sched/fair.c > > static void > prio_changed_fair(struct rq *rq, struct

[Query]: sched/fair: prio_changed_fair()

2012-11-06 Thread Viresh Kumar
Hi Ingo/Peter, I am trying to understand the complex scheduler code and just found something incorrect (maybe i am not reading it well): File: kernel/sched/fair.c static void prio_changed_fair(struct rq *rq, struct task_struct *p, int oldprio) { if (!p->se.on_rq) return;

[Query]: sched/fair: prio_changed_fair()

2012-11-06 Thread Viresh Kumar
Hi Ingo/Peter, I am trying to understand the complex scheduler code and just found something incorrect (maybe i am not reading it well): File: kernel/sched/fair.c static void prio_changed_fair(struct rq *rq, struct task_struct *p, int oldprio) { if (!p-se.on_rq) return;

Re: [Query]: sched/fair: prio_changed_fair()

2012-11-06 Thread Michael Wang
On 11/07/2012 03:49 PM, Viresh Kumar wrote: Hi, Viresh Hi Ingo/Peter, I am trying to understand the complex scheduler code and just found something incorrect (maybe i am not reading it well): File: kernel/sched/fair.c static void prio_changed_fair(struct rq *rq, struct task_struct *p,

Re: [Query]: sched/fair: prio_changed_fair()

2012-11-06 Thread Viresh Kumar
On 7 November 2012 13:26, Michael Wang wang...@linux.vnet.ibm.com wrote: It's the user nice value I suppose, so it should be reversed when we are talking about weight. Ahh.. I knew it .. How can i miss it. Sorry for the noise :( -- viresh -- To unsubscribe from this list: send the line