Re: [RFC] Add implicit barriers to irqsave/restore class of functions

2013-04-04 Thread Vineet Gupta
Hi Peter, On 04/04/2013 09:43 PM, Peter Zijlstra wrote: > - : "cc"); > + : "memory", "cc"); > That's not a memory barrier, that a memory clobber, aka a compiler > barrier. For the problem under consideration we indeed want a compiler barrier because the error shows up due to a stale

Re: [RFC] Add implicit barriers to irqsave/restore class of functions

2013-04-04 Thread Peter Zijlstra
On Wed, 2013-04-03 at 15:10 +0200, Christian Ruppert wrote: > This patch adds implicit memory barriers to irqsave/restore functions > of > the ARC architecture port in line with what is done in other > architectures. > diff --git a/arch/arc/include/asm/irqflags.h >

Re: [RFC] Add implicit barriers to irqsave/restore class of functions

2013-04-04 Thread Christian Ruppert
Hi Vineet, Just a short message to inform you that the test campaign on our RFC patch has run through successfully and we consider the patch stable enough for release to our customers. The main reason the barriers were added in this particular place is because other architectures do the same. I

Re: [RFC] Add implicit barriers to irqsave/restore class of functions

2013-04-04 Thread Christian Ruppert
Hi Vineet, Just a short message to inform you that the test campaign on our RFC patch has run through successfully and we consider the patch stable enough for release to our customers. The main reason the barriers were added in this particular place is because other architectures do the same. I

Re: [RFC] Add implicit barriers to irqsave/restore class of functions

2013-04-04 Thread Peter Zijlstra
On Wed, 2013-04-03 at 15:10 +0200, Christian Ruppert wrote: This patch adds implicit memory barriers to irqsave/restore functions of the ARC architecture port in line with what is done in other architectures. diff --git a/arch/arc/include/asm/irqflags.h b/arch/arc/include/asm/irqflags.h

Re: [RFC] Add implicit barriers to irqsave/restore class of functions

2013-04-04 Thread Vineet Gupta
Hi Peter, On 04/04/2013 09:43 PM, Peter Zijlstra wrote: - : cc); + : memory, cc); That's not a memory barrier, that a memory clobber, aka a compiler barrier. For the problem under consideration we indeed want a compiler barrier because the error shows up due to a stale register

Re: [RFC] Add implicit barriers to irqsave/restore class of functions

2013-04-03 Thread Vineet Gupta
Hi Christian, On 04/03/2013 06:40 PM, Christian Ruppert wrote: > This patch adds implicit memory barriers to irqsave/restore functions of > the ARC architecture port in line with what is done in other architectures. > > It seems to fix several seemingly unrelated issues in our platform but for >

[RFC] Add implicit barriers to irqsave/restore class of functions

2013-04-03 Thread Christian Ruppert
This patch adds implicit memory barriers to irqsave/restore functions of the ARC architecture port in line with what is done in other architectures. It seems to fix several seemingly unrelated issues in our platform but for the moment it is insufficiently tested (and might even be incomplete).

[RFC] Add implicit barriers to irqsave/restore class of functions

2013-04-03 Thread Christian Ruppert
This patch adds implicit memory barriers to irqsave/restore functions of the ARC architecture port in line with what is done in other architectures. It seems to fix several seemingly unrelated issues in our platform but for the moment it is insufficiently tested (and might even be incomplete).

Re: [RFC] Add implicit barriers to irqsave/restore class of functions

2013-04-03 Thread Vineet Gupta
Hi Christian, On 04/03/2013 06:40 PM, Christian Ruppert wrote: This patch adds implicit memory barriers to irqsave/restore functions of the ARC architecture port in line with what is done in other architectures. It seems to fix several seemingly unrelated issues in our platform but for the