Re: [RFC PATCH v1 1/1] arm64: Unwinder enhancements for reliable stack trace

2021-03-01 Thread Madhavan T. Venkataraman
On 2/25/21 5:58 AM, Mark Rutland wrote: > On Wed, Feb 24, 2021 at 01:34:09PM -0600, Madhavan T. Venkataraman wrote: >> On 2/24/21 6:17 AM, Mark Rutland wrote: >>> On Tue, Feb 23, 2021 at 12:12:43PM -0600, madve...@linux.microsoft.com >>> wrote: From: "Madhavan T. Venkataraman"

Re: [RFC PATCH v1 1/1] arm64: Unwinder enhancements for reliable stack trace

2021-02-25 Thread Mark Rutland
On Wed, Feb 24, 2021 at 01:34:09PM -0600, Madhavan T. Venkataraman wrote: > On 2/24/21 6:17 AM, Mark Rutland wrote: > > On Tue, Feb 23, 2021 at 12:12:43PM -0600, madve...@linux.microsoft.com > > wrote: > >> From: "Madhavan T. Venkataraman" > >>Termination > >>=== > >> > >>

Re: [RFC PATCH v1 1/1] arm64: Unwinder enhancements for reliable stack trace

2021-02-24 Thread Madhavan T. Venkataraman
On 2/24/21 6:17 AM, Mark Rutland wrote: > Hi Madhavan, > > As Mark Brown says, I think this needs to be split into several > patches. i have some comments on the general approach, but I'll save > in-depth review until this has been split. > OK. > On Tue, Feb 23, 2021 at 12:12:43PM -0600,

Re: [RFC PATCH v1 1/1] arm64: Unwinder enhancements for reliable stack trace

2021-02-24 Thread Madhavan T. Venkataraman
On 2/24/21 6:33 AM, Mark Brown wrote: > On Tue, Feb 23, 2021 at 01:20:49PM -0600, Madhavan T. Venkataraman wrote: >> On 2/23/21 1:02 PM, Mark Brown wrote: >>> On Tue, Feb 23, 2021 at 12:12:43PM -0600, madve...@linux.microsoft.com >>> wrote: > Reliable stack trace function

Re: [RFC PATCH v1 1/1] arm64: Unwinder enhancements for reliable stack trace

2021-02-24 Thread Mark Brown
On Tue, Feb 23, 2021 at 01:20:49PM -0600, Madhavan T. Venkataraman wrote: > On 2/23/21 1:02 PM, Mark Brown wrote: > > On Tue, Feb 23, 2021 at 12:12:43PM -0600, madve...@linux.microsoft.com > > wrote: > >> Reliable stack trace function > >> = > >> > >> Implement

Re: [RFC PATCH v1 1/1] arm64: Unwinder enhancements for reliable stack trace

2021-02-24 Thread Mark Rutland
Hi Madhavan, As Mark Brown says, I think this needs to be split into several patches. i have some comments on the general approach, but I'll save in-depth review until this has been split. On Tue, Feb 23, 2021 at 12:12:43PM -0600, madve...@linux.microsoft.com wrote: > From: "Madhavan T.

Re: [RFC PATCH v1 1/1] arm64: Unwinder enhancements for reliable stack trace

2021-02-23 Thread Madhavan T. Venkataraman
On 2/23/21 1:02 PM, Mark Brown wrote: > On Tue, Feb 23, 2021 at 12:12:43PM -0600, madve...@linux.microsoft.com wrote: >> From: "Madhavan T. Venkataraman" >> >> Unwinder changes >> > > This is making several different changes so should be split into a patch > series - for

Re: [RFC PATCH v1 1/1] arm64: Unwinder enhancements for reliable stack trace

2021-02-23 Thread Mark Brown
On Tue, Feb 23, 2021 at 12:12:43PM -0600, madve...@linux.microsoft.com wrote: > From: "Madhavan T. Venkataraman" > > Unwinder changes > This is making several different changes so should be split into a patch series - for example the change to terminate on a specific function

[RFC PATCH v1 1/1] arm64: Unwinder enhancements for reliable stack trace

2021-02-23 Thread madvenka
From: "Madhavan T. Venkataraman" Unwinder changes Termination === Currently, the unwinder terminates when both the FP (frame pointer) and the PC (return address) of a frame are 0. But a frame could get corrupted and zeroed. There