Re: [patch v6 03/21] sched: only count runnable avg on cfs_rq's nr_running

2013-04-02 Thread Alex Shi
On 04/03/2013 09:23 AM, Paul Turner wrote: > Nack: > Vincent is correct, rq->avg is supposed to be the average time that an > rq is runnable; this includes (for example) SCHED_RT. > > It's intended to be more useful as a hint towards something like a > power governor which wants to know how busy

Re: [patch v6 03/21] sched: only count runnable avg on cfs_rq's nr_running

2013-04-02 Thread Paul Turner
Nack: Vincent is correct, rq->avg is supposed to be the average time that an rq is runnable; this includes (for example) SCHED_RT. It's intended to be more useful as a hint towards something like a power governor which wants to know how busy the CPU is in general. > On the other side, periodic

Re: [patch v6 03/21] sched: only count runnable avg on cfs_rq's nr_running

2013-04-02 Thread Alex Shi
On 04/02/2013 10:30 PM, Vincent Guittot wrote: > On 30 March 2013 15:34, Alex Shi wrote: >> Old function count the runnable avg on rq's nr_running even there is >> only rt task in rq. That is incorrect, so correct it to cfs_rq's >> nr_running. >> >> Signed-off-by: Alex Shi >> --- >>

Re: [patch v6 03/21] sched: only count runnable avg on cfs_rq's nr_running

2013-04-02 Thread Vincent Guittot
On 30 March 2013 15:34, Alex Shi wrote: > Old function count the runnable avg on rq's nr_running even there is > only rt task in rq. That is incorrect, so correct it to cfs_rq's > nr_running. > > Signed-off-by: Alex Shi > --- > kernel/sched/fair.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [patch v6 03/21] sched: only count runnable avg on cfs_rq's nr_running

2013-04-02 Thread Vincent Guittot
On 30 March 2013 15:34, Alex Shi alex@intel.com wrote: Old function count the runnable avg on rq's nr_running even there is only rt task in rq. That is incorrect, so correct it to cfs_rq's nr_running. Signed-off-by: Alex Shi alex@intel.com --- kernel/sched/fair.c | 2 +- 1 file

Re: [patch v6 03/21] sched: only count runnable avg on cfs_rq's nr_running

2013-04-02 Thread Alex Shi
On 04/02/2013 10:30 PM, Vincent Guittot wrote: On 30 March 2013 15:34, Alex Shi alex@intel.com wrote: Old function count the runnable avg on rq's nr_running even there is only rt task in rq. That is incorrect, so correct it to cfs_rq's nr_running. Signed-off-by: Alex Shi

Re: [patch v6 03/21] sched: only count runnable avg on cfs_rq's nr_running

2013-04-02 Thread Paul Turner
Nack: Vincent is correct, rq-avg is supposed to be the average time that an rq is runnable; this includes (for example) SCHED_RT. It's intended to be more useful as a hint towards something like a power governor which wants to know how busy the CPU is in general. On the other side, periodic LB

Re: [patch v6 03/21] sched: only count runnable avg on cfs_rq's nr_running

2013-04-02 Thread Alex Shi
On 04/03/2013 09:23 AM, Paul Turner wrote: Nack: Vincent is correct, rq-avg is supposed to be the average time that an rq is runnable; this includes (for example) SCHED_RT. It's intended to be more useful as a hint towards something like a power governor which wants to know how busy the CPU

[patch v6 03/21] sched: only count runnable avg on cfs_rq's nr_running

2013-03-30 Thread Alex Shi
Old function count the runnable avg on rq's nr_running even there is only rt task in rq. That is incorrect, so correct it to cfs_rq's nr_running. Signed-off-by: Alex Shi --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c

[patch v6 03/21] sched: only count runnable avg on cfs_rq's nr_running

2013-03-30 Thread Alex Shi
Old function count the runnable avg on rq's nr_running even there is only rt task in rq. That is incorrect, so correct it to cfs_rq's nr_running. Signed-off-by: Alex Shi alex@intel.com --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git