Re: 2nd attempt: help with dma_alloc_coherent() + dma_free_coherent()

2013-01-08 Thread Jeff Chua
On Wed, Jan 9, 2013 at 1:24 AM, Linus Torvalds wrote: > On Tue, Jan 8, 2013 at 9:17 AM, Jeff Chua wrote: >> >> Interesting, but there are 54 lines under the kernel directories that >> use "dma_alloc_coherent(NULL," followed by "dma_free_coherent(NULL," > > As mentioned, it works on some

Re: 2nd attempt: help with dma_alloc_coherent() + dma_free_coherent()

2013-01-08 Thread Linus Torvalds
On Tue, Jan 8, 2013 at 9:17 AM, Jeff Chua wrote: > > Interesting, but there are 54 lines under the kernel directories that > use "dma_alloc_coherent(NULL," followed by "dma_free_coherent(NULL," As mentioned, it works on some platforms. That doesn't make it right. > So, shouldn't they be fixed

Re: 2nd attempt: help with dma_alloc_coherent() + dma_free_coherent()

2013-01-08 Thread Jeff Chua
On Wed, Jan 9, 2013 at 12:39 AM, Linus Torvalds wrote: > On Tue, Jan 8, 2013 at 7:51 AM, Jeff Chua wrote: >> No response so far ... I'm sure someone know this stuff ... Thanks, Jeff. >> >> I'm trying to understand how this oops in the diva driver and it's just a >> simple dma_alloc_coherent()

Re: 2nd attempt: help with dma_alloc_coherent() + dma_free_coherent()

2013-01-08 Thread Linus Torvalds
On Tue, Jan 8, 2013 at 7:51 AM, Jeff Chua wrote: > No response so far ... I'm sure someone know this stuff ... Thanks, Jeff. > > I'm trying to understand how this oops in the diva driver and it's just a > simple dma_alloc_coherent() followed by dma_free_coherent(), but it oops. > Why? Umm.

Re: 2nd attempt: help with dma_alloc_coherent() + dma_free_coherent()

2013-01-08 Thread Jonathan Corbet
On Tue, 8 Jan 2013 23:51:59 +0800 Jeff Chua wrote: > I'm trying to understand how this oops in the diva driver and it's just a > simple dma_alloc_coherent() followed by dma_free_coherent(), but it oops. > Why? Hmm...from a quick look... > static u32 *clock_data_addr; > static dma_addr_t

Re: 2nd attempt: help with dma_alloc_coherent() + dma_free_coherent()

2013-01-08 Thread Jonathan Corbet
On Tue, 8 Jan 2013 23:51:59 +0800 Jeff Chua jeff.chua.li...@gmail.com wrote: I'm trying to understand how this oops in the diva driver and it's just a simple dma_alloc_coherent() followed by dma_free_coherent(), but it oops. Why? Hmm...from a quick look... static u32 *clock_data_addr;

Re: 2nd attempt: help with dma_alloc_coherent() + dma_free_coherent()

2013-01-08 Thread Linus Torvalds
On Tue, Jan 8, 2013 at 7:51 AM, Jeff Chua jeff.chua.li...@gmail.com wrote: No response so far ... I'm sure someone know this stuff ... Thanks, Jeff. I'm trying to understand how this oops in the diva driver and it's just a simple dma_alloc_coherent() followed by dma_free_coherent(), but it

Re: 2nd attempt: help with dma_alloc_coherent() + dma_free_coherent()

2013-01-08 Thread Jeff Chua
On Wed, Jan 9, 2013 at 12:39 AM, Linus Torvalds torva...@linux-foundation.org wrote: On Tue, Jan 8, 2013 at 7:51 AM, Jeff Chua jeff.chua.li...@gmail.com wrote: No response so far ... I'm sure someone know this stuff ... Thanks, Jeff. I'm trying to understand how this oops in the diva driver

Re: 2nd attempt: help with dma_alloc_coherent() + dma_free_coherent()

2013-01-08 Thread Linus Torvalds
On Tue, Jan 8, 2013 at 9:17 AM, Jeff Chua jeff.chua.li...@gmail.com wrote: Interesting, but there are 54 lines under the kernel directories that use dma_alloc_coherent(NULL, followed by dma_free_coherent(NULL, As mentioned, it works on some platforms. That doesn't make it right. So,

Re: 2nd attempt: help with dma_alloc_coherent() + dma_free_coherent()

2013-01-08 Thread Jeff Chua
On Wed, Jan 9, 2013 at 1:24 AM, Linus Torvalds torva...@linux-foundation.org wrote: On Tue, Jan 8, 2013 at 9:17 AM, Jeff Chua jeff.chua.li...@gmail.com wrote: Interesting, but there are 54 lines under the kernel directories that use dma_alloc_coherent(NULL, followed by dma_free_coherent(NULL,