Re: GAK!!!! Re: PCI: AMD SATA IDE mode quirk

2008-02-26 Thread Alan Cox
> I agree. I [obviously] missed this when I ack'd, mainly ack'ing the > overall change. > > BIOS certainly may modify that PCI config register, but that's before > the kernel boots. So, using pdev->class is fine. I don't think the resume quirk is needed either as the core PCI save/restore

Re: GAK!!!! Re: PCI: AMD SATA IDE mode quirk

2008-02-26 Thread Alan Cox
I agree. I [obviously] missed this when I ack'd, mainly ack'ing the overall change. BIOS certainly may modify that PCI config register, but that's before the kernel boots. So, using pdev-class is fine. I don't think the resume quirk is needed either as the core PCI save/restore code

Re: GAK!!!! Re: PCI: AMD SATA IDE mode quirk

2008-02-25 Thread Crane Cai
在 2008-02-26Tue的 06:53 +0800,Jeff Garzik写道: > Alan Cox wrote: > >> Signed-off-by: Crane Cai <[EMAIL PROTECTED]> > >> Acked-by: Jeff Garzik <[EMAIL PROTECTED]> > >> Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> > > > > Vomitted-upon-by: Alan Cox <[EMAIL PROTECTED]> > > > >> -

Re: GAK!!!! Re: PCI: AMD SATA IDE mode quirk

2008-02-25 Thread Jeff Garzik
Alan Cox wrote: Signed-off-by: Crane Cai <[EMAIL PROTECTED]> Acked-by: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> Vomitted-upon-by: Alan Cox <[EMAIL PROTECTED]> - if ((pdev->class >> 8) == PCI_CLASS_STORAGE_IDE) { -

Re: GAK!!!! Re: PCI: AMD SATA IDE mode quirk

2008-02-25 Thread Jeff Garzik
Alan Cox wrote: Signed-off-by: Crane Cai [EMAIL PROTECTED] Acked-by: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] Vomitted-upon-by: Alan Cox [EMAIL PROTECTED] - if ((pdev-class 8) == PCI_CLASS_STORAGE_IDE) { - u8 tmp; +

Re: GAK!!!! Re: PCI: AMD SATA IDE mode quirk

2008-02-25 Thread Crane Cai
在 2008-02-26Tue的 06:53 +0800,Jeff Garzik写道: Alan Cox wrote: Signed-off-by: Crane Cai [EMAIL PROTECTED] Acked-by: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] Vomitted-upon-by: Alan Cox [EMAIL PROTECTED] -if ((pdev-class 8) ==

Re: GAK!!!! Re: PCI: AMD SATA IDE mode quirk

2008-02-22 Thread Jiri Slaby
On 02/22/2008 11:02 AM, Alan Cox wrote: On Fri, 22 Feb 2008 09:48:28 + Alan Cox <[EMAIL PROTECTED]> wrote: Signed-off-by: Crane Cai <[EMAIL PROTECTED]> Acked-by: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> Vomitted-upon-by: Alan Cox

Re: GAK!!!! Re: PCI: AMD SATA IDE mode quirk

2008-02-22 Thread Alan Cox
On Fri, 22 Feb 2008 09:48:28 + Alan Cox <[EMAIL PROTECTED]> wrote: > > Signed-off-by: Crane Cai <[EMAIL PROTECTED]> > > Acked-by: Jeff Garzik <[EMAIL PROTECTED]> > > Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> > > Vomitted-upon-by: Alan Cox <[EMAIL PROTECTED]> > > > -

GAK!!!! Re: PCI: AMD SATA IDE mode quirk

2008-02-22 Thread Alan Cox
> Signed-off-by: Crane Cai <[EMAIL PROTECTED]> > Acked-by: Jeff Garzik <[EMAIL PROTECTED]> > Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> Vomitted-upon-by: Alan Cox <[EMAIL PROTECTED]> > - if ((pdev->class >> 8) == PCI_CLASS_STORAGE_IDE) { > - u8 tmp; > +

Re: GAK!!!! Re: PCI: AMD SATA IDE mode quirk

2008-02-22 Thread Alan Cox
On Fri, 22 Feb 2008 09:48:28 + Alan Cox [EMAIL PROTECTED] wrote: Signed-off-by: Crane Cai [EMAIL PROTECTED] Acked-by: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] Vomitted-upon-by: Alan Cox [EMAIL PROTECTED] - if ((pdev-class 8)

GAK!!!! Re: PCI: AMD SATA IDE mode quirk

2008-02-22 Thread Alan Cox
Signed-off-by: Crane Cai [EMAIL PROTECTED] Acked-by: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] Vomitted-upon-by: Alan Cox [EMAIL PROTECTED] - if ((pdev-class 8) == PCI_CLASS_STORAGE_IDE) { - u8 tmp; + /* set

Re: GAK!!!! Re: PCI: AMD SATA IDE mode quirk

2008-02-22 Thread Jiri Slaby
On 02/22/2008 11:02 AM, Alan Cox wrote: On Fri, 22 Feb 2008 09:48:28 + Alan Cox [EMAIL PROTECTED] wrote: Signed-off-by: Crane Cai [EMAIL PROTECTED] Acked-by: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] Vomitted-upon-by: Alan Cox [EMAIL