Re: Module init call vs symbols exporting race?

2007-11-12 Thread Jan Glauber
On Sat, 2007-11-10 at 18:27 +1100, Rusty Russell wrote: > We fail rather than sleep in the "dependency isn't ready" case. Partially > because it's not happened before, but partially because we risk nasty loops. If we fail since we have to in the "dependency isn't ready" case then the warning

Re: Module init call vs symbols exporting race?

2007-11-12 Thread Jan Glauber
On Sat, 2007-11-10 at 18:27 +1100, Rusty Russell wrote: We fail rather than sleep in the dependency isn't ready case. Partially because it's not happened before, but partially because we risk nasty loops. If we fail since we have to in the dependency isn't ready case then the warning seems

Re: Module init call vs symbols exporting race?

2007-11-10 Thread Andi Kleen
Jan Glauber <[EMAIL PROTECTED]> writes: > I've seen a symbol-resolving race on s390. The qeth module uses symbols > from qdio and although the loading order seems correct and the qdio > symbols should be available the following error appears: FWIW i see such messages all the time with usb serial

Re: Module init call vs symbols exporting race?

2007-11-10 Thread Andi Kleen
Jan Glauber [EMAIL PROTECTED] writes: I've seen a symbol-resolving race on s390. The qeth module uses symbols from qdio and although the loading order seems correct and the qdio symbols should be available the following error appears: FWIW i see such messages all the time with usb serial on

Re: Module init call vs symbols exporting race?

2007-11-09 Thread Rusty Russell
On Friday 09 November 2007 23:16:47 Jan Glauber wrote: > On Fri, 2007-11-09 at 06:44 -0500, Jon Masters wrote: > > On Thu, 2007-11-08 at 13:10 +1100, Rusty Russell wrote: > > > On Wednesday 07 November 2007 21:01:30 Jan Glauber wrote: > > > > Hi Rusty, > > > > > > > > I've seen a symbol-resolving

Re: Module init call vs symbols exporting race?

2007-11-09 Thread Jan Glauber
On Thu, 2007-11-08 at 13:10 +1100, Rusty Russell wrote: > On Wednesday 07 November 2007 21:01:30 Jan Glauber wrote: > > Hi Rusty, > > > > I've seen a symbol-resolving race on s390. The qeth module uses symbols > > from qdio and although the loading order seems correct and the qdio > > symbols

Re: Module init call vs symbols exporting race?

2007-11-09 Thread Jon Masters
On Thu, 2007-11-08 at 13:10 +1100, Rusty Russell wrote: > On Wednesday 07 November 2007 21:01:30 Jan Glauber wrote: > > Hi Rusty, > > > > I've seen a symbol-resolving race on s390. The qeth module uses symbols > > from qdio and although the loading order seems correct and the qdio > > symbols

Re: Module init call vs symbols exporting race?

2007-11-09 Thread Rusty Russell
On Friday 09 November 2007 23:16:47 Jan Glauber wrote: On Fri, 2007-11-09 at 06:44 -0500, Jon Masters wrote: On Thu, 2007-11-08 at 13:10 +1100, Rusty Russell wrote: On Wednesday 07 November 2007 21:01:30 Jan Glauber wrote: Hi Rusty, I've seen a symbol-resolving race on s390. The

Re: Module init call vs symbols exporting race?

2007-11-09 Thread Jon Masters
On Thu, 2007-11-08 at 13:10 +1100, Rusty Russell wrote: On Wednesday 07 November 2007 21:01:30 Jan Glauber wrote: Hi Rusty, I've seen a symbol-resolving race on s390. The qeth module uses symbols from qdio and although the loading order seems correct and the qdio symbols should be

Re: Module init call vs symbols exporting race?

2007-11-09 Thread Jan Glauber
On Thu, 2007-11-08 at 13:10 +1100, Rusty Russell wrote: On Wednesday 07 November 2007 21:01:30 Jan Glauber wrote: Hi Rusty, I've seen a symbol-resolving race on s390. The qeth module uses symbols from qdio and although the loading order seems correct and the qdio symbols should be

Re: Module init call vs symbols exporting race?

2007-11-07 Thread Rusty Russell
On Wednesday 07 November 2007 21:01:30 Jan Glauber wrote: > Hi Rusty, > > I've seen a symbol-resolving race on s390. The qeth module uses symbols > from qdio and although the loading order seems correct and the qdio > symbols should be available the following error appears: > > qdio: loading QDIO

Re: Module init call vs symbols exporting race?

2007-11-07 Thread Jan Glauber
Hi Rusty, I've seen a symbol-resolving race on s390. The qeth module uses symbols from qdio and although the loading order seems correct and the qdio symbols should be available the following error appears: qdio: loading QDIO base support version 2 qeth: Unknown symbol qdio_synchronize qeth:

Re: Module init call vs symbols exporting race?

2007-11-07 Thread Jan Glauber
Hi Rusty, I've seen a symbol-resolving race on s390. The qeth module uses symbols from qdio and although the loading order seems correct and the qdio symbols should be available the following error appears: qdio: loading QDIO base support version 2 qeth: Unknown symbol qdio_synchronize qeth:

Re: Module init call vs symbols exporting race?

2007-11-07 Thread Rusty Russell
On Wednesday 07 November 2007 21:01:30 Jan Glauber wrote: Hi Rusty, I've seen a symbol-resolving race on s390. The qeth module uses symbols from qdio and although the loading order seems correct and the qdio symbols should be available the following error appears: qdio: loading QDIO base

Re: Module init call vs symbols exporting race?

2007-11-06 Thread Rusty Russell
On Tuesday 06 November 2007 20:20:58 Pavel Emelyanov wrote: > Hi. > > I looked at the sys_init_module() and found that the ->init callback > for the module is called without the module_mutex held and *after* > the module's symbols are exported. Doesn't this create the race when > loading two

Module init call vs symbols exporting race?

2007-11-06 Thread Pavel Emelyanov
Hi. I looked at the sys_init_module() and found that the ->init callback for the module is called without the module_mutex held and *after* the module's symbols are exported. Doesn't this create the race when loading two modules in parallel? Like this. Consider the first module to be (without

Module init call vs symbols exporting race?

2007-11-06 Thread Pavel Emelyanov
Hi. I looked at the sys_init_module() and found that the -init callback for the module is called without the module_mutex held and *after* the module's symbols are exported. Doesn't this create the race when loading two modules in parallel? Like this. Consider the first module to be (without any

Re: Module init call vs symbols exporting race?

2007-11-06 Thread Rusty Russell
On Tuesday 06 November 2007 20:20:58 Pavel Emelyanov wrote: Hi. I looked at the sys_init_module() and found that the -init callback for the module is called without the module_mutex held and *after* the module's symbols are exported. Doesn't this create the race when loading two modules in