RE: [PATCH 2/3] iio: adc: add new lp8788 adc driver

2012-08-10 Thread Kim, Milo
> This is mostly fine though things have gotten a little confused > wrt to the handling iio_priv in the probe and remove so that > needs cleaning up. A few other minor bits inline. > > Thanks, > > Jonathan Thanks a lot for detailed review. Patch v2 has been sent. Title: [PATCH v2] iio: adc:

RE: [PATCH 2/3] iio: adc: add new lp8788 adc driver

2012-08-10 Thread Kim, Milo
This is mostly fine though things have gotten a little confused wrt to the handling iio_priv in the probe and remove so that needs cleaning up. A few other minor bits inline. Thanks, Jonathan Thanks a lot for detailed review. Patch v2 has been sent. Title: [PATCH v2] iio: adc: add new

Re: [PATCH 2/3] iio: adc: add new lp8788 adc driver

2012-08-09 Thread Jonathan Cameron
On 08/09/2012 09:22 AM, Kim, Milo wrote: > TI LP8788 has ADC function. > The result of LP878 ADC is used in the LP8788 power supply driver. > (such like getting the battery voltage, temperature and etc) > Hi, This is mostly fine though things have gotten a little confused wrt to the handling

Re: [PATCH 2/3] iio: adc: add new lp8788 adc driver

2012-08-09 Thread Jonathan Cameron
On 08/09/2012 09:22 AM, Kim, Milo wrote: TI LP8788 has ADC function. The result of LP878 ADC is used in the LP8788 power supply driver. (such like getting the battery voltage, temperature and etc) Hi, This is mostly fine though things have gotten a little confused wrt to the handling