RE: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Salil Mehta
t...@vger.kernel.org; linux- > > ker...@vger.kernel.org; linux-r...@vger.kernel.org; Linuxarm > > Subject: Re: [PATCH net-next] net: hns3: Add support to change MTU in > > hardware & netdev > > > > > for example, > > > file: drivers/net/ethernet/chelsio/cxgb4/cxgb4_m

RE: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Salil Mehta
t...@vger.kernel.org; linux- > > ker...@vger.kernel.org; linux-r...@vger.kernel.org; Linuxarm > > Subject: Re: [PATCH net-next] net: hns3: Add support to change MTU in > > hardware & netdev > > > > > for example, > > > file: drivers/net/ethernet/chelsio/cxgb4/cxgb4_m

RE: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Salil Mehta
r.kernel.org; linux-r...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH net-next] net: hns3: Add support to change MTU in > hardware & netdev > > > for example, > > file: drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c > > static int init_one(str

RE: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Salil Mehta
r.kernel.org; linux-r...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH net-next] net: hns3: Add support to change MTU in > hardware & netdev > > > for example, > > file: drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c > > static int init_one(str

Re: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Andrew Lunn
> for example, > file: drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c > static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) > > netdev->priv_flags |= IFF_UNICAST_FLT; > > + /* MTU range: 81 - 9600 */ > + netdev->min_mtu = 81; > +

Re: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Andrew Lunn
> for example, > file: drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c > static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) > > netdev->priv_flags |= IFF_UNICAST_FLT; > > + /* MTU range: 81 - 9600 */ > + netdev->min_mtu = 81; > +

RE: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Salil Mehta
nel.org; linux-kernel@vger.kernel.org; linux- > r...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH net-next] net: hns3: Add support to change MTU in > hardware & netdev > > > > > + /* MTU range: 68 - 9706 */ > > > > + netdev->min_mtu = ETH_MI

RE: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Salil Mehta
nel.org; linux-kernel@vger.kernel.org; linux- > r...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH net-next] net: hns3: Add support to change MTU in > hardware & netdev > > > > > + /* MTU range: 68 - 9706 */ > > > > + netdev->min_mtu = ETH_MI

Re: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Andrew Lunn
> > > + /* MTU range: 68 - 9706 */ > > > + netdev->min_mtu = ETH_MIN_MTU; > > > > http://elixir.free- > > electrons.com/linux/latest/source/net/ethernet/eth.c#L361 > Supported range of Min and Max MTU should be at the discretion > of the driver. Therefore, initialization looks fine to me. > > I

Re: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Andrew Lunn
> > > + /* MTU range: 68 - 9706 */ > > > + netdev->min_mtu = ETH_MIN_MTU; > > > > http://elixir.free- > > electrons.com/linux/latest/source/net/ethernet/eth.c#L361 > Supported range of Min and Max MTU should be at the discretion > of the driver. Therefore, initialization looks fine to me. > > I

RE: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Salil Mehta
nel.org; linux-kernel@vger.kernel.org; linux- > r...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH net-next] net: hns3: Add support to change MTU in > hardware & netdev > > On Fri, Aug 18, 2017 at 12:35:58PM +0100, Salil Mehta wrote: > > This patch adds the following suppor

RE: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Salil Mehta
nel.org; linux-kernel@vger.kernel.org; linux- > r...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH net-next] net: hns3: Add support to change MTU in > hardware & netdev > > On Fri, Aug 18, 2017 at 12:35:58PM +0100, Salil Mehta wrote: > > This patch adds the following suppor

Re: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Andrew Lunn
On Fri, Aug 18, 2017 at 12:35:58PM +0100, Salil Mehta wrote: > This patch adds the following support to the HNS3 driver: > 1. Support to change the Maximum Transmission Unit of a >netdevice and of a port in hardware . > 2. Initializes the supported MTU range for the netdevice. > >

Re: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Andrew Lunn
On Fri, Aug 18, 2017 at 12:35:58PM +0100, Salil Mehta wrote: > This patch adds the following support to the HNS3 driver: > 1. Support to change the Maximum Transmission Unit of a >netdevice and of a port in hardware . > 2. Initializes the supported MTU range for the netdevice. > >