RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-21 Thread Gabriele Paoloni
ger.kernel.org; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v2] PCI: designware: move remaining rc setup code > to dw_pcie_setup_rc() > > On Tue, Apr 12, 2016 at 09:43:32AM +, Gabriele Paoloni wrote: > > Hi Bjorn > > > > [...] > > > >

RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-21 Thread Gabriele Paoloni
ger.kernel.org; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v2] PCI: designware: move remaining rc setup code > to dw_pcie_setup_rc() > > On Tue, Apr 12, 2016 at 09:43:32AM +, Gabriele Paoloni wrote: > > Hi Bjorn > > > > [...] > > > >

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-21 Thread Bjorn Helgaas
On Tue, Apr 12, 2016 at 09:43:32AM +, Gabriele Paoloni wrote: > Hi Bjorn > > [...] > > > > > > > > > What's the hisi plan for resuming after suspend-to-RAM? How does > > the > > > > RC get reprogrammed after it loses all its state? > > > > > > PM is not part of the driver yet. This is

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-21 Thread Bjorn Helgaas
On Tue, Apr 12, 2016 at 09:43:32AM +, Gabriele Paoloni wrote: > Hi Bjorn > > [...] > > > > > > > > > What's the hisi plan for resuming after suspend-to-RAM? How does > > the > > > > RC get reprogrammed after it loses all its state? > > > > > > PM is not part of the driver yet. This is

RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-14 Thread Gabriele Paoloni
el@vger.kernel.org; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v2] PCI: designware: move remaining rc setup code > to dw_pcie_setup_rc() > > Hi Gabriele, > > On Thu, Apr 14, 2016 at 5:22 PM, Jingoo Han <jingooh...@gmail.com> > wrote: > > On Wed

RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-14 Thread Gabriele Paoloni
el@vger.kernel.org; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v2] PCI: designware: move remaining rc setup code > to dw_pcie_setup_rc() > > Hi Gabriele, > > On Thu, Apr 14, 2016 at 5:22 PM, Jingoo Han > wrote: > > On Wednesday, April 13, 2016 4:58

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-14 Thread Pratyush Anand
Hi Gabriele, On Thu, Apr 14, 2016 at 5:22 PM, Jingoo Han wrote: > On Wednesday, April 13, 2016 4:58 PM, Gabriele Paoloni wrote: >> >> Hi Jingoo >> >> On 13 April 2016 06:52, Jingoo Han wrote: >> > On Tuesday, April 12, 2016 6:44 PM, Gabriele Paoloni wrote: [...] >> > > So

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-14 Thread Pratyush Anand
Hi Gabriele, On Thu, Apr 14, 2016 at 5:22 PM, Jingoo Han wrote: > On Wednesday, April 13, 2016 4:58 PM, Gabriele Paoloni wrote: >> >> Hi Jingoo >> >> On 13 April 2016 06:52, Jingoo Han wrote: >> > On Tuesday, April 12, 2016 6:44 PM, Gabriele Paoloni wrote: [...] >> > > So I will update the

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-14 Thread Jingoo Han
On Wednesday, April 13, 2016 4:58 PM, Gabriele Paoloni wrote: > > Hi Jingoo > > On 13 April 2016 06:52, Jingoo Han wrote: > > On Tuesday, April 12, 2016 6:44 PM, Gabriele Paoloni wrote: > > > > > > Hi Bjorn > > > > > > [...] > > > > > > > > > > > > > > > What's the hisi plan for resuming after

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-14 Thread Jingoo Han
On Wednesday, April 13, 2016 4:58 PM, Gabriele Paoloni wrote: > > Hi Jingoo > > On 13 April 2016 06:52, Jingoo Han wrote: > > On Tuesday, April 12, 2016 6:44 PM, Gabriele Paoloni wrote: > > > > > > Hi Bjorn > > > > > > [...] > > > > > > > > > > > > > > > What's the hisi plan for resuming after

RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-13 Thread Gabriele Paoloni
nel.org; linux-arm- > ker...@lists.infradead.org; 'Jingoo Han' > Subject: Re: [PATCH v2] PCI: designware: move remaining rc setup code > to dw_pcie_setup_rc() > > On Tuesday, April 12, 2016 6:44 PM, Gabriele Paoloni wrote: > > > > Hi Bjorn > > > > [...] > &

RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-13 Thread Gabriele Paoloni
nel.org; linux-arm- > ker...@lists.infradead.org; 'Jingoo Han' > Subject: Re: [PATCH v2] PCI: designware: move remaining rc setup code > to dw_pcie_setup_rc() > > On Tuesday, April 12, 2016 6:44 PM, Gabriele Paoloni wrote: > > > > Hi Bjorn > > > > [...] > &

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-12 Thread Jingoo Han
On Tuesday, April 12, 2016 6:44 PM, Gabriele Paoloni wrote: > > Hi Bjorn > > [...] > > > > > > > > > What's the hisi plan for resuming after suspend-to-RAM? How does > > the > > > > RC get reprogrammed after it loses all its state? > > > > > > PM is not part of the driver yet. This is planned

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-12 Thread Jingoo Han
On Tuesday, April 12, 2016 6:44 PM, Gabriele Paoloni wrote: > > Hi Bjorn > > [...] > > > > > > > > > What's the hisi plan for resuming after suspend-to-RAM? How does > > the > > > > RC get reprogrammed after it loses all its state? > > > > > > PM is not part of the driver yet. This is planned

RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-12 Thread Gabriele Paoloni
Hi Bjorn [...] > > > > > > What's the hisi plan for resuming after suspend-to-RAM? How does > the > > > RC get reprogrammed after it loses all its state? > > > > PM is not part of the driver yet. This is planned for near > > future release so haven't made such considerations yet > > > > > >

RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-12 Thread Gabriele Paoloni
Hi Bjorn [...] > > > > > > What's the hisi plan for resuming after suspend-to-RAM? How does > the > > > RC get reprogrammed after it loses all its state? > > > > PM is not part of the driver yet. This is planned for near > > future release so haven't made such considerations yet > > > > > >

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-08 Thread Bjorn Helgaas
t; Cc: Jisheng Zhang; jingooh...@gmail.com; pratyush.an...@gmail.com; > > bhelg...@google.com; linux-...@vger.kernel.org; linux- > > ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org > > Subject: Re: [PATCH v2] PCI: designware: move remaining rc setup code > > to dw

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-08 Thread Bjorn Helgaas
t; Cc: Jisheng Zhang; jingooh...@gmail.com; pratyush.an...@gmail.com; > > bhelg...@google.com; linux-...@vger.kernel.org; linux- > > ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org > > Subject: Re: [PATCH v2] PCI: designware: move remaining rc setup code > > to dw

RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-08 Thread Gabriele Paoloni
.kernel.org; linux- > ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v2] PCI: designware: move remaining rc setup code > to dw_pcie_setup_rc() > > On Thu, Apr 07, 2016 at 10:06:45AM +, Gabriele Paoloni wrote: > > Hi Jisheng > > > &g

RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-08 Thread Gabriele Paoloni
.kernel.org; linux- > ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v2] PCI: designware: move remaining rc setup code > to dw_pcie_setup_rc() > > On Thu, Apr 07, 2016 at 10:06:45AM +, Gabriele Paoloni wrote: > > Hi Jisheng > > > &g

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-07 Thread Bjorn Helgaas
pratyush.an...@gmail.com; > > bhelg...@google.com; linux-...@vger.kernel.org; linux- > > ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org > > Subject: Re: [PATCH v2] PCI: designware: move remaining rc setup code > > to dw_pcie_setup_rc() > > > > Hi Gab

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-07 Thread Bjorn Helgaas
pratyush.an...@gmail.com; > > bhelg...@google.com; linux-...@vger.kernel.org; linux- > > ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org > > Subject: Re: [PATCH v2] PCI: designware: move remaining rc setup code > > to dw_pcie_setup_rc() > > > > Hi Gab

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-07 Thread Jisheng Zhang
On Thu, 7 Apr 2016 10:06:45 + Gabriele Paoloni wrote: > Hi Jisheng > .. > > > > > > > > > > > Is it acceptable that pcie-hisi adds a call to dw_pcie_setup_rc() > > in > > > > hisi_add_pcie_port()? > > > > > > I don't think so...that would try to overwrite what is already set by > > >

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-07 Thread Jisheng Zhang
On Thu, 7 Apr 2016 10:06:45 + Gabriele Paoloni wrote: > Hi Jisheng > .. > > > > > > > > > > > Is it acceptable that pcie-hisi adds a call to dw_pcie_setup_rc() > > in > > > > hisi_add_pcie_port()? > > > > > > I don't think so...that would try to overwrite what is already set by > > >

RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-07 Thread Gabriele Paoloni
el.org; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v2] PCI: designware: move remaining rc setup code > to dw_pcie_setup_rc() > > Hi Gabriele, > > On Thu, 7 Apr 2016 08:20:28 + Gabriele Paoloni wrote: > > > Hi Jisheng > > > > Thanks for your re

RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-07 Thread Gabriele Paoloni
el.org; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v2] PCI: designware: move remaining rc setup code > to dw_pcie_setup_rc() > > Hi Gabriele, > > On Thu, 7 Apr 2016 08:20:28 + Gabriele Paoloni wrote: > > > Hi Jisheng > > > > Thanks for your re

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-07 Thread Jisheng Zhang
i; jingooh...@gmail.com; pratyush.an...@gmail.com; > > bhelg...@google.com > > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > > ker...@lists.infradead.org > > Subject: Re: [PATCH v2] PCI: designware: move remaining rc setup code > > to dw_pcie_set

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-07 Thread Jisheng Zhang
i; jingooh...@gmail.com; pratyush.an...@gmail.com; > > bhelg...@google.com > > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > > ker...@lists.infradead.org > > Subject: Re: [PATCH v2] PCI: designware: move remaining rc setup code > > to dw_pcie_set

RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-07 Thread Gabriele Paoloni
el@vger.kernel.org; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v2] PCI: designware: move remaining rc setup code > to dw_pcie_setup_rc() > > Hi Gabriele, > > On Wed, 6 Apr 2016 14:50:29 + Gabriele Paoloni wrote: > > > Hi, sorry to

RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-07 Thread Gabriele Paoloni
el@vger.kernel.org; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v2] PCI: designware: move remaining rc setup code > to dw_pcie_setup_rc() > > Hi Gabriele, > > On Wed, 6 Apr 2016 14:50:29 + Gabriele Paoloni wrote: > > > Hi, sorry to

RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-07 Thread Gabriele Paoloni
.org; linux-kernel@vger.kernel.org; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v2] PCI: designware: move remaining rc setup code > to dw_pcie_setup_rc() > > Hi Gab, > > Thanks for bringing it. > > > On Wed, Apr 6, 2016 at 8:20 PM, Gabriele Paoloni >

RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-07 Thread Gabriele Paoloni
.org; linux-kernel@vger.kernel.org; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v2] PCI: designware: move remaining rc setup code > to dw_pcie_setup_rc() > > Hi Gab, > > Thanks for bringing it. > > > On Wed, Apr 6, 2016 at 8:20 PM, Gab

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-07 Thread Pratyush Anand
Hi Gab, Thanks for bringing it. On Wed, Apr 6, 2016 at 8:20 PM, Gabriele Paoloni wrote: > Hi, sorry to be late on this > >> -Original Message- >> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- >> ow...@vger.kernel.org] On Behalf Of Jisheng

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-07 Thread Pratyush Anand
Hi Gab, Thanks for bringing it. On Wed, Apr 6, 2016 at 8:20 PM, Gabriele Paoloni wrote: > Hi, sorry to be late on this > >> -Original Message- >> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- >> ow...@vger.kernel.org] On Behalf Of Jisheng Zhang >> Sent: 16 March 2016

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-06 Thread Jisheng Zhang
Hi Gabriele, On Wed, 6 Apr 2016 14:50:29 + Gabriele Paoloni wrote: > Hi, sorry to be late on this > > > -Original Message- > > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > > ow...@vger.kernel.org] On Behalf Of Jisheng Zhang > > Sent: 16 March 2016 11:41 > > To:

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-06 Thread Jisheng Zhang
Hi Gabriele, On Wed, 6 Apr 2016 14:50:29 + Gabriele Paoloni wrote: > Hi, sorry to be late on this > > > -Original Message- > > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > > ow...@vger.kernel.org] On Behalf Of Jisheng Zhang > > Sent: 16 March 2016 11:41 > > To:

RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-06 Thread Gabriele Paoloni
Hi, sorry to be late on this > -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Jisheng Zhang > Sent: 16 March 2016 11:41 > To: jingooh...@gmail.com; pratyush.an...@gmail.com; bhelg...@google.com > Cc:

RE: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-06 Thread Gabriele Paoloni
Hi, sorry to be late on this > -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Jisheng Zhang > Sent: 16 March 2016 11:41 > To: jingooh...@gmail.com; pratyush.an...@gmail.com; bhelg...@google.com > Cc:

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-05 Thread Bjorn Helgaas
On Wed, Mar 16, 2016 at 07:40:33PM +0800, Jisheng Zhang wrote: > dw_pcie_setup_rc(), as its name indicates, setups the RC. But current > dw_pcie_host_init() also contains some necessary rc setup code. > > Another reason: the host may lost power during suspend to ram, the RC > need to be re-setup

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-04-05 Thread Bjorn Helgaas
On Wed, Mar 16, 2016 at 07:40:33PM +0800, Jisheng Zhang wrote: > dw_pcie_setup_rc(), as its name indicates, setups the RC. But current > dw_pcie_host_init() also contains some necessary rc setup code. > > Another reason: the host may lost power during suspend to ram, the RC > need to be re-setup

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-03-19 Thread Pratyush Anand
On Wed, Mar 16, 2016 at 5:10 PM, Jisheng Zhang wrote: > dw_pcie_setup_rc(), as its name indicates, setups the RC. But current > dw_pcie_host_init() also contains some necessary rc setup code. > > Another reason: the host may lost power during suspend to ram, the RC > need to

Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()

2016-03-19 Thread Pratyush Anand
On Wed, Mar 16, 2016 at 5:10 PM, Jisheng Zhang wrote: > dw_pcie_setup_rc(), as its name indicates, setups the RC. But current > dw_pcie_host_init() also contains some necessary rc setup code. > > Another reason: the host may lost power during suspend to ram, the RC > need to be re-setup after