>
> On Sun, 2015-08-30 at 10:36 +, Winkler, Tomas wrote:
> > > > >
> > > > >
> > > > > I'm just not sure why the patches are not merged or even rejected.
> > > >
> > > > Because ideally I want a Maintainer ack. That's Doug Gilbert.
> >
> > James
> > The patches were discussed and the ACked
>
> On Sun, 2015-08-30 at 10:36 +, Winkler, Tomas wrote:
> > > > >
> > > > >
> > > > > I'm just not sure why the patches are not merged or even rejected.
> > > >
> > > > Because ideally I want a Maintainer ack. That's Doug Gilbert.
> >
> > James
> > The patches were discussed and the ACked
On Sun, 2015-08-30 at 10:36 +, Winkler, Tomas wrote:
> > > >
> > > >
> > > > I'm just not sure why the patches are not merged or even rejected.
> > >
> > > Because ideally I want a Maintainer ack. That's Doug Gilbert.
>
> James
> The patches were discussed and the ACked by Doug in February
> > >
> > >
> > > I'm just not sure why the patches are not merged or even rejected.
> >
> > Because ideally I want a Maintainer ack. That's Doug Gilbert.
James
The patches were discussed and the ACked by Doug in February and reviewed again
after resend by Martin Petersen
> >
> > > I'm
I'm just not sure why the patches are not merged or even rejected.
Because ideally I want a Maintainer ack. That's Doug Gilbert.
James
The patches were discussed and the ACked by Doug in February and reviewed again
after resend by Martin Petersen
I'm submitting patches to
On Sun, 2015-08-30 at 10:36 +, Winkler, Tomas wrote:
I'm just not sure why the patches are not merged or even rejected.
Because ideally I want a Maintainer ack. That's Doug Gilbert.
James
The patches were discussed and the ACked by Doug in February
7/7 wasn't.
and
On Wed, 2015-08-26 at 16:38 -0700, James Bottomley wrote:
> On Tue, 2015-08-25 at 21:03 +, Winkler, Tomas wrote:
> >
> > > > + /* this should never happen */
> > > > + if (WARN_ON(!cmnd))
> > > > + return SCSI_MLQUEUE_HOST_BUSY;
> > > >
> > > > - if (NULL ==
On Wed, 2015-08-26 at 16:38 -0700, James Bottomley wrote:
On Tue, 2015-08-25 at 21:03 +, Winkler, Tomas wrote:
+ /* this should never happen */
+ if (WARN_ON(!cmnd))
+ return SCSI_MLQUEUE_HOST_BUSY;
- if (NULL == cmnd || NULL == devip) {
On Tue, 2015-08-25 at 21:03 +, Winkler, Tomas wrote:
>
> > > + /* this should never happen */
> > > + if (WARN_ON(!cmnd))
> > > + return SCSI_MLQUEUE_HOST_BUSY;
> > >
> > > - if (NULL == cmnd || NULL == devip) {
> > > - pr_warn("called with NULL cmnd or devip pointer\n");
> >
On Tue, 2015-08-25 at 21:03 +, Winkler, Tomas wrote:
+ /* this should never happen */
+ if (WARN_ON(!cmnd))
+ return SCSI_MLQUEUE_HOST_BUSY;
- if (NULL == cmnd || NULL == devip) {
- pr_warn(called with NULL cmnd or devip pointer\n);
+ if (NULL == devip) {
> > + /* this should never happen */
> > + if (WARN_ON(!cmnd))
> > + return SCSI_MLQUEUE_HOST_BUSY;
> >
> > - if (NULL == cmnd || NULL == devip) {
> > - pr_warn("called with NULL cmnd or devip pointer\n");
> > + if (NULL == devip) {
> > + pr_warn("called
On Tue, 2015-07-28 at 16:54 +0300, Tomas Winkler wrote:
> The function should never be called with cmnd NULL so
> put a fat WARN there.
> Fix also smatch wraning:
> schedule_resp() warn: variable dereferenced before check 'cmnd'
>
> Cc: Douglas Gilbert
> Signed-off-by: Tomas Winkler
> Acked-by:
On Tue, 2015-07-28 at 16:54 +0300, Tomas Winkler wrote:
The function should never be called with cmnd NULL so
put a fat WARN there.
Fix also smatch wraning:
schedule_resp() warn: variable dereferenced before check 'cmnd'
Cc: Douglas Gilbert dgilb...@interlog.com
Signed-off-by: Tomas
+ /* this should never happen */
+ if (WARN_ON(!cmnd))
+ return SCSI_MLQUEUE_HOST_BUSY;
- if (NULL == cmnd || NULL == devip) {
- pr_warn(called with NULL cmnd or devip pointer\n);
+ if (NULL == devip) {
+ pr_warn(called devip == NULL\n);
> "Tomas" == Tomas Winkler writes:
Tomas> The function should never be called with cmnd NULL so put a fat
Tomas> WARN there. Fix also smatch wraning: schedule_resp() warn:
Tomas> variable dereferenced before check 'cmnd'
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle
Tomas == Tomas Winkler tomas.wink...@intel.com writes:
Tomas The function should never be called with cmnd NULL so put a fat
Tomas WARN there. Fix also smatch wraning: schedule_resp() warn:
Tomas variable dereferenced before check 'cmnd'
Reviewed-by: Martin K. Petersen
16 matches
Mail list logo
