Re: linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always false test ?
On Mon, Oct 17, 2016 at 07:33:33AM +, David Binderman wrote:
> Hello there,
>
>
>
> linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973]: (style)
> Checking if unsigned variable 'cli.cl_avail_grant' is less than zero.
>
>
>
> Source code is
>
>
>
> if (cli->cl_avail_grant < 0) {
>
>
>
> Suggest code rework.
Great! Please send a patch.
thanks,
greg k-h
Re: linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always false test ?
On Mon, Oct 17, 2016 at 07:33:33AM +, David Binderman wrote:
> Hello there,
>
>
>
> linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973]: (style)
> Checking if unsigned variable 'cli.cl_avail_grant' is less than zero.
>
>
>
> Source code is
>
>
>
> if (cli->cl_avail_grant < 0) {
>
>
>
> Suggest code rework.
Great! Please send a patch.
thanks,
greg k-h
