Re: potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Darren Hart
On 07/18/2012 11:01 AM, Dave Jones wrote: > On Wed, Jul 18, 2012 at 09:03:22AM -0700, Darren Hart wrote: > > > > This will oops if pi_mutex is NULL. > > > > > > 2374 rt_mutex_unlock(pi_mutex); > > > 2375 } else if (ret == -EINTR) { > > > > Nice

Re: potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Dave Jones
On Wed, Jul 18, 2012 at 09:03:22AM -0700, Darren Hart wrote: > > This will oops if pi_mutex is NULL. > > > > 2374 rt_mutex_unlock(pi_mutex); > > 2375 } else if (ret == -EINTR) { > > Nice Dan, thanks for taking a closer look. This appears to be a

Re: potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Darren Hart
On 07/18/2012 07:25 AM, Dan Carpenter wrote: > Hi Darren, > > The patch 52400ba94675: "futex: add requeue_pi functionality" from > Apr 3, 2009, leads to the following warning: > kernel/futex.c:2373 futex_wait_requeue_pi() > error: potential NULL derefer

Re: potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Dan Carpenter
queue_pi functionality" from > > > Apr 3, 2009, leads to the following warning: > > > kernel/futex.c:2373 futex_wait_requeue_pi() > > > error: potential NULL dereference 'pi_mutex'. > > > > This sounds like the oops I saw that I reported at > &

Re: potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Darren Hart
ing warning: > > kernel/futex.c:2373 futex_wait_requeue_pi() > > error: potential NULL dereference 'pi_mutex'. > > This sounds like the oops I saw that I reported at > https://lkml.org/lkml/2012/7/13/328 I'm looking into the report Dave sent today (delayed from piles of urgent issues after

Re: potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Dave Jones
On Wed, Jul 18, 2012 at 05:25:14PM +0300, Dan Carpenter wrote: > Hi Darren, > > The patch 52400ba94675: "futex: add requeue_pi functionality" from > Apr 3, 2009, leads to the following warning: > kernel/futex.c:2373 futex_wait_requeue_pi() > error: potentia

potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Dan Carpenter
Hi Darren, The patch 52400ba94675: "futex: add requeue_pi functionality" from Apr 3, 2009, leads to the following warning: kernel/futex.c:2373 futex_wait_requeue_pi() error: potential NULL dereference 'pi_mutex'. 2330 if (!q.rt_waiter) { 2331

potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Dan Carpenter
Hi Darren, The patch 52400ba94675: futex: add requeue_pi functionality from Apr 3, 2009, leads to the following warning: kernel/futex.c:2373 futex_wait_requeue_pi() error: potential NULL dereference 'pi_mutex'. 2330 if (!q.rt_waiter) { 2331 /* 2332

Re: potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Dave Jones
On Wed, Jul 18, 2012 at 05:25:14PM +0300, Dan Carpenter wrote: Hi Darren, The patch 52400ba94675: futex: add requeue_pi functionality from Apr 3, 2009, leads to the following warning: kernel/futex.c:2373 futex_wait_requeue_pi() error: potential NULL dereference 'pi_mutex

Re: potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Darren Hart
() error: potential NULL dereference 'pi_mutex'. This sounds like the oops I saw that I reported at https://lkml.org/lkml/2012/7/13/328 I'm looking into the report Dave sent today (delayed from piles of urgent issues after returning from vacation, my apologies). Dan, under which workload are you

Re: potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Dan Carpenter
to the following warning: kernel/futex.c:2373 futex_wait_requeue_pi() error: potential NULL dereference 'pi_mutex'. This sounds like the oops I saw that I reported at https://lkml.org/lkml/2012/7/13/328 I'm looking into the report Dave sent today (delayed from piles of urgent issues after

Re: potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Darren Hart
On 07/18/2012 07:25 AM, Dan Carpenter wrote: Hi Darren, The patch 52400ba94675: futex: add requeue_pi functionality from Apr 3, 2009, leads to the following warning: kernel/futex.c:2373 futex_wait_requeue_pi() error: potential NULL dereference 'pi_mutex'. 2330

Re: potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Dave Jones
On Wed, Jul 18, 2012 at 09:03:22AM -0700, Darren Hart wrote: This will oops if pi_mutex is NULL. 2374 rt_mutex_unlock(pi_mutex); 2375 } else if (ret == -EINTR) { Nice Dan, thanks for taking a closer look. This appears to be a simple fix,

Re: potential NULL dereference in futex_wait_requeue_pi()

2012-07-18 Thread Darren Hart
On 07/18/2012 11:01 AM, Dave Jones wrote: On Wed, Jul 18, 2012 at 09:03:22AM -0700, Darren Hart wrote: This will oops if pi_mutex is NULL. 2374 rt_mutex_unlock(pi_mutex); 2375 } else if (ret == -EINTR) { Nice Dan, thanks for