Re: "scsi: convert host_busy to atomic_t" series causes regressions for some hardware configurations

2015-09-07 Thread Christoph Hellwig
Hi Sergio, sorry for the delay. I'm fighting deadlines at the moment, so even if this is my highest spare time priority right now I can't find enough quiet time to dig into the problem. I'd suggest you resend a report to linux-ide (with a Cc to linux-scsi) so that the people who know the libata

Re: "scsi: convert host_busy to atomic_t" series causes regressions for some hardware configurations

2015-09-07 Thread Sergio Callegari
Hi Christoph (and those reading!), I wonder if there might be any update or, most important, anything else for me to test in order to provide info to address this issue... I really would like to find out whether it is a bug in my hardware (which would be OK, as I know already how to work

Re: "scsi: convert host_busy to atomic_t" series causes regressions for some hardware configurations

2015-09-07 Thread Sergio Callegari
Hi Christoph (and those reading!), I wonder if there might be any update or, most important, anything else for me to test in order to provide info to address this issue... I really would like to find out whether it is a bug in my hardware (which would be OK, as I know already how to work

Re: "scsi: convert host_busy to atomic_t" series causes regressions for some hardware configurations

2015-09-07 Thread Christoph Hellwig
Hi Sergio, sorry for the delay. I'm fighting deadlines at the moment, so even if this is my highest spare time priority right now I can't find enough quiet time to dig into the problem. I'd suggest you resend a report to linux-ide (with a Cc to linux-scsi) so that the people who know the libata

Re: "scsi: convert host_busy to atomic_t" series causes regressions for some hardware configurations

2015-08-30 Thread Sergio Callegari
Hi Christoph, just checked. Unfortunately, the patch below, applied on top of Linus' v3.17 (which I am using as a test kernel) *does not fix the issue*. Best regards, Sergio On 25/08/2015 13:00, Christoph Hellwig wrote: Hi Sergio, can you give the patch below a try? libata currently

Re: scsi: convert host_busy to atomic_t series causes regressions for some hardware configurations

2015-08-30 Thread Sergio Callegari
Hi Christoph, just checked. Unfortunately, the patch below, applied on top of Linus' v3.17 (which I am using as a test kernel) *does not fix the issue*. Best regards, Sergio On 25/08/2015 13:00, Christoph Hellwig wrote: Hi Sergio, can you give the patch below a try? libata currently

Re: "scsi: convert host_busy to atomic_t" series causes regressions for some hardware configurations

2015-08-26 Thread Sergio Callegari
Sure, thanks! I'll test this weekend. Best, Sergio On 25/08/2015 13:00, Christoph Hellwig wrote: Hi Sergio, can you give the patch below a try? libata currently completes the SCSI command before freeing the internal command structure, which could lead to various races that mess with the

Re: scsi: convert host_busy to atomic_t series causes regressions for some hardware configurations

2015-08-26 Thread Sergio Callegari
Sure, thanks! I'll test this weekend. Best, Sergio On 25/08/2015 13:00, Christoph Hellwig wrote: Hi Sergio, can you give the patch below a try? libata currently completes the SCSI command before freeing the internal command structure, which could lead to various races that mess with the

Re: "scsi: convert host_busy to atomic_t" series causes regressions for some hardware configurations

2015-08-25 Thread Christoph Hellwig
Hi Sergio, can you give the patch below a try? libata currently completes the SCSI command before freeing the internal command structure, which could lead to various races that mess with the ATA command state, which might cause issues like the one you see. diff --git a/drivers/ata/libata-scsi.c

Re: scsi: convert host_busy to atomic_t series causes regressions for some hardware configurations

2015-08-25 Thread Christoph Hellwig
Hi Sergio, can you give the patch below a try? libata currently completes the SCSI command before freeing the internal command structure, which could lead to various races that mess with the ATA command state, which might cause issues like the one you see. diff --git a/drivers/ata/libata-scsi.c

"scsi: convert host_busy to atomic_t" series causes regressions for some hardware configurations

2015-08-24 Thread Sergio Callegari
Thanks Christoph for the answer! Apparently I missed a piece of the thread where the test patch was originally proposed . Now, I have gone through it and I see how the patch was not meant to be a final correction. My (possibly naive) understanding is that: - Even if this might be due to

scsi: convert host_busy to atomic_t series causes regressions for some hardware configurations

2015-08-24 Thread Sergio Callegari
Thanks Christoph for the answer! Apparently I missed a piece of the thread where the test patch was originally proposed . Now, I have gone through it and I see how the patch was not meant to be a final correction. My (possibly naive) understanding is that: - Even if this might be due to