Ingo Molnar wrote:
[announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]
i'm pleased to announce the first release of the Modular Scheduler Core
and Completely Fair Scheduler [CFS] patchset:
http://redhat.com/~mingo/cfs-scheduler/sched-modular+cfs.patch
This
pages within the target area are reclaimed,
including both active and recently referenced pages.
[EMAIL PROTECTED]: additionally apply pressure to referenced paged]
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
Acked-by: Mel Gorman [EMAIL PROTECTED]
---
diff --git a/mm/vmscan.c b/mm/vmscan.c
behaviour at this same boundary, more
agressivly targetting pages in reclaim at higher order.
This patch removes all these magical numbers and replaces with
with a constant HIGH_ORDER.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
Acked-by: Mel Gorman [EMAIL PROTECTED]
---
diff --git a/include
-by: Andy Whitcroft [EMAIL PROTECTED]
Acked-by: Mel Gorman [EMAIL PROTECTED]
---
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 428da1a..466435f 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1212,6 +1212,7 @@ static unsigned long balance_pgdat(pg_data_t *pgdat, int
order)
.may_swap = 1
constant.
Against: 2.6.21-rc6-mm1
-apw
Changes in lumpy V5:
Andy Whitcroft:
lumpy: back out removal of active check in isolate_lru_pages
lumpy: only count taken pages as scanned
Changes in lumpy V4:
Andy Whitcroft:
lumpy: isolate_lru_pages wants to specifically take active
Andrew Morton wrote:
On Sat, 21 Apr 2007 01:28:43 -0700 Andrew Morton [EMAIL PROTECTED] wrote:
It would have been better to have patched page_alloc.c independently, then
to have used HIGH_ORDER in lumpy: increase pressure at the end of the
inactive
list.
Actually that doesn't matter,
Following this email are three patches which represent the
current state of the lumpy reclaim patches; collectively lumpy V5.
This patch kit is against 2.6.21-rc3-mm2. This stack is split out
to show the incremental changes in this version. This contains
one fixup following on from Christoph
Whitcroft [EMAIL PROTECTED]
Acked-by: Peter Zijlstra [EMAIL PROTECTED]
Acked-by: Mel Gorman [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
--- 8
Changes in lumpy V4:
Andy Whitcroft:
lumpy: isolate_lru_pages wants to specifically take active or inactive
pages
As pointed out by Christop Lameter it should not be possible for a
page to change its active/inactive state without taking the lru_lock.
Reinstate this safety net.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
Acked-by: Mel Gorman [EMAIL PROTECTED]
---
diff --git a/mm/vmscan.c b/mm/vmscan.c
.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
Acked-by: Mel Gorman [EMAIL PROTECTED]
---
diff --git a/mm/vmscan.c b/mm/vmscan.c
index d7a0860..c3dc544 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -732,11 +732,11 @@ static unsigned long isolate_lru_pages(unsigned long
nr_to_scan
Dave Hansen wrote:
On Mon, 2007-03-12 at 18:23 +, Andy Whitcroft wrote:
+ /* The target page is in the block, ignore it. */
+ if (unlikely(pfn == page_pfn))
+ continue;
+#ifdef CONFIG_HOLES_IN_ZONE
Andrew Morton wrote:
On Mon, 12 Mar 2007 18:22:45 + Andy Whitcroft [EMAIL PROTECTED] wrote:
Following this email are three patches which represent the
current state of the lumpy reclaim patches; collectively lumpy V5.
So where do we stand with this now?Does it make anything get
Martin Bligh wrote:
Christoph Lameter wrote:
On Fri, 16 Mar 2007, Martin Bligh wrote:
You have to do some sort of lookup anyway, and Andy seemed to have them
all folded into one.
What lookup would you need to do? On x86_64 even the TLB use is hidden
by the existing 2M entries for 1-1
[applogies in advance if this has already been asked]
I note that PG_booked and PG_readahead are both using bit 20 in
2.6.21-rc3-mm2. Is this intentional or perhaps a miss-merge. They do
not sound obviously non-overlapping to my mind.
-apw
-
To unsubscribe from this list: send the line
Andrew Morton wrote:
Temporarily at
http://userweb.kernel.org/~akpm/2.6.21-rc4-mm1/
Will appear later at
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc4/2.6.21-rc4-mm1/
[All of the below is from the pre hot-fix runs. The very few results
which are
The thought of having a helper for the holes within zones code
has come up on two different threads in the last couple of days.
So I took the pfn_valid_within() patch I had developed for the
linear reclaim series and pulled it forward to 2.6.21-rc4-mm1.
I have split it into a three patch series to
holes within
a MAX_ORDER_NR_PAGES block of pages.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
Acked-by: Mel Gorman [EMAIL PROTECTED]
---
diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index 7206c77..8c87d79 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
Move to using pfn_valid_within().
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
Acked-by: Mel Gorman [EMAIL PROTECTED]
---
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 695b5a6..3d7c29e 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -747,12 +747,10 @@ int move_freepages(struct
Switch to using pfn_valid_within() in lumpy reclaim.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
Acked-by: Mel Gorman [EMAIL PROTECTED]
---
diff --git a/mm/vmscan.c b/mm/vmscan.c
index c3dc544..cf55c57 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -722,11 +722,10 @@ static unsigned long
Andy Whitcroft wrote:
Andrew Morton wrote:
Temporarily at
http://userweb.kernel.org/~akpm/2.6.21-rc4-mm1/
Will appear later at
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc4/2.6.21-rc4-mm1/
[All of the below is from the pre hot-fix runs. The very few
Andy Whitcroft wrote:
Andy Whitcroft wrote:
Andrew Morton wrote:
Temporarily at
http://userweb.kernel.org/~akpm/2.6.21-rc4-mm1/
Will appear later at
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc4/2.6.21-rc4-mm1/
[All of the below is from the pre hot-fix
Con Kolivas wrote:
On Thursday 22 March 2007 20:48, Andy Whitcroft wrote:
Andy Whitcroft wrote:
Andy Whitcroft wrote:
Andrew Morton wrote:
Temporarily at
http://userweb.kernel.org/~akpm/2.6.21-rc4-mm1/
Will appear later at
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches
Andy Whitcroft wrote:
Con Kolivas wrote:
On Thursday 22 March 2007 20:48, Andy Whitcroft wrote:
Andy Whitcroft wrote:
Andy Whitcroft wrote:
Andrew Morton wrote:
Temporarily at
http://userweb.kernel.org/~akpm/2.6.21-rc4-mm1/
Will appear later at
ftp://ftp.kernel.org/pub/linux
Con Kolivas wrote:
On Friday 23 March 2007 05:17, Andy Whitcroft wrote:
Ok, I have yet a third x86_64 machine is is blowing up with the latest
2.6.21-rc4-mm1+hotfixes+rsdl-0.32 but working with
2.6.21-rc4-mm1+hotfixes-RSDL. I have results on various hotfix levels
so I have just fired off
Andy Whitcroft wrote:
Con Kolivas wrote:
On Friday 23 March 2007 05:17, Andy Whitcroft wrote:
Ok, I have yet a third x86_64 machine is is blowing up with the latest
2.6.21-rc4-mm1+hotfixes+rsdl-0.32 but working with
2.6.21-rc4-mm1+hotfixes-RSDL. I have results on various hotfix levels
so I
Eric Dumazet wrote:
Some NUMA machines have a big MAX_NUMNODES (possibly 1024), but fewer
possible nodes. This patch dynamically sizes the 'struct kmem_cache' to
allocate only needed space.
I moved nodelists[] field at the end of struct kmem_cache, and use the
following computation in
Con Kolivas wrote:
On Saturday 24 March 2007 08:45, Con Kolivas wrote:
On Friday 23 March 2007 23:28, Andy Whitcroft wrote:
Andy Whitcroft wrote:
Con Kolivas wrote:
On Friday 23 March 2007 05:17, Andy Whitcroft wrote:
Ok, I have yet a third x86_64 machine is is blowing up with the
latest
Con Kolivas wrote:
This is about the only place I can see the run_list is looked at unlocked. Can
you see if this simple patch helps? The debug patch is unnecessary now.
Tests queued with this patch. Will let you know.
-apw
-
To unsubscribe from this list: send the line unsubscribe
Andy Whitcroft wrote:
Con Kolivas wrote:
This is about the only place I can see the run_list is looked at unlocked.
Can
you see if this simple patch helps? The debug patch is unnecessary now.
Tests queued with this patch. Will let you know.
That patch had no effect on the problem
. CCing Andy Whitcroft who will hopefully
merge this all of this together into sparsemem including the S/390
implementation.
Yep grabbed this one and added it to the stack. Now to find a sparc to
test it with!
-apw
-
To unsubscribe from this list: send the line unsubscribe linux-kernel
Andrew Morton wrote:
- Judging by the number of times I get asked is there a git tree for -mm,
nobody is reading the boilerplate. Here it is again:
The git tree version of -mm seems to be sick. A fetch of the tag gives
you something but it is significantly (200k lines of diff) away from
reclaim V2 patch
which forms the foundation.
[EMAIL PROTECTED]: ia64 pfn_to_nid fixes and loop cleanup]
[EMAIL PROTECTED]: static declarations for internal functions]
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
Acked-by: Peter Zijlstra [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL
. This is no longer an
error and we should simply ignore them.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
---
diff --git a/mm/vmscan.c b/mm/vmscan.c
index f15ffcb..b878d54 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -663,12 +663,13 @@ static int __isolate_lru_page(struct page *page, int
active
Following this email are five patches which represent the current
state of the lumpy reclaim patches; collectivly lumpy v4. This
patch kit is designed as a complete drop-in replacement for the
lumpy patches in 2.6.20-mm2. This stack is split out to show the
incremental changes in this version.
Now that we are passing in a boolean active flag we need to
ensure that the result of PageActive(page) is comparible
to that boolean.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
---
diff --git a/mm/vmscan.c b/mm/vmscan.c
index b878d54..2bfad79 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
We have a number of subtle comparisons when scanning a block, and
we make use of a lot of buddy mem_map guarentees. Add commentary about
each.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
---
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 2bfad79..bef7e92 100644
--- a/mm/vmscan.c
+++ b/mm
We only need to check that each page is valid with pfn_valid when
we are on an architecture which had holes within zones. Make this
check conditional.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
---
diff --git a/mm/vmscan.c b/mm/vmscan.c
index bef7e92..f249ad7 100644
--- a/mm/vmscan.c
+++ b
Christoph Lameter wrote:
On Tue, 27 Feb 2007, Andy Whitcroft wrote:
+static int __isolate_lru_page(struct page *page, int active)
+{
+int ret = -EINVAL;
+
+if (PageLRU(page) (PageActive(page) == active)) {
+ret = -EBUSY;
+if (likely(get_page_unless_zero
Christoph Lameter wrote:
On Tue, 27 Feb 2007, Andy Whitcroft wrote:
The caller of isolate_lru_pages specifically knows whether it wants
to take either inactive or active pages. Currently we take the
state of the LRU page at hand and use that to scan for matching
pages in the order sized
Add an i386 implementation of alternative_io modelled on
the x86_64 version.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
---
Ok, this seems to fix things up here. I have only boot
tested this on an SMP so I'd not call that 'heavily tested'
in any real sense
Christoph Lameter wrote:
On Mon, 2 Apr 2007, Martin Bligh wrote:
Its just the opposite. The vmemmap code is so efficient that we can remove
lots of other code and gops of these alternate implementations. On x86_64
its even superior to FLATMEM since FLATMEM still needs a memory reference
for
Andi Kleen wrote:
On Monday 02 April 2007 23:56:08 Dave Hansen wrote:
On Mon, 2007-04-02 at 14:28 -0700, Christoph Lameter wrote:
I do not care what its called as long as it
covers all the bases and is not a glaring performance regresssion (like
SPARSEMEM so far).
I honestly don't doubt
On Mon, Jan 14, 2008 at 09:48:53AM -0600, James Bottomley wrote:
This error:
ERROR: no space before that close parenthesis ')'
#501: FILE: drivers/scsi/dpt_i2o.c:2299:
+ if (dev_status == 0x02 /*CHECK_CONDITION*/) {
Is definitely wrong. I think it's stripped the comments so
On Fri, Jan 11, 2008 at 06:06:35PM +0100, Stefan Richter wrote:
Signed-off-by: Stefan Richter [EMAIL PROTECTED]
Acked-by: Jiri Slaby [EMAIL PROTECTED]
As an absolute minimum this seems reasonable to me. I guess we could
make no arguments default to '-' also. There are up and downsides to
On Sun, Jan 13, 2008 at 11:34:05PM +0100, Paolo Ciarrocchi wrote:
With the patch applied the output of checkpatch.pl is as follow:
./arch/arm/mach-footbridge/ebsa285-pci.c
total: 1 errors, 0 warnings, 48 lines checked
Adding the file name allowed me to collects stats running:
find .
On Mon, Jan 14, 2008 at 09:35:15AM -0800, Daniel Walker wrote:
On Mon, 2008-01-14 at 17:17 +, Andy Whitcroft wrote:
On Fri, Jan 11, 2008 at 06:06:35PM +0100, Stefan Richter wrote:
Signed-off-by: Stefan Richter [EMAIL PROTECTED]
Acked-by: Jiri Slaby [EMAIL PROTECTED
On Sun, Jan 13, 2008 at 08:41:20PM -0500, Steven Rostedt wrote:
Hi guys,
Just wondering what the proper way to export a symbol that is defined in
assembly? Or is there some kind of annotation I can add in comment form
that will let checkpatch know the variable is not in C?
Here's what
line endings
- detect redundant casts for kalloc()
Andy Whitcroft (18):
Version: 0.10
asmlinkage is also a storage type
pull out inline specifiers
allow only some operators before a unary operator
parenthesised values may span line ends
add additional
On Wed, Sep 12, 2007 at 11:09:47AM -0400, Lee Schermerhorn wrote:
Interesting, I don't see a memory controller function in the stack
trace, but I'll double check to see if I can find some silly race
condition in there.
right. I noticed that after I sent the mail.
Also, config
On Wed, Sep 12, 2007 at 06:58:54PM +0200, Michal Piotrowski wrote:
FS
Subject : hanging ext3 dbench tests
References : http://lkml.org/lkml/2007/9/11/176
Last known good : ?
Submitter : Andy Whitcroft [EMAIL PROTECTED]
Caused-By : ?
Handled-By : ?
Status
On Tue, Aug 21, 2007 at 06:29:59PM -0400, Mike Frysinger wrote:
Check for a few common errors in Blackfin-specific code wrt MMR loading in
assembly and doing core/system syncs.
If we are going to pull arch specific things into checkpatch I think we
need to make sure we are pretty specific about
On Tue, Sep 11, 2007 at 04:10:47AM +0900, FUJITA Tomonori wrote:
The only patch which touches qla1280 is git-block.patch. From a quick
squizz the change looks OK, although it's tricky and something might have
broken.
Can you try this patch (against 2.6.23-rc4-mm1)?
Yep this patch seems
On Tue, Sep 11, 2007 at 04:31:12AM +0900, FUJITA Tomonori wrote:
[...]
The only patch which touches qla1280 is git-block.patch. From a quick
squizz the change looks OK, although it's tricky and something might have
broken.
(the dprintk at line 2929 needs to print remseg, not seg_cnt).
On Tue, Sep 11, 2007 at 06:30:49PM +0100, Andy Whitcroft wrote:
Annoyingly this seems to be intermittent, and I have not managed to get
a machine into this state again yet. Will keep trying.
Ok, I have been completly unsuccessful in reproducing this. Dispite
having two distinct machines
Anton, this seems a little reminicient of that bug which popped up in
2.6.23-rc3 so do with SLB loading (if memory serves), with machine
checks and signal 7's. Of course that is _supposed_ to be fixed by this
time ...
I believe it was Paul who fixed up that one, and he is already copied.
-apw
On Tue, Sep 18, 2007 at 02:43:48PM +0530, Kamalesh Babulal wrote:
Andrew Morton wrote:
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc6/2.6.23-rc6-mm1/
2.6.23-rc6-mm1 is a 29MB diff against 2.6.23-rc6.
snip
Hi Andrew,
The 2.6.23-rc6-mm1build fails at
I am seeing this strange link error from a PowerMac G5 (powerpc):
[...]
KSYM.tmp_kallsyms2.S
AS .tmp_kallsyms2.o
LD vmlinux.o
ld: dynreloc miscount for fs/built-in.o, section .opd
ld: can not edit opd Bad value
make: *** [vmlinux.o] Error 1
Compiler version
Seeing the following panic booting an old powerpc LPAR:
Unable to handle kernel paging request for data at address 0x
Faulting instruction address: 0xc0047b48
cpu 0x0: Vector: 300 (Data Access) at [c06a3750]
pc: c0047b48: .pSeries_log_error+0x364/0x420
lr:
Seems I have a case of a largish i386 NUMA (NUMA-Q) which has a mkfs
stuck in a 'D' wait:
===
mkfs.ext2 D c10220f4 0 6233 6222
c344fc80 0082 0286 c10220f4 c344fc90 002ed099 c2963340 c2b9f640
c142bce0 c2b9f640 c344fc90 002ed099 c344fcfc
On Wed, Sep 19, 2007 at 06:36:29PM +0200, Segher Boessenkool wrote:
I am seeing this strange link error from a PowerMac G5 (powerpc):
[...]
KSYM.tmp_kallsyms2.S
AS .tmp_kallsyms2.o
LD vmlinux.o
ld: dynreloc miscount for fs/built-in.o, section .opd
ld: can
On Fri, Sep 14, 2007 at 10:49:05AM +0100, Andy Whitcroft wrote:
On Tue, Sep 11, 2007 at 06:30:49PM +0100, Andy Whitcroft wrote:
Annoyingly this seems to be intermittent, and I have not managed to get
a machine into this state again yet. Will keep trying.
Ok, I have been completly
On Thu, Sep 20, 2007 at 12:38:55AM +0200, Michael Opdenacker wrote:
Andrew, you're completely right... The patches should all aim at being
included into mainline or die.
I'm finishing a sequence of crazy weeks and I will have time to send you
patches one by one next week, starting with the
On Sat, Nov 10, 2007 at 07:30:57PM -0500, Erez Zadok wrote:
Andrew,
I'm getting minor warnings when applying two patches from
http://userweb.kernel.org/~akpm/mmotm/
It's probably not serious but I wonder if checkpatch catches this.
Applying patch..git-net.patch
Warning: commit message
On Mon, Nov 12, 2007 at 02:46:30PM -0500, Mike Frysinger wrote:
the current checkpatch.pl does not reject new files that lack a
newline, yet rejects patches that fix newlines in files ... quite the
opposite of what we actually want
Nice. Just what the world needs. I wonder what the heck that
On Mon, Nov 12, 2007 at 02:46:30PM -0500, Mike Frysinger wrote:
the current checkpatch.pl does not reject new files that lack a
newline, yet rejects patches that fix newlines in files ... quite the
opposite of what we actually want
[EMAIL PROTECTED] echo -n moo no-newline.c
[EMAIL PROTECTED]
- handle patches which introduce or remove lines without newlines
Andy Whitcroft (19):
Version: 0.12
style fixes as spotted by checkpatch
add a --terse options of a single line of output per report
block brace checks should only apply for single line blocks
all new bare
We seem to have some general problem with mkfs for all filesystems.
I am seeing this across at least three test systems although
most are unable to compile this kernel :(, even with the hotfix.
Basically, all mkfs operations for any filsystem type are failing,
ext2 reports this as short write,
));
}
Reviewed-by: Andy Whitcroft [EMAIL PROTECTED]
-apw
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
When testing some of the later 2.6.24-rc2-mm1+hotfix combinations on three
of our test systems one job from each batch (1/4) failed. In each case the
machine appears to have booted normally all the way to a login: prompt.
However in the failed boots the networking though apparently initialised
All of our machines with QLogics ISP1020 cards seem to have lost them on
boot with 2.6.24-rc1-mm1+hotfixes.
# lspci
:00:0a.0 SCSI storage controller: QLogic Corp. ISP1020 Fast-wide
SCSI (rev 05)
# lspci -n
:00:0a.0 0100: 1077:1020 (rev 05)
# lspci -v -v
:00:0a.0 SCSI storage
On Fri, Nov 16, 2007 at 09:16:58PM -0800, Andrew Morgan wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
This warning is just saying that you might want to reconsider
recompiling your dhclient with a newer libcap - which has native support
for 64-bit capabilities. This is
On Wed, Dec 19, 2007 at 11:23:48PM -0700, Grant Likely wrote:
+ /* Make the sysace device 'live' */
+ if (ace-fsm_state != ACE_FSM_STATE_INVALIDATE_MEDIA);
+ add_disk(ace-gd);
checkpatch.pl reports the above if as suspect due to the trailing ;.
On Thu, Nov 29, 2007 at 06:35:28PM -0800, Joe Perches wrote:
On Fri, 2007-11-30 at 09:54 +0800, Li Zefan wrote:
So it doesn't deserve the effort to eliminate these periods, isn't it?
I hope these will eventually disappear.
Or we can add a check to checkpatch.pl to prevent new ones.
On Mon, Dec 03, 2007 at 03:53:17PM -0800, Andrew Morton wrote:
+#define READ_SC(p, r)readb ((p)-membase + RD_##r)
+#define WRITE_SC(p, r, v)writeb ((v), (p)-membase + WR_##r)
No space before the (. checkpatch misses this.
Yep, over careful in the special case for the
On Tue, Dec 18, 2007 at 06:46:41AM +0100, Borislav Petkov wrote:
On Mon, Dec 17, 2007 at 08:11:05AM +0100, Borislav Petkov wrote:
A slightly microoptimized version 1.1:
---
From: Borislav Petkov [EMAIL PROTECTED]
Check the patch level of the single hunks in a patch file, however only
On Wed, Nov 28, 2007 at 12:07:38PM +0100, Holger Schurig wrote:
I have a case where scripts/checkpatch.pl returns a false error.
First, here is the code:
static int lbs_scan_add_rates_tlv(u8 *tlv)
{
int i;
struct mrvlietypes_ratesparamset *rate_tlv =
(struct
On Sun, Nov 18, 2007 at 11:03:47AM +0100, Geert Uytterhoeven wrote:
checkpatch: Print filenames of patches instead of the very uninformative
`Your patch'.
Well this isn't quite enough as we often use this thing checking its
stdin. Which leads to an even less useful '- has no obvious ...'. I
I have one powerpc machine which managed to compile this snapshot! It
paniced on boot as below, might be nfs so copied them. General results
are popping out on TKO.
-apw
Freeing initrd memory: 1224k freed
Installing knfsd (copyright (C) 1996 [EMAIL PROTECTED]).
Unable to handle kernel paging
On Tue, Dec 25, 2007 at 04:50:04PM -0500, Erez Zadok wrote:
Using v2.6.24-rc6-125-g5356f66, code such as this:
if (is_file)/* dirs can be unlinked but chdir'ed to */
err = -ESTALE;
produces this false checkpatch error:
foo.c:947: ERROR: trailing statements
On Tue, Jan 01, 2008 at 12:12:22PM +0200, Benny Halevy wrote:
checkpatch.pl does not recognize #elif as a preprocessor directive
causing it to print bogus errors for, e.g.:
ERROR: need consistent spacing around '' (ctx:WxV)
when the operator is not recognized as unary in this context.
for
On Tue, Jan 01, 2008 at 06:15:46PM +0200, Boaz Harrosh wrote:
I have this code:
c_code
/*
* osd-r10 4.12.5 Data-In and Data-Out buffer offsets
* byte offset = mantissa * (2^(exponent+8))
*/
typedef __be32 osd_cdb_offset;
osd_cdb_offset __osd_encode_offset(u64 offset, unsigned
On Sun, Dec 02, 2007 at 01:03:35PM +0100, Christer Weinigel wrote:
Hi Andy,
you seem to be the last person messing around with checkpatch.pl so I'm
addressing this to you. :-)
checkpatch complains about the following:
WARNING: no space between function name and open parenthesis '('
On Thu, Jan 03, 2008 at 01:54:42AM +0100, Arjan van de Ven wrote:
Subject: Make checkpatch.pl's quiet option not print the summary on no
errors
From: Arjan van de Ven [EMAIL PROTECTED]
CC: [EMAIL PROTECTED]
Right now, in quiet mode, checkpatch.pl still prints a summary line even
if the
On Thu, Oct 25, 2007 at 01:48:14PM -0700, Andrew Morton wrote:
Andy, I thought we were going to whine about __inline__ and __inline, too?
Hmmm, I don't remember that coming up, but I'll add it to the todo. I
am assuming plain 'inline' is preferred over both of these -- yell if
you meant
On Sat, Oct 27, 2007 at 11:43:28AM +0100, Andy Whitcroft wrote:
On Thu, Oct 25, 2007 at 01:48:14PM -0700, Andrew Morton wrote:
Andy, I thought we were going to whine about __inline__ and __inline, too?
Hmmm, I don't remember that coming up, but I'll add it to the todo. I
am assuming
-by? And/or ack/nack's on my half-arsed theory above?
This code is definatly only used when SPARSEMEM is enabled, and VMEMMAP
is not which is not a combination we see on x86_64.
Acked-by: Andy Whitcroft [EMAIL PROTECTED]
Linus
--
From: Linus Torvalds [EMAIL PROTECTED]
Revert x86_64
On Tue, Oct 30, 2007 at 02:27:13PM -0500, Timur Tabi wrote:
I'm running checkpatch.pl (dated 10/17), and it complains about this line:
crc = __be32_to_cpu(* ((__be32 *) ((void *) firmware + calc_size)));
the message I get is:
ERROR: need space before that '*' (ctx:BxW)
#721: FILE:
On Tue, Oct 30, 2007 at 10:11:44PM -0700, Greg Kroah-Hartman wrote:
From: Keiichi Kii [EMAIL PROTECTED]
Fix typo.
Signed-off-by: Keiichi Kii [EMAIL PROTECTED]
Cc: Andy Whitcroft [EMAIL PROTECTED]
Cc: Randy Dunlap [EMAIL PROTECTED]
Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED
Seems we are getting some kind of bug out of our s390x partition (lnxabat1)
when booting latest mainline releases, specifically since 2.6.23-git3.
Kernel BUG at 0002 Ýverbose debug info unavailable¨
illegal operation: 0001 Ý#1¨
Modules linked in: dm_mod sit tunnel4 ipv6 qeth ccwgroup
The check then is to see if a non {}'d block has no statements in it if the
ifdef is null. Hmmm. May be possible. Will think on it.
if (err)
+#ifdef CONFIG_GFAR_NAPI
napi_disable(priv-napi);
+#endif
-apw
-
To unsubscribe from this list: send the line unsubscribe
On Thu, Oct 18, 2007 at 01:13:52PM +0200, Ingo Molnar wrote:
latest checkpatch.pl works really well on sched.c.
there's only one problem left, this bogus false positive warning
reappeared:
WARNING: braces {} are not necessary for single statement blocks
#5710: FILE: sched.c:5710:
On Thu, Oct 18, 2007 at 08:25:21PM +0100, Andy Whitcroft wrote:
On Thu, Oct 18, 2007 at 01:13:52PM +0200, Ingo Molnar wrote:
latest checkpatch.pl works really well on sched.c.
there's only one problem left, this bogus false positive warning
reappeared:
WARNING: braces
On Thu, Oct 18, 2007 at 10:51:47PM +0200, Ingo Molnar wrote:
* Avi Kivity [EMAIL PROTECTED] wrote:
if (foo)
bar();
baz();
one();
detecting that would be awesome - it's often the sign of a real bug
because the intent is often to have bar() and
On Tue, Oct 23, 2007 at 08:44:20PM +0200, Jens Axboe wrote:
On Tue, Oct 23 2007, Kamalesh Babulal wrote:
Hi,
Kernel oops is triggered while running fsx-linux test, followed by cpu
softlock
over the AMD box
Unable to handle kernel NULL pointer dereference at 0018 RIP:
Seems that we are now getting strange errors mounting an ext2 root
filesystem under 2.6.23-git18:
EXT2-fs error (device sda1): ext2_check_page: bad entry in directory #2:
rec_len is smaller than minimal - offset=0, inode=0, rec_len=0,
name_len=0
This seems to be occuring consistently since
On Wed, Oct 24, 2007 at 03:59:00PM +0200, Jan Kara wrote:
Hello,
On Wed 24-10-07 14:15:40, Andy Whitcroft wrote:
Seems that we are now getting strange errors mounting an ext2 root
filesystem under 2.6.23-git18:
EXT2-fs error (device sda1): ext2_check_page: bad entry in directory
On Wed, Oct 24, 2007 at 05:03:03PM +0200, Jan Kara wrote:
e2image -r /dev/sda1 - | gzip -dc root-image.gz
This thing is 27MB, I'll try and find some space to hold it and
let you know where it is offlist.
-apw
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
On Sun, Feb 10, 2008 at 03:33:02PM +0100, Marcin Slusarz wrote:
Hi
Checkpatch in current mainline outputs following errors:
$ ./scripts/checkpatch.pl -q --file ./fs/udf/misc.c
ERROR: need consistent spacing around '*' (ctx:WxV)
#205: FILE: fs/udf/misc.c:205:
+ tag *tag_p;
On Mon, Feb 11, 2008 at 06:58:08PM +0200, Benny Halevy wrote:
OK, but the return type doesn't have to be in the patched line, it could be in
a synchronization line or even missing if the function has a long multi-line
argument
list.
Ok, I guess thats fair criticism. Could you check out the
On Mon, Feb 11, 2008 at 06:05:48PM +0200, Benny Halevy wrote:
I saw this too with checkpatch.pl version 0.12
It seems like checkpatch.pl knows only about types derived
from @typeList by build_types.
Example below...
Benny
$ cat EOF | scripts/checkpatch.pl -
Signed-off-by: [EMAIL
1 - 100 of 940 matches
Mail list logo
