Re: [PATCH for 3.7] mtd: nand: fix Samsung SLC NAND identification regression

2012-10-31 Thread Brian Norris
Hi David, On Wed, Oct 10, 2012 at 12:48 AM, David Woodhouse dw...@infradead.org wrote: On Tue, 2012-10-09 at 23:39 -0700, Brian Norris wrote: I can see if that's possible, but I think it's unlikely. They don't even bother following standards (ONFI). Is this an obstacle to merging? No. I

[PATCH for 3.7] mtd: nand: fix Samsung SLC NAND identification regression

2012-10-10 Thread Brian Norris
Norris computersforpe...@gmail.com Tested-by: Brian Norris computersforpe...@gmail.com Reported-by: Marek Vasut ma...@denx.de Tested-by: Marek Vasut ma...@denx.de --- David, Marek and I just discovered this issue during the merge window. Please merge this fix in the 3.7-rc cycle. Thanks. drivers

Re: [PATCH for 3.7] mtd: nand: fix Samsung SLC NAND identification regression

2012-10-10 Thread Brian Norris
On Tue, Oct 9, 2012 at 11:31 PM, David Woodhouse dw...@infradead.org wrote: On Tue, 2012-10-09 at 23:26 -0700, Brian Norris wrote: I have heuristically determined that all the chips that use the new table have ID strings which wrap around after the 6th byte. I'd be happier if we had

Re: [PATCH] mtd: use the NAND_STATUS_FAIL to replace the hardcode

2012-10-25 Thread Brian Norris
FWIW On Sun, Oct 14, 2012 at 8:47 PM, Huang Shijie shij...@gmail.com wrote: Use the NAND_STATUS_FAIL to replace the hardcode 0x01, which make the code more readable. Signed-off-by: Huang Shijie shij...@gmail.com Acked-by: Brian Norris computersforpe...@gmail.com -- To unsubscribe from

[RFC 2/3] ahci_platform: convert to module_platform_driver

2012-10-25 Thread Brian Norris
The ahci_platform driver can now use the module_platform_driver() macro. Signed-off-by: Brian Norris computersforpe...@gmail.com --- drivers/ata/ahci_platform.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/ata/ahci_platform.c b/drivers/ata

[RFC 0/3] libata/ahci unbinding, power down sequence

2012-10-25 Thread Brian Norris
standalone suggestions :) Please see my previous email (URL above) and/or patch 3/3 for a more detailed description. Thanks, Brian Brian Norris (3): ahci_platform: enable hotplug unbinding ahci_platform: convert to module_platform_driver libata: don't perform HW activity in devres drivers/ata

[RFC 3/3] libata: don't perform HW activity in devres

2012-10-25 Thread Brian Norris
of the ata_host_detach() sequence already performed by all SATA drivers at device exit. Signed-off-by: Brian Norris computersforpe...@gmail.com --- drivers/ata/libata-core.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata

[RFC 1/3] ahci_platform: enable hotplug unbinding

2012-10-25 Thread Brian Norris
platform_driver_register(). Signed-off-by: Brian Norris computersforpe...@gmail.com --- drivers/ata/ahci_platform.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c index 9e419e1..f467ba8 100644 --- a/drivers/ata

Re: [RFC 3/3] libata: don't perform HW activity in devres

2012-10-25 Thread Brian Norris
On Thu, Oct 25, 2012 at 10:25 AM, Tejun Heo t...@kernel.org wrote: On Thu, Oct 25, 2012 at 09:56:01AM -0700, Brian Norris wrote: devres functions are intended for simplified cleanup of memory and other software resources on device exit, not for hardware shutdown sequences. In addition

Re: [PATCH v5 0/3] mtd: use the full-id as the keyword for some nand chips

2013-03-13 Thread Brian Norris
On Wed, Mar 13, 2013 at 7:59 PM, Huang Shijie b32...@freescale.com wrote: As time goes on, we begin to meet the situation that we can not get enough information from some nand chips's id data. Take some Toshiba's nand chips for example. I have 4 Toshiba's nand chips in my hand:

Re: [PATCH v5 3/3] mtd: add 4 Toshiba nand chips for the full-id case

2013-03-13 Thread Brian Norris
On Wed, Mar 13, 2013 at 7:59 PM, Huang Shijie b32...@freescale.com wrote: I have 4 Toshiba nand chips which can not be parsed out by the id data. We can not get the oob size from the id data. So add them as the full-id nand chips in the first of nand_flash_ids. The nand_get_flash_type() scans

Re: [PATCH v5 2/3] mtd: add the support to parse out the full-id nand type

2013-03-13 Thread Brian Norris
Hi Huang, A few nitpicks, and a few real comments. On Wed, Mar 13, 2013 at 7:59 PM, Huang Shijie b32...@freescale.com wrote: When we meet a full-id nand type which @mfr_id is true, we can use the find_full_id_nand() to parse out the neccessary information for a s/neccessary/necessary nand

Re: [PATCH V4 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-13 Thread Brian Norris
On Wed, Mar 13, 2013 at 6:04 AM, Huang Shijie shij...@gmail.com wrote: On Wed, Mar 13, 2013 at 6:54 PM, Artem Bityutskiy artem.bityuts...@linux.intel.com wrote: On Thu, 2013-03-07 at 18:49 +0800, Huang Shijie wrote: diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h index

Re: [PATCH v5 0/3] mtd: use the full-id as the keyword for some nand chips

2013-03-14 Thread Brian Norris
On 03/14/2013 12:07 AM, Artem Bityutskiy wrote: On Wed, 2013-03-13 at 21:48 -0700, Brian Norris wrote: On Wed, Mar 13, 2013 at 7:59 PM, Huang Shijie b32...@freescale.com wrote: As time goes on, we begin to meet the situation that we can not get enough information from some nand chips's id data

Re: [PATCH v5 3/3] mtd: add 4 Toshiba nand chips for the full-id case

2013-03-15 Thread Brian Norris
On 03/14/2013 07:29 PM, Huang Shijie wrote: sorry for my poor english. No need to apologize. Thanks for braving through the 6 iterations of this! We were going to need this eventually anyway. Now that the dust is settling, your v6 is looking pretty good. I'll have a closer look later and

Re: [PATCH v6 0/3] mtd: use the full-id as the keyword for some nand chips

2013-03-18 Thread Brian Norris
insertions(+), 3 deletions(-) Series looks good to me. Thanks Huang! Reviewed-by: Brian Norris computersforpe...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-04 Thread Brian Norris
On Mon, Mar 4, 2013 at 12:59 AM, Huang Shijie b32...@freescale.com wrote: 于 2013年03月04日 16:46, Artem Bityutskiy 写道: Thanks, I forgot we have this great table. BTW, please, do not forget to update it with information about these 4 chip you are adding, irrespective of the solution we end up

Re: Bug in mtd_get_device_size()?

2013-02-28 Thread Brian Norris
+ Richard On Thu, Feb 28, 2013 at 4:30 AM, Velykokhatko, Sergey sergey.velykokha...@mcc-med.de wrote: I got today such case: * Kernel 3.8 * We are using M29F2G16 NAND chip with 4096 blocks, each has 128k * Configured with CONFIG_MTD_UBI_BEB_LIMIT=100 This is your

Re: [PATCH] mtd:nand:clk: preparation for switch to common clock framework

2012-09-07 Thread Brian Norris
On Fri, Sep 7, 2012 at 2:56 PM, Karicheri, Muralidharan m-kariche...@ti.com wrote: How do these patch get to upstream? Does this get merged through davinci maintainer or through individual subsystem maintainers? I think this driver would be taken by David Woodhouse in his linux-mtd repo.

Re: [PATCH] mtd: remove obsolete JEDEC mapping drivers

2013-07-27 Thread Brian Norris
this. But FWIW: Acked-by: Brian Norris computersforpe...@gmail.com drivers/mtd/maps/Kconfig| 18 --- drivers/mtd/maps/Makefile | 2 - drivers/mtd/maps/octagon-5066.c | 246 drivers/mtd/maps/vmax301.c | 196

Re: [PATCH 2/4] mtd: m25p80: make CONFIG_M25PXX_USE_FAST_READ safe to enable

2013-08-19 Thread Brian Norris
On Mon, Aug 19, 2013 at 10:42:26AM +0200, Sascha Hauer wrote: On Sat, Aug 17, 2013 at 01:17:02PM -0700, Brian Norris wrote: On Mon, Aug 12, 2013 at 12:22:24PM +0200, Sascha Hauer wrote: This patch adds a flag to struct flash_info indicating that fast_read is not supported. This now gives

Re: [PATCH 4/4] mtd: m25p80: remove unnecessary ifdef

2013-08-19 Thread Brian Norris
On Mon, Aug 12, 2013 at 12:22:26PM +0200, Sascha Hauer wrote: of_property_read_bool properly compiles away, no need to ifdef this for non DT builds. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Pushed only this one to l2-mtd.git, since it's independent. Thanks, Brian -- To unsubscribe

Re: [PATCH v2] m25p80 / fast read

2013-08-20 Thread Brian Norris
On Tue, Aug 20, 2013 at 09:54:38AM +0200, Sascha Hauer wrote: Changes since v1: - rebase on git.infradead.org/l2-mtd.git - improve description for patch 2/3 Thanks for these. Sascha Markus Niebel (1): mtd:

[Device-tree] mailing list responsiveness and discoverability

2013-08-20 Thread Brian Norris
Hello device tree maintainers, I (sub)maintain the Linux MTD subsystem and hang out on the linux-...@infradead.org mailing list. I have been seeing an increasing number of submissions that involve device-tree changes. Many of these changes are ill thought out and may even cause ABI breakage.

Re: [Device-tree] mailing list responsiveness and discoverability

2013-08-21 Thread Brian Norris
On Wed, Aug 21, 2013 at 9:10 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/20/2013 08:25 PM, Brian Norris wrote: Hello device tree maintainers, I (sub)maintain the Linux MTD subsystem and hang out on the linux-...@infradead.org mailing list. I have been seeing an increasing number

Re: [PATCH RESEND 1/2] mtd: bcm47: convert kzalloc to avoid invalid access

2013-08-22 Thread Brian Norris
On Thu, May 30, 2013 at 10:22:12AM +0800, Libo Chen wrote: mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member. So I use devm_kazlloc instead of kazlloc to avoid it. * Changelog: convert to devm_kzalloc Signed-off-by: Libo chen libo.c...@huawei.com

checkpatch.pl: false warning about -p0 patch

2013-08-22 Thread Brian Norris
Hello, I have received what appears to be a false warning from checkpatch.pl when checking a patch named 'b': $ scripts/checkpatch.pl b WARNING: patch prefix 'b' exists, appears to be a -p0 patch total: 0 errors, 1 warnings, 16 lines checked b has style problems, please review.

Re: checkpatch.pl: false warning about -p0 patch

2013-08-22 Thread Brian Norris
On Thu, Aug 22, 2013 at 2:57 PM, Joe Perches j...@perches.com wrote: On Thu, 2013-08-22 at 14:45 -0700, Brian Norris wrote: Hello, Hello. I have received what appears to be a false warning from checkpatch.pl when checking a patch named 'b': $ scripts/checkpatch.pl b WARNING

Re: [PATCH] block: add command line partition parser

2013-08-14 Thread Brian Norris
On Wed, Aug 14, 2013 at 3:57 PM, Andrew Morton a...@linux-foundation.org wrote: On Tue, 13 Aug 2013 06:02:17 + Caizhiyong caizhiy...@huawei.com wrote: move the command line parser to a separate module, and change it into library-style code. reference: https://lkml.org/lkml/2013/8/6/550

Re: [PATCH] block: add command line partition parser

2013-08-14 Thread Brian Norris
On Thu, Aug 15, 2013 at 03:38:47AM +, Caizhiyong wrote: -Original Message- From: Brian Norris [mailto:computersforpe...@gmail.com] Sent: Thursday, August 15, 2013 8:12 AM To: Andrew Morton Cc: Caizhiyong; Karel Zak; linux-...@lists.infradead.org; linux-kernel

Re: [PATCH] block: add command line partition parser

2013-08-15 Thread Brian Norris
On Thu, Aug 15, 2013 at 06:16:04AM +, Caizhiyong wrote: -Original Message- From: Brian Norris [mailto:computersforpe...@gmail.com] Sent: Thursday, August 15, 2013 1:00 PM To: Caizhiyong Cc: Andrew Morton; Karel Zak; linux-...@lists.infradead.org; linux-kernel

Re: [PATCH] block: add command line partition parser

2013-08-15 Thread Brian Norris
On 08/15/2013 12:45 AM, Caizhiyong wrote: -Original Message- From: Brian Norris [mailto:computersforpe...@gmail.com] ... On Thu, Aug 15, 2013 at 06:16:04AM +, Caizhiyong wrote: I want to use the MTD command line partition method on block devices (eMMC). It is very suitable

Re: [PATCH 2/4] mtd: m25p80: make CONFIG_M25PXX_USE_FAST_READ safe to enable

2013-08-17 Thread Brian Norris
if device node contains m25p,fast-read 2) enable fast_read if forced in Kconfig If we correct this description, then: Acked-by: Brian Norris computersforpe...@gmail.com I can edit the patch and push the whole thing if this is acceptable. One related question (not required for this series): do we

Re: [PATCH -next] mtd: nand: omap: fix error return code in omap_nand_probe()

2013-11-05 Thread Brian Norris
On Thu, Oct 31, 2013 at 7:18 PM, Jingoo Han jg1@samsung.com wrote: On Friday, November 01, 2013 9:16 AM, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function.

Re: [PATCH 2/2] mtd: cmdlinepart: use cmdline partition parser lib

2013-11-05 Thread Brian Norris
On Tue, Nov 5, 2013 at 2:43 PM, Andrew Morton a...@linux-foundation.org wrote: On Tue, 22 Oct 2013 13:14:17 + Caizhiyong caizhiy...@hisilicon.com wrote: In the previous version, adjust the cmdline parser code to library-style code, and move it to a separate file block/cmdline-parser.c,

Re: [PATCH -next] mtd: nand: omap: fix error return code in omap_nand_probe()

2013-11-06 Thread Brian Norris
On Tue, Nov 05, 2013 at 07:45:27PM -0300, Ezequiel Garcia wrote: On Tue, Nov 05, 2013 at 01:59:25PM -0800, Brian Norris wrote: On Thu, Oct 31, 2013 at 7:18 PM, Jingoo Han jg1@samsung.com wrote: On Friday, November 01, 2013 9:16 AM, Wei Yongjun wrote: From: Wei Yongjun yongjun_

Re: [PATCH -next] mtd: nand: omap: fix error return code in omap_nand_probe()

2013-11-06 Thread Brian Norris
On Wed, Nov 06, 2013 at 06:06:25PM +, Pekon Gupta wrote: From: Brian Norris [mailto:computersforpe...@gmail.com] On Thu, Oct 31, 2013 at 7:18 PM, Jingoo Han jg1@samsung.com From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return a negative error code from the error

Re: [PATCH] mtd: nand: remove deprecated IRQF_DISABLED

2013-11-07 Thread Brian Norris
On Sun, Oct 13, 2013 at 08:21:32AM +0200, Michael Opdenacker wrote: This patch proposes to remove the use of the IRQF_DISABLED flag It's a NOOP since 2.6.35 and it will be removed one day. Signed-off-by: Michael Opdenacker michael.opdenac...@free-electrons.com Pushed to l2-mtd.git. Thanks!

Re: [PATCH] UBIFS: fix error return code in ubifs_remount_rw() and ubifs_fill_super()

2013-10-02 Thread Brian Norris
Bump, Artem? I'm cleaning out my old email, and this patch looks obviously correct. On Thu, Jun 6, 2013 at 7:17 PM, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return -ENOMEM in the kmalloc() and d_make_root() error handling case instead of 0,

Re: [GIT PULL] ARM: SoC fixes for 3.12-rc

2013-10-02 Thread Brian Norris
(Trimming CC list) Hi David, On Thu, Sep 19, 2013 at 4:19 PM, Woodhouse, David david.woodho...@intel.com wrote: On Thu, 2013-09-19 at 15:57 -0700, Brian Norris wrote: Speaking of such process issues: there's an outstanding patch for a (small) memory leak that was introduced in the nand_base.c

[PATCH] mtd: nand: fix memory leak in ONFI extended parameter page

2013-09-16 Thread Brian Norris
Page In the success case, we never freed the 'ep' buffer. Also, this fixes an oversight in the same commit where we (harmlessly) freed the NULL pointer. Signed-off-by: Brian Norris computersforpe...@gmail.com Cc: Huang Shijie b32...@freescale.com --- David, if there are no objections, can you

Re: [PATCH] mtd: onenand: omap: remove two unused functions

2013-09-16 Thread Brian Norris
On Wed, Aug 07, 2013 at 08:16:49PM +0200, Paul Bolle wrote: Nothing calls omap2_onenand_rephase(). And __adjust_timing() is only called by omap2_onenand_rephase(). Remove these two unused functions. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Completely untested. Compile-tested

Re: [PATCH] mtd: nand: fix memory leak in ONFI extended parameter page

2013-09-18 Thread Brian Norris
On Tue, Sep 17, 2013 at 10:12:57AM +0800, Huang Shijie wrote: 于 2013年09月17日 09:31, Brian Norris 写道: This fixes a memory leak in the ONFI support code for detecting the required ECC levels from this commit: commit 6dcbe0cdd83fb5f77be4f44c9e06c535281c375a Author: Huang Shijie b32

Re: [GIT PULL] ARM: SoC fixes for 3.12-rc

2013-09-19 Thread Brian Norris
in l2-mtd.git (will need cherry-picked out of there) and ready for the next linux-next: commit b2bdf43fcc1d440d8f4e1d5c8c59bf2ca76204df Author: Brian Norris computersforpe...@gmail.com Date: Mon Sep 16 17:59:20 2013 -0700 mtd: nand: fix memory leak in ONFI extended parameter page Brian

Re: [GIT PULL] ARM: SoC fixes for 3.12-rc

2013-09-19 Thread Brian Norris
On Thu, Sep 19, 2013 at 4:19 PM, Woodhouse, David david.woodho...@intel.com wrote: On Thu, 2013-09-19 at 15:57 -0700, Brian Norris wrote: On Thu, Sep 19, 2013 at 2:39 PM, Woodhouse, David david.woodho...@intel.com wrote: On Thu, 2013-09-19 at 12:47 -0700, Olof Johansson wrote: - A fix

Re: [PATCH] MIPS: Alchemy: add missing platform_set_drvdata() in au1550nd_probe()

2013-11-26 Thread Brian Norris
On Mon, Nov 11, 2013 at 02:18:29PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Add missing platform_set_drvdata() in au1550nd_probe(), otherwise calling platform_get_drvdata() in remove returns NULL. An alternative solution: just allocate ctx with

Re: [PATCH 07/12] memory: davinci-aemif: introduce AEMIF driver

2013-11-26 Thread Brian Norris
On Tue, Nov 26, 2013 at 01:26:44PM -0500, Santosh Shilimkar wrote: On Tuesday 26 November 2013 12:21 PM, Sekhar Nori wrote: On 11/26/2013 8:35 PM, Santosh Shilimkar wrote: On Tuesday 26 November 2013 02:20 AM, Sekhar Nori wrote: On Monday 11 November 2013 10:36 PM, Khoronzhuk, Ivan wrote:

Re: [PATCH v2 00/10] Reuse davinci-nand driver for Keystone arch

2013-11-26 Thread Brian Norris
Hi Ivan, On Thu, Nov 21, 2013 at 01:28:15PM +0200, Ivan Khoronzhuk wrote: This series contains fixes and updates of Davinci nand driver in order to reuse it for Keystone platform. The series is combination of two following series: - Davinci nand driver fixes and updates:

Re: [PATCH] MIPS: Alchemy: add missing platform_set_drvdata() in au1550nd_probe()

2013-11-26 Thread Brian Norris
Hi Jingoo, On Wed, Nov 27, 2013 at 09:14:18AM +0900, Jingoo Han wrote: On Wednesday, November 27, 2013 8:50 AM, Brian Norris wrote: On Mon, Nov 11, 2013 at 02:18:29PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Add missing platform_set_drvdata

Re: [PATCH 00/23] mtd: st_spi_fsm: Add new device

2013-11-26 Thread Brian Norris
+ Huang, Mark, SPI list There seem to be multiple efforts going on that are vaguely related. I'd like to see more of the same people appearing on the CC list, to keep better coordinated. On that topic, is the SPI dev list relevant, or would anybody working on the intersection of SPI and MTD be

Re: [PATCH] mtg: docg3: use free_bch() instead of kfree()

2013-10-11 Thread Brian Norris
On Fri, Oct 11, 2013 at 12:40:21PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Use free_bch() instead of kfree() to free init_bch() allocated data. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Pushed to l2-mtd.git. Thanks! Brian -- To unsubscribe

Re: [PATCH] mtd: Move major number definitions to major.h

2013-10-15 Thread Brian Norris
+ LKML On Sun, Oct 13, 2013 at 2:05 PM, Ezequiel Garcia ezequiel.gar...@free-electrons.com wrote: This patch moves the char and block major number definitions to major.h to be with the rest of the major numbers. While doing this, include major.h in the files that need it. The patch looks good

[GIT PULL] MTD changes for 3.13

2013-11-13 Thread Brian Norris
! Alexander Sverdlin (1): mtd: phram: Make phram 64-bit compatible Brian Norris (21): nand: docg4: use nand_base's default BBT scan mtd: nand: lpc32xx_slc: don't call nand_default_bbt directly mtd: nandsim: don't call

Re: [PATCH 02/12] mtd: Remove superfluous name casts

2013-11-13 Thread Brian Norris
On Tue, Nov 12, 2013 at 08:07:15PM +0100, Geert Uytterhoeven wrote: map_info.name is const char * Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Cc: David Woodhouse dw...@infradead.org Cc: linux-...@lists.infradead.org Pushed to l2-mtd.git/next. Thanks! Brian -- To unsubscribe from

Re: [PATCH 03/12] mtd: pasemi_nand.c: Remove superfluous name cast

2013-11-13 Thread Brian Norris
On Tue, Nov 12, 2013 at 08:07:16PM +0100, Geert Uytterhoeven wrote: device_driver.name is const char * Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Cc: Olof Johansson o...@lixom.net Cc: linux-...@lists.infradead.org Pushed to l2-mtd.git/next. Thanks! Brian -- To unsubscribe from

Re: [PATCH 10/12] mtd: ms02-nv: Remove superfluous name cast

2013-11-13 Thread Brian Norris
On Tue, Nov 12, 2013 at 08:07:23PM +0100, Geert Uytterhoeven wrote: mtd_info.name is const char * Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Cc: David Woodhouse dw...@infradead.org Cc: linux-...@lists.infradead.org Pushed to l2-mtd.git/next. Thanks! Brian -- To unsubscribe from

Re: [PATCH] mtd: Make mtd_partition.name const

2013-11-13 Thread Brian Norris
On Tue, Nov 12, 2013 at 08:11:26PM +0100, Geert Uytterhoeven wrote: This allows to drop a few casts. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Pushed to l2-mtd.git/next. Thanks! Brian -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [PATCH v2] mxc_nand: remove duplicated ecc_stats counting

2013-12-04 Thread Brian Norris
On Fri, Nov 29, 2013 at 02:14:29PM +0100, Michael Grzeschik wrote: The ecc_stats.corrected count variable will already be incremented in the above framework-layer just after this callback. Cc: sta...@vger.kernel.org Added a 2.6.36+ note, just for reference. Signed-off-by: Michael Grzeschik

[PATCH 0/2] MTD maintenance updates

2013-12-04 Thread Brian Norris
work these days). Brian [1] http://lists.infradead.org/pipermail/linux-mtd/2013-November/050122.html Brian Norris (1): MAINTAINERS: mtd: add Brian Norris for MTD maintenance Ezequiel Garcia (1): MAINTAINERS: mtd: add PXA3xx NAND driver to MAINTAINERS MAINTAINERS | 9 - 1 file

[PATCH 1/2] MAINTAINERS: mtd: add Brian Norris for MTD maintenance

2013-12-04 Thread Brian Norris
While we're at it, change the git URL to remove the version legacy. It's been a symlink to linux-mtd.git for a while now anyway. Signed-off-by: Brian Norris computersforpe...@gmail.com Cc: David Woodhouse dw...@infradead.org Cc: linux-...@lists.infradead.org --- MAINTAINERS | 3 ++- 1 file

[PATCH v2 2/2] MAINTAINERS: mtd: add PXA3xx NAND driver to MAINTAINERS

2013-12-04 Thread Brian Norris
From: Ezequiel Garcia ezequiel.gar...@free-electrons.com Add the pxa3xx-nand driver which supports PXA3xx and Armada 370/XP SoC family to MAINTAINERS to ensure I get proper Cc on patches. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com Signed-off-by: Brian Norris computersforpe

[PATCH] iommu: add missing include

2013-12-04 Thread Brian Norris
Fix a warning in of_iommu.c: drivers/iommu/of_iommu.c:38:5: warning: no previous prototype for 'of_get_dma_window' [-Wmissing-prototypes] Signed-off-by: Brian Norris computersforpe...@gmail.com Cc: Hiroshi DOYU hd...@nvidia.com --- drivers/iommu/of_iommu.c | 1 + 1 file changed, 1 insertion

Re: [PATCH] mtd: nand: MTD_NAND_SH_FLCTL should depend on HAS_DMA

2014-02-21 Thread Brian Norris
Hi Geert, On Fri, Feb 21, 2014 at 09:27:27PM +0100, Laurent Pinchart wrote: On Friday 21 February 2014 20:54:34 Geert Uytterhoeven wrote: If NO_DMA=y: drivers/built-in.o: In function `flctl_dma_fifo0_transfer': sh_flctl.c:(.text+0x210398): undefined reference to `dma_map_single'

Re: [PATCH] MTD: atmel_nand: POI fall back is not an issue: change log level

2014-02-22 Thread Brian Norris
On Wed, Feb 12, 2014 at 12:42:00PM +0100, Alexandre Belloni wrote: Small nitpick, subject should read PIO, not POI. Amended the commit message and pushed to l2-mtd.git. Thanks! Brian -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

[GIT PULL] MTD fixes for 3.14-rc

2014-02-25 Thread Brian Norris
in Linux. The expected layouts are now documented in the commit messages, and we plan to add this under Documentation/mtd/nand/ eventually. Brian Norris (1): mtd: nand: fix off-by-one read retry mode counting Pekon Gupta (3

Re: [PATCH 1/2] jffs2: Fix segmentation fault found in stress test

2014-02-25 Thread Brian Norris
On Mon, Jan 06, 2014 at 07:06:54PM +0530, Kamlakant Patel wrote: Creating a large file on a JFFS2 partition sometimes crashes with this call trace: [...] This crash is caused because the 'positions' is declared as an array of signed short. The value of position is in the range 0..65535, and

Re: What is wrong?

2014-02-27 Thread Brian Norris
+ others Hi Leon, Can you please keep the CC list intact? And please try to reply below the quotes and trim context, rather than top-posting. Thanks! On Thu, Feb 27, 2014 at 02:00:25PM +0200, Leon Pollak wrote: I am VERY(!) thankful to you for the answer. First, I am calm now that there is no

Re: What is wrong?

2014-03-04 Thread Brian Norris
On Mon, Mar 03, 2014 at 03:13:36PM -0600, Andrew Ruder wrote: On Thu, Feb 27, 2014 at 01:22:08PM -0800, Brian Norris wrote: Perhaps Richard or Andrew can comment on whether this patch should help you. But I think JFFS2 on NAND uses write-buffered support which can be affected by this bug

Re: [PATCH v2 RESEND 1/2] mtd: Add a retlen parameter to _get_{fact,user}_prot_info

2014-03-04 Thread Brian Norris
On Tue, Jan 28, 2014 at 09:29:44AM +0100, Christian Riesch wrote: Signed-off-by: Christian Riesch christian.rie...@omicron.at Cc: Artem Bityutskiy artem.bityuts...@linux.intel.com Cc: Brian Norris computersforpe...@gmail.com --- drivers/mtd/chips/cfi_cmdset_0001.c | 31

Re: [PATCH v2 RESEND 2/2] mtd: Fix the behavior of otp write if there is not enough room for data

2014-03-04 Thread Brian Norris
Hi Christian, A few comments below. On Tue, Jan 28, 2014 at 09:29:45AM +0100, Christian Riesch wrote: An OTP write shall write as much data as possible to the OTP memory and return the number of bytes that have actually been written. If no data could be written at all due to lack of OTP

Re: [PATCH v2 RESEND 2/2] mtd: Fix the behavior of otp write if there is not enough room for data

2014-03-04 Thread Brian Norris
A few more things... On Tue, Mar 04, 2014 at 11:20:10PM -0800, Brian Norris wrote: On Tue, Jan 28, 2014 at 09:29:45AM +0100, Christian Riesch wrote: An OTP write shall write as much data as possible to the OTP memory and return the number of bytes that have actually been written

Re: [PATCH] mtd: m25p80: Flash protection support for STmicro chips

2014-03-05 Thread Brian Norris
+ Marek, Angus On Thu, Feb 27, 2014 at 03:34:06PM +0100, Gerlando Falauto wrote: Hi, it's me again. In my opinion (and experience) this introduces a pretty serious bug (not to mention the compatibility issues), yet I haven't heard a single word or found a patch applied about it in three

Re: [PATCH] mtd: m25p80: Flash protection support for STmicro chips

2014-03-05 Thread Brian Norris
Different email for Austin? On Wed, Mar 05, 2014 at 12:10:08AM -0800, Brian Norris wrote: + Marek, Angus On Thu, Feb 27, 2014 at 03:34:06PM +0100, Gerlando Falauto wrote: Hi, it's me again. In my opinion (and experience) this introduces a pretty serious bug (not to mention

Re: [PATCH v2 RESEND 2/2] mtd: Fix the behavior of otp write if there is not enough room for data

2014-03-06 Thread Brian Norris
Hi, On Wed, Mar 05, 2014 at 09:50:35AM +0100, Christian Riesch wrote: On March 04, 2014 23:20 -0800 Brian Norris computersforpe...@gmail.com wrote: On Tue, Jan 28, 2014 at 09:29:45AM +0100, Christian Riesch wrote: An OTP write shall write as much data as possible to the OTP memory

Re: [PATCH 3/4] mtd: block2mtd: check device size

2014-03-06 Thread Brian Norris
Hi, On Wed, Jan 29, 2014 at 08:51:05PM +0800, Fabian Frederick wrote: On Wed, 29 Jan 2014 07:04:25 -0300 Ezequiel Garcia ezequiel.gar...@free-electrons.com wrote: I saw you sent a v2 for one of the patches on this series, but maybe this is worth considering too. On Thu, Jan 23, 2014

Re: [PATCH 1/1] mtd: mtd_blkdevs: handle REQ_FLUSH request and do explicit flush of writeback buffer

2014-03-06 Thread Brian Norris
On Thu, Jan 02, 2014 at 01:21:21AM +0900, Roman Pen wrote: From: Roman Peniaev r.peni...@gmail.com mtd_blkdevs is device with volatile cache (writeback buffer), so it should support REQ_FLUSH to do explicit flush. Without this patch 'sync' does not guarantee that writeback buffer will be

Re: [PATCH v2 linux-next] mtd: block2mtd: check device size

2014-03-08 Thread Brian Norris
On Thu, Mar 6, 2014 at 2:04 AM, Fabian Frederick f...@skynet.be wrote: fixme applied : check device size is a multiple of erasesize. Signed-off-by: Fabian Frederick f...@skynet.be Pushed to l2-mtd.git. Thanks! Brian -- To unsubscribe from this list: send the line unsubscribe linux-kernel in

Re: [PATCH 01/35] mtd: st_spi_fsm: Allocate resources and register with MTD framework

2014-03-08 Thread Brian Norris
Hi Lee, From my very first glance here, it looks like there are several (mostly minor) comments that still aren't addressed in this series. I'll point at the ones I notice in this patch, but can you recheck my comments from v2? I'll still try to take another pass at reading the next 34 patches...

Re: [PATCH] mtd: nand: assign mtd-name in find_full_id_nand

2014-01-11 Thread Brian Norris
Hi, On Thu, Dec 26, 2013 at 10:19:39AM +0800, Huang Shijie wrote: On Thu, Dec 26, 2013 at 01:51:58AM +, Caizhiyong wrote: From: Cai Zhiyong caizhiy...@huawei.com Date: Wed, 25 Dec 2013 21:19:21 +0800 Subject: [PATCH] mtd: nand: assign mtd-name in find_full_id_nand This patch

Re: [PATCH] mtd: nand: assign mtd-name in find_full_id_nand

2014-01-12 Thread Brian Norris
On Mon, Jan 13, 2014 at 04:12:45AM +, Caizhiyong wrote: -Original Message- From: Brian Norris [mailto:computersforpe...@gmail.com] Sent: Sunday, January 12, 2014 4:10 AM On Thu, Dec 26, 2013 at 10:19:39AM +0800, Huang Shijie wrote: On Thu, Dec 26, 2013 at 01:51:58AM +

Re: [PATCH] mtd: nand: fix erronous read_buf call in nand_write_page_raw_syndrome

2014-02-11 Thread Brian Norris
On Sat, Feb 01, 2014 at 07:10:28PM +0100, Boris BREZILLON wrote: read_buf is called in place of write_buf in the nand_write_page_raw_syndrome function. Signed-off-by: Boris BREZILLON b.brezillon@gmail.com Good catch! I guess no one really tests this function. I can understand that, since

Re: [PATCH 0/8] mtd: Remove unnecessary OOM messages

2014-02-11 Thread Brian Norris
On Thu, Feb 06, 2014 at 03:07:19PM +0900, Jingoo Han wrote: The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. For example, k.alloc and v.alloc failures use dump_stack(). Jingoo Han (8): mtd: devices: elm: Remove unnecessary

Re: [PATCH 15/28] Remove TI_AEMIF

2014-02-11 Thread Brian Norris
+ Ivan, others On Sun, Feb 09, 2014 at 09:54:02PM +0100, Paul Bolle wrote: On Sun, 2014-02-09 at 19:47 +0100, Richard Weinberger wrote: The symbol is an orphan, get rid of it. Signed-off-by: Richard Weinberger rich...@nod.at --- drivers/mtd/nand/Kconfig | 2 +- 1 file changed, 1

Re: [PATCH 2/3] jffs2: avoid soft-lockup in jffs2_reserve_space_gc()

2014-02-11 Thread Brian Norris
Hi Andrew, On Tue, Feb 11, 2014 at 3:54 PM, Andrew Morton a...@linux-foundation.org wrote: On Sat, 8 Feb 2014 10:15:39 +0800 Li Zefan lize...@huawei.com wrote: I now have four jffs2 bugfixes but cannot unload them on anyone. Waddup? Well, at best we have 3 maintainers involved in MTD (David,

Re: [PATCH v6 01/35] mtd: st_spi_fsm: Allocate resources and register with MTD framework

2014-03-20 Thread Brian Norris
Hi Lee, I really can't take this patch separately. You'll need to resend the whole series soon. On Tue, Mar 11, 2014 at 08:23:16AM +, Lee Jones wrote: Sorry about the previous fixup misses. There were a couple of patches which I had failed to squash into the pack. Hopefully the rest of the

Re: [PATCH 27/35] mtd: st_spi_fsm: Supply a busy wait for post-write status

2014-03-20 Thread Brian Norris
On Tue, Feb 18, 2014 at 02:55:54PM +, Lee Jones wrote: When we write data to the Serial Flash chip we'll wait a predetermined period of time before giving up. During that period of time we poll the status register until completion. Acked-by Angus Clark angus.cl...@st.com Signed-off-by:

Re: [PATCH 11/35] mtd: st_spi_fsm: Use device size to determine address width

2014-03-20 Thread Brian Norris
On Tue, Feb 18, 2014 at 02:55:38PM +, Lee Jones wrote: Take some known parameters, namely size and number of sectors and use them to determine weather a device can support 32bit addressing or not. If it can, set the associated flash capability flag for latter use. Acked-by Angus Clark

Re: [PATCH 25/35] mtd: st_spi_fsm: Add the ability to read from a Serial Flash device

2014-03-20 Thread Brian Norris
On Tue, Feb 18, 2014 at 02:55:52PM +, Lee Jones wrote: diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c index fe538bb..e4815fe 100644 --- a/drivers/mtd/devices/st_spi_fsm.c +++ b/drivers/mtd/devices/st_spi_fsm.c @@ -942,6 +945,100 @@ static int

Re: [PATCH v5 00/35] mtd: st_spi_fsm: Add new driver

2014-03-20 Thread Brian Norris
On Tue, Feb 18, 2014 at 02:55:27PM +, Lee Jones wrote: This should be the final version. :) I had a few more comments. Contrary to my comment on patch 1, I don't think too many of my comments were repeats. But nothing too big anyway. I expect that I'll merge this as soon as you address my

Re: [PATCH v6 00/36] mtd: st_spi_fsm: Add new driver

2014-03-20 Thread Brian Norris
On Thu, Mar 20, 2014 at 09:20:32AM +, Lee Jones wrote: This should be the final version (again) :) Version 6: Serviced 3 nits picked up by Brian during final review. I'm really sorry to do this again, but can you *please* read *all* of my comments? You're missing at least the following

Re: [PATCH v6 00/36] mtd: st_spi_fsm: Add new driver

2014-03-20 Thread Brian Norris
On Thu, Mar 20, 2014 at 09:20:32AM +, Lee Jones wrote: This should be the final version (again) :) Version 6: Serviced 3 nits picked up by Brian during final review. [...] Documentation/devicetree/bindings/mtd/st-fsm.txt | 26 ++ arch/arm/boot/dts/stih416-pinctrl.dtsi

Re: [PATCH v6 36/36] ARM: STi: Add support for the FSM Serial Flash Controller

2014-03-20 Thread Brian Norris
this fine, but it doesn't seem standard, and it may prevent you from using the partition name in certain ways. For instance, it might make it harder to use with the ubi.mtd= module parameter. But otherwise: Acked-by: Brian Norris computersforpe...@gmail.com + reg

Re: [PATCH 0/5] mtd: st_spi_fsm: Sweep-up remaining blocking-issues

2014-03-20 Thread Brian Norris
On Thu, Mar 20, 2014 at 11:11:42AM +, Lee Jones wrote: Sincerest apologies for missing these before. I hope this now covers all of points you raised. Looks good. Thanks for following up. Pushed all to l2-mtd.git. Thanks, Brian -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 1/5] mtd: st_spi_fsm: Remove useless consts from function arguments

2014-03-20 Thread Brian Norris
On Thu, Mar 20, 2014 at 04:48:10AM -0700, Joe Perches wrote: On Thu, 2014-03-20 at 11:41 +, Lee Jones wrote: On Thu, 20 Mar 2014, Joe Perches wrote: On Thu, 2014-03-20 at 11:11 +, Lee Jones wrote: Reported-by: Brian Norris computersforpe...@gmail.com Signed-off-by: Lee Jones

Re: [PATCH 1/5] mtd: st_spi_fsm: Remove useless consts from function arguments

2014-03-20 Thread Brian Norris
On Thu, Mar 20, 2014 at 5:03 AM, Lee Jones lee.jo...@linaro.org wrote: Signed-off-by: Brian Norris computersforpe...@gmail.com Patch looks good to me: Acked-by: Lee Jones lee.jo...@linaro.org Squashed into $SUBJECT patch and pushed to l2-mtd.git. Brian -- To unsubscribe from this list

Re: [PATCH 1/5] mtd: st_spi_fsm: Remove useless consts from function arguments

2014-03-20 Thread Brian Norris
On Thu, Mar 20, 2014 at 5:13 AM, Joe Perches j...@perches.com wrote: On Thu, 2014-03-20 at 12:03 +, Lee Jones wrote: Good catch. That wasn't my intention. Why? An oversight. That's still not an explanation. Why, unless cast away by the code itself, is const removal a good thing?

Re: [PATCH 1/5] mtd: st_spi_fsm: Remove useless consts from function arguments

2014-03-20 Thread Brian Norris
On Thu, Mar 20, 2014 at 05:44:45AM -0700, Joe Perches wrote: On Thu, 2014-03-20 at 05:41 -0700, Brian Norris wrote: I also don't think that a function parameter is the right place to mark const like this. Function arguments are always pass-by-value, so this 'const' tells users (callers

Re: [PATCH 2/3] mtd: davinci-nand: add dts property for NAND_NO_SUBPAGE_WRITE option

2014-03-20 Thread Brian Norris
On Thu, Mar 20, 2014 at 01:12:35PM -0400, Santosh Shilimkar wrote: Boris, Who's Boris? And why should Boris be taking this patch? It's an MTD patch. On Thursday 20 March 2014 01:06 PM, Ivan Khoronzhuk wrote: From: Murali Karicheri m-kariche...@ti.com After testing NAND flash with ubifs

Re: [PATCH 2/3] mtd: davinci-nand: add dts property for NAND_NO_SUBPAGE_WRITE option

2014-03-20 Thread Brian Norris
On Thu, Mar 20, 2014 at 01:37:42PM -0400, Santosh Shilimkar wrote: On Thursday 20 March 2014 01:29 PM, Brian Norris wrote: On Thu, Mar 20, 2014 at 01:12:35PM -0400, Santosh Shilimkar wrote: Boris, Who's Boris? And why should Boris be taking this patch? It's an MTD patch. I got your

Re: [PATCH 2/3] mtd: davinci-nand: add dts property for NAND_NO_SUBPAGE_WRITE option

2014-03-20 Thread Brian Norris
On Thu, Mar 20, 2014 at 02:02:39PM -0400, Santosh Shilimkar wrote: On Thursday 20 March 2014 01:44 PM, Warner Losh wrote: I though sub page writing was one of the fields in the onfi and/or jedec(toggle) meta data structures. Have you looked there? Am not sure if I follow you. The

  1   2   3   4   5   6   7   8   9   10   >