with all the warnings. Or alternatively
if you just want to check one file then the command is:
~/progs/smatch/devel/smatch_scripts/kchecker drivers/file.c
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
On Thu, Nov 01, 2012 at 11:42:59PM -0700, Kumar Amit Mehta wrote:
fix for macro coding style.
No. The parenthesis are not needed. I assume this is a
checkpatch.pl warning?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
On Fri, Nov 02, 2012 at 12:36:30AM -0700, Kumar amit mehta wrote:
On Fri, Nov 02, 2012 at 09:55:55AM +0300, Dan Carpenter wrote:
On Thu, Nov 01, 2012 at 11:42:59PM -0700, Kumar Amit Mehta wrote:
fix for macro coding style.
No. The parenthesis are not needed. I assume
Hi,
I have created a bug for this:
https://bugzilla.kernel.org/show_bug.cgi?id=47871
Please add the following information:
*) Last known good kernel version
*) Current broken kernel version
*) Complete dmesg
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe
=47881
Is it fixed now?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
report and attach
the .jpg.
regards,
dan carpenter
On Fri, Sep 07, 2012 at 09:24:13PM +1000, yvahk-xre...@zacglen.net wrote:
I am getting either a a kernel Oops or freeze (without any console output)
on recent kernels. I have tested on 2.6.32.26 PAE, 3.1.9 PAE, and 3.4.9 PAE
all with similar
serial card.
There is not enough information here for us to help you. Sorry.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
loading in iwlwifi driver. Not sure if it can use SG.
drivers/net/wireless/iwlwifi/iwl-drv.c
iwl_alloc_ucode() - iwl_alloc_fw_desc() - dma_alloc_coherent()
I'm filing bugzilla entries for regressions. What's the status on
this?
regards,
dan carpenter
--
To unsubscribe from this list
Hi,
I have created a bug for this:
https://bugzilla.kernel.org/show_bug.cgi?id=47901
Please add the following information:
*) Last known good kernel version
*) Current broken kernel version
*) Complete dmesg
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe
kernel?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
better to leave
the warnings in for now.
checkpatch.pl is not the king of us.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
);
^
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
checkpatch
doesn't find it. Don't do that.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
]
[patch 4/4]
[patch 5/5]...
Write your patches. Wait over night. Review it the next morning.
Email it.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
We only need to allocate mapping if there is an rproc domain.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Static checker stuff. Handle with appropriate caution.
diff --git a/drivers/remoteproc/remoteproc_core.c
b/drivers/remoteproc/remoteproc_core.c
index b6c6229..f163704 100644
printed.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/remoteproc/remoteproc_debugfs.c
b/drivers/remoteproc/remoteproc_debugfs.c
index 10a3825..ea90a56 100644
--- a/drivers/remoteproc/remoteproc_debugfs.c
+++ b/drivers/remoteproc/remoteproc_debugfs.c
@@ -82,7 +82,7
copy_from_user() returns the number of bytes remaining to be copied, but
we want to return an error code here.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/remoteproc/remoteproc_debugfs.c
b/drivers/remoteproc/remoteproc_debugfs.c
index ea90a56..157a573 100644
Added Tejun to the CC list.
regards,
dan carpenter
On Fri, Sep 14, 2012 at 02:07:24AM +, Jongman Heo wrote:
Hi Guys,
I hit this warning with current linus + for-next branch of wq.git, running
Fedora 17 on VMWare linux guest.
[89449.738642] [ cut here
Did any of the old kernels work? Have you ruled out bad hardware?
If the answers to both questions are yes then it makes your email
harder to ignore. In which case, we'd probably want the complete
dmesg.
The USB mailing list is linux-...@vger.kernel.org.
regards,
dan carpenter
Hi,
I have created a bug for this:
https://bugzilla.kernel.org/show_bug.cgi?id=47931
Please add the following information:
*) Last known good kernel version
*) Complete dmesg
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
the following information:
*) Complete dmesg
*) lsmod, working and non-working
*) .config
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
the dprintk macros instead of prettifying
them.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org
).
Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru
Looks good.
Reviewed-by: Dan Carpenter dan.carpen...@oracle.com
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
/thermal_sys.c:396 update_temperature() warn: inconsistent
returns mutex:tz-lock: locked (390) unlocked (396)
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
);
+
+ WLAN_REASSOCREQ_OFF_LISTEN_INT);
Really??? I'm not a huge fan of the 80 character line limit, but at
least the left side of the line should be within the 80 characters.
Yeah. This patch is going nowhere.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
This is fixed now?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Wed, Sep 26, 2012 at 02:39:22PM +, R, Durgadoss wrote:
Hi,
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Wednesday, September 26, 2012 1:58 AM
To: R, Durgadoss
Cc: Zhang, Rui; linux-kernel@vger.kernel.org
Subject: re: Thermal: Update
a little comment here under the --- line
about what changed between v1 and v2?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
number and compare against 63 and take the minimum...
It's root only so it's not a problem but it's a hassle to audit.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
the original
potential issue? If so, what tool was it?
But wasn't the scripted fix applied to the rest of the tree
robotically?
It was coccinelle. It just prints a warning. You have to go in
manually, review the code and pick the correct error code.
regards,
dan carpenter
--
To unsubscribe
a cpu_to_be32() or cpu_to_le32().
2470 fis-device = 1 6;
2471 fis-features= nsect 0xFF;
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Mon, Nov 05, 2012 at 09:34:21PM +0900, anish kumar wrote:
Hello Dan,
Is this patch of yours picked up by anyone?
David this should go through you?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
to be included twice
It's small enough that I don't have strong feelings about it, but
in general that's how you should do it.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Fri, Oct 12, 2012 at 11:01:08PM +0200, Linus Walleij wrote:
On Thu, Oct 11, 2012 at 8:56 AM, Dan Carpenter dan.carpen...@oracle.com
wrote:
-last_ier is an unsigned long but the high bits can't be used int the
original code because the shift wraps.
Signed-off-by: Dan Carpenter
if it won't be fixed.
That's sort of the point of staging.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
I changed the strict_strtoul() to kstrtouint(). That has the check
for UINT_MAX built in to it so the ifdefs can be removed. Also
I changed a printk() to pr_info().
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/clocksource/acpi_pm.c b/drivers/clocksource/acpi_pm.c
-vm_next;
950 if (!vma)
951 goto again;
952 }
953
954 offset = max(offset, vma-vm_start);
^
then it leads to a NULL dereference here.
regards,
dan carpenter
and it is broken now. Is my assumption that
orderly_poweroff() could be invoked from the interrupt context a wrong
assumption?
You can't call orderly_poweroff() from interrupt context.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
On Tue, Oct 23, 2012 at 02:24:58PM +, KY Srinivasan wrote:
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Tuesday, October 23, 2012 1:47 AM
To: KY Srinivasan
Cc: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org;
de
We need to check for negative values before doing the swab16() for the
error handling to work.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/power/ds2782_battery.c b/drivers/power/ds2782_battery.c
index 6bb6e2f..2fa9b6b 100644
--- a/drivers/power/ds2782_battery.c
We fixed a bunch of integer overflows in timekeeping code during the 3.6
cycle. I did an audit based on that and found this potential overflow.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
I'm not super familiar with this code so please review my work
carefully.
diff --git a/kernel
the
maintaier's original code.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Fixed in:
commit fdd514e16bb2531c0c61ae8a1f87740ce217f630
Author: Tejun Heo t...@kernel.org
Date: Thu Jun 9 20:43:59 2011 +0200
block: make disk_block_events() properly wait for work cancellation
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux
Add netdev to the CC list.
regards,
dan carpenter
On Fri, Sep 21, 2012 at 10:27:04PM +0400, Alexey Vlasov wrote:
Hi.
Here it writes LOG module (netfilter) in syslog:
Sep 21 22:24:04 l24 kernel: ipsec:SYN-OUTPUT-HTTP IN= OUT=eth0
SRC= DST= LEN=60 TOS
On Tue, Oct 09, 2012 at 02:50:10PM +0200, Eric Dumazet wrote:
On Tue, 2012-10-09 at 15:36 +0300, Dan Carpenter wrote:
Add netdev to the CC list.
netdev already in the CC list by Borislav Petkov
Sorry. He sent the email twice in two threads and I was still
looking at the first report
there is a good reason why then we shouldn't put arbitrary
limits like that. If we leave it in people at least run static
analyzers on it and try modprobing it.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
On Tue, Oct 09, 2012 at 04:15:15PM +0200, Ohad Ben-Cohen wrote:
On Tue, Oct 9, 2012 at 3:28 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
Unless there is a good reason why
That's what I'm asking. Is there an inherent coupling with some
platform/architecture ? E.g., OMAP remote
-last_ier is an unsigned long but the high bits can't be used int the
original code because the shift wraps.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/gpio/gpio-timberdale.c b/drivers/gpio/gpio-timberdale.c
index 031c6ad..1a3e2b9 100644
--- a/drivers/gpio/gpio
We added a new return but forgot to drop the lock first.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Bug introduced in e353546e [SCSI] bfa: Add diagnostic port (D-Port)
support.
diff --git a/drivers/scsi/bfa/bfad_bsg.c b/drivers/scsi/bfa/bfad_bsg.c
index 555e7db..91465b2 100644
Smatch complains that we are writing more data than -srlid_base
member can hold. In fact, we are over writing the whole struct. I've
re-written it to be a bit more clear and to silence the static checker
warning.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/scsi
thread_mask is an unsigned long. It's better to use 1UL here so we
can take advantage of the high bits as well.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 4c69326..cfe1283 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq
On Wed, Oct 24, 2012 at 03:08:07PM -0700, Andrew Morton wrote:
On Wed, 24 Oct 2012 14:26:13 -0400
Ed Cashin ecas...@coraid.com wrote:
After calling dev_queue_xmit it is no longer safe to access the
members of the skb.
Reported-by: Dan Carpenter dan.carpen...@oracle.com
hm
We need to unlock here before returning.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Only needed in linux-next.
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index d5f9742..14251c3 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -728,7 +728,8
copy_from_user() returns the number of bytes remaining but we should be
returning -EFAULT here.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Only needed in linux-next.
diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c
index ed4943f..ce1014e 100644
--- a/drivers/misc/mei
copy_to_user() returns the number of bytes remaining to be copied.
put_user() returns -EFAULT on error.
This function ORs a bunch of stuff together and returns jumbled non-zero
values on error. It should return -EFAULT.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers
I don't think this works as intended. '|' higher precedence than ?: so
the bitwize OR 0 | (val STR_MOST) is a no-op.
I have re-written it to be more clear.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
I don't have a way to test this.
diff --git a/sound/pci/es1968.c b/sound/pci
On Tue, Nov 13, 2012 at 12:03:10AM -0800, Joe Perches wrote:
On Tue, 2012-11-13 at 10:44 +0300, Dan Carpenter wrote:
I don't think this works as intended. '|' higher precedence than ?: so
the bitwize OR 0 | (val STR_MOST) is a no-op.
I have re-written it to be more clear.
[]
diff
received: %d\n,
+ dev_dbg(urb-dev-dev,
+ %s - nonzero write bulk status received: %d\n,
__func__, urb-status);
Don't mix in these unrelated 80 character limit changes.
regards,
dan carpenter
--
To unsubscribe from this list: send the line
is 35 characters long. It
isn't even clear from the name what it holds. It's just a very crap
name.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
.message_length,
+ (int)sizeof(pod-prog_data) +
+ 7);
Better to get rid of the cast. You're already over the 80 character
limit so putting the 7); on the line before is ok.
regards,
dan carpenter
);
+ spin_unlock_irqrestore(vmbus_connection.channelmsg_lock, flags);
+
+error0:
It's better to give the labels meaningful names like error_del and
error_pages instead of GW-BASIC numbers.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
with
and without. I can't imagine how it would make a measurable
difference here.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
When you're writing the subject you don't need to add the Drivers:
bit. That is understood.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
;
+int uf_verify_m4 (unifi_priv_t *priv, const unsigned char *packet,
+ unsigned int length) {
The original was correct. The new code is wrong.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
in the original code almost but now
they are done in a random way. Why???
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
; /* kHz */
These are nonsense indenting. :(
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
is wrong.
I'm not reviewing any more of this patchset. Sorry. Please redo
everything.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
should be working against linux-next.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org
We recently changed how the locking worked here, but this error path was
missed.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 8c84070..2728fb7 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -3031,8 +3031,10 @@ static ssize_t
if (rt_mutex_owner(pi_mutex) == current)
This will oops if pi_mutex is NULL.
2374 rt_mutex_unlock(pi_mutex);
2375 } else if (ret == -EINTR) {
regards,
dan carpenter
--
To unsubscribe from this list: send the line
On Wed, Jul 18, 2012 at 08:41:38AM -0700, Darren Hart wrote:
On 07/18/2012 08:31 AM, Dave Jones wrote:
On Wed, Jul 18, 2012 at 05:25:14PM +0300, Dan Carpenter wrote:
Hi Darren,
The patch 52400ba94675: futex: add requeue_pi functionality from
Apr 3, 2009, leads
files. The
vme change is separate because it's in a different module.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
The ctx variable can never be NULL here and also we dereference it
on the previous line.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c
index 7389d2d..4db19f7 100644
--- a/fs/ntfs/file.c
+++ b/fs/ntfs/file.c
@@ -309,8 +309,7
, having the result
of
it completely unknown.
This result in having the probe return 0, unloading the driver may (not) cause
ambigous result.
These bugs were there before your patch, but we should also be doing
an unregister_hdlc_device() and a free_netdev().
regards,
dan carpenter
here. What about if only cxt-fprz is non-NULL?
Also these are crap variable names, przs and cprz look so similar.
It makes my head hurt to keep them appart.
424 cxt-pstore.buf = kmalloc(cxt-pstore.bufsize, GFP_KERNEL);
425 spin_lock_init(cxt-pstore.buf_lock);
regards,
dan
is not the first member of the pci_dev struct then
to_pci_dev() never returns NULL. If you give it a NULL pointer it
returns a bogus pointer back.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
My bug was fixed in March. There was an email thread about it when
the merge window opened but I can't find it...
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Thu, Jul 19, 2012 at 04:20:32PM -0700, Anton Vorontsov wrote:
Hi Dan,
On Thu, Jul 19, 2012 at 05:28:56PM +0300, Dan Carpenter wrote:
The patch a694d1b5916a: pstore/ram: Add ftrace messages handling
from Jul 9, 2012, leads to the following Smatch complaint:
A nice tool. The homepage
What prompted this patch is that in dma_pool_create() we call
dev_to_node() before checking whether dev is NULL. It looks like
there are places which call dma_pool_create() with a NULL pointer. An
example is in drivers/usb/gadget/amd5536udc.c.
Signed-off-by: Dan Carpenter dan.carpen
We sometimes pass NULL pointers to free_tty_struct(). One example where
it can happen is in the error handling code in pty_common_install().
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index ca7c25d..e49b839 100644
--- a/drivers
On Fri, Jul 20, 2012 at 04:24:25PM +0800, Michael Wang wrote:
On 07/20/2012 02:41 PM, Dan Carpenter wrote:
My bug was fixed in March. There was an email thread about it when
the merge window opened but I can't find it...
Hi, Dan
Thanks for your reply.
Currently this issue won't appear
Smatch complains that on 64 bit systems, there is a hole in the
MW_ABILITIES struct between -component_count and -component_list[].
It leaks stack information from the mwave_ioctl() function.
I've added a memset() to initialize the struct to zero.
Signed-off-by: Dan Carpenter dan.carpen
returns positive numbers.
There isn't a place which check LMK_BUSY so maybe it's best to just
return zero?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
be a #define in shrinker.h instead of in
drivers/staging/android/.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
ret += nr_before - shrink_ret;
293 count_vm_events(SLABS_SCANNED, batch_size);
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
duplication in si476x_radio_read_rsq_blob and
si476x_radio_read_rsq_primary_blob.
* Add some BUG_ON statements for function pointers that should never be NULL
Signed-off-by: Andrey Smirnov andrew.smir...@gmail.com
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
This should be a Reported
On Fri, Apr 19, 2013 at 09:52:42PM +0800, rogera...@realtek.com wrote:
From: Roger Tseng rogera...@realtek.com
Adding support of model RTL8411B. Since the model is similar to RTL8411,
differences are implemented in rtl8411.c.
What tree is this against?
regards,
dan carpenter
The info.fill array isn't initialized so it can leak uninitialized
stack information to user space.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/misc/sgi-gru/grufile.c b/drivers/misc/sgi-gru/grufile.c
index 44d273c..ed5fc43 100644
--- a/drivers/misc/sgi-gru
The info.fill array isn't initialized so it can leak uninitialized
stack information to user space.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
v2: style changes
diff --git a/drivers/misc/sgi-gru/grufile.c b/drivers/misc/sgi-gru/grufile.c
index 44d273c..0535d1e 100644
--- a/drivers
automatically.
After that you will be an official kernel maintainer with all the
honor and dignity that goes along with it. :)
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
There were a couple signedness bugs decrementing i which would lead to
a forever loops.
I've made a couple other variables signed as well because they are all
related array offsets and it would be weird if they weren't the same
type.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff
://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
(tty-linus branch).
Good deal.
Btw, by the time that Fenguang's kbuild scripts emailed you, it was
already too late to send a v2 patch.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
We unlock here when we failed to take the lock.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
This is in linux-next, and I think the debugfs code is only in Sumit's
tree.
diff --git a/drivers/base/dma-buf.c b/drivers/base/dma-buf.c
index 466476f..174cd2c 100644
--- a/drivers/base/dma
Oops... I mailed that prematurely. There isn't a [patch 2/2].
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
with basic testing so they are rare.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Fri, Apr 12, 2013 at 08:43:05AM +0530, Sumit Semwal wrote:
Hi Dan,
On Apr 11, 2013 11:54 AM, Dan Carpenter dan.carpen...@oracle.com wrote:
We unlock here when we failed to take the lock.
Thanks for catching this; I will add it to the for-next queue.
Could I merge this change
On 64 bit systems the agp_info struct has a hole between -agp_mode and
-aper_base. We need to clear it to avoid leaking stack information to
userspace.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/char/agp/frontend.c b/drivers/char/agp/frontend.c
index 2e04433
it as several
patches.
[patch 1/3] Staging: rtl8192u: r8192U_dm.h: use c99 comments
[patch 2/3] Staging: rtl8192u: r8192U_dm.h: use proper white space
[patch 3/3] Staging: rtl8192u: r8192U_dm.h: reposition the braces
regards,
dan carpenter
--
To unsubscribe from this list: send the line
usbduxsub_submit_inurbs(struct usbduxsub *usbduxsub)
{
- int i, errFlag;
+ int i, err_flag;
This is really just a regular error code, not a flag. But that was
there in the original so no worries.
Looks good.
Reviewed-by: Dan Carpenter dan.carpen...@oracle.com
regards,
dan carpenter
1 - 100 of 9290 matches
Mail list logo
