Re: Hang in XFS reclaim on 3.7.0-rc3

2012-10-29 Thread Dave Chinner
? This is the fourth time in the last month or so that I've seen XFS bug reports with silent hangs and associated lockdep output that implicate GFP_KERNEL allocations from vm_map_ram in GFP_NOFS conditions as the potential cause Cheers, Dave. -- Dave Chinner da...@fromorbit.com xfs: don't

Re: Hang in XFS reclaim on 3.7.0-rc3

2012-10-29 Thread Dave Chinner
[add the linux-mm cc I forgot to add before sending] On Tue, Oct 30, 2012 at 09:26:13AM +1100, Dave Chinner wrote: On Mon, Oct 29, 2012 at 09:03:15PM +0100, Torsten Kaiser wrote: After experiencing a hang of all IO yesterday ( http://marc.info/?l=linux-kernelm=135142236520624w=2 ), I turned

Re: [PATCH 2/3] ext4: introduce ext4_error_remove_page

2012-10-30 Thread Dave Chinner
be using xattrs because then the application has complete control of what is stored without caring about what filesystem it is storing it on. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: Hang in XFS reclaim on 3.7.0-rc3

2012-11-01 Thread Dave Chinner
On Thu, Nov 01, 2012 at 04:30:10PM -0500, Ben Myers wrote: Hi Dave, On Tue, Oct 30, 2012 at 09:26:13AM +1100, Dave Chinner wrote: On Mon, Oct 29, 2012 at 09:03:15PM +0100, Torsten Kaiser wrote: After experiencing a hang of all IO yesterday ( http://marc.info/?l=linux-kernelm

Re: [RFC v4 Patch 0/4] fs/inode.c: optimization for inode lock usage

2012-09-23 Thread Dave Chinner
On Mon, Sep 24, 2012 at 10:42:21AM +0800, Guo Chao wrote: On Sat, Sep 22, 2012 at 08:49:12AM +1000, Dave Chinner wrote: On Fri, Sep 21, 2012 at 05:31:02PM +0800, Guo Chao wrote: This patchset optimizes several places which take the per inode spin lock. They have not been fully tested

Re: [RFC v4 Patch 0/4] fs/inode.c: optimization for inode lock usage

2012-09-24 Thread Dave Chinner
On Mon, Sep 24, 2012 at 02:12:05PM +0800, Guo Chao wrote: On Mon, Sep 24, 2012 at 02:23:43PM +1000, Dave Chinner wrote: On Mon, Sep 24, 2012 at 10:42:21AM +0800, Guo Chao wrote: On Sat, Sep 22, 2012 at 08:49:12AM +1000, Dave Chinner wrote: On Fri, Sep 21, 2012 at 05:31:02PM +0800

Re: [RFC v4 Patch 0/4] fs/inode.c: optimization for inode lock usage

2012-09-24 Thread Dave Chinner
On Mon, Sep 24, 2012 at 03:08:52PM +0800, Guo Chao wrote: On Mon, Sep 24, 2012 at 04:28:12PM +1000, Dave Chinner wrote: Ah, this is intended to be a code clean patchset actually. I thought these locks are redundant in an obvious and trivial manner. If, on the contrary

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-24 Thread Dave Chinner
because the generic writeback code is extremely important to performance and the impact of a change cannot be evaluated from a single test. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [RFC v2 01/10] vfs: introduce private rb structures

2012-09-25 Thread Dave Chinner
that keeps track of fs-wide hot data */ + struct hot_inode_tree hot_inode_tree; +}; The comment is redundant... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [RFC v2 02/10] vfs: add support for updating access frequency

2012-09-25 Thread Dave Chinner
/hot_tracking.h, so you shouldn't need these forward declarations... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [RFC v2 03/10] vfs: add one new mount option '-o hottrack'

2012-09-25 Thread Dave Chinner
or not. This then means the hot inode tracking for the superblock can be initialised by the filesystem as part of it's fill_super method, along with the filesystem specific code that will use the hot tracking information the VFS gathers Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from

Re: [RFC v4 Patch 0/4] fs/inode.c: optimization for inode lock usage

2012-09-25 Thread Dave Chinner
On Tue, Sep 25, 2012 at 04:59:55PM +0800, Guo Chao wrote: On Mon, Sep 24, 2012 at 06:26:54PM +1000, Dave Chinner wrote: @@ -783,14 +783,19 @@ static void __wait_on_freeing_inode(struct inode *inode); static struct inode *find_inode(struct super_block *sb

Re: [RFC v2 03/10] vfs: add one new mount option '-o hottrack'

2012-09-26 Thread Dave Chinner
On Wed, Sep 26, 2012 at 10:56:08AM +0800, Zhi Yong Wu wrote: On Tue, Sep 25, 2012 at 5:28 PM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:28PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Introduce one new mount option '-o

Re: [RFC v2 02/10] vfs: add support for updating access frequency

2012-09-26 Thread Dave Chinner
On Wed, Sep 26, 2012 at 10:53:07AM +0800, Zhi Yong Wu wrote: On Tue, Sep 25, 2012 at 5:17 PM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:27PM +0800, zwu.ker...@gmail.com wrote: I note that the code will always insert range items of a length RANGE_SIZE. This means

Re: [RFC v2 04/10] vfs: add init and exit support

2012-09-26 Thread Dave Chinner
); And call this in .fill_super() after parsing the hottrack argument. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [RFC v2 05/10] vfs: introduce one hash table

2012-09-26 Thread Dave Chinner
. HEAT_MAP_SIZE, not HASH_SIZE. As it is, there aren't any users of the heat maps that are generated in this patch set - it's not even exported to userspace or to debugfs, so I'm not sure how it will be used yet. How are these heat maps going to be used by filesystems, Zhi? Cheers, Dave. -- Dave Chinner da

Re: [RFC v2 06/10] vfs: enable hot data tracking

2012-09-26 Thread Dave Chinner
writes or fsync-triggered writes, are are far more likely to be to hot ranges in a file... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [RFC v2 07/10] vfs: fork one kthread to update data temperature

2012-09-26 Thread Dave Chinner
comments earlier in the series, there's not a lot of point in me spending time commenting on ethe code in detail here as it will change significantly as a result of all the earlier comments Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line

Re: [RFC v2 05/10] vfs: introduce one hash table

2012-09-27 Thread Dave Chinner
On Thu, Sep 27, 2012 at 02:23:16PM +0800, Zhi Yong Wu wrote: On Thu, Sep 27, 2012 at 11:43 AM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:30PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Adds a hash table structure which

Re: [RFC v2 06/10] vfs: enable hot data tracking

2012-09-27 Thread Dave Chinner
On Thu, Sep 27, 2012 at 02:28:12PM +0800, Zhi Yong Wu wrote: On Thu, Sep 27, 2012 at 11:54 AM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:31PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Miscellaneous features that implement

Re: [RFC v2 07/10] vfs: fork one kthread to update data temperature

2012-09-27 Thread Dave Chinner
On Thu, Sep 27, 2012 at 02:54:22PM +0800, Zhi Yong Wu wrote: On Thu, Sep 27, 2012 at 12:03 PM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:32PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Fork and run one kernel kthread

Re: [RFC v2 03/10] vfs: add one new mount option '-o hottrack'

2012-09-27 Thread Dave Chinner
On Thu, Sep 27, 2012 at 01:25:34PM +0800, Zhi Yong Wu wrote: On Tue, Sep 25, 2012 at 5:28 PM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:28PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Introduce one new mount option '-o

[PATCH] loop: Make explicit loop device destruction lazy

2012-09-28 Thread Dave Chinner
From: Dave Chinner dchin...@redhat.com xfstests has always had random failures of tests due to loop devices failing to be torn down and hence leaving filesytems that cannot be unmounted. This causes test runs to immediately stop. Over the past 6 or 7 years we've added hacks like explicit unmount

Re: [RFC, PATCH] Extensible AIO interface

2012-10-03 Thread Dave Chinner
On Tue, Oct 02, 2012 at 07:41:10PM -0700, Kent Overstreet wrote: On Wed, Oct 03, 2012 at 11:28:25AM +1000, Dave Chinner wrote: On Tue, Oct 02, 2012 at 05:20:29PM -0700, Kent Overstreet wrote: On Tue, Oct 02, 2012 at 01:41:17PM -0400, Jeff Moyer wrote: Kent Overstreet koverstr

Re: VFS hot tracking: How to calculate data temperature?

2012-11-05 Thread Dave Chinner
to expand the functionality further... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: Problem with DISCARD and RAID5

2012-11-05 Thread Dave Chinner
of sequential unaligned requests, the device may ignore them all. Hence you end up with nothing being discarded, even though the entire range being discarded is much, much larger than the discard granularity Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line

Re: [PATCH] xfs: add hot tracking support.

2012-11-07 Thread Dave Chinner
version when I get to fixing it. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-10-21 Thread Dave Chinner
even if they show no change. It wasn't until I got this far that I even realised that you'd even tested BTRFS. I don't know what to make of this, because I don't know what the throughput rates compared to XFS and EXT4 are Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from

Re: [PATCH v3 00/22] loop: Issue O_DIRECT aio using bio_vec

2012-10-22 Thread Dave Chinner
loop into a light weight layer that translates bios into iocbs. I note that there is no support for XFS in this patch set. Is there a particular problem that prevents XFS from being converted, or it just hasn't been done? Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from

Re: [PATCH v3 00/22] loop: Issue O_DIRECT aio using bio_vec

2012-10-22 Thread Dave Chinner
On Mon, Oct 22, 2012 at 07:53:40PM -0500, Dave Kleikamp wrote: On 10/22/2012 07:07 PM, Dave Chinner wrote: On Mon, Oct 22, 2012 at 10:15:00AM -0500, Dave Kleikamp wrote: This is the current version of the patchset I presented at the LSF-MM Summit in San Francisco in April. I apologize

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-23 Thread Dave Chinner
need to explain why you need to change the default block device readahead on the fly, and why fadvise(POSIX_FADV_NORMAL) is inappropriate to set readahead windows to the new defaults. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 11/16] f2fs: add inode operations for special inodes

2012-10-23 Thread Dave Chinner
of them can still be followed by direct tail data and extended attributes. I'm not sure that the resultant code complexity is worth saving an extra block here and there. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH 1/2] brw_mutex: big read-write mutex

2012-10-23 Thread Dave Chinner
performance degradation because of it is measurable. This doesn't sound like a new problem. Hasn't this global access, single modifier exclusion problem been solved before in the VFS? e.g. mnt_want_write()/mnt_make_readonly() Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from

Re: [PATCH 00/16] f2fs: introduce flash-friendly file system

2012-10-09 Thread Dave Chinner
types of flash, then either add your timing attack derived information on specific hardware to the above table, or force vendors to update it themselves if they want their flash memory supported by this filesystem. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from

Re: [PATCH] mm: Fix XFS oops due to dirty pages without buffers on s390

2012-10-10 Thread Dave Chinner
this is probably just an oversight in the distro QA environment more than anything Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread Dave Chinner
On Wed, Oct 24, 2012 at 07:53:59AM +0800, YingHang Zhu wrote: Hi Dave, On Wed, Oct 24, 2012 at 6:47 AM, Dave Chinner da...@fromorbit.com wrote: On Tue, Oct 23, 2012 at 08:46:51PM +0800, Ying Zhu wrote: Hi, Recently we ran into the bug that an opened file's ra_pages does not synchronize

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-24 Thread Dave Chinner
On Thu, Oct 25, 2012 at 08:17:05AM +0800, YingHang Zhu wrote: On Thu, Oct 25, 2012 at 4:19 AM, Dave Chinner da...@fromorbit.com wrote: On Wed, Oct 24, 2012 at 07:53:59AM +0800, YingHang Zhu wrote: Hi Dave, On Wed, Oct 24, 2012 at 6:47 AM, Dave Chinner da...@fromorbit.com wrote: On Tue

Re: [PATCH 1/2] brw_mutex: big read-write mutex

2012-10-25 Thread Dave Chinner
On Thu, Oct 25, 2012 at 10:09:31AM -0400, Mikulas Patocka wrote: On Wed, 24 Oct 2012, Dave Chinner wrote: On Fri, Oct 19, 2012 at 06:54:41PM -0400, Mikulas Patocka wrote: On Fri, 19 Oct 2012, Peter Zijlstra wrote: Yes, I tried this approach - it involves doing LOCK

Re: [PATCH] mm: readahead: remove redundant ra_pages in file_ra_state

2012-10-25 Thread Dave Chinner
, telling the kernel that you are now going to do sequential IO should reset the readahead to the maximum ra_pages value supported Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 2/3] ext4: introduce ext4_error_remove_page

2012-10-28 Thread Dave Chinner
corrupted errors, we should add EFSCORRUPTED (i.e. filesystem corrupted) at the same time Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [RFC v4 03/15] vfs,hot_track: add the function for collecting I/O frequency

2012-10-28 Thread Dave Chinner
is wrong whatever way you look at it. ;) Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: xfs: Use bool type rather than a custom boolean_t type.

2012-11-12 Thread Dave Chinner
of places, so just remove it completely. Also, can you please place patches in line rather than attaching them. Attaching them means they cannot be quoted in reply. See Documentation/SubmittingPatches and Documentation/email-clients.txt for guidelines. Cheers, Dave. -- Dave Chinner da...@fromorbit.com

Re: xfs: Remove boolean_t typedef completely.

2012-11-12 Thread Dave Chinner
On Mon, Nov 12, 2012 at 10:36:47PM -0200, Thiago Farina wrote: On Mon, Nov 12, 2012 at 10:24 PM, Dave Chinner da...@fromorbit.com wrote: On Mon, Nov 12, 2012 at 09:36:17PM -0200, Thiago Farina wrote: Hi, Please, take a look. Patch attached. It's a good start for a cleanup

Re: Local DoS through write heavy I/O on CFQ Deadline

2012-10-14 Thread Dave Chinner
. So what you are seeing is likely an ext4 problem, not an IO scheduler problem. Suggestion: try the same test with XFS. If the problem still exists, then it *might* be an ioscheduler problem. If it goes away, then it's an ext4 problem. Cheers, Dave. -- Dave Chinner da...@fromorbit.com

Re: [RFC v3 11/13] vfs: add 3 new ioctl interfaces

2012-10-15 Thread Dave Chinner
; + char filename[PATH_MAX]; Don't put the filename in the ioctl and open the file in the kernel. Have userspace open the file directly and issue the ioctl on the fd that is returned. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line

Re: [RFC v3 12/13] vfs: add debugfs support

2012-10-15 Thread Dave Chinner
what files users are accessing from this information. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC v3 12/13] vfs: add debugfs support

2012-10-15 Thread Dave Chinner
/seq_operations constructs? Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-15 Thread Dave Chinner
update that slabtop got, so it is indicative of the impending OOM situation that occurred. Changelog from v2: 1.) Converted to Radix trees, not RB-tree [Zhiyong, Dave Chinner] 2.) Added memory shrinker [Dave Chinner] I haven't looked at the shrinker, but clearly it is not working, otherwise

Re: [PATCH 11/16] f2fs: add inode operations for special inodes

2012-10-15 Thread Dave Chinner
of that information how they please (whether in the kernel or via userspace tools), but having filesystem specific interfaces and implementations of the same functionality is extremely wasteful. Let's do it once, and do it right the first time. ;) Cheers, Dave. -- Dave Chinner da...@fromorbit.com

Re: Write is not atomic?

2012-10-15 Thread Dave Chinner
: $ for i in `seq 0 1`; do ./a.out ; cat /mnt/scratch/foo ; echo ; done | sort |uniq -c 40 Ouille 9961 OuilleOuille $ So both filesystems behave according to the POSIX definition of concurrent writes Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list

Re: xfs: fix buffer lookup race on allocation failure

2012-10-15 Thread Dave Chinner
fe2429b0966a7ec42b5fe3bf96f0f10de0a3b536 Author: Dave Chinner dchin...@redhat.com Date: Mon Apr 23 15:58:45 2012 +1000 xfs: fix buffer lookup race on allocation failure When memory allocation fails to add the page array or tht epages to a buffer during xfs_buf_get(), the buffer is left

[PATCH] xfs: add hot tracking support.

2012-10-15 Thread Dave Chinner
From: Dave Chinner dchin...@redhat.com Connect up the VFS hot tracking support so XFS filesystems can make use of it. Signed-off-by: Dave Chinner dchin...@redhat.com --- fs/xfs/xfs_mount.h |1 + fs/xfs/xfs_super.c |9 + 2 files changed, 10 insertions(+) diff --git a/fs/xfs

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-15 Thread Dave Chinner
[ 200.064574] [81b765c0] ? gs_change+0x13/0x13 Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC v3 09/13] vfs: add one wq to update map info periodically

2012-10-15 Thread Dave Chinner
; Add the struct delayed_work here, too. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [RFC v3 11/13] vfs: add 3 new ioctl interfaces

2012-10-15 Thread Dave Chinner
can't see how this is a manageable interface. It is not persistent, so after every filesystem mount you'd have to set the flag on all your inodes again. Hence, for the moment, I'd suggest that dropping per-inode tracking control until all the core issues are sorted out Cheers, Dave. -- Dave

Re: [PATCH 11/16] f2fs: add inode operations for special inodes

2012-10-16 Thread Dave Chinner
On Tue, Oct 16, 2012 at 11:38:35AM +, Arnd Bergmann wrote: On Tuesday 16 October 2012, Jaegeuk Kim wrote: On Monday 15 October 2012, Dave Chinner wrote: On Sun, Oct 14, 2012 at 03:19:37PM +, Arnd Bergmann wrote: On Sunday 14 October 2012, Vyacheslav Dubeyko wrote: On Oct 14

Re: xfs: fix buffer lookup race on allocation failure

2012-10-16 Thread Dave Chinner
On Tue, Oct 16, 2012 at 11:27:48AM +0200, William Dauchy wrote: Hello Dave, Thanks for your reply. On Tue, Oct 16, 2012 at 1:21 AM, Dave Chinner da...@fromorbit.com wrote: You're running a CONFIG_XFS_DEBUG kernel. If you can reproduce the problem with CONFIG_XFS_DEBUG, then it probably

Re: [PATCH 11/16] f2fs: add inode operations for special inodes

2012-10-16 Thread Dave Chinner
with the appropriate string instead of user Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-17 Thread Dave Chinner
On Wed, Oct 17, 2012 at 04:57:14PM +0800, Zhi Yong Wu wrote: On Tue, Oct 16, 2012 at 4:42 AM, Dave Chinner da...@fromorbit.com wrote: On Wed, Oct 10, 2012 at 06:07:22PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com (*) Tested on an empty 17TB XFS

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-17 Thread Dave Chinner
On Thu, Oct 18, 2012 at 12:44:47PM +0800, Zhi Yong Wu wrote: On Thu, Oct 18, 2012 at 12:29 PM, Dave Chinner da...@fromorbit.com wrote: On Wed, Oct 17, 2012 at 04:57:14PM +0800, Zhi Yong Wu wrote: On Tue, Oct 16, 2012 at 4:42 AM, Dave Chinner da...@fromorbit.com wrote: On Wed, Oct 10, 2012

Re: RT and XFS

2005-07-13 Thread Dave Chinner
because if you end up waiting on one of them you can forget about pretty much any RT guarantee that you've ever given Cheers, Dave. -- Dave Chinner RD Software Engineer SGI Australian Software Group - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH] xfs: fix comment typo of struct xfs_da_blkinfo.

2012-07-19 Thread Dave Chinner
you'll have to make significant changes to support a second XFS disk format in the not-to-distant future... Thanks for the interest in helping us! We want it to work! ;) Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: Loopback device hung [was Re: xfs deadlock on 3.9-rc5 running xfstests case #78]

2013-04-09 Thread Dave Chinner
one of these fixes merged quickly? xfstests is unusable on any kernel more recent than 3.9-rc4 because of these problems Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: Loopback device hung [was Re: xfs deadlock on 3.9-rc5 running xfstests case #78]

2013-04-09 Thread Dave Chinner
On Tue, Apr 09, 2013 at 09:01:39AM +0200, Jens Axboe wrote: On Tue, Apr 09 2013, Dave Chinner wrote: On Thu, Apr 04, 2013 at 04:30:54PM -0400, Phillip Susi wrote: I have not tested it yet, but I am pretty sure it won't work. It looks like the patch changes the BLKRRPART path to go

Re: [PATCH 08/10] mm: vmscan: Have kswapd shrink slab only once per priority

2013-04-09 Thread Dave Chinner
infrastructure and LRUs make the relationship much more direct ;) Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: Excessive stall times on ext4 in 3.9-rc2

2013-04-11 Thread Dave Chinner
priority as reads. Ext4 is already using REQ_META for this purpose. I'm surprised that no-one has suggested change the IO elevator yet. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: Excessive stall times on ext4 in 3.9-rc2

2013-04-12 Thread Dave Chinner
On Fri, Apr 12, 2013 at 11:19:52AM -0400, Theodore Ts'o wrote: On Fri, Apr 12, 2013 at 02:50:42PM +1000, Dave Chinner wrote: If that is the case, one possible solution that comes to mind would be to mark buffer_heads that contain metadata with a flag, so that the flusher thread can write

Loopback device hung [was Re: xfs deadlock on 3.9-rc5 running xfstests case #78]

2013-04-02 Thread Dave Chinner
: prevent bdev freeing while device in use 8761a3d loop: cleanup partitions when detaching loop device 183cfb5 loop: fix error return code in loop_add() $ So this looks like someone hasn't been testing their loopback driver changes properly... Cheers, Dave. -- Dave Chinner da...@fromorbit.com

Re: [PATCH 2/9] vfs: export do_splice_direct() to modules

2013-03-17 Thread Dave Chinner
. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 11/12] rwsem: wake all readers when first waiter is a reader

2013-03-18 Thread Dave Chinner
On Wed, Mar 13, 2013 at 10:00:51PM -0400, Peter Hurley wrote: On Wed, 2013-03-13 at 14:23 +1100, Dave Chinner wrote: We don't care about the ordering between multiple concurrent metadata modifications - what matters is whether the ongoing data IO around them is ordered correctly. Dave

Re: [PATCH 3/4] writeback: replace custom worker pool implementation with unbound workqueue

2013-03-20 Thread Dave Chinner
in writeback from the sysrq-w or hangcheck output is pretty damn important Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: Tux3 Report: Initial fsck has landed

2013-03-21 Thread Dave Chinner
. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] vfs: dcache: cond_resched in shrink_dentry_list

2013-03-25 Thread Dave Chinner
for changing the shrink_dentry_list() behaviour adversely for other users Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] vfs: dcache: cond_resched in shrink_dentry_list

2013-03-25 Thread Dave Chinner
On Mon, Mar 25, 2013 at 05:39:13PM -0700, Greg Thelen wrote: On Mon, Mar 25 2013, Dave Chinner wrote: On Mon, Mar 25, 2013 at 10:22:31AM -0700, Greg Thelen wrote: Call cond_resched() from shrink_dentry_list() to preserve shrink_dcache_parent() interactivity. void shrink_dcache_parent

Re: [PATCH 11/12] rwsem: wake all readers when first waiter is a reader

2013-03-08 Thread Dave Chinner
dependencies on the barrier effect of metadata operations on data IO... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 11/12] rwsem: wake all readers when first waiter is a reader

2013-03-10 Thread Dave Chinner
On Fri, Mar 08, 2013 at 05:20:34PM -0800, Michel Lespinasse wrote: On Fri, Mar 8, 2013 at 4:32 PM, Dave Chinner da...@fromorbit.com wrote: On Wed, Mar 06, 2013 at 03:21:50PM -0800, Michel Lespinasse wrote: When the first queued waiter is a reader, wake all readers instead of just those

Re: [PATCH 11/12] rwsem: wake all readers when first waiter is a reader

2013-03-11 Thread Dave Chinner
On Sun, Mar 10, 2013 at 10:17:42PM -0700, Michel Lespinasse wrote: On Sun, Mar 10, 2013 at 5:16 PM, Dave Chinner da...@fromorbit.com wrote: On Fri, Mar 08, 2013 at 05:20:34PM -0800, Michel Lespinasse wrote: On Fri, Mar 8, 2013 at 4:32 PM, Dave Chinner da...@fromorbit.com wrote: Isn't

Re: torrent hash failures since 3.9.0-rc1

2013-03-12 Thread Dave Chinner
reproduce in isolation. :/ Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH 11/12] rwsem: wake all readers when first waiter is a reader

2013-03-12 Thread Dave Chinner
On Mon, Mar 11, 2013 at 11:43:34PM -0700, Michel Lespinasse wrote: Hi Dave, On Mon, Mar 11, 2013 at 7:36 PM, Dave Chinner da...@fromorbit.com wrote: On Sun, Mar 10, 2013 at 10:17:42PM -0700, Michel Lespinasse wrote: - since all readers are woken at once, you might see burst of direct IO

Re: [PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign()

2013-03-04 Thread Dave Chinner
. In future, please check first that the bug you are reporting is reproducable on a current upstream kernel and userspace. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH] tmpfs: support SEEK_DATA and SEEK_HOLE (reprise)

2012-11-29 Thread Dave Chinner
allocate memory) Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [PATCH 17/19] drivers: convert shrinkers to new count/scan API

2012-11-29 Thread Dave Chinner
On Thu, Nov 29, 2012 at 02:29:33PM +0400, Glauber Costa wrote: On 11/29/2012 01:28 AM, Dave Chinner wrote: On Wed, Nov 28, 2012 at 12:21:54PM +0400, Glauber Costa wrote: On 11/28/2012 07:17 AM, Dave Chinner wrote: On Wed, Nov 28, 2012 at 01:13:11AM +, Chris Wilson wrote: On Wed, 28

Re: [RFC, PATCH 00/19] Numa aware LRU lists and shrinkers

2012-11-29 Thread Dave Chinner
On Thu, Nov 29, 2012 at 11:02:24AM -0800, Andi Kleen wrote: Dave Chinner da...@fromorbit.com writes: Comments, thoughts and flames all welcome. Doing the reclaim per CPU sounds like a big change in the VM balance. It's per node, not per CPU. And AFAICT, it hasn't changed the balance

Re: [PATCH v2] Do a proper locking for mmap and block size change

2012-11-29 Thread Dave Chinner
. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2] Do a proper locking for mmap and block size change

2012-11-30 Thread Dave Chinner
On Fri, Nov 30, 2012 at 11:36:01AM -0500, Christoph Hellwig wrote: On Fri, Nov 30, 2012 at 01:49:10PM +1100, Dave Chinner wrote: Ugh. That's a big violation of how buffer-heads are supposed to work: the block number is very much defined to be in multiples of b_size (see for example

Re: [patch,v2] bdi: add a user-tunable cpu_list for the bdi flusher threads

2012-12-03 Thread Dave Chinner
Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v4 16/31] loop: use aio to perform io on the underlying file

2012-12-03 Thread Dave Chinner
On Mon, Dec 03, 2012 at 10:59:39AM -0600, Dave Kleikamp wrote: On 11/22/2012 05:06 PM, Dave Chinner wrote: On Wed, Nov 21, 2012 at 04:40:56PM -0600, Dave Kleikamp wrote: From: Zach Brown z...@zabbo.net This uses the new kernel aio interface to process loopback IO by submitting

Re: [PATCH] Update atime from future.

2012-12-04 Thread Dave Chinner
that use atime to determine newly accessed files IMO, if you fat-finger a manual atime update or use atimes direct from tarballs, then that's your problem as a user and not the responsibility of the kernel to magically fix for you Cheers, Dave. -- Dave Chinner da...@fromorbit.com

Re: [patch,v2] bdi: add a user-tunable cpu_list for the bdi flusher threads

2012-12-04 Thread Dave Chinner
On Tue, Dec 04, 2012 at 09:42:55AM -0500, Jeff Moyer wrote: Dave Chinner da...@fromorbit.com writes: On Mon, Dec 03, 2012 at 01:53:39PM -0500, Jeff Moyer wrote: +static ssize_t cpu_list_store(struct device *dev, + struct device_attribute *attr, const char *buf, size_t count

Re: [PATCH] fs: encode_fh: return FILEID_INVALID if invalid fid_type

2013-02-11 Thread Dave Chinner
; /* invalid */ + return FILEID_INVALID; /* invalid */ } I think you can drop the /* invalid */ comment from there now as it is redundant with this change. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH 0/6 RFC] Mapping range lock

2013-02-05 Thread Dave Chinner
is not the right level to be providing IO exclusion semantics. After all, it's entire IO ranges that we need to provide -atomic- exclusion for... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 0/6 RFC] Mapping range lock

2013-02-06 Thread Dave Chinner
On Wed, Feb 06, 2013 at 08:25:34PM +0100, Jan Kara wrote: On Wed 06-02-13 10:25:12, Dave Chinner wrote: On Mon, Feb 04, 2013 at 01:38:31PM +0100, Jan Kara wrote: On Thu 31-01-13 16:07:57, Andrew Morton wrote: c) i_mutex doesn't allow any paralellism of operations using it and some

Re: 3.8-rc5 xfs corruption

2013-01-30 Thread Dave Chinner
allocated xfs_bufs are zeroed before being initialised. I really need to know what you are doing to be able to get to the bottom of it Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign()

2013-02-26 Thread Dave Chinner
reproduce the problem on your system - that way we'll know if the bug really has been fixed or not Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [GIT PULL] ext4 updates for 3.9

2013-02-28 Thread Dave Chinner
. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH V5 00/30] loop: Issue O_DIRECT aio using bio_vec

2013-01-20 Thread Dave Chinner
as they will do a whole lot more than just data IO to the loop devices... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [RFC, PATCH 00/19] Numa aware LRU lists and shrinkers

2013-01-21 Thread Dave Chinner
On Mon, Jan 21, 2013 at 08:08:53PM +0400, Glauber Costa wrote: On 11/28/2012 03:14 AM, Dave Chinner wrote: [PATCH 09/19] list_lru: per-node list infrastructure This makes the generic LRU list much more scalable by changing it to a {list,lock,count} tuple per node. There are no external

Re: [RFC, PATCH 00/19] Numa aware LRU lists and shrinkers

2013-01-23 Thread Dave Chinner
On Wed, Jan 23, 2013 at 06:36:33PM +0400, Glauber Costa wrote: On 01/22/2013 03:21 AM, Dave Chinner wrote: On Mon, Jan 21, 2013 at 08:08:53PM +0400, Glauber Costa wrote: On 11/28/2012 03:14 AM, Dave Chinner wrote: [PATCH 09/19] list_lru: per-node list infrastructure This makes

Re: [PATCH 09/19] list_lru: per-node list infrastructure

2013-01-16 Thread Dave Chinner
On Wed, Jan 16, 2013 at 11:21:44AM -0800, Glauber Costa wrote: On 11/27/2012 03:14 PM, Dave Chinner wrote: From: Dave Chinner dchin...@redhat.com Now that we have an LRU list API, we can start to enhance the implementation. This splits the single LRU list into per-node lists and locks

Re: [PATCH 09/19] list_lru: per-node list infrastructure

2013-01-16 Thread Dave Chinner
of structure, not that specific instances of a filesystem could use different types Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

  1   2   3   4   5   6   7   8   9   10   >