On 2013/8/19 16:00, Johannes Berg wrote:
3.11-rc6's commit 58ad436fcf49 (genetlink: fix family dump race)
gives me the lockdep trace below at startup.
Hmm. Yes, I see now how this happens, not sure why I didn't run into it.
The problem is that genl_family_rcv_msg() is called with the
于 2013/11/16 8:40, Paul E. McKenney 写道:
From: Paul E. McKenney paul...@linux.vnet.ibm.com
The sparse checking for rcu_assign_pointer() was recently upgraded
to reject non-__kernel address spaces. This also rejects __rcu,
which is almost always the right thing to do. However, the uses in
, and then the real dev will call ndo_set_rx_mode(), if the real
dev is vlan dev, the ndo_set_rx_mode() will hold netif_addr_lock again, so
deadlock
happened.
Don't allow to add vlan on vlan dev to fix this problem.
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
net/8021q/vlan.c | 5
On 2014/2/28 10:08, Ding Tianhong wrote:
I run these steps:
modprobe 8021q
vconfig add eth2 20
vconfig add eth2.20 20
ifconfig eth2 xx.xx.xx.xx
then the Call Trace happened:
[32524.386288] =
[32524.386293] [ INFO: possible recursive locking
, and then the real dev will call ndo_set_rx_mode(), if the real
dev is vlan dev, the ndo_set_rx_mode() will hold netif_addr_lock again, so
deadlock
happened.
Don't allow to add vlan on vlan dev to fix this problem.
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
net/8021q/vlan.c | 5
On 2014/2/28 11:45, John Fastabend wrote:
On 2/27/2014 6:43 PM, Ding Tianhong wrote:
I run these steps:
modprobe 8021q
vconfig add eth2 20
vconfig add eth2.20 20
ifconfig eth2 xx.xx.xx.xx
then the Call Trace happened
On 2014/2/28 13:41, Florian Fainelli wrote:
2014-02-27 21:26 GMT-08:00 Ding Tianhong dingtianh...@huawei.com:
On 2014/2/28 11:45, John Fastabend wrote:
On 2/27/2014 6:43 PM, Ding Tianhong wrote:
I run these steps:
modprobe 8021q
vconfig add eth2 20
vconfig add eth2.20 20
ifconfig eth2
On 2014/3/5 8:10, Ben Hutchings wrote:
On Thu, 2014-02-27 at 19:45 -0800, John Fastabend wrote:
On 2/27/2014 6:43 PM, Ding Tianhong wrote:
I run these steps:
modprobe 8021q
vconfig add eth2 20
vconfig add eth2.20 20
ifconfig eth2 xx.xx.xx.xx
then the Call Trace happened
/bond_netlink.c | 6 +-
drivers/net/bonding/bond_options.c | 102
drivers/net/bonding/bond_procfs.c | 8 +-
drivers/net/bonding/bond_sysfs.c | 8 +-
9 files changed, 288 insertions(+), 307 deletions(-)
Reviewed-by: Ding Tianhong dingtianh...@huawei.com
--
To unsubscribe
/bond_main.c | 6 +++---
3 files changed, 21 insertions(+), 23 deletions(-)
Reviewed-by: Ding Tianhong dingtianh...@huawei.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On 2014/3/20 16:51, Zheng Li wrote:
Except bond mode 1, in other bond modes, inactive slaves should keep inactive
flag to
1 to refuse to receive broadcast packets. Now, active slave send broadcast
packets
(for example ARP requests) which will arrive inactive slaves on same host
from
On 2014/3/21 10:39, zheng.li wrote:
于 2014年03月21日 01:02, Jay Vosburgh 写道:
Zheng Li zheng.x...@oracle.com wrote:
Except bond mode 1, in other bond modes, inactive slaves should keep
inactive flag to 1 to refuse to receive broadcast packets. Now, active
slave send broadcast packets (for
On 2013/9/2 14:06, Baoquan He wrote:
Hi both,
Thanks for your patches. I tried to test your patches, first the 2nd
one, namely Hillf's patch, it's OK. Then when I wanted to reproduce and
test Cong's patch, it failed to happen again.
I remember this bug happened randomly at the very
On 2013/9/2 14:06, Baoquan He wrote:
Hi both,
Thanks for your patches. I tried to test your patches, first the 2nd
one, namely Hillf's patch, it's OK. Then when I wanted to reproduce and
test Cong's patch, it failed to happen again.
I remember this bug happened randomly at the very
On 2013/9/2 16:24, Baoquan He wrote:
Hi Tianhong,
I applied your patch and execute below cmd.
Then keyboard inputting problems happened,
I can't enter user/password correctly, then reboot again, it's OK now.
Thanks for your work, I don't understand that the keyboard problem is the patch
...@redhat.com
Uh, yes, I missed that. Thanks a lot!
Acked-by: Hannes Frederic Sowa han...@stressinduktion.org
Acked-by: Ding Tianhong dingtianh...@huawei.com
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info
On 2014/5/7 10:45, Li Zefan wrote:
On 2014/5/6 20:19, Ding Tianhong wrote:
On 2014/5/6 19:15, sanil kumar wrote:
On 5/6/2014 4:37 PM, Ding Tianhong wrote:
On 2014/5/6 17:29, maobibo 00177601 wrote:
Hi Tianhong,
I have two questions about the HULK
1) When we get kernel from HULK
The __vlan_find_dev_deep should always called in RCU, according
David's suggestion, rename to __vlan_find_dev_deep_rcu looks more
reasonable.
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c | 2 +-
drivers/net/ethernet/chelsio/cxgb4
On 2014/5/8 10:29, Ding Tianhong wrote:
The __vlan_find_dev_deep should always called in RCU, according
David's suggestion, rename to __vlan_find_dev_deep_rcu looks more
reasonable.
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
Self Nacked, I make this patch from net repository
The __vlan_find_dev_deep should always called in RCU, according
David's suggestion, rename to __vlan_find_dev_deep_rcu looks more
reasonable.
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c | 2 +-
drivers/net/ethernet/chelsio/cxgb4
On 2014/1/6 23:11, Johannes Berg wrote:
On Thu, 2013-12-26 at 19:40 +0800, Ding Tianhong wrote:
Use the possibly more efficient ether_addr_equal
to instead of memcmp.
This is a slow-path, I don't think that's really worth it. It kinda
makes sense, but relies on the struct mac_address
On 2014/1/7 21:54, Mauro Carvalho Chehab wrote:
Em Thu, 26 Dec 2013 19:09:10 +0800
Ding Tianhong dingtianh...@huawei.com escreveu:
On 2013/12/25 18:57, Sergei Shtylyov wrote:
Hello.
On 25-12-2013 7:29, Ding Tianhong wrote:
Use possibly more efficient ether_addr_equal
instead of memcmp
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Don Fry pcne...@frontier.com
Cc: net...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/amd/pcnet32.c | 2 +-
1 file changed, 1 insertion(+), 1
-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/wireless/hostap/hostap_80211_tx.c | 4 ++--
drivers/net/wireless/hostap/hostap_ap.c | 28 +--
drivers/net/wireless/hostap/hostap_hw.c | 2 +-
drivers/net/wireless/hostap/hostap_ioctl.c| 4 ++--
drivers
Use possibly more efficient ether_addr_equal
instead of memcmp.
Cc: Rupesh Gujare rupesh.guj...@atmel.com
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Cc: de...@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Tan Xiaojun tanxiao...@huawei.com
Signed-off-by: Ding Tianhong
@vger.kernel.org
Signed-off-by: Weilong Chen chenweil...@huawei.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/wireless/rtlwifi/cam.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/cam.c
b/drivers/net/wireless/rtlwifi/cam.c
index
Use possibly more efficient ether_addr_equal
instead of memcmp.
Cc: Mauro Carvalho Chehab m.che...@samsung.com
Cc: linux-me...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Yang Yingliang yangyingli...@huawei.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
Acked
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Michal Ostrowski mostr...@earthlink.net
Cc: net...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ppp/pppoe.c | 4 ++--
1 file changed, 2 insertions(+), 2
Xiaojun tanxiao...@huawei.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/wireless/zd1211rw/zd_mac.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/zd1211rw/zd_mac.c
b/drivers/net/wireless/zd1211rw/zd_mac.c
index eff79a3..e7af261
Use possibly more efficient ether_addr_equal
instead of memcmp.
Cc: Karsten Keil i...@linux-pingi.de
Cc: net...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Yang Yingliang yangyingli...@huawei.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/isdn/i4l
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Joerg Reuter jreu...@yaina.de
Cc: linux-h...@vger.kernel.org
Cc: net...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/hamradio/bpqether.c | 2 +-
1 file
-off-by: Wang Weidong wangweido...@huawei.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/infiniband/hw/nes/nes_cm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/nes/nes_cm.c
b/drivers/infiniband/hw/nes/nes_cm.c
index 6b29249
...@huawei.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
net/mac80211/iface.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
index 7aa9f9d..a4f9812 100644
--- a/net/mac80211/iface.c
+++ b/net/mac80211/iface.c
...@samsung.com
Best Regards
Ding
Ding Tianhong (5):
net: freescale: remove unused compare_addr()
net: pcnet: slight optimization of addr compare
net: atl1: slight optimization of addr compare
hamradio: slight optimization of addr compare
ppp: slight optimization of addr compare
...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Tan Xiaojun tanxiao...@huawei.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
Acked-by: Antonio Quartulli anto...@meshcoding.com
---
net/batman-adv/originator.c| 2 +-
net/batman-adv/translation-table.c | 2 +-
2
The function did not be used any more, so remove it.
Cc: Li Yang le...@freescale.com
Cc: net...@vger.kernel.org
Cc: linuxppc-...@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/freescale/ucc_geth.c | 5 -
1 file
-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/wireless/mwifiex/11n.c | 2 +-
drivers/net/wireless/mwifiex/sta_cmdresp.c | 3 +--
drivers/net/wireless/mwifiex/sta_rx.c | 2 +-
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/mwifiex/11n.c
-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/atheros/atlx/atl1.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/atheros/atlx/atl1.c
b/drivers/net/ethernet/atheros/atlx/atl1.c
index 538211d..55d86ec 100644
--- a/drivers/net/ethernet
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/wireless/cw1200/sta.c | 5 +++--
drivers/net/wireless/cw1200/txrx.c | 3 +--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/cw1200/sta.c
b/drivers/net/wireless/cw1200/sta.c
index 010b252..103f7bc
On 2014/1/8 10:50, Bing Zhao wrote:
Hi Ding,
Use possibly more efficient ether_addr_equal
instead of memcmp.
@@ -782,8 +782,7 @@ static int mwifiex_ret_ibss_coalescing_status(struct
mwifiex_private *priv,
}
/* If BSSID is diff, modify current BSS parameters */
-if
Use possibly more efficient ether_addr_equal
instead of memcmp.
Cc: Chas Williams c...@cmf.nrl.navy.mil
Cc: linux-atm-gene...@lists.sourceforge.net
Cc: net...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Yang Yingliang yangyingli...@huawei.com
Signed-off-by: Ding Tianhong
...@huawei.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/wireless/ipw2x00/ipw2200.c | 34
drivers/net/wireless/ipw2x00/libipw_rx.c | 10 +-
2 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/net/wireless/ipw2x00
-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/wireless/adm8211.c| 2 +-
drivers/net/wireless/brcm80211/brcmfmac/p2p.c | 7 +++
drivers/net/wireless/hostap/hostap_80211_rx.c | 8
drivers/net/wireless/prism54/isl_ioctl.c | 3 ++-
drivers/net/wireless/ti
On 2014/1/8 15:06, Antonio Quartulli wrote:
On 08/01/14 03:53, Ding Tianhong wrote:
It is better to use batadv_compate_eth instead of memcpy for
concise style.
Cc: Marek Lindner mareklind...@neomailbox.ch
Cc: Simon Wunderlich s...@simonwunderlich.de
Cc: Antonio Quartulli anto
On 2014/1/15 1:17, Veaceslav Falico wrote:
Hi,
I'm hitting a strange issue and/or I'm completely lost in sysfs internals.
Consider having two net_device *a, *b; which are registered normally.
Now, to create a link from /sys/class/net/a-name/linkname to b, one should
use:
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/3com/3c509.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/3com
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Sathya Perla sathya.pe...@emulex.com
Cc: Subbu Seetharaman subbu.seethara...@emulex.com
Cc: Ajit Khaparde ajit.khapa...@emulex.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/emulex/benet
This is the second patchset for slight optimization of address compare,
mainly for net tree, just following the Joe's opinion, it will help review
the code for maintainers and supports.
Best Regards
Ding
Ding Tianhong (20):
net: 3com: slight optimization of addr compare
net: bnx2x: slight
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Dmitry Tarnyagin dmitry.tarnya...@lockless.no
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
net/caif/cfrfml.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Manish Chopra manish.cho...@qlogic.com
Cc: Sony Chacko sony.cha...@qlogic.com
Cc: Rajesh Borundia rajesh.borun...@qlogic.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/qlogic/netxen
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/plip/plip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/plip/plip.c b/drivers/net
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/micrel/ksz884x.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/net
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/fddi/skfp/fplustm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/fddi/skfp
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Jeff Kirsher jeffrey.t.kirs...@intel.com
Cc: Jesse Brandeburg jesse.brandeb...@intel.com
Cc: Carolyn Wyborny carolyn.wybo...@intel.com
Cc: Don Skidmore donald.c.skidm...@intel.com
Signed-off-by: Ding Tianhong dingtianh
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/sun/sunvnet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/sun
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Jon Mason jdma...@kudzu.us
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/neterion/vxge/vxge-main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/ti/cpsw_ale.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/seeq/sgiseeq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/seeq
Use the possibly more efficient ether_addr_equal or
ether_addr_equal_unaligned to instead of memcmp.
Cc: Himanshu Madhani himanshu.madh...@qlogic.com
Cc: Rajesh Borundia rajesh.borun...@qlogic.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/qlogic/qlcnic
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Santosh Raspatur sant...@chelsio.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c | 2 +-
drivers/net/ethernet/chelsio/cxgb3/l2t.c | 2 +-
2 files
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/renesas/sh_eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Amir Vadai am...@mellanox.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/mellanox/mlx4/en_netdev.c| 4 ++--
drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 2 +-
2 files
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/packetengines/yellowfin.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Jeff Kirsher jeffrey.t.kirs...@intel.com
Cc: Jesse Brandeburg jesse.brandeb...@intel.com
Cc: Bruce Allan bruce.w.al...@intel.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/intel/ixgbe
Use the possibly more efficient ether_addr_equal or
ether_addr_equal_unaligned to instead of memcmp.
Cc: Ariel Elior ari...@broadcom.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c| 10 --
drivers/net/ethernet/broadcom/bnx2x
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Christian Benvenuti be...@cisco.com
Cc: Sujith Sankar ssuj...@cisco.com
Cc: Govindarajulu Varadarajan govindarajul...@gmail.com
Cc: Neel Patel neepa...@cisco.com
Cc: Nishank Trivedi nistr...@cisco.com
Signed-off-by: Ding
On 2013/12/27 23:48, Eric Dumazet wrote:
On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote:
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/plip/plip.c | 2
On 2013/12/28 1:06, Joe Perches wrote:
On Fri, 2013-12-27 at 07:48 -0800, Eric Dumazet wrote:
On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote:
Use possibly more efficient ether_addr_equal
to instead of memcmp.
[]
diff --git a/drivers/net/plip/plip.c b/drivers/net/plip/plip.c
On 2013/12/28 13:11, Joe Perches wrote:
On Sat, 2013-12-28 at 13:07 +0800, Ding Tianhong wrote:
On 2013/12/28 1:06, Joe Perches wrote:
On Fri, 2013-12-27 at 07:48 -0800, Eric Dumazet wrote:
On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote:
Use possibly more efficient ether_addr_equal
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Amir Vadai am...@mellanox.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/mellanox/mlx4/en_netdev.c| 4 ++--
drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 2 +-
2 files
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/3com/3c509.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/3com
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Christian Benvenuti be...@cisco.com
Cc: Sujith Sankar ssuj...@cisco.com
Cc: Govindarajulu Varadarajan govindarajul...@gmail.com
Cc: Neel Patel neepa...@cisco.com
Cc: Nishank Trivedi nistr...@cisco.com
Signed-off-by: Ding
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/packetengines/yellowfin.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/fddi/skfp/fplustm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/fddi/skfp
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/seeq/sgiseeq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/seeq
Use possibly more efficient ether_addr_equal_64bits
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Suggested-by: Eric Dumazet eduma...@google.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/plip/plip.c |4 ++--
1 files changed, 2 insertions(+), 2
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Dmitry Tarnyagin dmitry.tarnya...@lockless.no
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
net/caif/cfrfml.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/ti/cpsw_ale.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti
Use the possibly more efficient ether_addr_equal or
ether_addr_equal_unaligned to instead of memcmp.
Cc: Himanshu Madhani himanshu.madh...@qlogic.com
Cc: Rajesh Borundia rajesh.borun...@qlogic.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/qlogic/qlcnic
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/sun/sunvnet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/sun
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/renesas/sh_eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Manish Chopra manish.cho...@qlogic.com
Cc: Sony Chacko sony.cha...@qlogic.com
Cc: Rajesh Borundia rajesh.borun...@qlogic.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/qlogic/netxen
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Sathya Perla sathya.pe...@emulex.com
Cc: Subbu Seetharaman subbu.seethara...@emulex.com
Cc: Ajit Khaparde ajit.khapa...@emulex.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/emulex/benet
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Jon Mason jdma...@kudzu.us
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/neterion/vxge/vxge-main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Jeff Kirsher jeffrey.t.kirs...@intel.com
Cc: Jesse Brandeburg jesse.brandeb...@intel.com
Cc: Carolyn Wyborny carolyn.wybo...@intel.com
Cc: Don Skidmore donald.c.skidm...@intel.com
Signed-off-by: Ding Tianhong dingtianh
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Jeff Kirsher jeffrey.t.kirs...@intel.com
Cc: Jesse Brandeburg jesse.brandeb...@intel.com
Cc: Bruce Allan bruce.w.al...@intel.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/intel/ixgbe
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/micrel/ksz884x.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/net
Use the possibly more efficient ether_addr_equal or
ether_addr_equal_unaligned to instead of memcmp.
Cc: Ariel Elior ari...@broadcom.com
Cc: Sergei Shtylyov sergei.shtyl...@cogentembedded.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Santosh Raspatur sant...@chelsio.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c | 2 +-
drivers/net/ethernet/chelsio/cxgb3/l2t.c | 2 +-
2 files
of ether_addr_equal for patch 19.
In fact, there are a lot of places which could use ether_addr_equal_64bits
to instead of ether_addr_equal, but not this time, thanks for Joe's
opinion.
Best Regards
Ding
Ding Tianhong (20):
net: 3com: slight optimization of addr compare
net
于 2013/12/28 14:59, Joe Perches 写道:
On Sat, 2013-12-28 at 14:18 +0800, Ding Tianhong wrote:
Use possibly more efficient ether_addr_equal
to instead of memcmp.
This may be a distinction without difference, but
is a CAIF seghead also an ethernet address?
NO，this is a coincidence, the CAIF
于 2013/12/28 21:58, Sergei Shtylyov 写道:
Hello.
On 28-12-2013 10:17, Ding Tianhong wrote:
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet
On 2013/12/29 1:04, Joe Perches wrote:
On Sat, 2013-12-28 at 23:02 +0800, Ding Tianhong wrote:
于 2013/12/28 14:59, Joe Perches 写道:
On Sat, 2013-12-28 at 14:18 +0800, Ding Tianhong wrote:
Use possibly more efficient ether_addr_equal
to instead of memcmp.
This may be a distinction without
On 2013/12/29 1:23, Joe Perches wrote:
On Sat, 2013-12-28 at 23:18 +0800, Ding Tianhong wrote:
于 2013/12/28 21:58, Sergei Shtylyov 写道:
Hello.
On 28-12-2013 10:17, Ding Tianhong wrote:
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da
On 2013/12/30 14:05, Joe Perches wrote:
On Mon, 2013-12-30 at 10:39 +0800, Ding Tianhong wrote:
I don't understand packetengine NIC anymore, But I think the change is
clearly,
as your said, the broadcast check is enough here, did you mean that?
!is_broadcast_ether_addr((u8
Use the possibly more efficient ether_addr_equal or
ether_addr_equal_unaligned to instead of memcmp.
Cc: Ariel Elior ari...@broadcom.com
Cc: Sergei Shtylyov sergei.shtyl...@cogentembedded.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/3com/3c509.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/3com
to use the ether_addr_equal
to compare a non mac address, so remove the patch from the series.
Best Regards
Ding
Ding Tianhong (19):
net: 3com: slight optimization of addr compare
net: bnx2x: slight optimization of addr compare
net: cxgb3: slight optimization of addr compare
net: enic
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Jon Mason jdma...@kudzu.us
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/ethernet/neterion/vxge/vxge-main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Amir Vadai am...@mellanox.com
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
Acked-By: Amir Vadai am...@mellanox.com
---
drivers/net/ethernet/mellanox/mlx4/en_netdev.c| 4 ++--
drivers/net/ethernet/mellanox/mlx4
1 - 100 of 887 matches
Mail list logo
