Re: [GIT PATCHES] V4L/DVB updates

2007-04-16 Thread Dmitry Torokhov
Hi Mauro, On 4/15/07, Mauro Carvalho Chehab [EMAIL PROTECTED] wrote: - Fix Kernel Bugzilla #8301: spinlock fix for flexcop-pci While move of spin_lock_init before request_irq is obviously correct I wonder what is the reason behind changing spin_lock_irq() into spin_lock_irqsave() as I do

Re: [Patch -mm 0/3] RFC: module unloading vs. release function

2007-04-16 Thread Dmitry Torokhov
On 4/16/07, Cornelia Huck [EMAIL PROTECTED] wrote: Hi, based on the discussion in How should an exit routine wait for release() callbacks?, I've cooked up some patches that make module unload wait until the last reference for a kobject has been dropped. This should plug the release function in

Re: [Patch -mm 0/3] RFC: module unloading vs. release function

2007-04-16 Thread Dmitry Torokhov
On 4/16/07, Greg KH [EMAIL PROTECTED] wrote: On Mon, Apr 16, 2007 at 02:30:17PM -0400, Dmitry Torokhov wrote: On 4/16/07, Cornelia Huck [EMAIL PROTECTED] wrote: Hi, based on the discussion in How should an exit routine wait for release() callbacks?, I've cooked up some patches that make

Re: [Patch -mm 0/3] RFC: module unloading vs. release function

2007-04-16 Thread Dmitry Torokhov
On 4/16/07, Alan Stern [EMAIL PROTECTED] wrote: On Mon, 16 Apr 2007, Dmitry Torokhov wrote: On 4/16/07, Cornelia Huck [EMAIL PROTECTED] wrote: Hi, based on the discussion in How should an exit routine wait for release() callbacks?, I've cooked up some patches that make module unload

Re: [Patch -mm 0/3] RFC: module unloading vs. release function

2007-04-16 Thread Dmitry Torokhov
On 4/16/07, Greg KH [EMAIL PROTECTED] wrote: On Mon, Apr 16, 2007 at 03:47:13PM -0400, Dmitry Torokhov wrote: On 4/16/07, Alan Stern [EMAIL PROTECTED] wrote: On Mon, 16 Apr 2007, Dmitry Torokhov wrote: On 4/16/07, Cornelia Huck [EMAIL PROTECTED] wrote: Hi, based on the discussion

Re: [Patch -mm 0/3] RFC: module unloading vs. release function

2007-04-16 Thread Dmitry Torokhov
On 4/16/07, Greg KH [EMAIL PROTECTED] wrote: On Mon, Apr 16, 2007 at 03:03:16PM -0400, Dmitry Torokhov wrote: On 4/16/07, Greg KH [EMAIL PROTECTED] wrote: On Mon, Apr 16, 2007 at 02:30:17PM -0400, Dmitry Torokhov wrote: On 4/16/07, Cornelia Huck [EMAIL PROTECTED] wrote: Hi, based

Re: [PATCH 2/2] wistron_btns: add led support

2007-04-17 Thread Dmitry Torokhov
On Saturday 14 April 2007 12:09, Éric Piel wrote: This patch adds support for mail and wifi leds. It modifies the Kconfig file to automatically pull led_class with wistron_btns, hopefully everyone is fine with this. Was there 1/2 file? -- Dmitry - To unsubscribe from this list: send the

Re: [PATCH] general: convert kernel subdirectory to UTF-8

2007-04-17 Thread Dmitry Torokhov
On Tuesday 17 April 2007 13:19, John Anthony Kazos Jr. wrote:  /* - * Samma på svenska.. + * Samma pÃ¥ svenska..   */ Translating this comment into english so more people could understand it would be better option. -- Dmitry - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH RFD] alternative kobject release wait mechanism

2007-04-18 Thread Dmitry Torokhov
On 4/18/07, Tejun Heo [EMAIL PROTECTED] wrote: Hello, Alan Stern wrote: On Wed, 18 Apr 2007, Tejun Heo wrote: Hello, all. Agreed with the problem but I'm not very enthusiastic for adding kobj-owner. How about the following? exit() routines will have to do device_unregister_wait()

Re: [RFC 1/2] Input: ff, add FF_RAW effect

2007-04-18 Thread Dmitry Torokhov
Hi, On Thursday 19 April 2007 00:25, johann deneux wrote: On 4/18/07, Jiri Slaby [EMAIL PROTECTED] wrote: johann deneux napsal(a): Jiri, Which solution did you chose to implement? From what I remember, we last discussed Dmitry's idea of specifying an axis for an effect, then

Re: [PATCH RFD] alternative kobject release wait mechanism

2007-04-19 Thread Dmitry Torokhov
On 4/19/07, Cornelia Huck [EMAIL PROTECTED] wrote: On Wed, 18 Apr 2007 12:41:36 -0400, Dmitry Torokhov [EMAIL PROTECTED] wrote: I am still do not understand why this is needed. Would it not be simplier just to use a reference to struct device instead of embedding it in a larger structure

Re: [PATCH RFD] alternative kobject release wait mechanism

2007-04-19 Thread Dmitry Torokhov
On 4/19/07, Cornelia Huck [EMAIL PROTECTED] wrote: On Thu, 19 Apr 2007 09:13:43 -0400, Dmitry Torokhov [EMAIL PROTECTED] wrote: Because they are managed by 2 different entities. the struct device objects are managed by device core and driver-specific objects are managed by their respective

Re: [RFC 1/2] Input: ff, add FF_RAW effect

2007-04-19 Thread Dmitry Torokhov
On 4/19/07, Jiri Slaby [EMAIL PROTECTED] wrote: Dmitry Torokhov napsal(a): I have been thinking about this and I don't think that exporting motor data is a good idea, at least not in case of Phantom driver. The fact that there are 3 motors is a hardware implementation detail

Re: [PATCH RFD] alternative kobject release wait mechanism

2007-04-19 Thread Dmitry Torokhov
On 4/19/07, Alan Stern [EMAIL PROTECTED] wrote: On Wed, 18 Apr 2007, Dmitry Torokhov wrote: I am still do not understand why this is needed. Would it not be simplier just to use a reference to struct device instead of embedding it in a larger structure if their lifetimes are different

Re: [PATCH RFD] alternative kobject release wait mechanism

2007-04-20 Thread Dmitry Torokhov
On 4/20/07, Alan Stern [EMAIL PROTECTED] wrote: Dmitry, in thinking things over some more I realized there's going to be a problem with the autosuspend support in USB. It has to do with the way a driver needs to prevent (or block) suspends from occurring while it is actively using a device.

Re: Acecad USB Tablet: usbmouse takeover and odd motion

2007-04-20 Thread Dmitry Torokhov
On 4/20/07, Giuseppe Bilotta [EMAIL PROTECTED] wrote: Sorry, it seems I was wrong, it's not usbhid but usbmouse taking over. After a fresh plug (e.g. at bootup) I get the following: Well, the question is - why do you have usbmouse module on your system? -- Dmitry - To unsubscribe from this

Re: [PATCH RFD] alternative kobject release wait mechanism

2007-04-20 Thread Dmitry Torokhov
On 4/19/07, Alan Stern [EMAIL PROTECTED] wrote: Among the worst offenders are character devices. None of the subsystem providers offering char device registration performs immediate detach -- they are a lot like sysfs used to be. (In fact, they probably _can't_ provide it since read() or

Re: [PATCH RFD] alternative kobject release wait mechanism

2007-04-20 Thread Dmitry Torokhov
Hi Tejun, On 4/20/07, Tejun Heo [EMAIL PROTECTED] wrote: Hello, Dmitry. Dmitry Torokhov wrote: On 4/19/07, Cornelia Huck [EMAIL PROTECTED] wrote: On Thu, 19 Apr 2007 09:13:43 -0400, Dmitry Torokhov [EMAIL PROTECTED] wrote: Because they are managed by 2 different entities. the struct

Re: [PATCH RFD] alternative kobject release wait mechanism

2007-04-20 Thread Dmitry Torokhov
On 4/20/07, Tejun Heo [EMAIL PROTECTED] wrote: Hello, Dmitry. Dmitry Torokhov wrote: Many drivers (at least all the SCSI/IDE ones) consider struct device as the base class of the devices those drivers implement. I don't think we can just consider those drivers to be wrong. I am not saying

Re: Keyboard stops working after *lock [Was: 2.6.21-rc2-mm1]

2007-03-09 Thread Dmitry Torokhov
On 3/9/07, Jiri Slaby [EMAIL PROTECTED] wrote: Andrew Morton napsal(a): On Sat, 03 Mar 2007 16:54:45 +0100 Jiri Slaby [EMAIL PROTECTED] wrote: Jiri Slaby napsal(a): Andrew Morton napsal(a): Temporarily at http://userweb.kernel.org/~akpm/2.6.21-rc2-mm1/ Weird behaviour of numlock and

Re: [patch 1/3] Input: psmouse - create PS/2 protocol options for Kconfig

2007-03-09 Thread Dmitry Torokhov
On 3/9/07, Andres Salomon [EMAIL PROTECTED] wrote: I haven't seen patches in your tree; are you waiting for me to do the cleanups and resend? Still in my private tree; will try to push out over the weekend. -- Dmitry - To unsubscribe from this list: send the line unsubscribe linux-kernel in

Re: refcounting drivers' data structures used in sysfs buffers

2007-03-09 Thread Dmitry Torokhov
On 3/9/07, Oliver Neukum [EMAIL PROTECTED] wrote: Am Freitag, 9. März 2007 17:32 schrieb Alan Stern: On Fri, 9 Mar 2007, Oliver Neukum wrote: Am Donnerstag, 8. März 2007 17:02 schrieb Alan Stern: On Thu, 8 Mar 2007, Oliver Neukum wrote: Hi, after a lightning bolt from high

Re: refcounting drivers' data structures used in sysfs buffers

2007-03-09 Thread Dmitry Torokhov
On 3/9/07, Oliver Neukum [EMAIL PROTECTED] wrote: Am Freitag, 9. März 2007 18:02 schrieb Dmitry Torokhov: I think we already have all refcounting that is needed. What is missing is subsystem-provided -release() hooks for drivers to release driver-specific resources when a device finally goes

Re: Fix locking in mousedev

2007-03-09 Thread Dmitry Torokhov
Hi Pete, On 2/28/07, Pete Zaitcev [EMAIL PROTECTED] wrote: If a process is closing /dev/input/mice and an mouse disconnects simulta- neously, the system is likely to oops. This usually happens when someone hits AltCtrlF1 or logs out from X, and flips a KVM while the system is reacting. I

Re: Fix locking in mousedev

2007-03-09 Thread Dmitry Torokhov
On 3/9/07, Pete Zaitcev [EMAIL PROTECTED] wrote: On Fri, 9 Mar 2007 09:28:49 -0500, Dmitry Torokhov [EMAIL PROTECTED] wrote: On 2/28/07, Pete Zaitcev [EMAIL PROTECTED] wrote: Dmitry, please consider getting rid of the list of handles entirely. The other major user is drivers/char

[PATCH] Use attribute groups in struct device_type

2007-03-09 Thread Dmitry Torokhov
that they all cleaned up properly in case of errors. Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/base/core.c| 115 + include/linux/device.h |2 2 files changed, 70 insertions(+), 47 deletions(-) Index: work/drivers/base

Re: [PATCH] Use attribute groups in struct device_type

2007-03-09 Thread Dmitry Torokhov
On Saturday 10 March 2007 01:55, Greg KH wrote: On Fri, Mar 09, 2007 at 10:54:43PM -0800, Greg KH wrote: On Sat, Mar 10, 2007 at 01:37:34AM -0500, Dmitry Torokhov wrote: Greg, Please consider applying the patch below. It switches struct device_type to using attribute groups which

Re: refcounting drivers' data structures used in sysfs buffers

2007-03-12 Thread Dmitry Torokhov
On 3/12/07, Oliver Neukum [EMAIL PROTECTED] wrote: Am Montag, 12. März 2007 15:57 schrieb Alan Stern:probably nece On Mon, 12 Mar 2007, Oliver Neukum wrote: Why? What's wrong with simply calling kref_get/put? It's the same old problem: the race between unbind and sysfs I/O. What

Re: refcounting drivers' data structures used in sysfs buffers

2007-03-12 Thread Dmitry Torokhov
On 3/12/07, Alan Stern [EMAIL PROTECTED] wrote: On Mon, 12 Mar 2007, Oliver Neukum wrote: I don't like reverting my own code. But I predict he'll tell you that a driver's bond with a device should be represented in a data structure that is to be refcounted. :-) Coming to think

Re: 2.6.21-rc suspend regression: sysfs deadlock

2007-03-13 Thread Dmitry Torokhov
On 3/13/07, Hugh Dickins [EMAIL PROTECTED] wrote: On Tue, 13 Mar 2007, Alan Stern wrote: On the other hand, a quick survey of the kernel source shows that DEVICE_ATTR is used over 1500 times. Auditing all of them is not a job for the faint-of-heart! Indeed, and faint-hearted Hugh wasn't

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-14 Thread Dmitry Torokhov
Hi Eric, On 3/13/07, Eric Piel [EMAIL PROTECTED] wrote: Hello, As a sequel to my patch Wistron button support for TravelMate 610 of last week, here is a bigger addition of keymaps for the wistron_btns. Patch 1 adds all the database of acerhk which fits this driver (about 25 more laptops).

Re: FF layer restrictions [Was: [PATCH 1/1] Input: add sensable phantom driver]

2007-03-14 Thread Dmitry Torokhov
On 3/13/07, Jiri Slaby [EMAIL PROTECTED] wrote: Why did you remove all Cced people? Anyway I filtered some of them out johann deneux napsal(a): You are right, the direction in ff_effect is meant to be an angle. A dirty solution would be to use the 16 bits as two 8-bits angles. Or That would

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-14 Thread Dmitry Torokhov
On 3/14/07, Éric Piel [EMAIL PROTECTED] wrote: 03/14/2007 02:54 PM, Dmitry Torokhov wrote/a écrit: Hi Eric, : I have couple of comments/requests: 1. KEY_OPEN and KEY_CLOSE should not be used to signal state of the lid, they correspond to Accpication Control Open and Close keys from USB

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-14 Thread Dmitry Torokhov
On 3/14/07, Vojtech Pavlik [EMAIL PROTECTED] wrote: On Wed, Mar 14, 2007 at 09:54:27AM -0400, Dmitry Torokhov wrote: Hi Eric, On 3/13/07, Eric Piel [EMAIL PROTECTED] wrote: Hello, As a sequel to my patch Wistron button support for TravelMate 610 of last week, here is a bigger addition

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-14 Thread Dmitry Torokhov
On 3/14/07, Dmitry Torokhov [EMAIL PROTECTED] wrote: On 3/14/07, Vojtech Pavlik [EMAIL PROTECTED] wrote: On Wed, Mar 14, 2007 at 09:54:27AM -0400, Dmitry Torokhov wrote: Hi Eric, On 3/13/07, Eric Piel [EMAIL PROTECTED] wrote: Hello, As a sequel to my patch Wistron button support

Re: FF layer restrictions [Was: [PATCH 1/1] Input: add sensable phantom driver]

2007-03-14 Thread Dmitry Torokhov
On 3/14/07, STenyaK (Bruno González) [EMAIL PROTECTED] wrote: On 3/14/07, Anssi Hannula [EMAIL PROTECTED] wrote: Do we have any idea if there any users of FF out there? At least me :). I'm using it for wheel and joystick in modules for locally developped multiplatform virtual reality

Re: 2.6.21-rc suspend regression: sysfs deadlock

2007-03-15 Thread Dmitry Torokhov
On 3/15/07, Oliver Neukum [EMAIL PROTECTED] wrote: Am Donnerstag, 15. März 2007 13:31 schrieb Hugh Dickins: Quite apart from this mysterious other task, I don't understand access either. Perhaps defer would best capture the idea of another-task and maybe-delay? sysfs_defer_work(), struct

Re: [PATCH] Improve error recovery in serial mouse driver

2007-03-15 Thread Dmitry Torokhov
On Thursday 15 March 2007 15:16, Peter Osterlund wrote: If bytes get lost in the communication with a serial mouse using the MS protocol, the kernel driver could do a better job getting back in sync. The first byte in a packet has bit 6 set, and no other bytes have that bit set. Therefore, if

Re: USB Keyboard

2007-03-15 Thread Dmitry Torokhov
On 3/15/07, Jiri Kosina [EMAIL PROTECTED] wrote: (added linux-usb-devel@lists.sourceforge.net to CC) On Thu, 15 Mar 2007, linux-os (Dick Johnson) wrote: I have multiple AMD 64-bit servers in several configurations, with several different motherboards, which fail to recognize a USB keyboard

Re: [linux-usb-devel] USB Keyboard

2007-03-15 Thread Dmitry Torokhov
On 3/15/07, linux-os (Dick Johnson) [EMAIL PROTECTED] wrote: echo Loading uhci-hcd.ko module insmod /lib/uhci-hcd.ko echo Loading ehci-hcd.ko module insmod /lib/ehci-hcd.ko I don't see you loading OHCI and I thought AMD boxes used that flavor. echo Loading usbhid.ko module insmod

Re: New kernel mouse recognition problem

2007-03-16 Thread Dmitry Torokhov
Hi Victor, On Friday 16 March 2007 17:33, Victor Fernandes wrote: Dear kernel gurus, I have a long experience with linux but not at the kernel level, so my apologies if this post is not appropriate for the list, but it seemed to me to be the only possible one to post my question.

Re: [PATCH] input: extend EV_LED

2007-02-12 Thread Dmitry Torokhov
On 2/11/07, Németh Márton [EMAIL PROTECTED] wrote: Extend EV_LED handling code so that it can handle not only two states (on/off) but also others. For example a LED can blink using hardware acceleration. The code changed so that it is similar to the code at EV_SND. Hi, I am not sure we

Re: [patch 00/11] ANNOUNCE: Syslets, generic asynchronous system call support

2007-02-13 Thread Dmitry Torokhov
On 2/13/07, Alan [EMAIL PROTECTED] wrote: A syslet is executed opportunistically: i.e. the syslet subsystem assumes that the syslet will not block, and it will switch to a cachemiss kernel thread from the scheduler. This means that even a How is scheduler fairness maintained ? and what is

Re: [patch 00/11] ANNOUNCE: Syslets, generic asynchronous system call support

2007-02-13 Thread Dmitry Torokhov
Hi Ingo, On Tuesday 13 February 2007 15:39, Ingo Molnar wrote: * Dmitry Torokhov [EMAIL PROTECTED] wrote: What are the semantics of async sys_async_wait and async sys_async ? Ohh. OpenVMS lives forever ;) Me likeee ;) hm, i dont know OpenVMS - but googled around a bit for 'VMS

Re: [PATCH] input: extend EV_LED

2007-02-14 Thread Dmitry Torokhov
On 2/14/07, Németh Márton [EMAIL PROTECTED] wrote: Dmitry Torokhov [EMAIL PROTECTED] írta: On 2/11/07, Németh Márton [EMAIL PROTECTED] wrote: Extend EV_LED handling code so that it can handle not only two states (on/off) but also others. For example a LED can blink using hardware

Re: [PATCH 9/11] Panic delay fix

2007-02-15 Thread Dmitry Torokhov
On 2/14/07, Rusty Russell [EMAIL PROTECTED] wrote: On Mon, 2007-02-05 at 19:53 -0800, Zachary Amsden wrote: Failure to use real-time delay here causes the keyboard to become demonically possessed in the event of a kernel crash, with wildly blinking lights and unpredictable behavior. This has

Re: [PATCH] HIL: fix improper call of release_region v2

2007-02-15 Thread Dmitry Torokhov
On 2/15/07, Helge Deller [EMAIL PROTECTED] wrote: On Thursday 15 February 2007, Cyrill V. Gorcunov wrote: Thist patch prevents from improper call of release_region if the code has been compiled without CONFIG_HP300 support. Signed-off-by: Cyrill V. Gorcunov [EMAIL PROTECTED] Acked-by: Helge

Re: [patch 1/3] Input: psmouse - create PS/2 protocol options for Kconfig

2007-02-15 Thread Dmitry Torokhov
and TOUCHKIT protocol extensions the psmouse to be disabled during compilation. This will allow users save some memory when they certain that they will only use a certain type of mice. Signed-off-by: Andres Salomon [EMAIL PROTECTED] Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/input

Re: [PATCH] Add Cobalt button interface driver support

2007-02-15 Thread Dmitry Torokhov
On Thursday 15 February 2007 22:36, Yoichi Yuasa wrote: Hi, This patch adds support for the back panel buttons on Cobalt server. It's tested on the Cobalt Qube2. Hi, Thank you for your patch. Couple of comments: + + button++; + } + + mod_timer(buttons_timer,

Re: [patch 1/3] Input: psmouse - create PS/2 protocol options for Kconfig

2007-02-16 Thread Dmitry Torokhov
On 2/16/07, Andres Salomon [EMAIL PROTECTED] wrote: Dmitry Torokhov wrote: On Thursday 15 February 2007 20:30, Andrew Morton wrote: On Thu, 15 Feb 2007 19:55:29 -0500 Andres Salomon [EMAIL PROTECTED] wrote: [...] Perhaps a nicer implementation would be to have a separate .c file for each

Re: [PATCH] Add Cobalt button interface driver support

2007-02-16 Thread Dmitry Torokhov
On 2/16/07, Yoichi Yuasa [EMAIL PROTECTED] wrote: + +static int cobalt_buttons_open(struct inode *inode, struct file *file) +{ + buttons_timer.expires = jiffies + msecs_to_jiffies(BUTTONS_POLL_INTERVAL); + add_timer(buttons_timer); + + return nonseekable_open(inode, file); +

[git pull] Input patches for 2.6.20

2007-02-17 Thread Dmitry Torokhov
): Input: HIL - fix improper call to release_region() Dmitry Torokhov (5): Input: psmouse - properly reset mouse on shutdown/suspend Input: i8042 - let serio bus suspend ports Input: do not lock device when showing name, phys and uniq Input: hid-lgff - treat devices as joysticks

Re: [PATCH] platform: reorder platform_device_del

2007-02-18 Thread Dmitry Torokhov
Hi Jean, On Sunday 18 February 2007 15:30, Jean Delvare wrote: In platform_device_del(), we currently delete the device resources first, then we delete the device itself. This causes a (minor) bug to occur when one unregisters a platform device before unregistering its platform driver, and

Re: [PATCH] platform: reorder platform_device_del

2007-02-19 Thread Dmitry Torokhov
Hi Jean, On 2/19/07, Jean Delvare [EMAIL PROTECTED] wrote: Hi Dmitry, On Mon, 19 Feb 2007 01:05:30 -0500, Dmitry Torokhov wrote: On Sunday 18 February 2007 15:30, Jean Delvare wrote: In platform_device_del(), we currently delete the device resources first, then we delete the device itself

Re: New kernel mouse recognition problem

2007-03-19 Thread Dmitry Torokhov
Hi Victor, On Saturday 17 March 2007 13:06, Victor Fernandes wrote: Dmitry, Thanks for you feedback, sorry for the delay on my reply but because I'm not subscribe to the list, only now I saw your message. I hope you will be able to see that this message is a follow up on the previous ones.

Re: [patch 29/31] Input: i8042 - fix AUX IRQ delivery check

2007-03-19 Thread Dmitry Torokhov
On 3/19/07, Greg KH [EMAIL PROTECTED] wrote: -stable review patch. If anyone has any objections, please let us know. -- From: Dmitry Torokhov [EMAIL PROTECTED] Input: i8042 - fix AUX IRQ delivery check On boxes that do not implement AUX LOOP command we can not verify AUX IRQ

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-19 Thread Dmitry Torokhov
On 3/15/07, Éric Piel [EMAIL PROTECTED] wrote: 03/14/2007 08:02 PM, Vojtech Pavlik wrote/a écrit: On Wed, Mar 14, 2007 at 02:58:49PM -0400, Dmitry Torokhov wrote: 2. I also have a concern about using KEY_SCREEN to signal toggling display on and off. I am CCing Vojtech - he must know what

Re: strange keyboard lag after suspend testing

2007-03-20 Thread Dmitry Torokhov
On 3/20/07, Pavel Machek [EMAIL PROTECTED] wrote: Hi! I was testing suspend in 2.6.21-rc4 a lot, and now... machine feels like someone added 50..100msec delay somewhere in keyboard handling. Mouse does not seem affected. /proc/interrupts seem to increase as they should, for both

Re: FF layer restrictions [Was: [PATCH 1/1] Input: add sensable phantom driver]

2007-03-21 Thread Dmitry Torokhov
On 3/21/07, johann deneux [EMAIL PROTECTED] wrote: On 3/21/07, Jiri Slaby [EMAIL PROTECTED] wrote: STenyaK (Bruno González) napsal(a): On 3/14/07, Dmitry Torokhov [EMAIL PROTECTED] wrote: I have a question: if the force is to be 3D, why only 3 possible values? What would they be, 3

Re: [PATCH] Apple SMC driver (hardware monitoring and control)

2007-03-22 Thread Dmitry Torokhov
Hi Nicolas, On Monday 19 March 2007 01:19, Nicolas Boichat wrote: +   /* initialize the input class */ +   applesmc_idev-name = applesmc; You may want to set applesmc_idev-id.bus = BUS_HOST; +   applesmc_idev-cdev.dev = pdev-dev; +   applesmc_idev-evbit[0] = BIT(EV_ABS); +  

Re: FF layer restrictions [Was: [PATCH 1/1] Input: add sensable phantom driver]

2007-03-22 Thread Dmitry Torokhov
On Wednesday 21 March 2007 18:03, johann deneux wrote: On 3/21/07, Jiri Slaby [EMAIL PROTECTED] wrote: Dmitry Torokhov napsal(a): On 3/21/07, johann deneux [EMAIL PROTECTED] wrote: I would suggest adding a new effect type (3d effect) and extending the union in struct ff_effect. Let

Re: [PATCH 2.6.21-rc4] hwmon: HP Mobile Data Protection System 3D ACPI driver

2007-03-23 Thread Dmitry Torokhov
Hi Yan, On 3/23/07, Yan Burman [EMAIL PROTECTED] wrote: + +static unsigned int input_3d; +module_param(input_3d, bool, S_IRUGO); +MODULE_PARM_DESC(input_3d, Operate as a 3D joystick instead of 2D); Why do you need that? Just have the driver always report all 3 events and have applications

Re: keyboard.c: Stop flooding dmesg with useless warnings

2007-03-24 Thread Dmitry Torokhov
On Saturday 24 March 2007 23:38, Parag Warudkar wrote: Signed-off-by: Parag Warudkar [EMAIL PROTECTED] --- linux-2.6-wk/drivers/char/keyboard.c2007-03-24 23:01:19.0 -0400 +++ linux-2.6/drivers/char/keyboard.c 2007-03-24 21:43:58.0 -0400 @@ -1161,7

Re: keyboard.c: Stop flooding dmesg with useless warnings

2007-03-24 Thread Dmitry Torokhov
On Sunday 25 March 2007 01:27, Parag Warudkar wrote: Actually the keyboard driver should not emit input events for that key code. Is this a USB keyboard? -- Dmitry Yes this is a USB keyboard. Any hint as to where I should start looking to make the driver not emit input event

Re: chrdev_open lifetime question

2007-03-24 Thread Dmitry Torokhov
Hi Pete, On Monday 19 March 2007 21:02, Pete Zaitcev wrote: On Wed, 7 Mar 2007 17:23:05 -0500, Dmitry Torokhov [EMAIL PROTECTED] wrote: It seems that if a process keeps a character device open then other processes will also be able to get into filp-f_op-open(inode,filp) in chrdev_open

Re: [PATCH] INPUT: Delete unused source file drivers/input/power.c.

2007-03-25 Thread Dmitry Torokhov
On Sunday 25 March 2007 18:39, Andrew Morton wrote: On Sun, 25 Mar 2007 16:28:39 -0400 (EDT) Robert P. J. Day [EMAIL PROTECTED] wrote: Delete the never-compiled source file drivers/input/power.c, and remove its entry from the corresponding Makefile, as there is no Kconfig file that

Re: [PATCH] Use attribute groups in struct device_type

2007-03-25 Thread Dmitry Torokhov
Hi Greg, On Saturday 10 March 2007 02:22, Greg KH wrote: On Sat, Mar 10, 2007 at 02:12:04AM -0500, Dmitry Torokhov wrote: On Saturday 10 March 2007 01:55, Greg KH wrote: On Fri, Mar 09, 2007 at 10:54:43PM -0800, Greg KH wrote: On Sat, Mar 10, 2007 at 01:37:34AM -0500, Dmitry Torokhov

Re: Fix sudden warps in mousedev

2007-03-25 Thread Dmitry Torokhov
On Sunday 25 March 2007 14:19, Pete Zaitcev wrote: On Sun, 25 Mar 2007 01:34:02 -0400, Dmitry Torokhov [EMAIL PROTECTED] wrote: +    * Without this, a touchpad may report an unchanged position, +    * then a sync. The input_event() eats the position report

Re: Fix sudden warps in mousedev

2007-03-26 Thread Dmitry Torokhov
On 3/26/07, Pete Zaitcev [EMAIL PROTECTED] wrote: On Sun, 25 Mar 2007 23:19:38 -0400, Dmitry Torokhov [EMAIL PROTECTED] wrote: I tried to reproduce warping on console but could not for some reason. Could you please try the patch below and tell me if it fixes the problem for you? +++ work

Re: Fix sudden warps in mousedev

2007-03-26 Thread Dmitry Torokhov
On Monday 26 March 2007 17:42, Pete Zaitcev wrote: On Mon, 26 Mar 2007 15:30:42 -0400, Dmitry Torokhov [EMAIL PROTECTED] wrote: Regarding the synaptics driver and scroll problem. Yesterday I scrolled twice through entire Remarque's Spark of Life off lib.ru (once with 0.14.2 and once

Re: [PATCH] Correct bad CONFIG names in drivers/usb/input/Makefile.

2007-03-26 Thread Dmitry Torokhov
away. -- Dmitry Input: remove old USB touchscreen drivers itmtoch, mtouchusb and touchkitusb have been replaced with composite usbtouchscreen driver and can be removed now. Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/usb/input/itmtouch.c| 271

Re: [PATCH 0/3] wistron_btns: More keymaps, take 2

2007-03-26 Thread Dmitry Torokhov
On Sunday 18 March 2007 17:10, Éric Piel wrote: Hello, This is a new version of my patch to add support for more laptops to the wistron_btns driver. Modifications from the previous version: * sends lid close/open event as a switch event (not a key event) * Display on/off is KEY_SCREEN and

Re: Linux 2.6.21-rc5

2007-03-27 Thread Dmitry Torokhov
On 3/27/07, Andrew Morton [EMAIL PROTECTED] wrote: I have a few fixes here which belong to subsystem trees, which were missed by the maintainers and which we probably want to get into 2.6.21.

Re: usb hid: reset NumLock

2007-04-05 Thread Dmitry Torokhov
On 4/5/07, Pete Zaitcev [EMAIL PROTECTED] wrote: On a certain keyboard, when BIOS sets NumLock LED on, it survives the takeover by Linux and thus confuses users. Eating of an increasibly scarce quirk bit is unfortunate. We do it for safety, given the history of nervous input devices which crash

Re: usb touchscreen breakage in 2.6.21-rc5-mm4 ?

2007-04-06 Thread Dmitry Torokhov
On Friday 06 April 2007 20:54, Helge Hafting wrote: I have an usb touchscreen (egalax variety) that works with the 2.6.18 kernel supplied by debian. It fails when I compile 2.6.21-rc5-mm4, tuned to the machine in question. Unlike the debian kernel, this kernel don't use modules in order

Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

2007-04-08 Thread Dmitry Torokhov
On Friday 06 April 2007 18:57, David Brownell wrote: On Friday 06 April 2007 3:17 pm, Thomas Gleixner wrote: David, http://tglx.de/private/tglx/usbnet.png /me recommends emacs-develock.el for colorful white space wreckage display ! Then I'd have to switch to EMACS ... no thanks!  

Re: Fw: Re: + add-locking-to-evdev.patch added to -mm tree

2007-04-09 Thread Dmitry Torokhov
Hi Paul, On 4/8/07, Paul E. McKenney [EMAIL PROTECTED] wrote: On Fri, Mar 30, 2007 at 02:06:05PM -0700, [EMAIL PROTECTED] wrote: Input: evdev - implement proper locking OK, so I have to ask -- this is protecting multiple clients of a given mouse or keyboard, right? Doesn't look like it has

Re: [PATCH] Apple SMC driver - fix input device

2007-04-09 Thread Dmitry Torokhov
on input device. - Only activate the input device polling timer when the device is open. - Others minor fixes asked by Dmitry Torokhov. Signed-off-by: Nicolas Boichat [EMAIL PROTECTED] You may add: Acked-by: Dmitry Torokhov [EMAIL PROTECTED] -- Dmitry - To unsubscribe from this list: send

Re: [PATCH] Apple SMC driver - fix input device

2007-04-09 Thread Dmitry Torokhov
device polling timer when the device is open. - Others minor fixes asked by Dmitry Torokhov. Signed-off-by: Nicolas Boichat [EMAIL PROTECTED] Thanks. I've been assuming that this patch will go via Jean, since it is in drivers/hwmon/applesmc.c. But perhaps that is inappropriate, and it is more

Re: usb touchscreen breakage in 2.6.21-rc5-mm4 ?

2007-04-09 Thread Dmitry Torokhov
On Monday 09 April 2007 18:36, Helge Hafting wrote: On Fri, Apr 06, 2007 at 10:37:12PM -0400, Dmitry Torokhov wrote: On Friday 06 April 2007 20:54, Helge Hafting wrote: I have an usb touchscreen (egalax variety) that works with the 2.6.18 kernel supplied by debian. It fails when I

Re: Linux 2.6.21-rc6

2007-04-09 Thread Dmitry Torokhov
On Sunday 08 April 2007 19:09, Andrew Morton wrote: driver core: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc6/2.6.21-rc6-mm1/broken-out/update-documentation-driver-model-platformtxt.patch We should not encourage using platform_device_register_simple as we want to

Re: [PATCH] Make ati_remote button repeat sensitivity soft-configurable (V2)

2007-04-09 Thread Dmitry Torokhov
On Thursday 05 April 2007 10:23, Karl Pickett wrote: Dmitry, please use this instead of my previous patch.  Thanks to Vincent for the code review , fixes, and testing. Applied to the input tree; thank you Karl and Vincent. -- Dmitry - To unsubscribe from this list: send the line unsubscribe

Re: usb touchscreen breakage in 2.6.21-rc5-mm4 ?

2007-04-10 Thread Dmitry Torokhov
On 4/10/07, Helge Hafting [EMAIL PROTECTED] wrote: Dmitry Torokhov wrote: Hmm, I am concerned because not only you don't have an input device created, you don't even see the driver being registered with usbcore. Could you please try booting with debug_initcall to see with what error code

Re: usb touchscreen breakage in 2.6.21-rc5-mm4 ?

2007-04-11 Thread Dmitry Torokhov
On 4/11/07, Helge Hafting [EMAIL PROTECTED] wrote: Dmitry Torokhov wrote: *sigh* When will I learn to spell names of kernel parameters correctly? It is initcall_debug, not debug_initcall :( Could you try again, please? Here is the dmesg for rc5mm4 with initcall_debug, showing how no usbtouch

Re: i8042 lockdep false positive.

2007-04-13 Thread Dmitry Torokhov
Hi Dave, On 4/13/07, Dave Jones [EMAIL PROTECTED] wrote: I just had a user file the report below, which iirc, was deemed a false positive. Didn't we add something to the code so that lockdep would ignore what this was doing ? Did we regress? For some reasn lockdep annotations cease to work

Re: i8042 lockdep false positive.

2007-04-13 Thread Dmitry Torokhov
On 4/13/07, Dave Jones [EMAIL PROTECTED] wrote: On Fri, Apr 13, 2007 at 03:18:32PM -0400, Dmitry Torokhov wrote: Hi Dave, On 4/13/07, Dave Jones [EMAIL PROTECTED] wrote: I just had a user file the report below, which iirc, was deemed a false positive. Didn't we add something

Re: [lm-sensors] Hardware monitoring subsystem maintainer positionis open

2007-04-14 Thread Dmitry Torokhov
Hi, On Thursday 12 April 2007 03:27, Hans de Goede wrote: Krzysztof Helt wrote: * Must follow kernel coding style guidelines Is there any tool to check this? If there is one, a basic instruction how to use it would be great. No tool. Passing new drivres through scripts/Lindent

Re: Linux 2.6.21-rc6

2007-04-15 Thread Dmitry Torokhov
On Sunday 15 April 2007 07:16, Rafael J. Wysocki wrote: On Sunday, 15 April 2007 10:02, Tobias Diedrich wrote: With CONFIG_PM_DEBUG=y and CONFIG_DISABLE_CONSOLE_SUSPEND=y I see that the second suspend hangs at i8042 i8042: EARLY resume. This is kinda interesting because I'm normally

Re: Network: convert network devices to use struct device instead of class_device

2007-02-20 Thread Dmitry Torokhov
On 2/8/07, Greg KH [EMAIL PROTECTED] wrote: And it should also alow for proper power management functionality, using the changes that Linus put into the driver core about 8 months ago. Don't worry, I have input patches queued up next for you Dmitry :) Greg, Could you please forward me

Re: Re: Phis in /proc/bus/input/devices same for all devices?

2007-02-21 Thread Dmitry Torokhov
On 2/21/07, CIJOML [EMAIL PROTECTED] wrote: Hi, can anybody reply to this and share his/her opinion? Input core already exports uniq to udev and also via sysfs. -- Dmitry - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED]

Re: Re: Phis in /proc/bus/input/devices same for all devices?

2007-02-21 Thread Dmitry Torokhov
On 2/21/07, Marcel Holtmann [EMAIL PROTECTED] wrote: Hi Dmitry, can anybody reply to this and share his/her opinion? Input core already exports uniq to udev and also via sysfs. so do you think it would be better to create phys as a string of the source and destination address like src-dst

Re: Re: Phis in /proc/bus/input/devices same for all devices?

2007-02-22 Thread Dmitry Torokhov
Hi Marcel, On 2/21/07, Marcel Holtmann [EMAIL PROTECTED] wrote: Hi Dmitry, can anybody reply to this and share his/her opinion? Input core already exports uniq to udev and also via sysfs. so do you think it would be better to create phys as a string of the source and

Re: 2.6.21rc1 git usb mouse stops working after resume from ram

2007-02-22 Thread Dmitry Torokhov
On 2/21/07, Arkadiusz Miskiewicz [EMAIL PROTECTED] wrote: # # USB HID Boot Protocol drivers # CONFIG_USB_KBD=m CONFIG_USB_MOUSE=m Please do not enable USB boot protocol drivers unless generic HID driver is not working for you. -- Dmitry - To unsubscribe from this list: send the line

Re: BUG: 2.6.20 atkbd spams console after kernel panic

2007-02-22 Thread Dmitry Torokhov
On 2/22/07, Mark Lord [EMAIL PROTECTED] wrote: The kernel panic is my fault, but I'd still like to see the on-screen messages when it happens. Unfortunately, 2.6.20 atkbd.c continuously spams the console after a kernel panic (my fault), with these messages: ... kernel panic - not syncing: VFS:

Re: input.c: start on release

2007-02-23 Thread Dmitry Torokhov
On 2/23/07, Pete Zaitcev [EMAIL PROTECTED] wrote: Here's a curious code I found in drivers/input/input.c (2.6.21-rc1): void input_release_device(struct input_handle *handle) { if (handle-handler-start) handle-handler-start(handle); } Is the above supposed to be this

Re: [KJ][RFC][PATCH] BIT macro cleanup

2007-02-23 Thread Dmitry Torokhov
On 2/23/07, Richard Knutsson [EMAIL PROTECTED] wrote: Milind Choudhary wrote: On 2/23/07, Richard Knutsson [EMAIL PROTECTED] wrote: +#define BITWRAP(nr)(1UL ((nr) % BITS_PER_LONG)) make the whole input subsystem use it The change is huge, more than 125 files using input.h

Re: [KJ][RFC][PATCH] BIT macro cleanup

2007-02-23 Thread Dmitry Torokhov
On 2/23/07, Richard Knutsson [EMAIL PROTECTED] wrote: Dmitry Torokhov wrote: On 2/23/07, Richard Knutsson [EMAIL PROTECTED] wrote: Milind Choudhary wrote: On 2/23/07, Richard Knutsson [EMAIL PROTECTED] wrote: +#define BITWRAP(nr)(1UL ((nr) % BITS_PER_LONG)) make the whole

Re: [KJ][RFC][PATCH] BIT macro cleanup

2007-02-23 Thread Dmitry Torokhov
On 2/23/07, Richard Knutsson [EMAIL PROTECTED] wrote: Dmitry Torokhov wrote: I was not talking about name (I hate BITWRAP) but behavior. Oh, my bad :) but mainly since it only enables wrapping of the long-type. I'd provde BIT and separate LLBIT for ones who really need long long. People

Re: [KJ][RFC][PATCH] BIT macro cleanup

2007-02-23 Thread Dmitry Torokhov
On 2/23/07, Richard Knutsson [EMAIL PROTECTED] wrote: Dmitry Torokhov wrote: Hm, I thought as was clear, but apparently I messed up explaining my position: 1. I don't like BITWRAP name at all and I don't want anything like that near input code. I think BIT is just fine. Oh, I think I

Re: input.c: start on release

2007-02-24 Thread Dmitry Torokhov
On Friday 23 February 2007 19:44, Pete Zaitcev wrote: On Fri, 23 Feb 2007 10:06:14 -0500, Dmitry Torokhov [EMAIL PROTECTED] wrote: On 2/23/07, Pete Zaitcev [EMAIL PROTECTED] wrote: void input_release_device(struct input_handle *handle) { if (handle-handler-start

  1   2   3   4   5   6   7   8   9   10   >