from synchronization of processing with
the timer interrupt used to calculate the load.
- Did anybody encounter this problem?
- Know any solutions?
- Recommend any specific solution?
Many thanks,
Gilad.
--
Gilad Ben-Yossef [EMAIL PROTECTED]
http://benyossef.com :: +972(54)756701
"Anything tha
/lists/linux-mm/msg33860.html and disabling the
part that sends IPI to update cputime for nohz/cpuset CPUs.
Thanks,
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
gi...@benyossef.com
Israel Cell: +972-52-8260388
US Cell: +1-973-8260388
http://benyossef.com
If you take a class in large-scale
() through the slow path using TIF_NOHZ flag.
+ Exceptions handlers must be wrapped as well. Irqs are already
+ protected inside rcu_irq_enter/rcu_irq_exit() but preemption or
+ signal handling on irq exit still need to be protected.
Thanks,
Gilad
--
Gilad Ben-Yossef
Chief
of its good and
behavior performance on real hardware; so for what it's worth:
Tested-by: Gilad Ben-Yossef gi...@benyossef.com
Cheers,
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
gi...@benyossef.com
Israel Cell: +972-52-8260388
US Cell: +1-973-8260388
http://benyossef.com
If you take a class
marked for deletion
the minute a version of the relevant user tools exists that can be
used with the new mechanisms?
Just my 2c as an Arc kernel port user,
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
gi...@benyossef.com
Israel Cell: +972-52-8260388
US Cell: +1-973-8260388
http://benyossef.com
Hi,
[ Sorry for dropping LKML on my previous email. It was caused by
replying from my smartphone. Adding everyone back now ]
On Thu, Apr 4, 2013 at 9:23 PM, Christoph Lameter c...@linux.com wrote:
On Thu, 4 Apr 2013, Gilad Ben-Yossef wrote:
The vmstat work item leaving a timer running
just to change a config knob...
Thanks,
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
gi...@benyossef.com
Israel Cell: +972-52-8260388
US Cell: +1-973-8260388
http://benyossef.com
If you take a class in large-scale robotics, can you end up in a situation
where the homework eats your dog
On Mon, Apr 8, 2013 at 8:28 PM, Cody P Schafer c...@linux.vnet.ibm.com wrote:
On 04/08/2013 05:20 AM, Gilad Ben-Yossef wrote:
On Fri, Apr 5, 2013 at 11:33 PM, Cody P Schafer c...@linux.vnet.ibm.com
wrote:
In free_hot_cold_page(), we rely on pcp-batch remaining stable.
Updating it without
On Tue, Apr 9, 2013 at 9:03 AM, Gilad Ben-Yossef gi...@benyossef.com wrote:
I also wonder whether there could be unexpected interactions between -high
and -batch not changing together atomically. For example, could adjusting
this knob cause -batch to rise enough that it is greater than
.
Suggested by Gilad Ben-Yossef gi...@benyossef.com in this thread:
https://lkml.org/lkml/2013/4/9/23
Also reproduces his proposed comment.
Signed-off-by: Cody P Schafer c...@linux.vnet.ibm.com
---
mm/page_alloc.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/mm
On Wed, Apr 10, 2013 at 9:19 AM, Gilad Ben-Yossef gi...@benyossef.com wrote:
On Wed, Apr 10, 2013 at 2:28 AM, Cody P Schafer c...@linux.vnet.ibm.com
wrote:
In pageset_set_batch() and setup_pagelist_highmark(), ensure that batch
is always set to a safe value (1) prior to updating high
Add a sysctl knob to enable admin to hand pick the scapegoat cpu
that will perform the extra work of preiodically checking for
new VM activity on CPUs that have switched off their vmstat_update
work item schedling.
Signed-off-by: Gilad Ben-Yossef gi...@benyossef.com
CC: Christoph Lameter c
if VM activity is detected. The scapegoat CPU never stops its
vmstat_update work item instance.
Signed-off-by: Gilad Ben-Yossef gi...@benyossef.com
CC: Christoph Lameter c...@linux.com
CC: Paul E. McKenney paul...@linux.vnet.ibm.com
CC: linux-kernel@vger.kernel.org
CC: linux...@kvack.org
---
include
values
I know some people won't like this, but can we perhaps fold all these
into a single parameter, perhaps even the existing isolcpus?
Thanks,
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
gi...@benyossef.com
Israel Cell: +972-52-8260388
US Cell: +1-973-8260388
http://benyossef.com
If you take
better. So, for what it's worth -
Reviewed-by: Gilad Ben-Yossef gi...@benyossef.com
Thanks,
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
gi...@benyossef.com
Israel Cell: +972-52-8260388
US Cell: +1-973-8260388
http://benyossef.com
If you take a class in large-scale robotics, can you end up
Hi,
On Tue, Sep 10, 2013 at 9:47 AM, Mike Galbraith bitbuc...@online.de wrote:
On Tue, 2013-09-10 at 09:05 +0300, Gilad Ben-Yossef wrote:
Hi,
On Thu, Sep 5, 2013 at 11:07 PM, Christoph Lameter c...@linux.com wrote:
I am not sure how to call this kernel option but we need something
with
cpusets.
What if we re-did the implementation of isolcpu as creating an
cpuset with migration off as early as possible in the boot process, prior to
spawning init?
So basically, isolcpus becomes just a way to configure a cpuset early?
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
gi
.
Ok but you can change the affinity of a kthread from userspace, as
long as you define a cpu set that is among that kthread's cpus allowed.
There is also the problem of kernel threads registering timers. We
don't have a good way to migrate those yet, I believe.
Gilad
--
Gilad Ben-Yossef
Chief
to wait for the winter solstice :-)
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
gi...@benyossef.com
Israel Cell: +972-52-8260388
US Cell: +1-973-8260388
http://benyossef.com
If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?
-- Jean
statistics gathering produce
such a huge performance difference would be great. This is what we are
trying to do here.
Does it makes sense?
[*] To be honest it required one more patch, but this one or something
like is needed to get that one working, so...
Thanks,
Gilad
--
Gilad Ben-Yossef
--
Gilad Ben-Yossef
Chief Coffee Drinker
gi...@benyossef.com
Israel Cell: +972-52-8260388
US Cell: +1-973-8260388
http://benyossef.com
If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?
-- Jean-Baptiste Queru
--
To unsubscribe from this list
- can you explain a little what
you meant by this statement?
Is this statement because of the use of write back mode with ld/st to
or not related?
Thanks,
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
gi...@benyossef.com
Israel Cell: +972-52-8260388
US Cell: +1-973-8260388
http://benyossef.com
On Thu, Jun 20, 2013 at 5:05 PM, Christoph Lameter c...@linux.com wrote:
On Wed, 19 Jun 2013, Gilad Ben-Yossef wrote:
+static void vmstat_update(struct work_struct *w)
+{
+ int cpu, this_cpu = smp_processor_id();
+
+ if (unlikely(this_cpu == vmstat_monitor_cpu
as it
would get called via the IPI.
I would at least consider putting a test there to make sure IRQs
really are disabled when entering the function, otherwise the bugs
stemming from incorrect use can be tricky to catch.
Just my 0.2 BTC
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
gi
On Thu, Aug 8, 2013 at 5:59 PM, Christoph Lameter c...@gentwo.org wrote:
On Thu, 8 Aug 2013, Gilad Ben-Yossef wrote:
vmstat_update runs from the vmstat work queue item by the workqueue
kernel thread.
If this code is running, it means there are at least two schedulable tasks:
1
Hi Sasha and Kim,
I believe Kim is right and the WARN_ON_ONCE condition should be negated.
Furthermore, I'm pretty sure I'm the one to blame for this bug.
Good catch and thank you both.
(Un)fortunately, I'm in a vacation in an island resort in Thailand at
the moment and the beer is much better
Heo; Peter Zijlstra; Steven
Rostedt; Christoph Lameter; Gilad Ben Yossef; Linux API
Subject: Re: [PATCH 5/6] nohz: support PR_DATAPLANE_STRICT mode
On May 8, 2015 11:44 PM, Chris Metcalf cmetc...@ezchip.com wrote:
With QUIESCE mode, the task is in principle guaranteed not to be
interrupted
From: Mike Galbraith [mailto:umgwanakikb...@gmail.com]
Sent: Saturday, May 09, 2015 10:20 AM
To: Ingo Molnar
Cc: Andrew Morton; Chris Metcalf; Steven Rostedt; Gilad Ben Yossef; Ingo
Molnar; Peter Zijlstra; Rik van Riel; Tejun Heo; Frederic Weisbecker;
Thomas Gleixner; Paul E. McKenney
are possible
logical cores that don't happen to be active at the time, but could
hotplug up later on.
I hope this makes some sense.
Since the NPS-400 is not generally available yet I wouldn't worry too
much about stable kernel for now...
Thanks,
Gilad Ben-Yossef
--
Gilad Ben-Yossef
Chief
Hi Andy,
Thank for the feedback.
> From: Andy Lutomirski [mailto:l...@amacapital.net]
> Sent: Wednesday, October 21, 2015 9:53 PM
> To: Gilad Ben Yossef
> Cc: Chris Metcalf; Steven Rostedt; Ingo Molnar; Peter Zijlstra; Andrew
> Morton; Rik van Riel; Tejun Heo; Frederic Wei
> From: Frederic Weisbecker [mailto:fweis...@gmail.com]
> > This option also allows easy testing of nohz_full and task-isolation
> > modes to determine what functionality needs to be implemented,
> > and what possibly-spurious timer interrupts are scheduled when
> > the basic 1Hz tick has been
> From: Andy Lutomirski [mailto:l...@amacapital.net]
> Sent: Wednesday, October 21, 2015 4:43 AM
> To: Chris Metcalf
> Subject: Re: [PATCH v8 06/14] task_isolation: provide strict mode
> configurable signal
>
> On Tue, Oct 20, 2015 at 6:30 PM, Chris Metcalf
> wrote:
> > On
Ran into these two clean up / optimization opportunities while chasing
an unrelated bug.
Gilad Ben-Yossef (2):
scatterlist: reorder compound boolean expression
scatterlist: do not disable IRQs in sg_copy_buffer
lib/scatterlist.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions
s disabled IRQs") acknowledges disabling interrupts is no
longer needed for calls to kmap_atomic() and therefore unneeded for miter
ops either, so remove it from sg_copy_buffer().
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
lib/scatterlist.c | 4
1 file changed, 4 dele
Test the cheaper boolean expression with no side effects first.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
lib/scatterlist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/scatterlist.c b/lib/scatterlist.c
index 004fc70..393920f 100644
---
plain64, Qemu Virt platform
Arm64) and it works just fine.
Tested-by: Gilad Ben-Yossef <gi...@benyossef.com>
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
-- Jean-Baptiste Queru
On Thu, Jan 19, 2017 at 6:42 AM, Binoy Jayan <binoy.ja...@linaro.org> wrote:
> Hi Gilad,
>
> On 18 January 2017 at 20:51, Gilad Ben-Yossef <gi...@benyossef.com> wrote:
>> I have some review comments and a bug report -
>
> Thank you very much for testing this
sg_out,
Also, where do the scatterlist src2 and dst2 that you use
sg_set_page() get sg_init_table() called on?
I couldn't figure it out...
Last but not least, when performing the following sequence on Arm64
(on latest Qemu Virt platform) -
1. cryptsetup luksFormat fs3.img
2. cryptsetup open --type luk
On Wed, Mar 1, 2017 at 3:21 PM, Ondrej Mosnacek <omosn...@redhat.com> wrote:
> 2017-03-01 13:42 GMT+01:00 Gilad Ben-Yossef <gi...@benyossef.com>:
>
> Wouldn't adopting a bulk request API (something like what I tried to
> do here [1]) that allows users to supply
d potentially multiple
hardware implementations
and putting this in the crypto API domain is the way to abstract this
so you use the one
that works best of your platform.
Thanks,
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
-- Jean-Baptiste Queru
On Wed, Mar 1, 2017 at 11:29 AM, Milan Broz <gmazyl...@gmail.com> wrote:
>
> On 03/01/2017 09:30 AM, Gilad Ben-Yossef wrote:
> > On Tue, Feb 28, 2017 at 11:05 PM, Milan Broz <gmazyl...@gmail.com> wrote:
> >>
> >> On 02/22/2017 07:12 AM, Bino
w.
>
Good idea. I wanted to test the patch but alas it does not apply cleanly.
You seem to have a blank line at the end of files and other small
transgressions that makes checkpatch grumpy.
Also...
>
> Not-signed-off-by: Binoy Jayan <binoy.ja...@linaro.org>
What is Not-signed-off-by ? :-)
Thanks,
Gilad Ben-Yossef
time when a lot of concurrent file accesses are made to the
protected volume.
Move DM_VERITY to the asynchronous hash API.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Tested-by: Milan Broz <gmazyl...@gmail.com>
CC: Eric Biggers <ebigge...@gmail.com>
CC: Ondrej Mosnáček &l
On Tue, Apr 18, 2017 at 6:39 PM, Greg Kroah-Hartman
<gre...@linuxfoundation.org> wrote:
> On Tue, Apr 18, 2017 at 05:07:50PM +0300, Gilad Ben-Yossef wrote:
>> Arm TrustZone CryptoCell 700 is a family of cryptographic hardware
>> accelerators. It is supported by a long lived
t
> should be something like "arm,cryptocell-712-ree" (and each variant
> should have its own string).
Got it. Will change.
Thanks for the review even in this unconventional form :-) !
>
> I don't have documentation to hand to attempt to review the rest.
>
> I would appre
Add CryptoCell AEAD support
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/Kconfig |1 +
drivers/staging/ccree/Makefile |2 +-
drivers/staging/ccree/cc_crypto_ctx.h | 21 +
drivers/staging/ccree/ssi_aead.c
I work for Arm on maintaining the TrustZone CryptoCell driver.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 676c139..f21caa1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -
Add CryptoCell skcipher support
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/Kconfig |8 +
drivers/staging/ccree/Makefile |2 +-
drivers/staging/ccree/cc_crypto_ctx.h | 21 +
drivers/staging/ccree/ssi_buffer_mgr.c
Add FIPS mode support to CryptoCell driver
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/Kconfig |9 +
drivers/staging/ccree/Makefile |1 +
drivers/staging/ccree/ssi_aead.c|6 +
drivers/staging/ccree/ssi_ci
.
A Git repository based off of Linux 4.11-rc7 is also available at
https://github.com/gby/linux.git branch ccree_v2 for those inclined.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
CC: Binoy Jayan <binoy.ja...@linaro.org>
CC: Ofir Drang <ofir.dr...@arm.com>
CC: Stuar
Add TODO list for moving out of staging tree for ccree crypto driver
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/TODO | 28
1 file changed, 28 insertions(+)
create mode 100644 drivers/staging/ccree/TODO
diff --git a/d
This adds DT bindings for the Arm TrustZone CryptoCell cryptographic
accelerator IP.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
.../devicetree/bindings/crypto/arm-cryptocell.txt | 27 ++
1 file changed, 27 insertions(+)
create mode 100644
drivers/s
On Thu, Apr 20, 2017 at 4:30 PM, Greg Kroah-Hartman
<gre...@linuxfoundation.org> wrote:
> On Thu, Apr 20, 2017 at 04:12:54PM +0300, Gilad Ben-Yossef wrote:
>> Arm TrustZone CryptoCell 700 is a family of cryptographic hardware
>> accelerators. It is supported by a long lived
Add CryptoCell IV hardware generation support.
This patch adds the needed support to drive the HW but does not expose
the ability via the kernel crypto API yet.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/Makefile | 2 +-
drivers/staging
Add CryptoCell async. hash and HMAC support.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/Kconfig |6 +
drivers/staging/ccree/Makefile |2 +-
drivers/staging/ccree/cc_crypto_ctx.h | 22 +
drivers/staging/ccree/hash_defs.h
On Thu, Apr 20, 2017 at 4:33 PM, Greg Kroah-Hartman
<gre...@linuxfoundation.org> wrote:
> On Thu, Apr 20, 2017 at 04:12:55PM +0300, Gilad Ben-Yossef wrote:
>> +++ b/drivers/staging/ccree/bsp.h
>> @@ -0,0 +1,21 @@
>> +/*
>> + * Copyright (C) 2012-2
Hi Mark,
On Tue, Apr 18, 2017 at 6:13 PM, Mark Rutland <mark.rutl...@arm.com> wrote:
> Hi,
>
> On Tue, Apr 18, 2017 at 05:07:50PM +0300, Gilad Ben-Yossef wrote:
>> Arm TrustZone CryptoCell 700 is a family of cryptographic hardware
>> accelerators. It is supported by
.
A Git repository based off of Linux 4.11-rc7 is available at
https://github.com/gby/linux.git branch ccree.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
CC: Binoy Jayan <binoy.ja...@linaro.org>
CC: Ofir Drang <ofir.dr...@arm.com>
Gilad Ben-Yossef (4):
staging: add c
his fixed up.
This issue, along with some others pointed by reviewers, are fixed in
v3 of the patch set.
I will be happy if you choose to take it into the staging tree and
will continue to work to cut down the TODO list.
Thanks,
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
-- Jean-Baptiste Queru
.cocci
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Signed-off-by: Fengguang Wu <fengguang...@intel.com>
---
drivers/staging/ccree/ssi_sysfs.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ccree/ssi_sysfs.c
b/drivers/staging/ccree
Remove kbuild test robot reported NULL check for a struct field address.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Reported-by: kbuild test robot <fengguang...@intel.com>
---
drivers/staging/ccree/ssi_buffer_mgr.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
From: kbuild test robot <l...@intel.com>
drivers/staging/ccree/ssi_request_mgr.c:623:3-4: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Signed-off-by: Fengguang W
is probably not required"
and kfreeaddr.cocci by Julia Lawall.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
Signed-off-by: Fengguang Wu <fengguang...@intel.com>
---
drivers/staging/ccree/ssi_hash.c | 27 +-
From: kbuild test robot <l...@intel.com>
drivers/staging/ccree/ssi_driver.c:484:6-11: No need to set .owner here. The
core will do it.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Signed-off-by: Gil
I work for Arm on maintaining the TrustZone CryptoCell driver.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 676c139..f21caa1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -
values.
NULL check before some freeing functions is not needed.
Based on checkpatch warning
"kfree(NULL) is safe this check is probably not required"
and kfreeaddr.cocci by Julia Lawall.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
Signed-off-by: Gilad Ben-Yossef <gi...@be
t; really necessary to implement a special case for your driver?
>
>
No it isn't. What ever the behavior we need it should be added,
pending review of course, to the generic FIPS logic handling.
I do wonder if there is value in alternate behavior of stopping crypto
API on FIPS error rather than a panic though. I will try to get an
explanation why we do it this way.
Handling all these has been added to the driver staging TODO list and
will be handled before it matures into drivers/crypto/
Many thanks for the review!
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
-- Jean-Baptiste Queru
Add CryptoCell IV hardware generation support.
This patch adds the needed support to drive the HW but does not expose
the ability via the kernel crypto API yet.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/Makefile | 2 +-
drivers/staging
Add TODO list for moving out of staging tree for ccree crypto driver
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/TODO | 30 ++
1 file changed, 30 insertions(+)
create mode 100644 drivers/staging/ccree/TODO
diff --git a/d
.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
CC: Binoy Jayan <binoy.ja...@linaro.org>
CC: Ofir Drang <ofir.dr...@arm.com>
CC: Stuart Yoder <stuart.yo...@arm.com>
CC: Stephan Muller <smuel...@chronox.de>
Changes from v2:
- Fix stupid build error on i386 due
This adds DT bindings for the Arm TrustZone CryptoCell cryptographic
accelerator IP.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
.../devicetree/bindings/crypto/arm-cryptocell.txt | 27 ++
1 file changed, 27 insertions(+)
create mode 100644
drivers/s
Add FIPS mode support to CryptoCell driver
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/Kconfig |9 +
drivers/staging/ccree/Makefile |1 +
drivers/staging/ccree/ssi_aead.c|6 +
drivers/staging/ccree/ssi_ci
Add CryptoCell AEAD support
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/Kconfig |1 +
drivers/staging/ccree/Makefile |2 +-
drivers/staging/ccree/cc_crypto_ctx.h | 21 +
drivers/staging/ccree/ssi_aead.c
On Sun, Apr 23, 2017 at 12:48 PM, Gilad Ben-Yossef <gi...@benyossef.com> wrote:
> Hi,
>
> Thank you for the review.
>
> On Thu, Apr 20, 2017 at 4:39 PM, Stephan Müller <smuel...@chronox.de> wrote:
>
>>> +/* The function verifies that td
On Mon, Apr 24, 2017 at 9:16 AM, Stephan Müller <smuel...@chronox.de> wrote:
> Am Montag, 24. April 2017, 08:06:09 CEST schrieb Gilad Ben-Yossef:
>
> Hi Gilad,
>>
>> Well, it turns out there is and we do :-)
>>
>> This is from crypto/des_generic.c:
>&g
this function in the past, see [1].
>
> [1] https://patchwork.kernel.org/patch/8293441/
>
Thanks, I was not aware of that.
I guess we could change the function to indicate that a key is valid
for decryption but not encryption
and have the implementation limiting based on that if there is an
Add CryptoCell skcipher support
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/Kconfig |8 +
drivers/staging/ccree/Makefile |2 +-
drivers/staging/ccree/cc_crypto_ctx.h | 21 +
drivers/staging/ccree/ssi_buffer_mgr.c
Add CryptoCell async. hash and HMAC support.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/Kconfig |6 +
drivers/staging/ccree/Makefile |2 +-
drivers/staging/ccree/cc_crypto_ctx.h | 22 +
drivers/staging/ccree/hash_defs.h
On Wed, Mar 1, 2017 at 5:38 PM, Milan Broz <gmazyl...@gmail.com> wrote:
>
> On 03/01/2017 02:04 PM, Milan Broz wrote:
>> On 03/01/2017 01:42 PM, Gilad Ben-Yossef wrote:
>> ...
>>
>>> I can certainly understand if you don't wont to take the patch until
>&
Clean up comments: fix style, trim long lines and remove useless ones.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/ssi_aead.c| 40 +
drivers/staging/ccree/ssi_aead.h| 47 ++---
drivers/s
Fix source line indentation and breaks in ssi_aead.c
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/ssi_aead.c | 1024 --
1 file changed, 532 insertions(+), 492 deletions(-)
diff --git a/drivers/staging/ccree/ssi_ae
Put struct init braces on line of it's own.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/ssi_hash.c | 32
1 file changed, 24 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/ccree/ssi_hash.c b/drivers/staging
Replace BUG() macro usage that crash the kernel with alternatives
that signal error and/or try to recover.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/ssi_buffer_mgr.c | 14 ++
drivers/staging/ccree/ssi_cipher.c | 1 -
drivers/staging
The crypto API requires saving the last blocks of ciphertext
in req->info for use as IV for CTS mode. The ccree driver
was not doing it and so failing tcrypt tests in some
situations. This patch fixes the issue.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/stag
Use BIT macro for bit definitions where needed.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/ssi_cipher.h | 10 +-
drivers/staging/ccree/ssi_driver.c | 3 ++-
drivers/staging/ccree/ssi_driver.h | 6 +++---
3 files changed, 10 insertions
Fix multiple code indentation issues.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/ssi_buffer_mgr.c | 23 ---
drivers/staging/ccree/ssi_cipher.c | 2 +-
drivers/staging/ccree/ssi_sysfs.c | 4 +++-
3 files changed, 16 inse
Replace noop macro with a noop inline function
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/ssi_driver.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ccree/ssi_driver.h
b/drivers/staging/ccree/ssi_driver.h
Fix source line indentation and breaks
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/ssi_hash.c | 494 ++-
1 file changed, 284 insertions(+), 210 deletions(-)
diff --git a/drivers/staging/ccree/ssi_hash.c b/drivers/s
M32R requires special handling due due to how it has implemented
ioread32. It is also an orphaned arch on Linux and doesn't seem
to be worth the trouble. So until we have a real user, remove
support for it.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/K
ltiple uses of %pad
Signed-off-by: Joe Perches <j...@perches.com>
[ gby: rebase on top of latest changes ]
Acked-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/ssi_aead.c| 8
drivers/staging/ccree/ssi_buffer_mgr.c | 29 +--
Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/ssi_aead.c | 3 +-
drivers/staging/ccree/ssi_cipher.c | 3 +-
drivers/staging/ccree/ssi_driver.c | 102 -
drivers/staging/ccree/ssi_hash.c | 3 +-
4 files changed, 59 inser
Fix wrong indentation and line breaks, including missing tabs,
breaking lines longer then 80 char or wrongly broken.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/ssi_driver.c | 107 +++--
1 file changed, 67 insertions(
stered variable from driver probe as it seems
redundant.
(e) free_irq is not required any more, devm_request_irq() free's it
on driver detach.
(f) adjust log messages accordingly and remove any blank lines.
Signed-off-by: Suniel Mahesh <suni...@techveda.org>
Acked-by: Gilad Ben-Yossef <gi..
zalloc() is
automatically freed on driver detach, otherwise it leads to a double
free.
(c) remove unnecessary blank lines.
Signed-off-by: Suniel Mahesh <suni...@techveda.org>
[gby: rebase on top of latest coding style fixes changes]
Acked-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
dri
Change places where we alloc memory by sizeof type to sizeof var.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/ssi_aead.c| 4 ++--
drivers/staging/ccree/ssi_cipher.c | 4 ++--
drivers/staging/ccree/ssi_driver.c | 2 +-
drivers/staging
source() releases and unmaps mem region on driver detach.
(d) adjust log messages accordingly and remove any blank lines.
Signed-off-by: Suniel Mahesh <suni...@techveda.org>
[gby: rebase on top of latest coding style fixes changes]
Acked-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
dri
Fix various spelling mistakes in comments.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/ssi_cipher.c | 2 +-
drivers/staging/ccree/ssi_hash.c| 2 +-
drivers/staging/ccree/ssi_hash.h| 2 +-
drivers/staging/ccree/ssi_ivgen.c
Fix indentation in first comment.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/ssi_hash.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/ccree/ssi_hash.c b/drivers/staging/ccree/ssi_
Fix strings in log messages being split across lines and the resulting
alignment issues when being fixed.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/ssi_aead.c| 9 ++--
drivers/staging/ccree/ssi_buffer_mgr.c
icache_setup_completion is no longer used. Remove it.
Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
---
drivers/staging/ccree/ssi_driver.c | 2 --
drivers/staging/ccree/ssi_driver.h | 1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/staging/ccree/ssi_driver.c
b/drivers/s
1 - 100 of 1764 matches
Mail list logo