d, 9 insertions(+), 1 deletion(-)
I already have this queued.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
ixing up some of Mark's review comments in order to
re-submit the remainder.
> and should not conflict with this one
> (tested again on today's tree), but it may be nice anyway to have this
> in the regulator framework with the others.
> Mark, would you consider taking this one in your tree
egulator_init':
>
> Lee?
Better if you can send me the whole patch.
We're not paying by the Byte anymore. :)
I'll look into it.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this
ch. I'll fix it up properly by removing
the surplus guards.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a me
This is a skeleton DTS file which only enables serial. Just using
this simple file yields a terminal when booting u8540.
Signed-off-by: Lee Jones
---
arch/arm/boot/dts/u8540.dts | 36
1 file changed, 36 insertions(+)
create mode 100644 arch/arm/boot/dts
Until recently platform code took care of all MMCI level-shifting by
way of an ios_handler() call-back. Now it is the driver's responsibility
to handle. In order to so that we need to provide the VQMMC regulator
reference in Device Tree. This patch takes care of that.
Signed-off-by: Lee Jones
Ortiz
Signed-off-by: Lee Jones
---
drivers/mfd/db8500-prcmu.c | 40 +---
1 file changed, 21 insertions(+), 19 deletions(-)
diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
index 21f261b..1c4edbf8 100644
--- a/drivers/mfd/db8500-prcmu.c
The PRCMU's Tightly Coupled Data Memory on the DB8540 platform is
8kB larger than it's predecessor's. We need to reflect that in its
Device Tree. By re-specifying the address and size of the device
we effectively over-ride the previous values with more accurate
ones.
Signed-off-by: Lee Jones
supported by
all platforms into a common device structure and the remaining
ones into a platform specific one.
Cc: Samuel Ortiz
Signed-off-by: Lee Jones
---
drivers/mfd/db8500-prcmu.c | 45
1 file changed, 29 insertions(+), 16 deletions(-)
diff
If we attempt to use the existing u8500 of_dev_auxdata struct to boot
the u8540, we fail to obtain a console, due to a lack of DMA support
on the platform.
Signed-off-by: Lee Jones
---
arch/arm/mach-ux500/cpu-db8500.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions
When the thermal DT node was inserted a new PRCMU node was created;
however, one already exists in the Snowball DTS file. Here we
amalgamate the two into a single consolidated node.
Signed-off-by: Lee Jones
---
arch/arm/boot/dts/snowball.dts | 53 +++-
1
The Tightly Coupled Program Memory location is actually 32kB in
size, rather than the originally depicted 4kB.
Signed-off-by: Lee Jones
---
arch/arm/mach-ux500/devices-db8500.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-ux500/devices-db8500.c
b/arch
The Tightly Coupled Data Memory for the DB9540 is actually in the
same place as the DB8500's. This definition is just plain wrong.
Signed-off-by: Lee Jones
---
arch/arm/mach-ux500/include/mach/db8500-regs.h |1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-ux500/include/mach
GULATOR_REGISTERS;
> match = ab8500_regulator_match;
> - match_size = ARRAY_SIZE(ab8500_regulator_match)
> + match_size = ARRAY_SIZE(ab8500_regulator_match);
> }
>
> if (np) {
We already satisfy this requirement in:
"regulator: ab85
t; } else {
> regulator_info = ab8500_regulator_info;
> regulator_info_size = ARRAY_SIZE(ab8500_regulator_info);
Hmm... looks like a merge error, sorry for that.
Again is solved by the next patch in Mark's list:
"regulator: ab8500: Use a struct to select the good regulator
conf
On Wed, 03 Apr 2013, Linus Walleij wrote:
> On Wed, Apr 3, 2013 at 10:38 PM, Linus Walleij
> wrote:
> > On Tue, Apr 2, 2013 at 3:21 PM, Lee Jones wrote:
> >
> >> When the thermal DT node was inserted a new PRCMU node was created;
> >> however, one already e
This is a skeleton DTS file which only enables serial. Just using
this simple file yields a terminal when booting u8540.
Signed-off-by: Lee Jones
---
arch/arm/boot/dts/ccu8540.dts | 36
1 file changed, 36 insertions(+)
create mode 100644 arch/arm/boot/dts
The PRCMU's Tightly Coupled Data Memory on the DB8540 platform is
8kB larger than it's predecessor's. We need to reflect that in its
Device Tree. By re-specifying the address and size of the device
we effectively over-ride the previous values with more accurate
ones.
Signed-off-by: Lee Jones
Ortiz
Signed-off-by: Lee Jones
---
drivers/mfd/db8500-prcmu.c | 40 +---
1 file changed, 21 insertions(+), 19 deletions(-)
diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
index 21f261b..1c4edbf8 100644
--- a/drivers/mfd/db8500-prcmu.c
supported by
all platforms into a common device structure and the remaining
ones into a platform specific one.
Cc: Samuel Ortiz
Signed-off-by: Lee Jones
---
drivers/mfd/db8500-prcmu.c | 46 +---
1 file changed, 30 insertions(+), 16 deletions(-)
diff
On Thu, 04 Apr 2013, Lee Jones wrote:
> Currently we check to see if we obtained the Tightly Coupled Program
> Memory (TCPM) base and only execute the code within the check if we
> have it. It's more traditional to return early if we don't have it.
> This way we can flatten most of th
On Thu, 04 Apr 2013, Lee Jones wrote:
> The main aim for this cycle is to have the u8540 booting to a
> console. However, the u8540 doesn't support all of the u8500
> platform devices yet. After this stage is complete we can then
> fill in the inadequacies, such as specific c
On Wed, 03 Apr 2013, Linus Walleij wrote:
> On Tue, Apr 2, 2013 at 3:21 PM, Lee Jones wrote:
>
> > The main aim for this cycle is to have the u8540 booting to a
> > console. However, the u8540 doesn't support all of the u8500
> > platform devices yet. After this
Ortiz
Signed-off-by: Lee Jones
---
drivers/mfd/db8500-prcmu.c | 40 +---
1 file changed, 21 insertions(+), 19 deletions(-)
diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
index 21f261b..1c4edbf8 100644
--- a/drivers/mfd/db8500-prcmu.c
supported by
all platforms into a common device structure and the remaining
ones into a platform specific one.
Cc: Samuel Ortiz
Signed-off-by: Lee Jones
---
drivers/mfd/db8500-prcmu.c | 52
1 file changed, 33 insertions(+), 19 deletions(-)
diff
e *dev)
> mutex_unlock(>ab8500_gpadc_lock);
> return ret;
> }
> +#endif
>
> static int ab8500_gpadc_probe(struct platform_device *pdev)
> {
Looks sensible. I wonder why we haven't caught these before.
I guess we always enable PM_SLEEP.
Applied until Linus tells
spend(struct device *dev)
> {
Looks sensible. I wonder why we haven't caught these before.
I guess we always enable PM_SLEEP.
Applied until Linus tells me otherwise.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twi
0-core.c |2 ++
> 1 file changed, 2 insertions(+)
Looks fine to me. Applied, thanks.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe l
>
> Signed-off-by: Jingoo Han
> ---
> drivers/mfd/menelaus.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c
Applied, thanks.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open
| 10 +
> drivers/pinctrl/Makefile |1 +
> drivers/pinctrl/pinctrl-palmas.c | 1085
>
> include/linux/mfd/palmas.h | 35 +-
For the MFD stuff:
Acked-by: Lee Jones
> 5 fil
PIO is requested in _probe() of some device.
> > > Let's assume the GPIO number is in range of what LP3943 GPIO driver
> > provided.
> > > Then, gpio_request() will be failed because the GPIO is invalid at this
> > moment.
> > > If the device request again later, it will be OK
On Tue, 06 Aug 2013, Kukjin Kim wrote:
> On 07/25/13 00:09, Lee Jones wrote:
> >... for the sake of consistency and assumed convention.
> >
> >Cc: Kukjin Kim
> >Cc: linux-samsung-...@vger.kernel.org
> >Signed-off-by: Lee Jones
> >
> >diff --git a/arc
a forward declaration because now we call
> ab8500_regulator_is_enabled() in ab8500_regulator_set_mode().
> This change also makes the code better in readability by moving similar
> functions to one place.
>
> Signed-off-by: Axel Lin
Code looks good to me:
Acked-by: Lee
tage if both get_voltage get_voltage_sel are
> not implemented.
>
> Signed-off-by: Axel Lin
Nice simplification:
Acked-by: Lee Jones
> ---
> drivers/regulator/ab8500-ext.c | 16
> 1 file changed, 16 deletions(-)
>
> diff --git a/drivers/regula
tial status. The only benefit of keeping is_enabled flag is just save a
> register read when set_mode(). Remove is_enabled flag makes the code simpler.
>
> Signed-off-by: Axel Lin
Looks fine:
Acked-by: Lee Jones
> ---
> drivers/regulator/ab8500-ext.c | 14 +++---
&g
ay."
When you said you wanted the "whole thing" to go through Anton's Tree,
I thought that's what you meant?
> Anyway, I pulled this branch into mfd-next, with a tiny conflict.
Okay, that's good.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source softw
The pin names for DB8500 based platforms need to be moved out of
ux500 platform data and into the new proper location in include/
linux/platform_data/. This way we an reference them from other
external locations, such as the main DMA50 driver(s).
Signed-off-by: Lee Jones
---
arch/arm/mach-ux500
Signed-off-by: Lee Jones
---
arch/arm/mach-ux500/devices-db8500.c| 12
drivers/dma/ste_dma40.c | 19 ++-
include/linux/platform_data/dma-ste-dma40.h |4
3 files changed, 14 insertions(+), 21 deletions(-)
diff --git a/arch/arm
Signed-off-by: Lee Jones
---
arch/arm/mach-ux500/devices-db8500.c| 28 ---
drivers/dma/ste_dma40.c | 32 +--
include/linux/platform_data/dma-ste-dma40.h |4
3 files changed, 30 insertions(+), 34 deletions(-)
diff
Signed-off-by: Lee Jones
---
drivers/dma/ste_dma40.c |6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index ecca492..3543ea4 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -2471,16 +2471,10 @@ static int
There are various pieces of configuration which do not need to happen
until after a channel is allocated. Here we move some of these so they're
dealt with when it's time to configure the channel, rather than allocate
it.
Cc: Vinod Koul
Cc: Dan Williams
Cc: Per Forlin
Signed-off-by: Lee Jones
On Mon, 08 Apr 2013, Arnd Bergmann wrote:
> On Monday 08 April 2013, Lee Jones wrote:
> > The pin names for DB8500 based platforms need to be moved out of
> > ux500 platform data and into the new proper location in include/
> > linux/platform_data/. This way we an refe
Forlin
Signed-off-by: Lee Jones
---
drivers/dma/ste_dma40.c |6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index ecca492..3543ea4 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -2471,16 +2471,10 @@ static int
On Tue, 09 Apr 2013, Arnd Bergmann wrote:
> On Tuesday 09 April 2013, Lee Jones wrote:
> > According to the DMA documentation allocating a channel and configuring
> > it are two separate actions. By removing the configuration code from the
> > channel allocation path
On Tue, 09 Apr 2013, Samuel Ortiz wrote:
> Hi Lee,
>
> On Thu, Apr 04, 2013 at 11:39:00AM +0100, Lee Jones wrote:
> > Currently we check to see if we obtained the Tightly Coupled Program
> > Memory (TCPM) base and only execute the code within the check if we
> > hav
On Thu, 04 Apr 2013, Lee Jones wrote:
> The main aim for this cycle is to have the u8540 booting to a
> console. However, the u8540 doesn't support all of the u8500
> platform devices yet. After this stage is complete we can then
> fill in the inadequacies, such as specific c
channel, not whether the
function is called or not.
Signed-off-by: Lee Jones
---
drivers/dma/ste_dma40.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index 9e423ad..49d8c9d 100644
--- a/drivers/dma/ste_dma40.c
+++ b
There are various pieces of configuration which do not need to happen
until after a channel is allocated. Here we move some of these so they're
dealt with when it's time to configure the channel, rather than allocate
it.
Cc: Vinod Koul
Cc: Dan Williams
Cc: Per Forlin
Signed-off-by: Lee Jones
Devices which utilise DMA tend to use the same channel numbers for
transmitting and receiving. For this reason and the fact that it'll
decrease the burden of platform data passed to each device, we're
amalgamating source and destination device types.
Signed-off-by: Lee Jones
---
arch/arm/mach
The aim is to make the code that little more readable.
Signed-off-by: Lee Jones
---
drivers/dma/ste_dma40.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index c14db3e..7b96e75 100644
Acked-by: Arnd Bergmann
Signed-off-by: Lee Jones
---
arch/arm/mach-ux500/devices-db8500.c| 12
drivers/dma/ste_dma40.c | 12 +++-
include/linux/platform_data/dma-ste-dma40.h |4
3 files changed, 7 insertions(+), 21 deletions(-)
diff
Acked-by: Arnd Bergmann
Signed-off-by: Lee Jones
---
arch/arm/mach-ux500/devices-db8500.c| 28 ---
drivers/dma/ste_dma40.c | 32 +--
include/linux/platform_data/dma-ste-dma40.h |4
3 files changed, 30 insertions
it into the hardware's registers.
Signed-off-by: Lee Jones
---
drivers/dma/ste_dma40.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index 3b83dee..2a0a9d4 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -2831,6
Forlin
Acked-by: Arnd Bergmann
Signed-off-by: Lee Jones
---
drivers/dma/ste_dma40.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index 2a0a9d4..9e423ad 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
On Tue, 09 Apr 2013, Arnd Bergmann wrote:
> On Tuesday 09 April 2013, Lee Jones wrote:
> > Someone has spent a fair amount of effort writing a runtime configuration
> > changing algorithm for DMA clients. However, the config appears to never
> > actually make it
On Tue, 09 Apr 2013, Arnd Bergmann wrote:
> On Tuesday 09 April 2013, Lee Jones wrote:
> > Confusingly d40_log_cfg() is used to set up the logical channel
> > configuration registers, but d40_phy_cfg() is used to configure
> > physical and logical registers, so it sho
On Tue, 09 Apr 2013, Harvey Harrison wrote:
> On Tue, Apr 9, 2013 at 11:39 AM, Lee Jones wrote:
> >
> > The aim is to make the code that little more readable.
> >
> > Signed-off-by: Lee Jones
> > ---
>
> >
> > #define MAX(a, b) (((a)
supported by
all platforms into a common device structure and the remaining
ones into a platform specific one.
Cc: Samuel Ortiz
Signed-off-by: Lee Jones
---
drivers/mfd/db8500-prcmu.c | 32
1 file changed, 24 insertions(+), 8 deletions(-)
diff --git a/drivers
On Tue, 09 Apr 2013, Arnd Bergmann wrote:
> On Tuesday 09 April 2013, Harvey Harrison wrote:
> >
> > On Tue, Apr 9, 2013 at 11:39 AM, Lee Jones wrote:
> > >
> > > The aim is to make the code that little more readable.
> > >
> > > Signed-off-by:
l_i2c_write_u8(TWL6030_MODULE_ID1, TWL6030_GPADCS,
> + TWL6030_REG_TOGGLE1);
> + if (ret < 0) {
> + dev_err(>dev, "Failed to enable GPADC module\n");
> + return ret;
> + }
> +
> + /* create
> Thank you for the review. There is v3 of this patch. My bad I didn't put
> it in reply to v1.
> I'll address you comments in v4. Would you care to review v3, please.
I'd rather go straight on to review v4 with my comments addressed, if
it's all the same to you?
--
Lee Jones
Linaro ST
ge to provide more a more meaty
description, rather than just repeating the subject line and applied
the patch.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "u
LP3943_PWM_LED2,
> + LP3943_PWM_LED3,
> + LP3943_PWM_LED4,
> + LP3943_PWM_LED5,
> + LP3943_PWM_LED6,
> + LP3943_PWM_LED7,
> + LP3943_PWM_LED8,
> + LP3943_PWM_LED9,
> + LP3943_PWM_LED10,
> + LP3943_PWM_LED11,
> + LP3943_PWM_LED1
> drivers/mfd/sec-core.c|4 +++-
> 2 files changed, 23 insertions(+), 1 deletions(-)
For drivers/mfd/sec-core.c:
Acked-by: Lee Jones
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: F
> #define S2MPS11_BUCK6_RAMP_EN_SHIFT 0
> #define S2MPS11_PMIC_EN_SHIFT6
> -#define S2MPS11_REGULATOR_MAX (S2MPS11_REG_MAX - 3)
>
> #endif /* __LINUX_MFD_S2MPS11_H */
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Fo
> /* Disable LDO pulldowns while the device is suspended if we
> * don't know that something will be driving them. */
> if (!wm8994->ldo_ena_always_driven)
I don't see the duplicate?
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software fo
;
> diff --git a/drivers/mfd/wm8994-core.c b/drivers/mfd/wm8994-core.c
Happy with this. Will apply when I fully understand 1/2.
Acked-by: Lee Jones
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
hen doing
> configuration.
>
> Signed-off-by: Mark Brown
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
Applied, thanks.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Lina
--
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/mfd/wm8994-core.c b/drivers/mfd/wm8994-core.c
Thanks for the clarification.
Both patches applied.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twit
On Fri, 16 Aug 2013, Chao Xie wrote:
> On Thu, Aug 15, 2013 at 6:07 PM, Lee Jones wrote:
> >> >> +Optional parent device properties:
> >> >> +- marvell,88pm800-irq-write-clear: inicates whether interrupt status
> >> >> is cleared by write
> &
ngs have changed, pdata usually takes precedence over
DT i.e. if pdata is present it should be used. Can you reverse these
two if statements please?
Sorry to mess you around.
> + dev_err(dev, "No platform data found.\n");
> + return -EINVAL;
> +}
> +
--
Lee Jones
Linar
-by: Lee Jones
---
include/dt-bindings/mfd/dbx500-prcmu.h | 84 ++
include/linux/mfd/dbx500-prcmu.h | 77 +--
2 files changed, 86 insertions(+), 75 deletions(-)
create mode 100644 include/dt-bindings/mfd/dbx500-prcmu.h
diff --git
The platform which it pertains to is no longer supported and is actually
causing some confusion in the new common clock implementation. A recent
patch removed its use in the clock driver, let's take out the definitions
too.
Signed-off-by: Lee Jones
---
drivers/mfd/dbx500-prcmu-regs.h
ve a say have has plenty of opportunity and the
patch looks good to me now, so:
Applied, thanks.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubs
this
> change to the binding document seems to be more about adding a new
> feature than adding DT support to the driver...
I'm taking this as a NACK.
Once Stephen is happy I'll reapply any RESEND with his Ack.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source so
oo Han
Patches look good to me 1-3 applied.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
e you can annotate them with, surprise surprise --annotate. :)
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of
mc13xxx_add_subdevice(mc13xxx, "%s-led");
> @@ -712,6 +712,9 @@ err_revision:
>
> if (mc13xxx->flags & MC13XXX_USE_TOUCHSCREEN)
> mc13xxx_add_subdevice(mc13xxx, "%s-ts");
> +
> + if (mc13xxx->fla
t.
It's okay, I didn't intend on actually applying it. I just wanted to
see the full file changes. I usually apply it, then do a `git log -p
-U1000` to get the full picture. However, I can't even do that yet,
which suggests it's based on some non-upstream tree.
--
Lee Jones
Linaro ST-Ericsso
nt
> mails? Which command is recommended in this case?
To reply to emails on the list, you just need to use your standard
email client in the normal way.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
-
ied this
[PATCH 1/4] then it needs to be functional and buildable. This
isn't. This is telling the build system that these files exist and
here's how to build them, but the files do not exist yet. With this
patch should be *some* of the core driver. Probably just enough to
probe() and remove() the device
pt
to add the headers at the appropriate times too. Although, if you
don't know what they all do, I won't be too stringent on that. Just
make sure that you don't add any regmap headers before you use any
regmap functionality, that kind of thing.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Lin
start referencing them from your *.c
files. At the very least, they should go in *before* you start to use
them.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the lin
-regmap.c
I'll leave the review of this file to Mark, but it should be added
either when you start calling the functions, or at least before they
are used, or else the preceding commits won't build. This would cause
someone a major headache if their bisect landed in the middle of your
patches.
--
Lee Jon
g-changes-into-several-patches/
- http://nuclearsquid.com/writings/git-add/
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
th
On Tue, 20 Aug 2013, Florian Lobmaier wrote:
> On Tue, 20 Aug 2013, Lee Jones wrote:
> > -
> > http://kparal.wordpress.com/2011/08/18/git-tip-of-the-day-splitting-changes-into-several-patches/
>
> > - http://nuclearsquid.com/writings/git-add/
>
> Than
On Wed, 21 Aug 2013, Linus Walleij wrote:
> On Thu, Jun 6, 2013 at 2:17 PM, Lee Jones wrote:
>
> > @@ -232,15 +232,6 @@ static struct of_dev_auxdata u8500_auxdata_lookup[]
> > __initdata = {
> > /* Requires device name bindings. */
> > OF_DEV_AUXD
On Tue, 20 Aug 2013, Olof Johansson wrote:
> On Fri, Jul 19, 2013 at 7:13 AM, Lee Jones wrote:
> > Signed-off-by: Lee Jones
> > ---
> > arch/arm/boot/dts/{snowball.dts => ste-snowball.dts} | 0
> > 1 file changed, 0 insertions(+), 0 deletions(-)
> > re
On Tue, 20 Aug 2013, Linus Walleij wrote:
> On Thu, Jun 6, 2013 at 2:16 PM, Lee Jones wrote:
>
> > +++ b/arch/arm/boot/dts/dbx5x0.dtsi
> > @@ -572,6 +572,8 @@
> > v-i2c-supply = <_vape_reg>;
> >
> >
/rtsx_pci.h | 15 ++
> 7 files changed, 69 insertions(+), 16 deletions(-)
MFD parts looks okay to me:
Acked-by: Lee Jones
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubsc
deletions(-)
create mode 100644 Documentation/devicetree/bindings/mfd/s2mps11.txt
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kern
On Wed, 21 Aug 2013, Linus Walleij wrote:
> On Thu, Jun 6, 2013 at 2:17 PM, Lee Jones wrote:
>
> > This patch enables clocks to be specified from Device Tree via phandles
> > to the "prcmu-clock" node.
> (..)
> > @@ -52,14 +54,17 @@ void u8500_clk_in
On Wed, 21 Aug 2013, Linus Walleij wrote:
> On Thu, Jun 6, 2013 at 2:17 PM, Lee Jones wrote:
>
> > This patch enables clocks to be specified from Device Tree via phandles
> > to the "prcc-kernel-clock" node.
> >
> > Cc: Mike Turquette
> >
()
error: we previously assumed 'data' could be null (see line 313)
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: linux-...@vger.kernel.org
Cc: Dan Carpenter
Signed-off-by: Lee Jones
---
drivers/usb/musb/ux500_dma.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb
On Fri, 09 Aug 2013, Nishanth Menon wrote:
> On 08/09/2013 08:01 AM, Bill Huang wrote:
> >On Thu, 2013-08-08 at 20:32 +0800, Lee Jones wrote:
> >>On Thu, 08 Aug 2013, Bill Huang wrote:
> >>
> >>>Hook up "pm_power_off" to palmas power off rout
> where your patch is at this point, but I just wanted to point that
> out.
I haven't done anything with that patch yet, but I'd prefer they
stayed separate to be honest. If you make your changes and ensure
they're in an upstream tree (and let me know which one), I'll rebase
my patches on top of t
onto the line above, if it's all the same to you?
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a mess
> },
> + {
> + .ident = "UTH6",
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Kontron"),
> + DMI_MATCH(DMI_BOARD_NAME, "COMe-cTH6"),
> + },
> + .driver_data = (v
lams ->palmas
>
> drivers/mfd/palmas.c | 97
>
> include/linux/mfd/palmas.h | 49 ++
> 2 files changed, 146 insertions(+), 0 deletions(-)
Patch looks good to me. Unless anyone else has an opinion:
Tony, Benoit,
Poke
> Cc: Benoît Cousson
> Cc: Tony Lindgren
> Cc: linux-o...@vger.kernel.org
> Signed-off-by: Lee Jones
> ---
> arch/arm/boot/dts/omap5.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap5.dts
1 - 100 of 24010 matches
Mail list logo
