Re: 2.6.21-rc6-mm1 ATA HPT37x regression

2007-04-17 Thread Sergei Shtylyov
Hello. John Stoffel wrote: I was just testing out 2.6.21-rc6-mm1 to test some Cyclades patches and I noticed that my HPT302 (rev1) controller with a pair of 120gb WD disks are not longer detected and I get the following in the dmesg logs: [ 148.121490] hpt37x: DPLL did not stabilize.

Re: 2.6.21-rc6-mm1 ATA HPT37x regression

2007-04-17 Thread Sergei Shtylyov
John Stoffel wrote: I was just testing out 2.6.21-rc6-mm1 to test some Cyclades patches and I noticed that my HPT302 (rev1) controller with a pair of 120gb WD disks are not longer detected and I get the following in the dmesg logs: [ 148.121490] hpt37x: DPLL did not stabilize. Where

Re: Permanent Kgdb integration into the kernel - lets get with it.

2007-04-17 Thread Sergei Shtylyov
Hello. Randy Dunlap wrote: In spite of kgdb, shouldn't it have that \n anyways in case some other code gets added in the future after the macro? Or are you saying that there should never be any code ever after that macro? Sure if there is mainline code added after that macro we add the \n.

Re: Permanent Kgdb integration into the kernel - lets get with it.

2007-04-17 Thread Sergei Shtylyov
Randy Dunlap wrote: In spite of kgdb, shouldn't it have that \n anyways in case some other code gets added in the future after the macro? Or are you saying that there should never be any code ever after that macro? Sure if there is mainline code added after that macro we add the \n. But

Re: 2.6.21-rc6-mm1 ATA HPT37x regression

2007-04-17 Thread Sergei Shtylyov
Hello. John Stoffel wrote: Ok, so do I need to do anything special with the next -mm release and the next version? Well, let Alan decide that (2Alan: and I said that HPT code is bogus :-). Alan Try drivers/ide/pci/hpt366 - if that works grab a dmesg and let Alan me know. It means that

Re: [BUG] 2.6.21-rc7 hpt366 driver broken

2007-04-18 Thread Sergei Shtylyov
Hello. Mike Mattie wrote: I have added Sergei Shtylyov to the address list after seeing his recent posts on hpt366 issues, and the git changelog for the hpt366.c driver. I am very confident that I have pinpointed the defect in the driver. Indeed you have. Thank you. [ Cc's added, full

[PATCH pata-2.6 fix queue] hpt366: fix kernel oops with HPT302N

2007-04-18 Thread Sergei Shtylyov
The driver crashes the kernel on HPT302N chips due to the missing initializer for 'hpt302n.settings' having been unfortunately overlooked so far. :- Much thanks to Mike Mattie for pin-pointing the reason of crash. Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] --- Posting at last -- please

Re: [PATCH 14/15] ide: rework the code for selecting the best DMA transfer mode

2007-04-19 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: rework the code for selecting the best DMA transfer mode Depends on the ide: fix UDMA/MWDMA/SWDMA masks patch. I'm now trying to rewrite hpt366.c to benefit more from these patches... and alas, this very patch seems to be breaking

Re: [PATCH 14/15] ide: rework the code for selecting the best DMA transfer mode

2007-04-19 Thread Sergei Shtylyov
Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: rework the code for selecting the best DMA transfer mode Depends on the ide: fix UDMA/MWDMA/SWDMA masks patch. I'm now trying to rewrite hpt366.c to benefit more from these patches... and alas, this very

Re: [PATCH 14/15] ide: rework the code for selecting the best DMA transfer mode

2007-04-19 Thread Sergei Shtylyov
Hello, I wrote: Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: rework the code for selecting the best DMA transfer mode Depends on the ide: fix UDMA/MWDMA/SWDMA masks patch. I'm now trying to rewrite hpt366.c to benefit more from these patches... and alas, this very patch seems to be

Re: [PATCH 14/15] ide: rework the code for selecting the best DMA transfer mode

2007-04-20 Thread Sergei Shtylyov
Hello, I wrote: [PATCH] ide: rework the code for selecting the best DMA transfer mode Depends on the ide: fix UDMA/MWDMA/SWDMA masks patch. I'm now trying to rewrite hpt366.c to benefit more from these patches... and alas, this very patch seems to be breaking filtering (at least) in

Re: [PATCH 14/15] ide: rework the code for selecting the best DMA transfer mode

2007-04-20 Thread Sergei Shtylyov
Hello, I wrote: Index: b/drivers/ide/pci/hpt366.c === --- a/drivers/ide/pci/hpt366.c +++ b/drivers/ide/pci/hpt366.c @@ -513,43 +513,31 @@ static int check_in_drive_list(ide_drive return 0; } -static u8

Re: [PATCH 12/15] ide: make ide_hwif_t.ide_dma_host_on void

2007-04-20 Thread Sergei Shtylyov
Hello, once I wrote: [PATCH] ide: make ide_hwif_t.ide_dma_host_on void * since ide_hwif_t.ide_dma_host_on is called either when drive-using_dma == 1 or when return value is discarded make it void, also drop ide_ prefix * make __ide_dma_host_on() void and drop __ prefix BTW, it would

Re: [PATCH 13/15] ide: fix UDMA/MWDMA/SWDMA masks

2007-04-22 Thread Sergei Shtylyov
masks to match with chipset specific *_ratemask() (alim15x3, hpt366, serverworks and siimage drivers need UDMA mask filtering method - done in the next patch) v2: * piix: fix cable detection for 82801AA_1 and 82372FB_1 [ Noticed by Sergei Shtylyov [EMAIL PROTECTED]. ] * cmd64x: use hwif-cds

[PATCH pata-2.6 fix queue] aec62xx: fix PIO/DMA setup issues

2007-04-22 Thread Sergei Shtylyov
SWDMA modes; - stop hooking ide_dma_timeout() method as the handler clearly doesn't fit for the task... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] --- Warning: the patch has only been compile tested (the driver was on the way of some cleanup -- that's why I got around to fixing

Re: PATCH 2.6.20 11/14; CRIS architecture update - IDE driver

2007-04-23 Thread Sergei Shtylyov
Hello. Mikael Starvik wrote: The attached patch updates the CRIS IDE driver. Signed-off-by: Mikael Starvik [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] Please attach the patch as text/plain and clean it from the whitespace noise. :-/ /Mikael MBR, Sergei - To unsubscribe from this

Re: [PATCH] sl82c105: Switch to ref counting API

2007-04-23 Thread Sergei Shtylyov
Hello. Alan Cox wrote: Not sure how this one got missed in the great purge some time ago but it did. Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.21-rc6-mm1/drivers/ide/pci/sl82c105.c

Re: [PATCH 10/13] sl82c105: add -speedproc support

2007-03-14 Thread Sergei Shtylyov
Hello, I wrote: Bartlomiej Zolnierkiewicz wrote: [PATCH] sl82c105: add -speedproc support * add sl82c105_tunepio() wrapper for sl82c105_tune_drive() (just to get the error value) * add sl82c105_tune_chipset() (-speedproc method) for setting transfer mode Thanks for the patch!

Re: [PATCH] BLK_DEV_IDE_CELLEB dependency fix

2007-03-15 Thread Sergei Shtylyov
Hello. Akira Iguchi wrote: It's bool and it depends on BLK_DEV_IDE = should depend on BLK_DEV_IDE=y Hm, why I'm seeing module_init() in the driver? :-) And move it to if BLK_DEV_IDEDMA_PCI block because it depends on BLK_DEV_IDEDMA_PCI. IMHO, that driver shouldn't be in

Re: [patch 1/6 -rt] powerpc 2.6.20-rt8: add preemption checks for NEED_RESCHED_DELAYED.

2007-03-16 Thread Sergei Shtylyov
Hello. Tsutomu OWA wrote: To add preemption checks for the NEED_RESCHED_DELAYED flag. diff -rup linux-rt8/arch/powerpc/kernel/idle.c rt/arch/powerpc/kernel/idle.c --- linux-rt8/arch/powerpc/kernel/idle.c2007-02-20 14:30:38.0 +0900 +++ rt/arch/powerpc/kernel/idle.c

Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git mast er

2007-02-12 Thread Sergei Shtylyov
Hello. Marc St-Jean wrote: Fourth attempt at the serial driver patch for the PMC-Sierra MSP71xx device. I think you need to submit your patch to Andrew Morton since it requires a patch from his tree. OK, will do. In fact, since the serial drivers are not maintained anymore,

Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-15 Thread Sergei Shtylyov
Hello. Marc St-Jean wrote: There are three different fixes: 1. Fix for DesignWare APB THRE errata: In brief, this is a non-standard 16550 in that the THRE interrupt will not re-assert itself simply by disabling and re-enabling the THRI bit in the IER, it is only re-enabled if a character is

Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-16 Thread Sergei Shtylyov
Hello. Andrew Morton wrote: + status = *(volatile u32 *)up-port.private_data; It distresses me that this patch uses a variable which this patch doesn't initialise anywhere. It isn't complete. I assume this gets passed via early_serial_setup(). Marc? The

Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git mast er

2007-02-16 Thread Sergei Shtylyov
Hello. Marc St-Jean wrote: diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c index 3d91bfc..bfaacc5 100644 --- a/drivers/serial/8250.c +++ b/drivers/serial/8250.c @@ -308,6 +308,7 @@ static unsigned int serial_in(struct uar return inb(up-port.iobase + 1);

Re: 2.6.20-rc4-mm1: PCI=n: drivers/net/3c59x.c compile error

2007-02-17 Thread Sergei Shtylyov
Hello, I wrote: 3x59x-fix-pci-resource-management.patch causes the following compile error with CONFIG_PCI=n: -- snip -- ... CC drivers/net/3c59x.o /home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/net/3c59x.c: In function 'vortex_init_one':

Re: 2.6.20-rc4-mm1: PCI=n: drivers/net/3c59x.c compile error

2007-02-17 Thread Sergei Shtylyov
Hello. Sergei Shtylyov wrote: 3x59x-fix-pci-resource-management.patch causes the following compile error with CONFIG_PCI=n: -- snip -- ... CC drivers/net/3c59x.o /home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/net/3c59x.c: In function 'vortex_init_one': /home/bunk

Re: [git patches] more IDE updates

2007-02-19 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: Contains: IRQ-ack fix for ICH chipsets (Albert Lee), ide-floppy unformatted media fix (Alan Cox), more fixes for IDE PCI drivers (Sergei Shtylyov), new driver for Toshiba Cell Reference Board (Kou Ishizaki kou.ishizaki at toshiba.co.jp) and a bunch

Re: [git patches] more IDE updates

2007-02-19 Thread Sergei Shtylyov
Hello. Sergei Shtylyov wrote: Contains: IRQ-ack fix for ICH chipsets (Albert Lee), ide-floppy unformatted media fix (Alan Cox), more fixes for IDE PCI drivers (Sergei Shtylyov), new driver for Toshiba Cell Reference Board (Kou Ishizaki kou.ishizaki at toshiba.co.jp) and a bunch of rather

Re: [PATCH 10/13] sl82c105: add -speedproc support

2007-03-15 Thread Sergei Shtylyov
Hello. Russell King wrote: I wonder is there are some W83C554 users anywhere -- that chipset also supports UltraDMA... Sergei, ARM Netwinder machines are running hard disk IDE on SL82c105. Could you send me the actual source file to try (or a patch)? That's actually a W83C553 which

Re: [PATCH 3/3] Use correct IDE error recovery

2007-03-24 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: Since I think that it's worth to have it in 2.6.21-final and respin didn't happen I did the required changes myself (it also turned out that I missed few things during initial review), then applied the patch... Please let my know whether you are fine

Re: [PATCH 12/15] ide: make ide_hwif_t.ide_dma_host_on void

2007-03-26 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: make ide_hwif_t.ide_dma_host_on void * since ide_hwif_t.ide_dma_host_on is called either when drive-using_dma == 1 or when return value is discarded make it void, also drop ide_ prefix * make __ide_dma_host_on() void and drop __ prefix

Re: [PATCH] Correctly prevent IDE timer expiry function to run if request was already handled

2007-04-06 Thread Sergei Shtylyov
Hello. Suleiman Souhlal wrote: It is possible for the timer expiry function to run even though the request has already been handled: ide_timer_expiry() only checks that the handler is not NULL, but it is possible that we have handled a request (thus clearing the handler) and then started a new

Re: [PATCH] Correctly prevent IDE timer expiry function to run if request was already handled

2007-04-06 Thread Sergei Shtylyov
Hello. Suleiman Souhlal wrote: It is possible for the timer expiry function to run even though the request has already been handled: ide_timer_expiry() only checks that the handler is not NULL, but it is possible that we have handled a request (thus clearing the handler) and then started a new

Re: [git patches] more IDE updates

2007-02-26 Thread Sergei Shtylyov
Hello, I wrote: Contains: IRQ-ack fix for ICH chipsets (Albert Lee), ide-floppy unformatted media fix (Alan Cox), more fixes for IDE PCI drivers (Sergei Shtylyov), new driver for Toshiba Cell Reference Board (Kou Ishizaki kou.ishizaki at toshiba.co.jp) and a bunch of rather obvious cleanups

Re: 2.6.20-rc4-mm1: PCI=n: drivers/net/3c59x.c compile error

2007-02-26 Thread Sergei Shtylyov
Hello, I wrote: 3x59x-fix-pci-resource-management.patch causes the following compile error with CONFIG_PCI=n: -- snip -- ... CC drivers/net/3c59x.o /home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/net/3c59x.c: In function 'vortex_init_one':

Re: [PATCH] pata_cmd640: CMD640 PCI support

2007-03-03 Thread Sergei Shtylyov
Hello. Jeff Garzik wrote: +/* The second channel has shared timings and the setup timing is + messy to switch to merge it for worst case */ +if (ap-port_no pair) { +struct ata_timing p; +ata_timing_compute(pair, pair-pio_mode, p, T, 1); +

Re: [PATCH] pata_cmd640: CMD640 PCI support

2007-03-03 Thread Sergei Shtylyov
Alan Cox wrote: +if (t.active 16) +t.active = 16; Erm, clamping active time is not a right thing to do. Right thing to do was to bail out. I didn't do it in the legacy driver rewrite though... As far as I can work out its a can't happen +

Re: [PATCH][pata-2.6 tree] pdc202xx_old: rewrite mode programming code

2007-03-05 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] pdc202xx_old: rewrite mode programming code This patch is based on the documentation (I would like to thank Promise for it) and also partially on the older vendor driver. Rewrite mode programming code: * fix XFER_MW_DMA0 timings (they

Re: [PATCH][pata-2.6 tree] pdc202xx_old: rewrite mode programming code

2007-03-05 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] pdc202xx_old: rewrite mode programming code This patch is based on the documentation (I would like to thank Promise for it) and also partially on the older vendor driver. Rewrite mode programming code: * fix XFER_MW_DMA0 timings (they

Re: [PATCH][pata-2.6 tree] pdc202xx_old: rewrite mode programming code

2007-03-05 Thread Sergei Shtylyov
Hello, I wrote: official == same as in the docs and vendor driver :-) Erm, those look a bit doubtful... I believe that they are correct - please see explanations below. Yeah, sorry about that. Only SWDMA timings are suspicious. Hm, too early to say sorry. I was

Re: [patch 0/6 -rt] powerpc 2.6.20-rt8: fix boot/runtime errors/warnings for PowerPC(ppc64)

2007-03-07 Thread Sergei Shtylyov
Tsutomu OWA wrote: Hi Ingo, Please consider for inclusion in your rt tree. This series of patches fixes boot and runntime errors/warnings for powerpc (esp. 64 bit). This applies to linux-2.6.20, patch-2.6.20-rt8 and previous my patch set;

Re: [patch 2/6 -rt] powerpc 2.6.20-rt8: to convert spinlocks to raw ones.

2007-03-07 Thread Sergei Shtylyov
Hello. Tsutomu OWA wrote: --- linux-rt8/arch/powerpc/kernel/irq.c 2007-02-20 14:30:38.0 +0900 +++ rt/arch/powerpc/kernel/irq.c2007-03-05 18:54:34.0 +0900 @@ -392,7 +392,7 @@ EXPORT_SYMBOL(do_softirq); #ifdef CONFIG_PPC_MERGE static LIST_HEAD(irq_hosts); -static

Re: [patch 2/6 -rt] powerpc 2.6.20-rt8: to convert spinlocks to raw ones.

2007-03-07 Thread Sergei Shtylyov
Hello. Benjamin Herrenschmidt wrote: --- linux-rt8/arch/powerpc/kernel/irq.c 2007-02-20 14:30:38.0 +0900 +++ rt/arch/powerpc/kernel/irq.c2007-03-05 18:54:34.0 +0900 @@ -392,7 +392,7 @@ EXPORT_SYMBOL(do_softirq); #ifdef CONFIG_PPC_MERGE static LIST_HEAD(irq_hosts);

Re: v2.6.19-rt6, yum/rpm

2007-03-07 Thread Sergei Shtylyov
Hello, I wrote: could you resend them to me please? Seeing that GENERIC_TIME has been thrown out from the -rt patch, [...] hm, i did that accidentally during a rebase. That was certainly not meant to be a persistent condition. ok, the delta below is what i've managed to restore from

Re: 2.6.20-rc4-mm1: PCI=n: drivers/net/3c59x.c compile error

2007-03-06 Thread Sergei Shtylyov
Hello. Greg KH wrote: 3x59x-fix-pci-resource-management.patch causes the following compile error with CONFIG_PCI=n: -- snip -- ... CC drivers/net/3c59x.o /home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/net/3c59x.c: In function 'vortex_init_one':

Re: [patch 2/6 -rt] powerpc 2.6.20-rt8: to convert spinlocks to raw ones.

2007-03-07 Thread Sergei Shtylyov
Hello. Paul Mackerras wrote: I've already sent a patch fixing this one (along with many others) a month ago: http://ozlabs.org/pipermail/linuxppc-dev/2007-February/031164.html I wonder iof it was ever considered... :-/ The entire patch description was just this: Convert the

Re: [patch 2/6 -rt] powerpc 2.6.20-rt8: to convert spinlocks to raw ones.

2007-03-07 Thread Sergei Shtylyov
Hello. Paul Mackerras wrote: As I said, this was intended for the -rt patch, hence the question was for Ingo. I CC'ed the list just to keep people here in a loop. OK, fair enough, but I still think the patch description was inadequate. In the -rt context, I would at least expect to see

Re: [RFC] [patch 5/6] powerpc 2.6.20-rt8: fix a boot error for handle_percpu_irq

2007-03-07 Thread Sergei Shtylyov
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - I found a pile of e-mail started by Sergei Shtylyov on linuxppc-dev regarding this. Subject: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers From: Sergei Shtylyov [EMAIL PROTECTED] Date: Sun, 19 Nov 2006 22:43:34 +0300 Though

Re: [ PATCH] Add suspend/resume for HPET was: Re: [3/6] 2.6.21-rc4: known regressions

2007-03-29 Thread Sergei Shtylyov
Hello. Maxim wrote: --- This adds support of suspend/resume on i386 for HPET The part after usually --- gets cut off, the patch description and signoff should actially *precede* it. Signed-off-by: Maxim Levitsky [EMAIL PROTECTED] diff --git a/arch/i386/kernel/hpet.c

Re: [PATCH 2/15] ide: move wait_hwif_ready() documentation in the right place

2008-01-09 Thread Sergei Shtylyov
HNY. :-) Bartlomiej Zolnierkiewicz wrote: * Move wait_hwif_ready() documentation before this function. * Fix trailing whitespaces. * s/wait-for-busy/wait-for-non-busy/ * Remove no longer valid comment about the current code behavior. * Docbook-ize it. * Rename wait_hwif_ready()

Re: [PATCH 2/15] ide: move wait_hwif_ready() documentation in the right place

2008-01-09 Thread Sergei Shtylyov
(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Oops, forgot to stamp: Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 8/8] ide: add -cable_detect method to ide_hwif_t

2008-01-12 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: * Add -cable_detect method to ide_hwif_t. * Call the new method in ide_init_port() if: - the host supports UDMA modes UDMA2 ('hwif-ultra_mask 78') - DMA initialization was successful (if hwif-dma_base is not set ide_init_port() sets

Re: [PATCH][RESUBMIT] drivers/ide/ide-probe.c, kernel 2.6.23.1

2007-11-16 Thread Sergei Shtylyov
Jonas Stare wrote: diff -u linux-2.6.23.1-orig/drivers/ide/ide-probe.c linux-2.6.23.1/drivers/ide/ide-probe.c --- linux-2.6.23.1-orig/drivers/ide/ide-probe.c 2007-10-12 18:43:44.0 +0200 +++ linux-2.6.23.1/drivers/ide/ide-probe.c 2007-11-16 10:26:23.0 +0100 @@ -643,6

Re: PCI resource unavailable on mips

2007-12-17 Thread Sergei Shtylyov
Hello. Jon Dufresne wrote: I did a bit more work and investigation on this and it turns out I could not read the mmio in kernel space because I had not done a pci_enable_device_bars() on the device. I had never done this on x86 so I didn't realize it was necessary. The virtual address

Re: [PATCH] include/asm-mips/: Spelling fixes

2007-12-17 Thread Sergei Shtylyov
Hello. Joe Perches wrote: Signed-off-by: Joe Perches [EMAIL PROTECTED] diff --git a/include/asm-mips/mach-wrppmc/mach-gt64120.h b/include/asm-mips/mach-wrppmc/mach-gt64120.h index 00d8bf6..465234a 100644 --- a/include/asm-mips/mach-wrppmc/mach-gt64120.h +++

Re: [PATCH 01/63] ide-cd: fix SAMSUNG CD-ROM SCR-3231 quirk

2007-12-21 Thread Sergei Shtylyov
Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH 04/63] ide-cd: fix error messages in cdrom_{read,write}_check_ireason()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 05/63] ide-cd: add missing 'ireason' masking to cdrom_write_intr()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Mask 'ireason' variable with 0x3 so the valid interrupt reason value is passed to cdrom_write_check_ireason() for checking. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe

Re: [PATCH 02/63] ide-cd: fix ACER/AOpen 24X CDROM speed reporting on big-endian machines

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Fix ACER/AOpen 24X CDROM speed reporting on big-endian machines by adding missing le16_to_cpu() calls. While at it: * Replace ntohs() by be16_to_cpu(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL

Re: [PATCH 08/63] ide-cd: fix error message in cdrom_pc_intr()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 09/63] ide-cd: fix 'ireason' reporting in cdrom_pc_intr()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Mask 'ireason' variable so only the valid interrupt reason bits will be reported on drive appears confused error. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from

Re: [PATCH 13/63] ide-cd: fix DMA error handling in cdrom_newpc_intr()

2007-12-21 Thread Sergei Shtylyov
] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 16/63] ide-cd: remove stale cdrom_transfer_packet_command() comment

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 59/63] ide-cd: call blk_dump_rq_flags() on missing data in cdrom_rw_intr()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 63/63] ide-cd: update driver version, comments and copyrights

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Bump driver version. * Remove filename and stale TODO from comments. * Add my copyrights. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send

Re: [PATCH 21/63] ide-cd: remove unused and write-only struct ide_cd_config_flags fields

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: unused fields: * -writing * -reserved write-only fields: * -playmsf_as_bcd * -subchan_as_bcd * -test_write * -supp_disc_present Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei

Re: [PATCH 06/63] ide-cd: fix error messages in cdrom_write_intr()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 07/63] ide-cd: add error message for DMA error to cdrom_read_intr()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 42/63] ide-cd: coding style fixes for cdrom_get_toc_entry()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: This is a preparation to move code handling cdrom.c IOCTLs out of ide-cd.c. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 14/63] ide-cd: fix trailing whitespaces in changelog

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 17/63] ide-cd: remove unused defines from ide-cd.h

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 46/63] ide-cd: call blk_dump_rq_flags() on missing data in cdrom_newpc_intr()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 22/63] ide-cd: remove struct atapi_{mechstat_header,changer_info,slot}

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Remove -changer_info from struct cdrom_info (it is never allocated). * Remove unused struct atapi_{mechstat_header,changer_info,slot}. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei

Re: [PATCH 23/63] ide-cd: cleanup ide_cdrom_update_speed()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 19/63] ide-cd: remove unused struct atapi_cdrom_subchnl

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 20/63] ide-cd: remove needless zeroing of 'info' fields from ide_cdrom_setup()

2007-12-21 Thread Sergei Shtylyov
-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH 30/63] ide-cd: remove NO_DOOR_LOCKING define

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 34/63] ide-cd: remove duplicate sense keys definitions from ide-cd.h

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: ide-cd.c already uses sense keys definitions from scsi/scsi.h. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH 18/63] ide-cd: remove dead code from cdrom_pc_intr()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 12/63] ide-cd: fix missing data handling in cdrom_pc_intr()

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: If drive still wants to transfer the data we need to pad the transfer instead of just finishing the request. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list

Re: [PATCH 26/28] blk_end_request: changing ide-cd (take 3)

2007-12-03 Thread Sergei Shtylyov
PROTECTED] Cc: [EMAIL PROTECTED] Cc: Kiyoshi Ueda [EMAIL PROTECTED] Cc: Jun'ichi Nomura [EMAIL PROTECTED] Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send

Re: Peculiar out-of-sync boot log lines

2007-12-07 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: DMA reporting and validity checking fixes (take 2) * ide_xfer_verbose() fixups: - beautify returned mode names - fix PIO5 reporting - make it return 'const char *' * Change printk() level from KERN_DEBUG to KERN_INFO in

Re: [PATCH 1/2] ide: add ide_dump_identify() debug helper

2007-12-25 Thread Sergei Shtylyov
is enabled. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [MIPS] MEM_SDREFCFG is not defined for Alchemy DB1550 (compile fail)

2007-12-25 Thread Sergei Shtylyov
Hello. Alon Bar-Lev wrote: When I have: CONFIG_MIPS_DB1550 CONFIG_SOC_AU1550 CONFIG_SOC_AU1X00 CONFIG_PM MEM_SDREFCFG is used at: arch/mips/au1000/common/power.c::pm_do_freq() PM code is generally broken and unmaintained, so no wonder. I don't remember if anyone has fixed CPU context

Re: [MIPS] MEM_SDREFCFG is not defined for Alchemy DB1550 (compile fail)

2007-12-25 Thread Sergei Shtylyov
Alon Bar-Lev wrote: PM code is generally broken and unmaintained, so no wonder. I don't remember if anyone has fixed CPU context restoration code (it uses a skewed stack frame). So suspend modes on these boards are not supported? Only Always On configuration is supported? Sleep mode

Re: [PATCH 2/9] ide: fix ide_intr() for non-PCI devices and CONFIG_BLK_DEV_IDEPCI=y

2007-12-28 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: 'hwif-pci_dev !hwif-pci_dev-vendor' condition is never true, check for 'hwif-chipset != ide_pci' instead. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list

Re: [PATCH 1/9] piix: remove stale comments

2007-12-28 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/drivers/ide/pci/piix.c === --- a/drivers/ide/pci/piix.c +++ b/drivers/ide

Re: [PATCH 7/9] icside: use hwif-dev

2007-12-28 Thread Sergei Shtylyov
PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei PS: Russel, that was only an eyes check, the last word is yours. :-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH 4/9] ide: use ide_destroy_dmatable() instead of pci_unmap_sg()

2007-12-29 Thread Sergei Shtylyov
[EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH 7/9] icside: use hwif-dev

2007-12-29 Thread Sergei Shtylyov
PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 7/9] icside: use hwif-dev

2007-12-29 Thread Sergei Shtylyov
Sergei Shtylyov wrote: * Setup hwif-dev in icside_setup(). * Use hwif-dev instead of state-dev in icside_build_sglist(), icside_dma_end(), icside_dma_start() and icside_dma_setup(). * Remove no longer needed 'dev' field from struct icside_state. Cc: Russell King [EMAIL PROTECTED

Re: [PATCH 3/3] ide: add IDE_HFLAG_NO_DSC host flag

2007-12-29 Thread Sergei Shtylyov
[EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/include/linux/ide.h === --- a/include/linux/ide.h +++ b/include/linux/ide.h @@ -1098,6 +1098,8 @@ enum { IDE_HFLAG_CY82C693 = (1 27

Re: [PATCH 2/3] ide-pmac: macio resource freeing bugfix

2008-01-04 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Release DMA resource before zeroing pmif. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei -- To unsubscribe from this list: send the line

Re: Regression: commit ide: constify struct ide_port_info causes breakage

2007-10-26 Thread Sergei Shtylyov
Hello. Linus Torvalds wrote: We can just convert cariables declared as 'struct hpt_info' to const too -- they are read-only templates. Generally __devinitdata is better than const, since it means that the data may be thrown away. Agreed. So if you drop one over the other, No,

Re: Regression: commit ide: constify struct ide_port_info causes breakage

2007-10-26 Thread Sergei Shtylyov
Hello. Russell King wrote: commit 8562043606430185cad26d085d46adcc7ad67fd1 is broken, causing: CC drivers/ide/pci/cmd64x.o CC drivers/ide/pci/hpt366.o drivers/ide/pci/hpt366.c:1428: error: hpt366_chipsets causes a section type conflict and therefore should be reverted.

Re: [PATCH] ucc_geth: add support for netpoll

2007-10-27 Thread Sergei Shtylyov
Hello. Anton Vorontsov wrote: This patch adds netpoll support for the QE UCC Gigabit Ethernet driver. The approach is very similar to the gianfar driver. It's rather contrarywise -- this is standard approach and gianfar with its 3 TSEC IRQs has a quite non-standard poll_controller()

Re: [PATCH 0/3] ide: Fix use of paired device

2007-10-18 Thread Sergei Shtylyov
Hello. Benjamin Herrenschmidt wrote: At least 2 drivers (siimage and cs5535) have a bug where they use the construct: ide_drive_t *pair = hwif-drives[drive-dn ^ 1]; To access the other drive in a master/slave pair. This is bogus because drive-dn is not the unit number, but

Re: [PATCH 0/3] ide: Fix use of paired device

2007-10-18 Thread Sergei Shtylyov
Hello, I wrote: At least 2 drivers (siimage and cs5535) have a bug where they use the construct: ide_drive_t *pair= hwif-drives[drive-dn ^ 1]; To access the other drive in a master/slave pair. This is bogus because drive-dn is not the unit number, but the global drive number, thus

Re: [PATCH 1/3] ide: Add ide_get_paired_drive() helper

2007-10-18 Thread Sergei Shtylyov
Benjamin Herrenschmidt wrote: This adds a helper to get to the other drive on a pair connected to a given hwif. Maibe mate drive would've been a better name that paired... Signed-off-by: Benjamin Herrenschmidt [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei

Re: [PATCH 2/3] ide: Fix siimage driver accessing beyond array boundary

2007-10-18 Thread Sergei Shtylyov
PROTECTED] Please update the driver version in the driver's heading comment. Otherwise Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

  1   2   3   4   5   6   7   8   9   10   >