[PATCH 1/2] zram: forbid IO operations from within zram_init_device()

2012-10-30 Thread Sergey Senozhatsky
] ? __init_kthread_worker+0x70/0x70 Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- drivers/staging/zram/zram_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c index fb4a7c9..d2e0a85 100644

[PATCH 2/2] zram: permit sleeping while in pool zs_malloc()

2012-10-30 Thread Sergey Senozhatsky
[8119d5bd] do_fsync+0x5d/0x90 [8119d990] sys_fsync+0x10/0x20 [815dce06] tracesys+0xd4/0xd9 Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- drivers/staging/zram/zram_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH 1/2] zram: forbid IO operations from within zram_init_device()

2012-10-30 Thread Sergey Senozhatsky
please ignore this patch. on a second thought -- I'm sure it will not fix anything. will rework and resend. -ss On (10/30/12 12:01), Sergey Senozhatsky wrote: zram: forbid IO operations from within zram_init_device() Allocation operations in zram_make_request

[PATCH] zram: call zram_init_device() only from disksize_store()

2012-10-30 Thread Sergey Senozhatsky
-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- drivers/staging/zram/zram_drv.c | 18 -- drivers/staging/zram/zram_sysfs.c | 4 2 files changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c index

Re: [PATCH 2/2] zram: permit sleeping while in pool zs_malloc()

2012-10-30 Thread Sergey Senozhatsky
On (10/30/12 11:04), Greg Kroah-Hartman wrote: On Tue, Oct 30, 2012 at 12:03:19PM +0300, Sergey Senozhatsky wrote: zram: permit sleeping while in pool zs_malloc() 2/2? Huh? Where is 1/2? I have a raft of patches from you, all out of order, and full of responses from Nitin, and so

[PATCH 0/2] zram decompress_page and zram_sysfs patch seriess

2012-10-30 Thread Sergey Senozhatsky
Hello Greg, I'm gonna send you 2 zram patches shortly, reviewed by Nitin. [PATCH 1/2] zram: factor-out zram_decompress_page() function [PATCH 2/2] zram: handle mem suffixes in disk size zram_sysfs parameter Thanks, -ss -- To unsubscribe from this list: send the line

[PATCH 1/2] zram: factor-out zram_decompress_page() function

2012-10-30 Thread Sergey Senozhatsky
zram: factor-out zram_decompress_page() function zram_bvec_read() shared decompress functionality with zram_read_before_write() function. Factor-out and make commonly used zram_decompress_page() function, which also simplified error handling in zram_bvec_read(). Signed-off-by: Sergey

[PATCH 2/2] zram: handle mem suffixes in disk size zram_sysfs parameter

2012-10-30 Thread Sergey Senozhatsky
zram: handle mem suffixes in disk size zram_sysfs parameter Use memparse() to allow mem suffixes in disksize sysfs number. Examples: echo 256K /sys/block/zram0/disksize echo 512M /sys/block/zram0/disksize echo 1G /sys/block/zram0/disksize Signed-off-by: Sergey

Re: [PATCH 2/2] zram: permit sleeping while in pool zs_malloc()

2012-10-30 Thread Sergey Senozhatsky
On (10/30/12 12:18), Greg Kroah-Hartman wrote: the first one: [PATCH 1/2] zram: factor-out zram_decompress_page() function [PATCH 2/2] zram: handle mem suffixes in disk size zram_sysfs parameter ACKed by Nitin. the second one [PATCH 2/2] zram: permit sleeping while in pool

[PATCH 1/2] zram: factor-out zram_decompress_page() function (resend)

2012-10-30 Thread Sergey Senozhatsky
zram_bvec_read() shared decompress functionality with zram_read_before_write() function. Factor-out and make commonly used zram_decompress_page() function, which also simplified error handling in zram_bvec_read(). Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com Reviewed-by: Nitin

[PATCH 2/2] zram: handle mem suffixes in disk size zram_sysfs parameter (resend)

2012-10-30 Thread Sergey Senozhatsky
Use memparse() to allow mem suffixes in disksize sysfs number. Examples: echo 256K /sys/block/zram0/disksize echo 512M /sys/block/zram0/disksize echo 1G /sys/block/zram0/disksize Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com Reviewed-by: Nitin Gupta ngu

Re: [PATCH 1/2] zram: factor-out zram_decompress_page() function

2012-10-30 Thread Sergey Senozhatsky
(). now we handle both use after-kfree (as you did in your patch), and use after-kunmap. please review. Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- drivers/staging/zram/zram_drv.c | 91 + 1 file changed, 46 insertions(+), 45

Re: zram: use after free

2012-10-31 Thread Sergey Senozhatsky
I've renamed the topic. On (10/30/12 20:55), Nitin Gupta wrote: == zram: Fix use-after-free in partial I/O case When the compressed size of a page exceeds a threshold, the page is stored as-is i.e. in uncompressed form. In the partial I/O i.e. non-PAGE_SIZE'ed I/O case, however, the

Re: lots of suspicious RCU traces

2012-10-24 Thread Sergey Senozhatsky
On (10/16/12 23:49), Dave Jones wrote: I just triggered this while fuzz testing. All traces happened in quick succession. I can easily reproduce this one [ 5714.696329] === [ 5714.696332] [ INFO: suspicious RCU usage. ] [ 5714.696336]

Re: lots of suspicious RCU traces

2012-10-24 Thread Sergey Senozhatsky
On (10/24/12 20:06), Oleg Nesterov wrote: On 10/24, Sergey Senozhatsky wrote: small question, ptrace_notify() and forward calls are able to both indirectly and directly call schedule(), /* direct call from ptrace_stop()*/, should, in this case, rcu_user_enter() be called before

Re: include/linux/cgroup.h:566 suspicious rcu_dereference_check() usage!

2012-10-09 Thread Sergey Senozhatsky
] [814db660] ? gs_change+0x13/0x13 devcgroup_inode_mknod() part submitted by Paul E. McKenney. Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- security/device_cgroup.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/security

Re: linux-next: manual merge of the kmemleak tree with Linus' tree

2012-10-09 Thread Sergey Senozhatsky
On (10/10/12 14:06), Stephen Rothwell wrote: Hi Catalin, Today's linux-next merge of the kmemleak tree got a conflict in mm/kmemleak.c between commit 85d3a316c714 (kmemleak: use rbtree instead of prio tree) from Linus' tree and commit 48786770bf3b (kmemleak: do not leak object after tree

Re: linux-next: manual merge of the kmemleak tree with Linus' tree

2012-10-09 Thread Sergey Senozhatsky
On (10/10/12 14:06), Stephen Rothwell wrote: Hi Catalin, Today's linux-next merge of the kmemleak tree got a conflict in mm/kmemleak.c between commit 85d3a316c714 (kmemleak: use rbtree instead of prio tree) from Linus' tree and commit 48786770bf3b (kmemleak: do not leak object after tree

Re: include/linux/cgroup.h:566 suspicious rcu_dereference_check() usage!

2012-10-10 Thread Sergey Senozhatsky
] ? __init_kthread_worker+0x5a/0x5a [0.949069] [814db660] ? gs_change+0x13/0x13 devcgroup_inode_mknod() part submitted by Paul E. McKenney. Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- security/device_cgroup.c | 21 + 1 file changed

[PATCH] device_cgroup: RCU read-side protect task_devcgroup() usage

2012-10-10 Thread Sergey Senozhatsky
+0x5a/0x5a [0.949069] [814db660] ? gs_change+0x13/0x13 devcgroup_inode_mknod() part submitted by Paul E. McKenney. Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- security/device_cgroup.c | 21 + 1 file changed, 17 insertions(+), 4 deletions

Re: lots of suspicious RCU traces

2012-10-24 Thread Sergey Senozhatsky
On (10/24/12 20:52), Oleg Nesterov wrote: On 10/24, Sergey Senozhatsky wrote: On (10/24/12 20:06), Oleg Nesterov wrote: On 10/24, Sergey Senozhatsky wrote: small question, ptrace_notify() and forward calls are able to both indirectly and directly call schedule

Re: lots of suspicious RCU traces

2012-10-24 Thread Sergey Senozhatsky
On (10/24/12 12:41), Paul E. McKenney wrote: On Wed, Oct 24, 2012 at 12:17:16PM -0700, Sergey Senozhatsky wrote: On (10/24/12 20:52), Oleg Nesterov wrote: On 10/24, Sergey Senozhatsky wrote: On (10/24/12 20:06), Oleg Nesterov wrote: On 10/24, Sergey Senozhatsky wrote

Re: lots of suspicious RCU traces

2012-10-24 Thread Sergey Senozhatsky
On (10/24/12 13:11), Paul E. McKenney wrote: sorry, I meant idle from RCU point of view: int rcu_is_cpu_idle(void) { return !rcu_dynticks_nesting; } Hmmm... This reproduces on UP builds, then? I'll compile UP build (will offlining of N-1 CPUs do

Re: lots of suspicious RCU traces

2012-10-24 Thread Sergey Senozhatsky
On (10/25/12 00:32), Frederic Weisbecker wrote: First of all, thanks a lot for your report. 2012/10/24 Sergey Senozhatsky sergey.senozhat...@gmail.com: On (10/24/12 20:06), Oleg Nesterov wrote: On 10/24, Sergey Senozhatsky wrote: small question, ptrace_notify() and forward

Re: lots of suspicious RCU traces

2012-10-24 Thread Sergey Senozhatsky
On (10/25/12 00:32), Frederic Weisbecker wrote: My understanding is (I may be wrong) that we can schedule() from ptrace chain to some arbitrary task, which will continue its execution from the point where RCU assumes CPU as not idle, while CPU in fact still in idle state -- no one said

Re: lots of suspicious RCU traces

2012-10-26 Thread Sergey Senozhatsky
On (10/26/12 11:44), Frederic Weisbecker wrote: Thanks. Sergey, Dave, Does the patch I just sent you fix the issue? Patch is [PATCH] rcu: Fix unrecovered RCU user mode in syscall_trace_leave() good job, works fine for me. Tested-by: Sergey Senozhatsky sergey.senozhat...@gmail.com

[PATCH 1/2] zram: factor-out zram_decompress_page() function

2012-10-27 Thread Sergey Senozhatsky
-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- drivers/staging/zram/zram_drv.c | 115 +--- 1 file changed, 50 insertions(+), 65 deletions(-) diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c index 6edefde..7585467 100644

[PATCH 2/2] zram: handle mem suffixes in disk size zram_sysfs parameter

2012-10-27 Thread Sergey Senozhatsky
zram: handle mem suffixes in disk size zram_sysfs parameter Use memparse() to allow mem suffixes in disksize sysfs number. Examples: echo 256K /sys/block/zram0/disksize echo 512M /sys/block/zram0/disksize echo 1G /sys/block/zram0/disksize Signed-off-by: Sergey

Re: [PATCH 2/2] zram: handle mem suffixes in disk size zram_sysfs parameter

2012-10-29 Thread Sergey Senozhatsky
On (10/29/12 10:21), Nitin Gupta wrote: +#include linux/kernel.h #include zram_drv.h @@ -54,13 +55,12 @@ static ssize_t disksize_show(struct device *dev, static ssize_t disksize_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t len) { -

Re: [PATCH 1/2] zram: factor-out zram_decompress_page() function

2012-10-29 Thread Sergey Senozhatsky
On (10/29/12 10:14), Nitin Gupta wrote: Read before write message is not valid in case ZRAM_ZERO flag is set. Its true only in !handle case. do we actually need this message? Otherwise, the patch looks good to me. On a side note, zram still contains a known use-after-free bug

[PATCH 2/2] zram: handle mem suffixes in disk size zram_sysfs parameter (v2)

2012-10-29 Thread Sergey Senozhatsky
zram: handle mem suffixes in disk size zram_sysfs parameter Use memparse() to allow mem suffixes in disksize sysfs number. Examples: echo 256K /sys/block/zram0/disksize echo 512M /sys/block/zram0/disksize echo 1G /sys/block/zram0/disksize Signed-off-by: Sergey

[PATCH 1/2] zram: factor-out zram_decompress_page() function (v2)

2012-10-29 Thread Sergey Senozhatsky
message for handle_zero_page() case to a more general one Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- drivers/staging/zram/zram_drv.c | 115 +--- 1 file changed, 50 insertions(+), 65 deletions(-) diff --git a/drivers/staging/zram

Re: [PATCH 1/2] zram: factor-out zram_decompress_page() function (v2)

2012-10-29 Thread Sergey Senozhatsky
On (10/29/12 11:32), Nitin Gupta wrote: Nothing should be printed (even a debug only message) for the ZRAM_ZERO case. This case can be quite common for certain kinds of data and would cause a huge log spew. Also (!handle) case is not the same as zero-filled page case, so this message would

Re: [PATCH 1/2] zram: factor-out zram_decompress_page() function (v3)

2012-10-29 Thread Sergey Senozhatsky
message for handle_zero_page() case v2: changed debug message for handle_zero_page() case to a more general one Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- drivers/staging/zram/zram_drv.c | 113 +--- 1 file changed, 48 insertions(+), 65

[-next] fs/eventpoll.c:545 suspicious rcu_dereference_check() usage

2013-03-22 Thread Sergey Senozhatsky
Hello, got this with today's linux-next [3.163894] === [3.163895] [ INFO: suspicious RCU usage. ] [3.163897] 3.9.0-rc3-next-20130322-dbg-dirty #1 Not tainted [3.163898] --- [3.163900] fs/eventpoll.c:545 suspicious

Re: [-next] fs/eventpoll.c:545 suspicious rcu_dereference_check() usage

2013-03-24 Thread Sergey Senozhatsky
On (03/23/13 17:34), Eric Wong wrote: Sergey Senozhatsky sergey.senozhat...@gmail.com wrote: [3.163894] === [3.163895] [ INFO: suspicious RCU usage. ] [3.163897] 3.9.0-rc3-next-20130322-dbg-dirty #1 Not tainted [3.163898

Re: radeon causing sleeping function called from invalid context

2013-02-07 Thread Sergey Senozhatsky
On (02/07/13 22:53), Andreas Bombe wrote: On Sun, Jan 13, 2013 at 02:38:20PM +0300, Sergey Senozhatsky wrote: On (01/12/13 20:27), Dave Jones wrote: BUG: sleeping function called from invalid context at mm/slub.c:925 in_atomic(): 1, irqs_disabled(): 0, pid: 566, name: Xorg INFO

[RFC PATCH] x86: use new exception_enter()/exception_exit() API in do_device_not_available()

2012-08-28 Thread Sergey Senozhatsky
] [814d161b] device_not_available+0x1b/0x20 Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- arch/x86/kernel/traps.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index ab82cbd..dff3e72 100644 --- a/arch/x86/kernel/traps.c

Re: [RFC PATCH] x86: use new exception_enter()/exception_exit() API in do_device_not_available()

2012-08-28 Thread Sergey Senozhatsky
On (08/29/12 00:11), Borislav Petkov wrote: Date: Wed, 29 Aug 2012 00:11:13 +0200 From: Borislav Petkov b...@alien8.de To: Sergey Senozhatsky sergey.senozhat...@gmail.com Cc: Thomas Gleixner t...@linutronix.de, Ingo Molnar mi...@redhat.com, H. Peter Anvin h...@zytor.com, x...@kernel.org

Re: [RFC PATCH] x86: use new exception_enter()/exception_exit() API in do_device_not_available() (v2)

2012-08-28 Thread Sergey Senozhatsky
] [814d161b] device_not_available+0x1b/0x20 Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- arch/x86/kernel/traps.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index ab82cbd..fa226ef 100644 --- a/arch/x86/kernel/traps.c

[PATCH] acer-wmi: add Aspire 5741G touchpad toggle key

2012-11-26 Thread Sergey Senozhatsky
Add Aspire 5741G KEY_TOUCHPAD_TOGGLE to wmi keymap, preventing acer_wmi: Unknown key number - 0x85 error. Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- drivers/platform/x86/acer-wmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/acer-wmi.c b

Re: [PATCH] acer-wmi: add Aspire 5741G touchpad toggle key

2012-11-26 Thread Sergey Senozhatsky
On (11/27/12 14:31), joeyli wrote: 於 一,2012-11-26 於 21:35 +0300,Sergey Senozhatsky 提到: Add Aspire 5741G KEY_TOUCHPAD_TOGGLE to wmi keymap, preventing acer_wmi: Unknown key number - 0x85 error. Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com Signed-off-by: Lee, Chun

Re: radeon causing sleeping function called from invalid context

2013-01-13 Thread Sergey Senozhatsky
[811464c1] handle_mm_fault+0x231/0x330 [815facbc] __do_page_fault+0x15c/0x590 [81184cd9] ? do_vfs_ioctl+0x99/0x580 [815ff7c9] ? sysret_check+0x22/0x5d [815fb11b] do_page_fault+0x2b/0x50 [815f79a8] page_fault+0x28/0x30 Signed-off-by: Sergey

Re: [PATCH] Staging:BCM:DDRInit.c:Replacing __FUNCTION__

2013-08-07 Thread Sergey Senozhatsky
On (08/07/13 20:40), Paul McQuade wrote: __func__ replaces __Function__. Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/bcm/DDRInit.c | 75 - 1 file changed, 29 insertions(+), 46 deletions(-) diff --git

Re: [PATCH] LMK: Optimize lowmem_shrink

2013-08-23 Thread Sergey Senozhatsky
On (08/23/13 09:48), Greg KH wrote: Subject: Re: [PATCH] LMK: Optimize lowmem_shrink User-Agent: Mutt/1.5.21 (2010-09-15) On Wed, Aug 21, 2013 at 09:41:05AM +0800, Leon Ma wrote: From: Leon Ma xindong...@intel.com Date: Mon, 19 Aug 2013 14:22:38 +0800 Subject: [PATCH] LMK: Optimize

[sched next] overflowed cpu time for kernel threads in /proc/PID/stat

2013-08-20 Thread Sergey Senozhatsky
Hello, 3.11.0-rc6-next-20130820 at some point an overflowed cpu time is reported in /proc/PID/stat cat /proc/10/stat 10 (rcu_preempt) S 2 0 0 0 -1 2129984 0 0 0 0 0 406 0 0 20 0 1 0 10 0 0 18446744073709551615 0 0 0 0 0 0 0 2147483647 0 18446744073709551615 0 0 17 0 0 0 0 0 0 0 0 0 0 0 0 0 0

[PATCH next] netlink: prevent deadlock in ctrl_dumpfamily()

2013-08-20 Thread Sergey Senozhatsky
that supports parallel_ops. Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- net/netlink/genetlink.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c index f85f8a2..fca3659 100644 --- a/net/netlink/genetlink.c +++ b/net/netlink

Re: [sched next] overflowed cpu time for kernel threads in /proc/PID/stat

2013-08-20 Thread Sergey Senozhatsky
On (08/20/13 17:42), Frederic Weisbecker wrote: On Tue, Aug 20, 2013 at 06:35:50PM +0300, Sergey Senozhatsky wrote: On (08/20/13 17:15), Frederic Weisbecker wrote: On Tue, Aug 20, 2013 at 02:14:26PM +0300, Sergey Senozhatsky wrote: Hello, Please upload your config. I'm

Re: [sched next] overflowed cpu time for kernel threads in /proc/PID/stat

2013-08-20 Thread Sergey Senozhatsky
On (08/20/13 17:42), Frederic Weisbecker wrote: On Tue, Aug 20, 2013 at 06:35:50PM +0300, Sergey Senozhatsky wrote: On (08/20/13 17:15), Frederic Weisbecker wrote: On Tue, Aug 20, 2013 at 02:14:26PM +0300, Sergey Senozhatsky wrote: Hello, Please upload your config. I'm

Re: [PATCH next] netlink: prevent deadlock in ctrl_dumpfamily()

2013-08-20 Thread Sergey Senozhatsky
On (08/20/13 14:03), Berg, Johannes wrote: + if (need_locking) { + /* genl_mutex could be already locked in genl_rcv_msg() */ + rt = genl_family_find_byid(cb-nlh-nlmsg_type); + need_locking = need_locking rt-parallel_ops; + } This is equivalent to

Re: [sched next] overflowed cpu time for kernel threads in /proc/PID/stat

2013-08-21 Thread Sergey Senozhatsky
On (08/20/13 17:42), Frederic Weisbecker wrote: On Tue, Aug 20, 2013 at 06:35:50PM +0300, Sergey Senozhatsky wrote: On (08/20/13 17:15), Frederic Weisbecker wrote: On Tue, Aug 20, 2013 at 02:14:26PM +0300, Sergey Senozhatsky wrote: Hello, Please upload your config. I'm

Re: [LOCKDEP] cpufreq: possible circular locking dependency detected

2013-07-10 Thread Sergey Senozhatsky
On (07/01/13 12:42), Michael Wang wrote: On 06/26/2013 05:15 AM, Sergey Senozhatsky wrote: [snip] [ 60.277848] Chain exists of: ((j_cdbs-work)-work) -- j_cdbs-timer_mutex -- cpu_hotplug.lock [ 60.277864] Possible unsafe locking scenario: [ 60.277869]CPU0

Re: [LOCKDEP] cpufreq: possible circular locking dependency detected

2013-07-11 Thread Sergey Senozhatsky
On (07/11/13 10:43), Michael Wang wrote: Hi, Sergey On 07/11/2013 07:13 AM, Sergey Senozhatsky wrote: [snip] Please kindly review the following patch. Remove cpu device only upon succesful cpu down on CPU_POST_DEAD event, so we can kill off CPU_DOWN_FAILED case

Re: [LOCKDEP] cpufreq: possible circular locking dependency detected

2013-07-11 Thread Sergey Senozhatsky
On (07/11/13 16:47), Michael Wang wrote: On 07/11/2013 04:22 PM, Sergey Senozhatsky wrote: [snip] Hello Michael, nice job! works fine for me. Reported-and-Tested-by: Sergey Senozhatsky sergey.senozhat...@gmail.com Thanks for the test :) Borislav may also doing some testing

[PATCH] LZ4: compression/decompression signedness mismatch

2013-07-12 Thread Sergey Senozhatsky
LZ4 compression and decompression functions require different in signedness input/output parameters: unsigned char for compression and signed char for decompression. Change decompression API to require unsigned char. Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- include

Re: [PATCH] LZ4: compression/decompression signedness mismatch

2013-07-12 Thread Sergey Senozhatsky
= lz4_compress; -decompress = lz4_decompress_unknownoutputsize; the last one produces unneccessary compilation warning. -ss 2013/7/12 Sergey Senozhatsky [2]sergey.senozhat...@gmail.com LZ4 compression and decompression functions require different in signedness

Re: [PATCH staging-next] zram: protect zram_reset_device() call

2013-07-12 Thread Sergey Senozhatsky
On (07/03/13 11:37), Jerome Marchand wrote: Subject: Re: [PATCH staging-next] zram: protect zram_reset_device() call User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 On 06/26/2013 02:28 PM, Sergey Senozhatsky wrote: Commit

[PATCH] radeon kms: do not flush uninitialized hotplug work

2013-07-14 Thread Sergey Senozhatsky
-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- drivers/gpu/drm/radeon/radeon_irq_kms.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_irq_kms.c b/drivers/gpu/drm/radeon/radeon_irq_kms.c index bcdefd1..081886b 100644 --- a/drivers

Re: [LOCKDEP] cpufreq: possible circular locking dependency detected

2013-07-14 Thread Sergey Senozhatsky
@@ struct dbs_data { unsigned int min_sampling_rate; int usage_count; void *tuners; + int queue_stop; /* dbs_mutex protects dbs_enable in governor start/stop */ struct mutex mutex; Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com

Re: [LOCKDEP] cpufreq: possible circular locking dependency detected

2013-07-14 Thread Sergey Senozhatsky
On (07/14/13 14:47), Sergey Senozhatsky wrote: Now, as I fixed radeon kms, I can see: [ 806.660530] [ cut here ] [ 806.660539] WARNING: CPU: 0 PID: 2389 at arch/x86/kernel/smp.c:124 native_smp_send_reschedule+0x57/0x60() Well, this one is obviously not a lockdep

Re: [LOCKDEP] cpufreq: possible circular locking dependency detected

2013-07-15 Thread Sergey Senozhatsky
usage_count; void *tuners; +int queue_stop; /* dbs_mutex protects dbs_enable in governor start/stop */ struct mutex mutex; Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- drivers/cpufreq/cpufreq.c | 5

Re: [LOCKDEP] cpufreq: possible circular locking dependency detected

2013-07-15 Thread Sergey Senozhatsky
this intermediate fix too (2f7021a), to fix the CPU hotplug deadlock. Phew! Reported-by: Sergey Senozhatsky sergey.senozhat...@gmail.com Reported-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Signed-off-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com --- drivers/cpufreq

[PATCH] staging: zram: remove zram_sysfs

2013-06-18 Thread Sergey Senozhatsky
. zram_reset_device()/__zram_reset_device() pair. Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- drivers/staging/zram/Makefile | 2 +- drivers/staging/zram/zram_drv.c | 454 +++--- drivers/staging/zram/zram_drv.h | 12 - drivers/staging/zram

[PATCH staging-next] zram: remove zram_sysfs file

2013-06-21 Thread Sergey Senozhatsky
. zram_reset_device()/__zram_reset_device() pair. Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- drivers/staging/zram/Makefile | 2 +- drivers/staging/zram/zram_drv.c | 524 +- drivers/staging/zram/zram_drv.h | 10 - drivers/staging/zram

Re: [LOCKDEP] cpufreq: possible circular locking dependency detected

2013-07-16 Thread Sergey Senozhatsky
On (07/16/13 14:03), Srivatsa S. Bhat wrote: So here is the solution: On 3.11-rc1, apply these patches in the order mentioned below, and check whether it fixes _all_ problems (both the warnings about IPI as well as the lockdep splat). 1. Patch given in:

cpufreq: possible circular locking detected on suspend

2013-07-16 Thread Sergey Senozhatsky
Hello, extracted as a new thread from https://lkml.org/lkml/2013/7/16/344 cpufreq midifications are: Srivatsa S. Bhat wrote: 1. Patch given in: https://lkml.org/lkml/2013/7/11/661 (Just apply patch 1, not the entire patchset). 2. Apply the patch shown below, on top of the above patch:

Re: [PATCH] LZ4: compression/decompression signedness mismatch

2013-07-18 Thread Sergey Senozhatsky
Hello, On (07/12/13 12:48), Sergey Senozhatsky wrote: On (07/12/13 11:28), Yann Collet wrote: The reference implementation, hosted at :� [1]https://code.google.com/p/lz4/ only proposes char* (signed) types as part of the interface contract. I would recommend to keep

Re: [PATCH] LZ4: compression/decompression signedness mismatch

2013-07-19 Thread Sergey Senozhatsky
On (07/19/13 17:27), Kyungsik Lee wrote: On (07/12/13 11:28), Yann Collet wrote: The reference implementation, hosted at :� [1]https://code.google.com/p/lz4/ only proposes char* (signed) types as part of the interface contract. I would recommend to keep it that

[PATCH] LZ4: compression/decompression signedness mismatch (v2)

2013-07-19 Thread Sergey Senozhatsky
LZ4 compression and decompression functions require different in signedness input/output parameters: unsigned char for compression and signed char for decompression. Change decompression API to require (const) unsigned char *. v2: minor coding style fix. Signed-off-by: Sergey Senozhatsky

Re: [PATCH 1/2] staging: zram: minimize `slot_free_lock' usage

2013-09-09 Thread Sergey Senozhatsky
On (09/09/13 11:33), Dan Carpenter wrote: On Fri, Sep 06, 2013 at 05:55:45PM +0300, Sergey Senozhatsky wrote: On (09/06/13 16:42), Jerome Marchand wrote: On 09/06/2013 03:47 PM, Sergey Senozhatsky wrote: Calling handle_pending_slot_free() for every RW operation may cause unneccessary

Re: [PATCH 1/2] staging: zram: minimize `slot_free_lock' usage (v2)

2013-09-09 Thread Sergey Senozhatsky
Calling handle_pending_slot_free() for every RW operation may cause unneccessary slot_free_lock locking, because most likely process will see NULL slot_free_rq. handle_pending_slot_free() only when current detects that slot_free_rq is not NULL. v2: protect handle_pending_slot_free()

Re: [PATCH 1/2] staging: zram: minimize `slot_free_lock' usage (v2)

2013-09-09 Thread Sergey Senozhatsky
On (09/09/13 16:21), Dan Carpenter wrote: On Mon, Sep 09, 2013 at 03:49:42PM +0300, Sergey Senozhatsky wrote: Calling handle_pending_slot_free() for every RW operation may cause unneccessary slot_free_lock locking, because most likely process will see NULL slot_free_rq

Re: [PATCH 1/2] staging: zram: minimize `slot_free_lock' usage (v2)

2013-09-09 Thread Sergey Senozhatsky
On (09/09/13 17:52), Dan Carpenter wrote: On Mon, Sep 09, 2013 at 05:42:59PM +0300, Sergey Senozhatsky wrote: 3) Explain why it is safe to test zram-slot_free_rq when we are not holding the lock. I think it is unsafe. I don't want to even think about it without the numbers

Re: [PATCH 1/2] staging: zram: minimize `slot_free_lock' usage (v2)

2013-09-10 Thread Sergey Senozhatsky
On (09/09/13 18:10), Jerome Marchand wrote: On 09/09/2013 03:46 PM, Jerome Marchand wrote: On 09/09/2013 03:21 PM, Dan Carpenter wrote: On Mon, Sep 09, 2013 at 03:49:42PM +0300, Sergey Senozhatsky wrote: Calling handle_pending_slot_free() for every RW operation may cause unneccessary

[PATCH 1/2] staging: zram: fix handle_pending_slot_free() and zram_reset_device() race

2013-09-10 Thread Sergey Senozhatsky
-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- drivers/staging/zram/zram_drv.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c index 91d94b5..7a2d4de 100644 --- a/drivers/staging/zram

[PATCH 2/2] staging: zram: remove init_done from zram struct (v3)

2013-09-10 Thread Sergey Senozhatsky
`zram-init_done' in fact mimics `zram-meta != NULL' value. Introduce init_done() function that checks zram-meta (iow, checks if initialisation was performed), so `zram-init_done' can be removed. v3: init_done() in handle_pending_slot_free() v2: introduce init_done() Signed-off-by: Sergey

Re: [PATCH 1/2] staging: zram: minimize `slot_free_lock' usage (v2)

2013-09-10 Thread Sergey Senozhatsky
On (09/10/13 17:34), Sergey Senozhatsky wrote: [..] Now I think we can drop the call to handle_pending_slot_free() in zram_bvec_rw() altogether. As long as the write lock is held when handle_pending_slot_free() is called, there is no race. It's no different from any write request

Re: [117/251] radeon kms: do not flush uninitialized hotplug work

2013-09-11 Thread Sergey Senozhatsky
prepare a proper patch for stable. -ss -- From: Sergey Senozhatsky sergey.senozhat...@gmail.com [ Upstream commit a01c34f72e7cd2624570818f579b5ab464f93de2 ] Fix a warning from lockdep caused by calling flush_work() for uninitialized hotplug work. Initialize

Re: [117/251] radeon kms: do not flush uninitialized hotplug work

2013-09-11 Thread Sergey Senozhatsky
flush_work_sync() in radeon_irq_kms_fini() to rdev-irq.installed == true case (am I right?). if so, then looks good to me! -ss -- Steve From 39a678bf28d5c3e8266bd88ba1e831818102787e Mon Sep 17 00:00:00 2001 From: Sergey Senozhatsky sergey.senozhat...@gmail.com Date: Thu, 29 Aug 2013 12:29:35

Re: [117/251] radeon kms: do not flush uninitialized hotplug work

2013-09-11 Thread Sergey Senozhatsky
Reported-by: Meelis Roos mr...@linux.ee Tested-by: Meelis Roos mr...@linux.ee Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- drivers/gpu/drm/radeon/radeon_irq_kms.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_irq_kms.c

Re: [117/251] radeon kms: do not flush uninitialized hotplug work

2013-09-11 Thread Sergey Senozhatsky
On (09/11/13 12:13), Steven Rostedt wrote: On Wed, 11 Sep 2013 09:00:16 -0700 Greg KH gre...@linuxfoundation.org wrote: On Wed, Sep 11, 2013 at 05:36:29PM +0300, Sergey Senozhatsky wrote: This one on top of stable 3.6.11 git. What do you mean by this? I thought it was for linux

Re: [117/251] radeon kms: do not flush uninitialized hotplug work

2013-09-11 Thread Sergey Senozhatsky
On (09/11/13 14:54), Steven Rostedt wrote: On (09/11/13 12:13), Steven Rostedt wrote: On Wed, 11 Sep 2013 09:00:16 -0700 Greg KH gre...@linuxfoundation.org wrote: On Wed, Sep 11, 2013 at 05:36:29PM +0300, Sergey Senozhatsky wrote: This one on top of stable 3.6.11 git

Re: [PATCH 1/2] staging: zram: fix handle_pending_slot_free() and zram_reset_device() race

2013-09-13 Thread Sergey Senozhatsky
On (09/12/13 15:12), Greg KH wrote: On Wed, Sep 11, 2013 at 02:12:50AM +0300, Sergey Senozhatsky wrote: Dan Carpenter noted that handle_pending_slot_free() is racy with zram_reset_device(). Take write init_lock in zram_slot_free(), thus preventing any concurrent zram_slot_free

Re: [PATCH 2/2] staging: zram: add per-cpu support to Crypto

2013-07-30 Thread Sergey Senozhatsky
throughput for 8 mixed workload= 2957859.84 KB/sec Parent sees throughput for 8 mixed workload = 1859763.07 KB/sec Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- drivers/staging/zram/zram_drv.c | 604 +++- drivers/staging/zram

[PATCH next] n_tty: change lock oreding in n_tty_read()

2013-08-01 Thread Sergey Senozhatsky
] [8117987a] vfs_read+0x9a/0x170 [ 463.542671] [8117a05c] SyS_read+0x4c/0xa0 [ 463.542674] [81610c7e] tracesys+0xd0/0xd5 Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- drivers/tty/n_tty.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff

Re: [PATCH next] n_tty: change lock oreding in n_tty_read()

2013-08-01 Thread Sergey Senozhatsky
Oops. Really sorry about that. I didn't pay attention and made a silly typo in the Subject line. Of course, it was going to be change lock *ordering* in n_tty_read(). I'll resend the patch. -ss On (08/01/13 22:31), Sergey Senozhatsky wrote: Acquire atomic_read_lock before termios_rwsem

[PATCH next] n_tty: change lock ordering in n_tty_read() (v2)

2013-08-01 Thread Sergey Senozhatsky
] [8117987a] vfs_read+0x9a/0x170 [ 463.542671] [8117a05c] SyS_read+0x4c/0xa0 [ 463.542674] [81610c7e] tracesys+0xd0/0xd5 v2: correct subject typo. Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com --- drivers/tty/n_tty.c | 15 ++- 1 file changed, 6

Re: [PATCH next] n_tty: change lock ordering in n_tty_read() (v2)

2013-08-01 Thread Sergey Senozhatsky
On (08/01/13 16:01), Peter Hurley wrote: On 08/01/2013 03:46 PM, Sergey Senozhatsky wrote: Acquire atomic_read_lock before termios_rwsem rw-lock in n_tty_read(). termios_rwsem is getting released and re-acquired, while remaining readers are blocked on atomic_read_lock mutex, in case when

[libtraceevent] hrtimer_expire_entry unknown op '{'

2013-11-05 Thread Sergey Senozhatsky
Hello, libtraceevent reports ` unknown op '{' ' while processing hrtimer_expire_entry event cat /sys/kernel/debug/tracing/events/timer/hrtimer_expire_entry/format name: hrtimer_expire_entry ID: 91 format: field:unsigned short common_type; offset:0; size:2; signed:0;

Re: [libtraceevent] hrtimer_expire_entry unknown op '{'

2013-11-05 Thread Sergey Senozhatsky
On (11/05/13 08:15), Steven Rostedt wrote: Date: Tue, 5 Nov 2013 08:15:22 -0500 From: Steven Rostedt rost...@goodmis.org To: Sergey Senozhatsky sergey.senozhat...@gmail.com Cc: Arnaldo Carvalho de Melo a...@redhat.com, Namhyung Kim namhy...@kernel.org, Jon Stanley jonstan...@gmail.com, Sasha

Re: [PATCH 1/2] staging: zram: fix handle_pending_slot_free() and zram_reset_device() race

2013-09-17 Thread Sergey Senozhatsky
opinion. On Wed, Sep 11, 2013 at 02:12:50AM +0300, Sergey Senozhatsky wrote: Dan Carpenter noted that handle_pending_slot_free() is racy with zram_reset_device(). Take write init_lock in zram_slot_free(), thus Right but init_lock is what I really want to remove. Yes. It's just read-side lock so

Re: [libtraceevent] hrtimer_expire_entry unknown op '{'

2013-11-12 Thread Sergey Senozhatsky
On (11/05/13 08:15), Steven Rostedt wrote: Hello, libtraceevent reports ` unknown op '{' ' while processing hrtimer_expire_entry event Yes, we need to port the plugin code from trace-cmd to handle this and other cases. It's a known issue. Hello Steven, sorry if I'm bothering you

Re: [libtraceevent] hrtimer_expire_entry unknown op '{'

2013-11-12 Thread Sergey Senozhatsky
On (11/12/13 16:52), Steven Rostedt wrote: On (11/05/13 08:15), Steven Rostedt wrote: Hello, libtraceevent reports ` unknown op '{' ' while processing hrtimer_expire_entry event Yes, we need to port the plugin code from trace-cmd to handle this and other cases. It's a

Re: [PATCH] zram: include linux/err.h

2014-03-15 Thread Sergey Senozhatsky
Hello Arnd, On (03/15/14 10:40), Arnd Bergmann wrote: The zram driver uses the ERR_PTR macro defined in linux/err.h and relies on this header to be included implicitly through other headers, which is not (always) the case on the ARM architecture. returned from zcomp ERR_PTR is checked and

zram: zsmalloc calls sleeping function from atomic context

2014-03-17 Thread Sergey Senozhatsky
Hello gents, I just noticed that starting from commit commit 3d693a5127e79e79da7c34dc0c776bc620697ce5 Author: Andrew Morton a...@linux-foundation.org Date: Mon Mar 17 11:23:56 2014 +1100 mm-vmalloc-avoid-soft-lockup-warnings-when-vunmaping-large-ranges-fix add a might_sleep() to

Re: [PATCHv6 3/6] zram: factor out single stream compression

2014-02-24 Thread Sergey Senozhatsky
Hello Minchan, thanks for your review. On (02/24/14 11:31), Minchan Kim wrote: Hello Sergey, On Fri, Feb 21, 2014 at 02:50:40PM +0300, Sergey Senozhatsky wrote: This is preparation patch to add multi stream support to zcomp. Introduce struct zcomp_strm_single and a set of functions

Re: [PATCHv6 2/6] zram: use zcomp compressing backends

2014-02-24 Thread Sergey Senozhatsky
On (02/24/14 10:01), Minchan Kim wrote: On Fri, Feb 21, 2014 at 02:50:39PM +0300, Sergey Senozhatsky wrote: Do not perform direct LZO compress/decompress calls, initialise and use zcomp LZO backend (single compression stream) instead. Signed-off-by: Sergey Senozhatsky sergey.senozhat

Re: [PATCHv6 3/6] zram: factor out single stream compression

2014-02-24 Thread Sergey Senozhatsky
Good morning Minchan, On (02/25/14 08:07), Minchan Kim wrote: Hello Sergey, On Mon, Feb 24, 2014 at 11:31:52AM +0300, Sergey Senozhatsky wrote: Hello Minchan, thanks for your review. On (02/24/14 11:31), Minchan Kim wrote: Hello Sergey, On Fri, Feb 21, 2014 at 02:50:40PM

Re: [PATCHv6 4/6] zram: add multi stream functionality

2014-02-24 Thread Sergey Senozhatsky
On (02/25/14 08:43), Minchan Kim wrote: On Fri, Feb 21, 2014 at 02:50:41PM +0300, Sergey Senozhatsky wrote: This patch implements multi stream compression support. Introduce struct zcomp_strm_multi and a set of functions to manage zcomp_strm stream access. zcomp_strm_multi has a list

Re: [PATCHv6 5/6] zram: enalbe multi stream compression support in zram

2014-02-24 Thread Sergey Senozhatsky
On (02/25/14 08:53), Minchan Kim wrote: On Fri, Feb 21, 2014 at 02:50:42PM +0300, Sergey Senozhatsky wrote: 1) Add ZRAM_MULTI_STREAM configuration option and make multi stream zcomp support available. 2) Introduce zram device attribute max_comp_streams to show and store current zcomp's

  1   2   3   4   5   6   7   8   9   10   >