[PATCH][intel_agp] fix name for G35 chipset

2008-01-06 Thread Zhenyu Wang
Change origin chipset name i965G_1 to market name G35. Signed-off-by: Zhenyu Wang [EMAIL PROTECTED] --- drivers/char/agp/intel-agp.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c index d879619

[PATCH][AGP] intel_agp: add new chipset ids

2008-01-08 Thread Zhenyu Wang
Dave, This one adds new pci ids for Intel intergrated graphics chipset, with gtt table access change on it and new gtt table size definition. Thanks. Signed-off-by: Zhenyu Wang [EMAIL PROTECTED] --- drivers/char/agp/agp.h |3 +++ drivers/char/agp/intel-agp.c | 31

Re: X-freeze after clflush changes [Was: 2.6.23-rc6-mm1]

2007-09-20 Thread Zhenyu Wang
On 2007.09.20 17:33:45 +, Dave Airlie wrote: Maybe you are rather interested in these dmesg lines: Linux agpgart interface v0.102 agpgart: suspend/resume problematic: resume with 3D/DRI active may lockup X.Org on some chipset/BIOS combos (see DEBUG_AGP_PM in intel-agp.c) agpgart:

[RFC][PATCH 0/4] enabling graphics memory dma remapping

2007-12-17 Thread Zhenyu Wang
Intel IOMMU (a.k.a VT-d) is under rapid deployment on desktop and mobile platforms. As platform provides multiple dma remap engines for devices like those lives on south bridge (net, sound, etc.), and we also have one engine specific to graphics device. If this engine is functioning, the access

[RFC][PATCH 1/4][intel_iommu] explicit export current graphics dmar status

2007-12-17 Thread Zhenyu Wang
current status of DMAR, which would be used for completely express graphics dmar engine is active or not. Signed-off-by: Zhenyu Wang [EMAIL PROTECTED] --- drivers/pci/intel-iommu.c | 18 -- include/linux/dmar.h |6 ++ 2 files changed, 22 insertions(+), 2 deletions

[RFC][PATCH 2/4][AGP] Add generic support for graphics dma remapping

2007-12-17 Thread Zhenyu Wang
also been made to handle scratch_page in remapping case. Signed-off-by: Zhenyu Wang [EMAIL PROTECTED] --- drivers/char/agp/agp.h | 14 ++ drivers/char/agp/backend.c | 21 - drivers/char/agp/generic.c | 14 ++ include/linux/agp_backend.h

[RFC][PATCH 3/4][AGP] intel_agp: add support for graphics dma remapping on G33

2007-12-17 Thread Zhenyu Wang
support on G33 chipset, which has graphics device specific dmar engine avaiable. Signed-off-by: Zhenyu Wang [EMAIL PROTECTED] --- drivers/char/agp/Kconfig | 12 +++- drivers/char/agp/intel-agp.c | 134 +- 2 files changed, 141 insertions(+), 5

[agp-mm][PATCH 0/4] enabling graphics memory dma remapping

2007-12-18 Thread Zhenyu Wang
On 2007.12.18 13:08:09 +, Zhenyu Wang wrote: Here're three patches below: - intel_iommu-explicit-export-current-graphics-dmar-status.patch This exports current status of graphics dma remap engine, which depends on current platform iommu support, kernel config or runtime

[agp-mm][PATCH 1/4][intel_iommu] explicit export current graphics dmar status

2007-12-18 Thread Zhenyu Wang
current status of DMAR, which would be used for completely express graphics dmar engine is active or not. Signed-off-by: Zhenyu Wang [EMAIL PROTECTED] --- drivers/pci/intel-iommu.c | 18 -- include/linux/dmar.h |6 ++ 2 files changed, 22 insertions(+), 2 deletions

[agp-mm][PATCH 2/4][AGP] Add generic support for graphics dma remapping

2007-12-18 Thread Zhenyu Wang
also been made to handle scratch_page in remapping case. Signed-off-by: Zhenyu Wang [EMAIL PROTECTED] --- drivers/char/agp/agp.h | 13 + drivers/char/agp/backend.c | 21 - drivers/char/agp/generic.c | 14 ++ include/linux/agp_backend.h |7

[agp-mm][PATCH 3/4][AGP] intel_agp: add support for graphics dma remapping on G33

2007-12-18 Thread Zhenyu Wang
support on G33 chipset, which has graphics device specific dmar engine avaiable. Signed-off-by: Zhenyu Wang [EMAIL PROTECTED] --- drivers/char/agp/Kconfig | 12 +++- drivers/char/agp/intel-agp.c | 134 +- 2 files changed, 141 insertions(+), 5

Re: linux-2.6.24-rcX regression / xserver-xorg-video-intel / Q35

2007-12-22 Thread Zhenyu Wang
On 2007.12.22 01:25:16 +0100, Harald Welte wrote: I'm running an Intel DQ35JO mainboard (Q35 chipset, Q6600 CPU) and I am observing a regression with linux-2.6.24-rc1 through -rc6 (linux-2.6.git as of today, ea67db4cdbbf7f4e74150e71da0984e25121f500). The last working version is 2.6.24-rc1.

Re: 2.6.24-rc6-git7: Reported regressions from 2.6.23

2008-01-01 Thread Zhenyu Wang
http://bugzilla.kernel.org/show_bug.cgi?id=9618 Handled-By: Zhenyu Wang [EMAIL PROTECTED] Patch : This is resolved by turning on CONFIG_DMAR_GFX_WA. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [agp-mm][PATCH 1/4][intel_iommu] explicit export current graphics dmar status

2008-01-03 Thread Zhenyu Wang
On 2007.12.19 13:26:08 +, Zhenyu Wang wrote: [agp-mm] [intel_iommu] explicit export current graphics dmar status To make it possbile to tell other modules about curent graphics dmar engine status, that could decide if graphics driver should remap physical address to dma address

Re: X-freeze after clflush changes [Was: 2.6.23-rc6-mm1]

2007-09-20 Thread Zhenyu Wang
On 2007.09.21 00:10:26 +, Jiri Slaby wrote: Could you try current xf86-video-intel driver? just do git clone git://anongit.freedesktop.org/git/xorg/driver/xf86-video-intel It works! yep, I also pushed a fix for G33 in xf86-video-intel when fixing the intel agp. So for G33 user, you

[PATCH] [AGPGART] intel_agp: fix stolen mem range on G33

2007-09-05 Thread Zhenyu Wang
Subject: [PATCH] [AGPGART] intel_agp: fix stolen mem range on G33 G33 GTT stolen memory is below graphics data stolen memory and be seperate, so don't subtract it in stolen mem counting. Signed-off-by: Zhenyu Wang [EMAIL PROTECTED] --- drivers/char/agp/intel-agp.c |5 + 1 files changed

[PATCH] [AGPGART] intel_agp: fix GTT map size on G33

2007-09-05 Thread Zhenyu Wang
Subject: [PATCH] [AGPGART] intel_agp: fix GTT map size on G33 G33 has 1MB GTT table range. Fix GTT mapping in case like 512MB aperture size. Signed-off-by: Zhenyu Wang [EMAIL PROTECTED] --- drivers/char/agp/intel-agp.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git

Re: [agp-mm][PATCH 1/4][intel_iommu] explicit export current graphics dmar status

2008-01-24 Thread Zhenyu Wang
boot param to turn off whole intel iommu (intel_iommu=off), just turn off graphics remap engine (intel_iommu=igfx_off). So this exported interface is used to know that in runtime. Signed-off-by: Zhenyu Wang [EMAIL PROTECTED] --- drivers/pci/intel-iommu.c | 18

Re: [agp-mm][PATCH 1/4][intel_iommu] explicit export current graphics dmar status

2008-01-28 Thread Zhenyu Wang
On 2008.01.25 10:08:20 -0800, mark gross wrote: This is used for our graphics driver module to know if we have to do dma remapping in iommu case, both in kernel config and kernel boot time param config. ok. How soon do you need this export? As graphics part of these patches depend on

[AGPGART] intel_agp: fix ids for 945GME, 965GME

2007-07-19 Thread Zhenyu Wang
Subject: [PATCH] [AGPGART] intel_agp: fix ids for 945GME and 965GME These chipsets actually have new host bridge ids. This should fix the gart init problem on them. Please apply, thanks. Signed-off-by: Wang Zhenyu [EMAIL PROTECTED] --- drivers/char/agp/intel-agp.c | 10 ++ 1 files

Re: [Intel-gfx] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

2014-06-23 Thread Zhenyu Wang
...@intel.com This was added historically when supporting graphics device passthrough. Looks qemu upstream can't accept multiple ISA bridge and our PCH is always on device 31: func0 as far as I know. Looks good to me. Reviewed-by: Zhenyu Wang zhen...@linux.intel.com -- Open Source Technology Center, Intel

Re: [RFC 0/6] Non perf based Gen Graphics OA unit driver

2015-09-29 Thread Zhenyu Wang
On 2015.09.29 15:39:03 +0100, Robert Bragg wrote: > > - Logistically it might be more practical to contain this to the > graphics stack. > > It seems fair to consider that if we can't see a very compelling > benefit to building on perf, then containing this work to >

Re: [igvt-g-dev] [PATCH] drm/i915/gvt: Fix kmem_cache_create() name

2017-01-24 Thread Zhenyu Wang
On 2017.01.24 13:15:43 -0700, Alex Williamson wrote: > According to kmem_cache_sanity_check(), spaces are not allowed in the > name of a cache and results in a kernel oops with CONFIG_DEBUG_VM. > Convert to underscores. > > Signed-off-by: Alex Williamson > --- Will

Re: [igvt-g-dev] [PATCH] drm/i915/gvt/kvmgt: mdev ABI is available_instances, not available_instance

2017-01-24 Thread Zhenyu Wang
On 2017.01.24 12:53:45 -0700, Alex Williamson wrote: > Per the ABI specification[1], each mdev_supported_types entry should > have an available_instances, with an "s", not available_instance. > > [1] Documentation/ABI/testing/sysfs-bus-vfio-mdev > > Signed-off-by: Alex Williamson

Re: [PATCH -next] drm/i915/gvt: fix return value check

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 16:18:03 +, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function i915_gem_object_create() returns > ERR_PTR() not NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun

Re: [PATCH 2/2] drm/i915/gvt: fix compilation

2016-10-21 Thread Zhenyu Wang
On 2016.10.21 17:25:50 +0200, Arnd Bergmann wrote: > Two functions in the newly added gvt render code are obviously > broken, as they reference a variable without initialization and > don't reference another variable at all: > > drivers/gpu/drm/i915/gvt/render.c: In function >

Re: [PATCH 1/2] drm/i915/gvt: add ACPI and 64BIT dependencies

2016-10-21 Thread Zhenyu Wang
On 2016.10.21 17:25:49 +0200, Arnd Bergmann wrote: > The newly added gvt code produces lots of serious warnings and errors > when either built on 32-bit x86, or built with ACPI disabled, e.g. > > drivers/gpu/drm/i915/gvt/gtt.c: In function ???read_pte64???: > drivers/gpu/drm/i915/gvt/gtt.c:277:2:

Re: [Intel-gfx] linux-next: Tree for Oct 20 (gpu/drm/i915)

2016-10-20 Thread Zhenyu Wang
On 2016.10.20 21:25:03 +0300, Jani Nikula wrote: > On Thu, 20 Oct 2016, Daniel Vetter wrote: > > On Thu, Oct 20, 2016 at 7:37 PM, Randy Dunlap wrote: > >> On 10/19/16 20:20, Stephen Rothwell wrote: > >>> Hi all, > >>> > >>> Changes since 20161019: > >>> >

Re: linux-next: build warnings after merge of the drm-intel tree

2016-10-18 Thread Zhenyu Wang
On 2016.10.19 10:57:53 +1100, Stephen Rothwell wrote: > Hi all, > > After merging the drm-intel tree, today's linux-next build (x86_64 > allmodconfig) produced these warnings: > > drivers/gpu/drm/i915/gvt/execlist.c: In function > 'release_shadow_batch_buffer': >

Re: [PATCH v14 00/22] Add Mediated device support

2016-11-18 Thread Zhenyu Wang
On 2016.11.17 16:51:45 -0700, Alex Williamson wrote: > On Thu, 17 Nov 2016 23:29:38 + > "Tian, Kevin" wrote: > > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > Sent: Friday, November 18, 2016 5:25 AM > > > > > > On Thu, 17 Nov 2016 02:16:12 +0530 >

[RESEND][GIT PULL] i915/gvt KVMGT tree for 4.10

2016-12-16 Thread Zhenyu Wang
Hi, Linus This is KVMGT pull for 4.10 as explained by Daniel. The last minute rebase is to appease git pull-request since the diffstat was obvious bonghits and somehow included vfio/mdev again despite that was merged already. Thanks. The following changes since commit

Re: [PATCH] drm/i915/gvt: fix deadlock in dispatch_workload()'s error path

2016-12-04 Thread Zhenyu Wang
On 2016.12.04 23:57:18 +, Eric Engestrom wrote: > 90d27a1 moved the lock before this error path but forgot to add an > unlock here. > > Fixes: 90d27a1b180e51ef0713 ("drm/i915/gvt: fix deadlock in workload_thread") > Cc: Pei Zhang <pei.zh...@intel.

Re: linux-next: build failure after merge of the drm-intel-fixes tree

2017-01-03 Thread Zhenyu Wang
On 2017.01.02 21:48:57 -0700, Alex Williamson wrote: > > Alex, I liked to have kvmgt related mdev interface change be merged through > > vfio tree, but wasn't awared one of Jike's fix had conflict. Could you apply > > below fix in your tree? I think in general for possible interface change in > >

Re: linux-next: build failure after merge of the drm-intel-fixes tree

2017-01-02 Thread Zhenyu Wang
On 2017.01.03 10:42:39 +1100, Stephen Rothwell wrote: > Hi all, > > After merging the drm-intel-fixes tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/gpu/drm/i915/gvt/kvmgt.c: In function 'intel_vgpu_open': > drivers/gpu/drm/i915/gvt/kvmgt.c:511:32: error:

Re: [igvt-g-dev] [PATCH 1/1] drm/i915/gvt: verify functions types in new_mmio_info()

2016-12-26 Thread Zhenyu Wang
On 2016.12.26 14:52:23 +0100, Nicolas Iooss wrote: > The current prototype of new_mmio_info() uses void* for parameters read > and write, which are functions with precise calling conventions > (argument types and return type). Write down these conventions in > new_mmio_info() definition. > > This

Re: [PATCH] drm/i915/kvmgt: avoid dereferencing a potentially null info pointer

2017-03-23 Thread Zhenyu Wang
On 2017.03.23 14:43:44 +0100, Frans Klaver wrote: > On Thu, Mar 23, 2017 at 1:22 PM, Colin King wrote: > > From: Colin Ian King > > > > info is being checked to see if it is a null pointer, however, vpgu is > > dereferencing info before this

Re: [PATCH] kvmgt: Hold struct kvm reference

2017-03-20 Thread Zhenyu Wang
..@redhat.com> > > Cc: sta...@vger.kernel.org #v4.10 > > Cc: Jike Song <jike.s...@intel.com> > > Cc: Paolo Bonzini <pbonz...@redhat.com> > > Cc: Zhenyu Wang <zhen...@linux.intel.com> > > Cc: Zhi Wang <zhi.a.w...@intel.com> > > --- > >

Re: [PATCH] drm/i915: disable KASAN for handlers

2017-03-31 Thread Zhenyu Wang
;jsl...@suse.cz> > Cc: Martin Liska <mli...@suse.cz> > Cc: Zhenyu Wang <zhen...@linux.intel.com> > Cc: Zhi Wang <zhi.a.w...@intel.com> > Cc: Daniel Vetter <daniel.vet...@intel.com> > Cc: Jani Nikula <jani.nik...@linux.intel.com> > Cc: David Airlie &

Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation

2017-07-11 Thread Zhenyu Wang
On 2017.07.11 11:12:36 +0200, Daniel Vetter wrote: > On Tue, Jul 11, 2017 at 08:14:08AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > > +struct vfio_device_query_gfx_plane { > > > > + __u32 argsz; > > > > + __u32 flags; > > > > + struct vfio_device_gfx_plane_info plane_info; >

Re: [PATCH] drm/i915/gvt: fix typo: "supporte" -> "support"

2017-04-27 Thread Zhenyu Wang
On 2017.04.25 10:05:12 +0100, Colin King wrote: > From: Colin Ian King > > trivial fix to typo in WARN_ONCE message > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/i915/gvt/handlers.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v6 3/6] drm/i915/gvt: Frame buffer decoder support for GVT-g

2017-05-30 Thread Zhenyu Wang
On 2017.05.27 16:38:49 +0800, Xiaoguang Chen wrote: > decode frambuffer attributes of primary, cursor and sprite plane > > Signed-off-by: Xiaoguang Chen > --- > drivers/gpu/drm/i915/gvt/Makefile | 3 +- > drivers/gpu/drm/i915/gvt/display.c| 2 +- >

Re: [PATCH] drm/i915/gvt: remove redundant -Wall

2017-05-31 Thread Zhenyu Wang
On 2017.05.21 00:15:27 -0700, Nick Desaulniers wrote: > This flag is already set in the top level Makefile of the kernel. > > Also, by having set CONFIG_DRM_I915_GVT, thereby appending -Wall to > ccflags, you undo all the -Wno-* cflags previously set in the Make > variable KBUILD_CFLAGS. > > For

Re: [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g

2017-05-30 Thread Zhenyu Wang
On 2017.05.27 16:38:48 +0800, Xiaoguang Chen wrote: > OpRegion is needed to support display related operation for > intel vgpu. > > A vfio device region is added to intel vgpu to deliver the > host OpRegion information to user space so user space can > construct the OpRegion for vgpu. > >

Re: [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g

2017-05-31 Thread Zhenyu Wang
On 2017.05.31 06:22:28 +, Chen, Xiaoguang wrote: > >> @@ -467,6 +555,15 @@ static int intel_vgpu_create(struct kobject *kobj, > >struct mdev_device *mdev) > >>vgpu->vdev.mdev = mdev; > >>mdev_set_drvdata(mdev, vgpu); > >> > >> + ret = intel_vgpu_reg_init_opregion(vgpu); > >> + if

Re: [PATCH v8 3/6] drm/i915/gvt: Frame buffer decoder support for GVT-g

2017-06-14 Thread Zhenyu Wang
On 2017.06.09 14:50:39 +0800, Xiaoguang Chen wrote: > decode frambuffer attributes of primary, cursor and sprite plane > > Signed-off-by: Xiaoguang Chen ... > +/** > + * intel_vgpu_decode_primary_plane - Decode primary plane > + * @vgpu: input vgpu > + * @plane:

Re: [PATCH][drm-next] drm/i915/gvt: ensure -ve return value is handled correctly

2017-09-19 Thread Zhenyu Wang
On 2017.09.19 16:55:34 +0100, Colin King wrote: > From: Colin Ian King > > An earlier fix changed the return type from find_bb_size however the > integer return is being assigned to a unsigned int so the -ve error > check will never be detected. Make bb_size an int to

Re: [PATCH][drm-next] drm/i915/gvt: ensure -ve return value is handled correctly

2017-09-20 Thread Zhenyu Wang
On 2017.09.19 19:35:23 -0700, Joe Perches wrote: > On Wed, 2017-09-20 at 05:46 +0800, Zhenyu Wang wrote: > > On 2017.09.19 16:55:34 +0100, Colin King wrote: > > > From: Colin Ian King <colin.k...@canonical.com> > > > > > > An earlier fix changed

Re: [PATCH v18 0/6] drm/i915/gvt: Dma-buf support for GVT-g

2017-11-22 Thread Zhenyu Wang
On 2017.11.15 11:49:00 +0100, Gerd Hoffmann wrote: > On Wed, Nov 15, 2017 at 05:11:49PM +0800, Tina Zhang wrote: > > v17->v18: > > 1) unmap vgpu's opregion when destroying vgpu. > > 2) update comments for VFIO_DEVICE_GET_GFX_DMABUF. (Alex) > > > This patch set adds the dma-buf support for intel

Re: [PATCH] vfio: Simplify capability helper

2017-12-12 Thread Zhenyu Wang
am...@redhat.com> > > > Makes more sense now, thanks. I'll repost mine on top of this. > > > Reviewed-by: Alexey Kardashevskiy <a...@ozlabs.ru> > > Looks good for KVMGT part. Acked-by: Zhenyu Wang <zhen...@linux.intel.com> > Below o

Re: [PATCH v18 5/6] vfio: ABI for mdev display dma-buf operation

2017-11-15 Thread Zhenyu Wang
On 2017.11.15 11:48:42 -0700, Alex Williamson wrote: > On Wed, 15 Nov 2017 17:11:54 +0800 > Tina Zhang wrote: > > > Add VFIO_DEVICE_QUERY_GFX_PLANE ioctl command to let user query and get > > a plane and its information. So far, two types of buffers are supported: > >

Re: linux-next: Signed-off-by missing for commits in the drm tree

2017-12-03 Thread Zhenyu Wang
On 2017.12.04 10:57:35 +1100, Stephen Rothwell wrote: > Hi all, > > There is a series of commits > > 54cff6479fd8 - c1802534e5a6 > (not all in that range) > > that are missing a Signed-off-by from their committer. > They were originally committed by Zhi himself, but I had to rebase onto

Re: [PATCH] drm/i915/gvt/fb_decoder: Fix out-of-bounds read

2017-12-11 Thread Zhenyu Wang
On 2017.12.09 00:37:59 -0600, Gustavo A. R. Silva wrote: > In case function skl_format_to_drm returns -EINVAL, fmt turns into a huge > number as fmt is of type u32, hence there is an out-of-bounds read when > using fmt as an index for array skl_pixel_formats at line 225: > plane->bpp =

Re: [PATCH v4 1/2] vfio/mdev: Check globally for duplicate devices

2018-05-22 Thread Zhenyu Wang
equivalent course grained serialization if > necessary. Of course it would be better to implement that sooner > rather than later if required. > > I see that __intel_gvt_create_vgpu() makes use of gvt->lock, which > would seem to already provide this level of per-parent l

Re: [PATCH][drm-next] drm/i915/gvt: fix spelling mistake: "destoried" -> "destroyed"

2018-03-12 Thread Zhenyu Wang
On 2018.03.12 12:43:58 +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in gvt_err error message text. > > Signed-off-by: Colin Ian King > --- Thanks Colin, will pick up. > drivers/gpu/drm/i915/gvt/gtt.c

Re: [PATCH] drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs

2018-03-22 Thread Zhenyu Wang
On 2018.03.22 21:31:33 +, Chris Wilson wrote: > Quoting Gustavo A. R. Silva (2018-03-22 18:21:54) > > The checks are misleading and not required [1]. > > > > [1] https://lkml.org/lkml/2018/3/19/1792 > > > > Addresses-Coverity-ID: 1466017 > > Cc: Chris Wilson > >

Re: [PATCH 1/2] vfio: add edid api for display (vgpu) devices.

2018-09-17 Thread Zhenyu Wang
On 2018.09.14 14:25:52 +0200, Gerd Hoffmann wrote: > diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h > index 1aa7b82e81..901f279033 100644 > --- a/include/uapi/linux/vfio.h > +++ b/include/uapi/linux/vfio.h > @@ -200,12 +200,25 @@ struct vfio_device_info { > #define

Re: [PATCH 1/2] vfio: add edid api for display (vgpu) devices.

2018-09-17 Thread Zhenyu Wang
On 2018.09.17 10:50:33 +0200, Gerd Hoffmann wrote: > > > +#define VFIO_DEVICE_INFO_CAP_EDID1 > > > + > > > +struct vfio_device_info_edid_cap { > > > + struct vfio_info_cap_header header; > > > + __u32 max_x; /* Max display height (zero == no limit) */ > > > + __u32 max_y; /*

[AGPGART] intel_agp: fix ids for 945GME, 965GME

2007-07-19 Thread Zhenyu Wang
Subject: [PATCH] [AGPGART] intel_agp: fix ids for 945GME and 965GME These chipsets actually have new host bridge ids. This should fix the gart init problem on them. Please apply, thanks. Signed-off-by: Wang Zhenyu <[EMAIL PROTECTED]> --- drivers/char/agp/intel-agp.c | 10 ++ 1 files

[PATCH] [AGPGART] intel_agp: fix stolen mem range on G33

2007-09-05 Thread Zhenyu Wang
Subject: [PATCH] [AGPGART] intel_agp: fix stolen mem range on G33 G33 GTT stolen memory is below graphics data stolen memory and be seperate, so don't subtract it in stolen mem counting. Signed-off-by: Zhenyu Wang <[EMAIL PROTECTED]> --- drivers/char/agp/intel-agp.c |5 + 1

[PATCH] [AGPGART] intel_agp: fix GTT map size on G33

2007-09-05 Thread Zhenyu Wang
Subject: [PATCH] [AGPGART] intel_agp: fix GTT map size on G33 G33 has 1MB GTT table range. Fix GTT mapping in case like 512MB aperture size. Signed-off-by: Zhenyu Wang <[EMAIL PROTECTED]> --- drivers/char/agp/intel-agp.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-)

Re: [PATCH] [AGPGART] intel_agp: fix stolen mem range on G33

2007-09-05 Thread Zhenyu Wang
len memory is below graphics data stolen memory and be seperate, so don't subtract it in stolen mem counting. Signed-off-by: Zhenyu Wang <[EMAIL PROTECTED]> --- drivers/char/agp/intel-agp.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/char/agp/inte

Re: X-freeze after clflush changes [Was: 2.6.23-rc6-mm1]

2007-09-20 Thread Zhenyu Wang
On 2007.09.20 17:33:45 +, Dave Airlie wrote: > > Maybe you are rather interested in these dmesg lines: > > Linux agpgart interface v0.102 > > agpgart: suspend/resume problematic: resume with 3D/DRI active may lockup > > X.Org > > on some chipset/BIOS combos (see DEBUG_AGP_PM in intel-agp.c) >

Re: X-freeze after clflush changes [Was: 2.6.23-rc6-mm1]

2007-09-20 Thread Zhenyu Wang
On 2007.09.21 00:10:26 +, Jiri Slaby wrote: > > Could you try current xf86-video-intel driver? just do > > git clone git://anongit.freedesktop.org/git/xorg/driver/xf86-video-intel > > It works! yep, I also pushed a fix for G33 in xf86-video-intel when fixing the intel agp. So for G33 user,

Re: [Intel-gfx] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

2014-06-23 Thread Zhenyu Wang
; > So we just go back to check devfn to make life normal. > > Signed-off-by: Tiejun Chen This was added historically when supporting graphics device passthrough. Looks qemu upstream can't accept multiple ISA bridge and our PCH is always on device 31: func0 as far as I know. Looks good to

Re: [PATCH][drm-next] drm/i915/gvt: fix spelling mistake: "destoried" -> "destroyed"

2018-03-12 Thread Zhenyu Wang
On 2018.03.12 12:43:58 +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in gvt_err error message text. > > Signed-off-by: Colin Ian King > --- Thanks Colin, will pick up. > drivers/gpu/drm/i915/gvt/gtt.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs

2018-03-22 Thread Zhenyu Wang
On 2018.03.22 21:31:33 +, Chris Wilson wrote: > Quoting Gustavo A. R. Silva (2018-03-22 18:21:54) > > The checks are misleading and not required [1]. > > > > [1] https://lkml.org/lkml/2018/3/19/1792 > > > > Addresses-Coverity-ID: 1466017 > > Cc: Chris Wilson > > Signed-off-by: Gustavo A. R.

Re: [PATCH][drm-next] drm/i915/gvt: ensure -ve return value is handled correctly

2017-09-19 Thread Zhenyu Wang
On 2017.09.19 16:55:34 +0100, Colin King wrote: > From: Colin Ian King > > An earlier fix changed the return type from find_bb_size however the > integer return is being assigned to a unsigned int so the -ve error > check will never be detected. Make bb_size an int to fix this. > > Detected by

Re: [PATCH][drm-next] drm/i915/gvt: ensure -ve return value is handled correctly

2017-09-20 Thread Zhenyu Wang
On 2017.09.19 19:35:23 -0700, Joe Perches wrote: > On Wed, 2017-09-20 at 05:46 +0800, Zhenyu Wang wrote: > > On 2017.09.19 16:55:34 +0100, Colin King wrote: > > > From: Colin Ian King > > > > > > An earlier fix changed the return type from find_bb_size howev

Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation

2017-07-11 Thread Zhenyu Wang
On 2017.07.11 11:12:36 +0200, Daniel Vetter wrote: > On Tue, Jul 11, 2017 at 08:14:08AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > > +struct vfio_device_query_gfx_plane { > > > > + __u32 argsz; > > > > + __u32 flags; > > > > + struct vfio_device_gfx_plane_info plane_info; >

Re: [PATCH v18 0/6] drm/i915/gvt: Dma-buf support for GVT-g

2017-11-22 Thread Zhenyu Wang
On 2017.11.15 11:49:00 +0100, Gerd Hoffmann wrote: > On Wed, Nov 15, 2017 at 05:11:49PM +0800, Tina Zhang wrote: > > v17->v18: > > 1) unmap vgpu's opregion when destroying vgpu. > > 2) update comments for VFIO_DEVICE_GET_GFX_DMABUF. (Alex) > > > This patch set adds the dma-buf support for intel

Re: linux-next: Signed-off-by missing for commits in the drm tree

2017-12-03 Thread Zhenyu Wang
On 2017.12.04 10:57:35 +1100, Stephen Rothwell wrote: > Hi all, > > There is a series of commits > > 54cff6479fd8 - c1802534e5a6 > (not all in that range) > > that are missing a Signed-off-by from their committer. > They were originally committed by Zhi himself, but I had to rebase onto

Re: [PATCH] drm/i915/gvt/fb_decoder: Fix out-of-bounds read

2017-12-11 Thread Zhenyu Wang
On 2017.12.09 00:37:59 -0600, Gustavo A. R. Silva wrote: > In case function skl_format_to_drm returns -EINVAL, fmt turns into a huge > number as fmt is of type u32, hence there is an out-of-bounds read when > using fmt as an index for array skl_pixel_formats at line 225: > plane->bpp =

Re: [PATCH] vfio: Simplify capability helper

2017-12-12 Thread Zhenyu Wang
> Makes more sense now, thanks. I'll repost mine on top of this. > > > Reviewed-by: Alexey Kardashevskiy > > Looks good for KVMGT part. Acked-by: Zhenyu Wang > Below one observation, unrelated to this patch. > > > --- > > drivers/gpu/drm/i915/gvt/kvmgt.c

Re: [PATCH] drm/i915/gvt: return error when failing to take the module reference

2020-11-12 Thread Zhenyu Wang
mdev core doesn't take >* a reference for vendor driver. >*/ > - if (!try_module_get(THIS_MODULE)) > + if (!try_module_get(THIS_MODULE)) { > + ret = -ENODEV; > goto undo_group; > + } > > ret = kvmgt_guest_init(mdev); &g

Re: [PATCH] drm/i915/gvt: replace idr_init() by idr_init_base()

2020-11-10 Thread Zhenyu Wang
t;dmabuf_lock); > INIT_LIST_HEAD(>dmabuf_obj_list_head); > INIT_RADIX_TREE(>page_track_tree, GFP_KERNEL); > - idr_init(>object_idr); > + idr_init_base(>object_idr, 1); > intel_vgpu_init_cfg_space(vgpu, param->primary); > vgpu->d3_ent

Re: [PATCH v5 4/6] drm/i915/gvt: Deliver vGPU refresh event to userspace

2019-08-26 Thread Zhenyu Wang
On 2019.08.16 10:35:26 +0800, Tina Zhang wrote: > Deliver the display refresh events to the user land. Userspace can use > the irq mask/unmask mechanism to disable or enable the event delivery. > > As we know, delivering refresh event at each vblank safely avoids > tearing and unexpected event

Re: 2.6.24-rc6-git7: Reported regressions from 2.6.23

2008-01-01 Thread Zhenyu Wang
g/lkml/2007/12/21/269 > http://bugzilla.kernel.org/show_bug.cgi?id=9618 > Handled-By: Zhenyu Wang <[EMAIL PROTECTED]> > Patch : This is resolved by turning on CONFIG_DMAR_GFX_WA. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in t

Re: [agp-mm][PATCH 1/4][intel_iommu] explicit export current graphics dmar status

2008-01-03 Thread Zhenyu Wang
On 2007.12.19 13:26:08 +, Zhenyu Wang wrote: > > [agp-mm] [intel_iommu] explicit export current graphics dmar status > > To make it possbile to tell other modules about curent > graphics dmar engine status, that could decide if graphics > driver should remap physical addr

[PATCH][intel_agp] fix name for G35 chipset

2008-01-06 Thread Zhenyu Wang
Change origin chipset name i965G_1 to market name G35. Signed-off-by: Zhenyu Wang <[EMAIL PROTECTED]> --- drivers/char/agp/intel-agp.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c index d

[PATCH][AGP] intel_agp: add new chipset ids

2008-01-08 Thread Zhenyu Wang
Dave, This one adds new pci ids for Intel intergrated graphics chipset, with gtt table access change on it and new gtt table size definition. Thanks. Signed-off-by: Zhenyu Wang <[EMAIL PROTECTED]> --- drivers/char/agp/agp.h |3 +++ drivers/char/agp/intel-agp.c

Re: [agp-mm][PATCH 1/4][intel_iommu] explicit export current graphics dmar status

2008-01-24 Thread Zhenyu Wang
m config. The simplest case is that DMAR_GFX_WA is on, which no dma mapping will act in intel_agp. If no DMAR_GFX_WA, we still have boot param to turn off whole intel iommu (intel_iommu=off), just turn off graphics remap engine (intel_iommu=igfx_off). So this exported interface is used to know that i

Re: linux-2.6.24-rcX regression / xserver-xorg-video-intel / Q35

2007-12-22 Thread Zhenyu Wang
On 2007.12.22 01:25:16 +0100, Harald Welte wrote: > > I'm running an Intel DQ35JO mainboard (Q35 chipset, Q6600 CPU) and I am > observing a regression with linux-2.6.24-rc1 through -rc6 (linux-2.6.git as > of today, ea67db4cdbbf7f4e74150e71da0984e25121f500). > > The last working version is

Re: [agp-mm][PATCH 1/4][intel_iommu] explicit export current graphics dmar status

2008-01-28 Thread Zhenyu Wang
On 2008.01.25 10:08:20 -0800, mark gross wrote: > > This is used for our graphics driver module to know if we have to > > do dma remapping in iommu case, both in kernel config and kernel > > boot time param config. > > ok. How soon do you need this export? > As graphics part of these patches

[RFC][PATCH 0/4] enabling graphics memory dma remapping

2007-12-17 Thread Zhenyu Wang
Intel IOMMU (a.k.a VT-d) is under rapid deployment on desktop and mobile platforms. As platform provides multiple dma remap engines for devices like those lives on south bridge (net, sound, etc.), and we also have one engine specific to graphics device. If this engine is functioning, the access

[RFC][PATCH 1/4][intel_iommu] explicit export current graphics dmar status

2007-12-17 Thread Zhenyu Wang
current status of DMAR, which would be used for completely express graphics dmar engine is active or not. Signed-off-by: Zhenyu Wang <[EMAIL PROTECTED]> --- drivers/pci/intel-iommu.c | 18 -- include/linux/dmar.h |6 ++ 2 files changed, 22 insertions(+), 2 del

[RFC][PATCH 2/4][AGP] Add generic support for graphics dma remapping

2007-12-17 Thread Zhenyu Wang
also been made to handle scratch_page in remapping case. Signed-off-by: Zhenyu Wang <[EMAIL PROTECTED]> --- drivers/char/agp/agp.h | 14 ++ drivers/char/agp/backend.c | 21 - drivers/char/agp/generic.c | 14 ++ include/linux/agp_bac

[RFC][PATCH 3/4][AGP] intel_agp: add support for graphics dma remapping on G33

2007-12-17 Thread Zhenyu Wang
support on G33 chipset, which has graphics device specific dmar engine avaiable. Signed-off-by: Zhenyu Wang <[EMAIL PROTECTED]> --- drivers/char/agp/Kconfig | 12 +++- drivers/char/agp/intel-agp.c | 134 +- 2 files changed, 141 insertions

[agp-mm][PATCH 0/4] enabling graphics memory dma remapping

2007-12-18 Thread Zhenyu Wang
On 2007.12.18 13:08:09 +, Zhenyu Wang wrote: > > Here're three patches below: > > - intel_iommu-explicit-export-current-graphics-dmar-status.patch > > This exports current status of graphics dma remap engine, which > depends on current platform iommu support, ker

[agp-mm][PATCH 1/4][intel_iommu] explicit export current graphics dmar status

2007-12-18 Thread Zhenyu Wang
current status of DMAR, which would be used for completely express graphics dmar engine is active or not. Signed-off-by: Zhenyu Wang <[EMAIL PROTECTED]> --- drivers/pci/intel-iommu.c | 18 -- include/linux/dmar.h |6 ++ 2 files changed, 22 insertions(+), 2 del

[agp-mm][PATCH 2/4][AGP] Add generic support for graphics dma remapping

2007-12-18 Thread Zhenyu Wang
also been made to handle scratch_page in remapping case. Signed-off-by: Zhenyu Wang <[EMAIL PROTECTED]> --- drivers/char/agp/agp.h | 13 + drivers/char/agp/backend.c | 21 - drivers/char/agp/generic.c | 14 ++ include/linux/agp_bac

[agp-mm][PATCH 3/4][AGP] intel_agp: add support for graphics dma remapping on G33

2007-12-18 Thread Zhenyu Wang
support on G33 chipset, which has graphics device specific dmar engine avaiable. Signed-off-by: Zhenyu Wang <[EMAIL PROTECTED]> --- drivers/char/agp/Kconfig | 12 +++- drivers/char/agp/intel-agp.c | 134 +- 2 files changed, 141 insertions

Re: [PATCH] drm/i915/gvt: fix uninitialized return in intel_gvt_update_reg_whitelist()

2021-01-26 Thread Zhenyu Wang
On 2021.01.25 09:44:53 +, Chris Wilson wrote: > Quoting Dan Carpenter (2021-01-25 08:48:30) > > Smatch found an uninitialized variable bug in this code: > > > > drivers/gpu/drm/i915/gvt/cmd_parser.c:3191 > > intel_gvt_update_reg_whitelist() > > error: uninitialized symbol 'ret'. > >

Re: [PATCH] drm/i915/gvt: Use ARRAY_SIZE for vgpu_types

2020-05-19 Thread Zhenyu Wang
On 2020.05.18 22:00:52 +0100, Chris Wilson wrote: > Quoting Aishwarya Ramakrishnan (2020-05-18 16:03:36) > > Prefer ARRAY_SIZE instead of using sizeof > > > > Fixes coccicheck warning: Use ARRAY_SIZE > > > > Signed-off-by: Aishwarya Ramakrishnan > Reviewed-by: Chris Wilson Applied, thanks!

Re: [PATCH] drm/i915/gvt: print actionable error message when gm runs out

2020-06-04 Thread Zhenyu Wang
ut what actions a user can > take to resolve this situation. > > Cc: Thomas Prescher > Cc: Zhenyu Wang > Signed-off-by: Julian Stecklina > --- > drivers/gpu/drm/i915/gvt/aperture_gm.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH v18 5/6] vfio: ABI for mdev display dma-buf operation

2017-11-15 Thread Zhenyu Wang
On 2017.11.15 11:48:42 -0700, Alex Williamson wrote: > On Wed, 15 Nov 2017 17:11:54 +0800 > Tina Zhang wrote: > > > Add VFIO_DEVICE_QUERY_GFX_PLANE ioctl command to let user query and get > > a plane and its information. So far, two types of buffers are supported: > > buffers based on dma-buf

Re: [RFC PATCH v4 1/6] vfio: Define device specific irq type capability

2019-07-19 Thread Zhenyu Wang
On 2019.07.18 23:56:35 +0800, Kechen Lu wrote: > From: Tina Zhang > > Cap the number of irqs with fixed indexes and use capability chains > to chain device specific irqs. > > Signed-off-by: Tina Zhang > Signed-off-by: Eric Auger > --- > include/uapi/linux/vfio.h | 19 ++- > 1

Re: [RFC PATCH v4 4/6] drm/i915/gvt: Deliver vGPU refresh event to userspace

2019-07-19 Thread Zhenyu Wang
On 2019.07.18 23:56:38 +0800, Kechen Lu wrote: > From: Tina Zhang > > Deliver the display refresh events to the user land. Userspace can use > the irq mask/unmask mechanism to disable or enable the event delivery. > > As we know, delivering refresh event at each vblank safely avoids > tearing

Re: [RFC PATCH v4 6/6] drm/i915/gvt: Add cursor plane reg update trap emulation handler

2019-07-19 Thread Zhenyu Wang
On 2019.07.18 23:56:40 +0800, Kechen Lu wrote: > This patch adds the cursor plane CURBASE reg update trap handler > in order to : > > - Deliver the cursor refresh event at each vblank emulation, > the flip_done_event bit check is supposed to do here. If cursor > plane updates happen, deliver the

Re: [RFC PATCH v4 1/6] vfio: Define device specific irq type capability

2019-07-19 Thread Zhenyu Wang
On 2019.07.19 09:02:33 +, Lu, Kechen wrote: > Hi, > > > -Original Message- > > From: Zhenyu Wang [mailto:zhen...@linux.intel.com] > > Sent: Friday, July 19, 2019 2:06 PM > > To: Lu, Kechen > > Cc: intel-gvt-...@lists.freedesktop.org; k

Re: [PATCH 1/2] vfio: ABI for setting mdev display flip eventfd

2019-05-27 Thread Zhenyu Wang
On 2019.05.27 16:43:11 +0800, Tina Zhang wrote: > Add VFIO_DEVICE_SET_GFX_FLIP_EVENTFD ioctl command to set eventfd > based signaling mechanism to deliver vGPU framebuffer page flip > event to userspace. > Should we add probe to see if driver can support gfx flip event? > Signed-off-by: Tina

  1   2   >