[PATCH] openvswitch: fix odd_ptr_err.cocci warnings

2014-12-23 Thread kbuild test robot
net/openvswitch/vport-gre.c:188:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 189 PTR_ERR should access the value just tested by IS_ERR Semantic patch information: There can be false positives in the patch case, where it is the call IS_ERR that is wrong. Generated by:

[PATCH] iio: imu: kmx61: fix simple_return.cocci warnings

2014-12-26 Thread kbuild test robot
drivers/iio/imu/kmx61.c:543:1-4: WARNING: end returns can be simpified drivers/iio/imu/kmx61.c:480:1-4: WARNING: end returns can be simpified if negative or 0 value Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by:

[PATCH iio] iio: imu: kmx61: kmx61_set_wake_up_odr() can be static

2014-12-12 Thread kbuild test robot
drivers/iio/imu/kmx61.c:422:5: sparse: symbol 'kmx61_set_wake_up_odr' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- kmx61.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c

[iio:testing 44/44] drivers/iio/imu/kmx61.c:422:5: sparse: symbol 'kmx61_set_wake_up_odr' was not declared. Should it be static?

2014-12-12 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git testing head: fd3ae7a9f21c2a51a1d220bc7a7c3b45ab5e6ad1 commit: fd3ae7a9f21c2a51a1d220bc7a7c3b45ab5e6ad1 [44/44] iio: imu: kmx61: Add support for any motion trigger reproduce: # apt-get install sparse git checkout

[PATCH] drm/gm204/i2c: fix semicolon.cocci warnings

2014-12-02 Thread kbuild test robot
drivers/gpu/drm/nouveau/core/subdev/i2c/padgm204.c:74:26-27: Unneeded semicolon Removes unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Signed-off-by: Fengguang Wu fengguang...@intel.com --- padgm204.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---

[PATCH jbarnes] drm/i915: fence_lock can be static

2014-12-02 Thread kbuild test robot
drivers/gpu/drm/i915/i915_sync.c:43:12: sparse: symbol 'fence_lock' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- i915_sync.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_sync.c

[jbarnes:upstream-sync-points 2/2] drivers/gpu/drm/i915/i915_sync.c:43:12: sparse: symbol 'fence_lock' was not declared. Should it be static?

2014-12-02 Thread kbuild test robot
tree: git://people.freedesktop.org/~jbarnes/linux upstream-sync-points head: 97b242f63adaf11c3edf16b0282243cc4274eac8 commit: 97b242f63adaf11c3edf16b0282243cc4274eac8 [2/2] drm/i915: Android sync points for i915 v3 reproduce: # apt-get install sparse git checkout

[PATCH hisi] Input: i2c_atmel_read() can be static

2014-12-18 Thread kbuild test robot
drivers/input/touchscreen/atmel_mXT224E.c:460:5: sparse: symbol 'i2c_atmel_read' was not declared. Should it be static? drivers/input/touchscreen/atmel_mXT224E.c:496:5: sparse: symbol 'i2c_atmel_write' was not declared. Should it be static? drivers/input/touchscreen/atmel_mXT224E.c:532:5:

[hisi:integration-hilt-linux-linaro 17/28] drivers/input/touchscreen/atmel_mXT224E.c:460:5: sparse: symbol 'i2c_atmel_read' was not declared. Should it be static?

2014-12-18 Thread kbuild test robot
tree: git://github.com/hisilicon/linux-hisi integration-hilt-linux-linaro head: 791a2af480ea27735b4669c623b665c5bfea9b5c commit: d7e9caafdf706341b4165d0a8c2089e60dcebc68 [17/28] Input: enable touch atmel_mXT224E reproduce: # apt-get install sparse git checkout

[vireshk:cpufreq/stats/cleanups 12/14] drivers/cpufreq/cpufreq_stats.c:19:1: sparse: symbol 'cpufreq_stats_lock' was not declared. Should it be static?

2014-12-19 Thread kbuild test robot
tree: https://git.linaro.org/people/vireshk/linux cpufreq/stats/cleanups head: f6439741b76da59257758838e8b24472831e850c commit: 2194c3c381af6cbfe8ab4fda481e07a004446e30 [12/14] cpufreq: stats: replace spinlock with mutex reproduce: # apt-get install sparse git checkout

[PATCH vireshk] cpufreq: stats: cpufreq_stats_lock can be static

2014-12-19 Thread kbuild test robot
drivers/cpufreq/cpufreq_stats.c:19:1: sparse: symbol 'cpufreq_stats_lock' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- cpufreq_stats.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/cpufreq_stats.c

[PATCH] staging: fpga manager: fix odd_ptr_err.cocci warnings

2014-12-19 Thread kbuild test robot
drivers/staging/fpga/socfpga.c:647:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 648 PTR_ERR should access the value just tested by IS_ERR Semantic patch information: There can be false positives in the patch case, where it is the call IS_ERR that is wrong. Generated by:

[PATCH] drm/fb-helper: fix simple_return.cocci warnings

2014-12-19 Thread kbuild test robot
drivers/gpu/drm/cirrus/cirrus_fbdev.c:330:1-4: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci CC: Thierry Reding tred...@nvidia.com Signed-off-by:

[PATCH] Thermal: fix platform_no_drv_owner.cocci warnings

2014-12-21 Thread kbuild test robot
drivers/thermal/int340x_thermal/int3402_thermal.c:234:6-11: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Aaron Lu aaron...@intel.com Signed-off-by:

[PATCH] ASoC: Intel: fix platform_no_drv_owner.cocci warnings

2014-12-21 Thread kbuild test robot
sound/soc/intel/cht_bsw_rt5672.c:273:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Mengdong Lin mengdong@intel.com Signed-off-by: Fengguang Wu

[PATCH tixy] gator: wq_get_stats can be static

2014-12-16 Thread kbuild test robot
drivers/gator/gator_events_net.c:48:1: sparse: symbol 'wq_get_stats' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- gator_events_net.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gator/gator_events_net.c

[tixy:tracking-armlt-gator 1/6] drivers/gator/gator_events_meminfo.c:371:26: sparse: incorrect type in initializer (different modifiers)

2014-12-16 Thread kbuild test robot
tree: https://git.linaro.org/people/tixy/kernel tracking-armlt-gator head: 9b552ac355654e1fdd504f4b84b57c971084d83e commit: a7bdf015d9043286f35de13eb11f54f64f2af143 [1/6] gator: Version 5.20 reproduce: # apt-get install sparse git checkout a7bdf015d9043286f35de13eb11f54f64f2af143 make

[PATCH robclark] drm: get_properties() can be static

2014-12-17 Thread kbuild test robot
drivers/gpu/drm/drm_crtc.c:1995:5: sparse: symbol 'get_properties' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- drm_crtc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_crtc.c

[robclark:atomic-properties 5/12] drivers/gpu/drm/drm_crtc.c:1995:5: sparse: symbol 'get_properties' was not declared. Should it be static?

2014-12-17 Thread kbuild test robot
tree: git://people.freedesktop.org/~robclark/linux atomic-properties head: 4e73d9848e88a1bdd90c2506457dc4e7583c2f58 commit: d9224ddf063bb89803a3f4cce2dfd3d2afcb4906 [5/12] drm: refactor getproperties/getconnector reproduce: # apt-get install sparse git checkout

[PATCH] dmaengine: rcar-dmac: fix platform_no_drv_owner.cocci warnings

2014-12-17 Thread kbuild test robot
drivers/dma/sh/rcar-dmac.c:1490:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Fengguang Wu fengguang...@intel.com --- rcar-dmac.c |1 -

[PATCH md] lib: raid: raid_cauchy_init() can be static

2014-12-03 Thread kbuild test robot
lib/raid/module.c:417:12: sparse: symbol 'raid_cauchy_init' was not declared. Should it be static? lib/raid/raid.c:156:9: sparse: symbol 'raid_zero_block' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- module.c |2 +- raid.c |2 +- 2

[PATCH] ASoC: fix platform_no_drv_owner.cocci warnings

2014-12-06 Thread kbuild test robot
sound/soc/xtensa/xtfpga-i2s.c:666:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Fengguang Wu fengguang...@intel.com --- xtfpga-i2s.c |

[PATCH] Bluetooth: fix err_cast.cocci warnings

2014-12-07 Thread kbuild test robot
net/bluetooth/smp.c:2650:9-16: WARNING: ERR_CAST can be used with tfm_aes Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)) Generated by: scripts/coccinelle/api/err_cast.cocci CC: Johan Hedberg johan.hedb...@intel.com Signed-off-by: Fengguang Wu fengguang...@intel.com --- smp.c

[PATCH] clk: qcom: fix platform_no_drv_owner.cocci warnings

2014-12-08 Thread kbuild test robot
drivers/clk/qcom/hfpll.c:102:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Stephen Boyd sb...@codeaurora.org Signed-off-by: Fengguang Wu

[PATCH] clk: qcom: fix platform_no_drv_owner.cocci warnings

2014-12-08 Thread kbuild test robot
drivers/clk/qcom/kpss-xcc.c:89:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Stephen Boyd sb...@codeaurora.org Signed-off-by: Fengguang Wu

[PATCH] pinctrl: fix platform_no_drv_owner.cocci warnings

2014-12-09 Thread kbuild test robot
drivers/pinctrl/intel/pinctrl-baytrail.c:605:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Mika Westerberg mika.westerb...@linux.intel.com

[PATCH] pinctrl: fix platform_no_drv_owner.cocci warnings

2014-12-09 Thread kbuild test robot
drivers/pinctrl/intel/pinctrl-cherryview.c:1500:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Mika Westerberg mika.westerb...@linux.intel.com

[PATCH tj-misc] bitmap: bitmap_print_list() can be static

2014-12-09 Thread kbuild test robot
lib/bitmap.c:574:6: sparse: symbol 'bitmap_print_list' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- bitmap.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bitmap.c b/lib/bitmap.c index c5dd40e..dc43a01 100644 ---

[tj-misc:review-wq-dump 1/15] lib/bitmap.c:574:6: sparse: symbol 'bitmap_print_list' was not declared. Should it be static?

2014-12-09 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git review-wq-dump head: c48dd4e1a0d7225c97d7294958dd8ba6be82fde9 commit: 069dcda94642807dc31bf52895bd409512531249 [1/15] bitmap: restructure bitmap_sn[list]printf() reproduce: # apt-get install sparse git checkout

[socfpga-nex:for_next-fpgamgr-without-overlays-v4 8/9] drivers/staging/fpga/fpga-mgr.c:46:5: sparse: symbol 'fpga_mgr_low_level_state' was not declared. Should it be static?

2014-12-09 Thread kbuild test robot
tree: git://git.rocketboards.org/linux-socfpga-next for_next-fpgamgr-without-overlays-v4 head: 590b747bfa6791797c241116453acf50bc4e5dda commit: 356ae534a603de3aa8b1cfc173a777f59273d32e [8/9] staging: fpga manager: framework core reproduce: # apt-get install sparse git checkout

[PATCH socfpga-nex] staging: fpga manager: fpga_mgr_low_level_state() can be static

2014-12-09 Thread kbuild test robot
drivers/staging/fpga/fpga-mgr.c:46:5: sparse: symbol 'fpga_mgr_low_level_state' was not declared. Should it be static? drivers/staging/fpga/fpga-mgr.c:324:30: sparse: symbol 'fpga_mgr_groups' was not declared. Should it be static? drivers/staging/fpga/fpga-mgr.c:365:25: sparse: symbol

[PATCH] staging: fpga manager: fix array_size.cocci warnings

2014-12-10 Thread kbuild test robot
drivers/staging/fpga/altera.c:368:33-34: WARNING: Use ARRAY_SIZE Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element Semantic patch information: This makes an effort to find cases where ARRAY_SIZE can be used such as where there is a division of sizeof the array by the

[PATCH] staging: fpga manager: fix platform_no_drv_owner.cocci warnings

2014-12-10 Thread kbuild test robot
drivers/staging/fpga/altera.c:768:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Alan Tull at...@opensource.altera.com Signed-off-by: Fengguang Wu

[socfpga-nex:for_next-fpgamgr-without-overlays-v4.3 8/9] drivers/staging/fpga/socfpga.c:655:25: sparse: symbol 'socfpga_fpga_ops' was not declared. Should it be static?

2014-12-10 Thread kbuild test robot
tree: git://git.rocketboards.org/linux-socfpga-next for_next-fpgamgr-without-overlays-v4.3 head: 7920447fc75922e9a72db640cddf890d75a30e0d commit: 99aa2d008ce7a2a925368bfddd53ae83d307fb38 [8/9] staging: fpga manager: add driver for socfpga fpga manager reproduce: # apt-get install sparse

[PATCH socfpga-nex] staging: fpga manager: socfpga_fpga_ops can be static

2014-12-10 Thread kbuild test robot
drivers/staging/fpga/socfpga.c:655:25: sparse: symbol 'socfpga_fpga_ops' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- socfpga.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fpga/socfpga.c

[PATCH] GMAC: fix simple_return.cocci warnings

2015-01-02 Thread kbuild test robot
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:425:1-4: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci CC: Roger Chen roger.c...@rock-chips.com

[PATCH] sched: completion: fix boolreturn.cocci warnings

2015-01-23 Thread kbuild test robot
kernel/sched/completion.c:278:9-10: WARNING: return of 0/1 in function 'try_wait_for_completion' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci CC: Nicholas Mc Guire

[hwmon:hwmon-next 19/19] drivers/hwmon/tmp102.c:284:1: sparse: symbol 'tmp102_dev_pm_ops' was not declared. Should it be static?

2015-02-03 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next head: 8170089e3c31b8b50ef5d2e21bdf20d7b7fa95b7 commit: 8170089e3c31b8b50ef5d2e21bdf20d7b7fa95b7 [19/19] hwmon: (tmp102) add hibernation callbacks reproduce: # apt-get install sparse git checkout

[PATCH hwmon] hwmon: tmp102_dev_pm_ops can be static

2015-02-03 Thread kbuild test robot
drivers/hwmon/tmp102.c:284:1: sparse: symbol 'tmp102_dev_pm_ops' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- tmp102.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/tmp102.c b/drivers/hwmon/tmp102.c index

[baohua:sirf-3.18 2573/2782] sound/soc/sirf/atlas7-iacc.c:168:24: sparse: symbol 'atlas7_iacc_dai_ops' was not declared. Should it be static?

2015-02-05 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/baohua/linux sirf-3.18 head: d61ca44a1d96f134d35d31522ca8efb19a6e1451 commit: 81aba96393135459ac811ce78fe8f91a8b767b82 [2573/2782] ASoC: sirf: atlas7: Add internal audio codec controller driver reproduce: # apt-get install sparse git

[PATCH baohua] ASoC: sirf: atlas7: atlas7_iacc_dai_ops can be static

2015-02-05 Thread kbuild test robot
sound/soc/sirf/atlas7-iacc.c:168:24: sparse: symbol 'atlas7_iacc_dai_ops' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- atlas7-iacc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sirf/atlas7-iacc.c

[PATCH] ASoC: sirf: atlas7: fix platform_no_drv_owner.cocci warnings

2015-02-07 Thread kbuild test robot
sound/soc/sirf/atlas7-iacc.c:625:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Rongjun Ying rongjun.y...@csr.com Signed-off-by: Fengguang Wu

[trace:ftrace/tracefs-v1 8/9] fs/tracefs/inode.c:95:31: sparse: symbol 'tracefs_dir_inode_operations' was not declared. Should it be static?

2015-01-21 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git ftrace/tracefs-v1 head: a9cda87887e46b28202c20658ad0e8de939b09cd commit: d85d95eb1961627f3d16ced602f9653ee13ed427 [8/9] tracing: Have mkdir and rmdir be part of tracefs reproduce: # apt-get install sparse git

[PATCH ext3] quota: qtype_enforce_flag() can be static

2015-01-21 Thread kbuild test robot
fs/quota/quota.c:69:14: sparse: symbol 'qtype_enforce_flag' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- quota.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/quota/quota.c b/fs/quota/quota.c index a5b7c35..7283117

[ext3:quota_interface 18/31] fs/quota/quota.c:69:14: sparse: symbol 'qtype_enforce_flag' was not declared. Should it be static?

2015-01-21 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git quota_interface head: 9ba4f6c1cc8a43d25369db0f43af9220bfcd1b92 commit: 34c3165e700a877be816f226c5b14fe90919e74e [18/31] quota: Wire up -quota_{enable,disable} callbacks into Q_QUOTA{ON,OFF} reproduce: # apt-get install

[PATCH trace] tracing: tracefs_dir_inode_operations can be static

2015-01-21 Thread kbuild test robot
fs/tracefs/inode.c:95:31: sparse: symbol 'tracefs_dir_inode_operations' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- inode.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c index

[PATCH kvm] KVM: kvm_read_nested_guest_page() can be static

2015-01-19 Thread kbuild test robot
arch/x86/kvm/x86.c:495:5: sparse: symbol 'kvm_read_nested_guest_page' was not declared. Should it be static? arch/x86/kvm/x86.c:646:5: sparse: symbol '__kvm_set_xcr' was not declared. Should it be static? arch/x86/kvm/x86.c:1183:15: sparse: symbol 'max_tsc_khz' was not declared. Should it be

[kvm:master 1/1] arch/x86/kvm/../../../virt/kvm/kvm_main.c:2062:25: sparse: incorrect type in assignment (different address spaces)

2015-01-19 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/virt/kvm/kvm.git master head: cdef511985374dd042a40bb32c1c346c2662c9dc commit: cdef511985374dd042a40bb32c1c346c2662c9dc [1/1] KVM: fix sparse warning in include/trace/events/kvm.h reproduce: # apt-get install sparse git checkout

[PATCH] fix platform_no_drv_owner.cocci warnings

2015-01-15 Thread kbuild test robot
drivers/pwm/pwm-stmpe.c:99:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Fengguang Wu fengguang...@intel.com --- pwm-stmpe.c |1 - 1

[ext4:crypto 8/21] fs/ext4/xattr_encryption.c:80:5: sparse: symbol 'ext4_xattr_encryption_context_set' was not declared. Should it be static?

2015-01-15 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git crypto head: e32261a72a3c0c6c59d761820d8ca8b7c90008af commit: db813a4cea85922497d58e94304d75517576af03 [8/21] ext4 crypto: add encryption xattr support reproduce: # apt-get install sparse git checkout

[PATCH ext4] ext4 crypto: ext4_xattr_encryption_context_set() can be static

2015-01-15 Thread kbuild test robot
fs/ext4/xattr_encryption.c:80:5: sparse: symbol 'ext4_xattr_encryption_context_set' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- xattr_encryption.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/xattr_encryption.c

[PATCH vireshk] cpufreq: __cpufreq_boost_supported() can be static

2015-01-15 Thread kbuild test robot
drivers/cpufreq/cpufreq.c:512:5: sparse: symbol '__cpufreq_boost_supported' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- cpufreq.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/cpufreq.c

[vireshk:cpufreq/core/locking 57/60] drivers/cpufreq/cpufreq.c:512:5: sparse: symbol '__cpufreq_boost_supported' was not declared. Should it be static?

2015-01-15 Thread kbuild test robot
tree: https://git.linaro.org/people/vireshk/linux cpufreq/core/locking head: 12d5339e685739289c2f629c943b8bfad4c64f1e commit: fbce49b78afdaeeaee3017cfbd968e44ddba8496 [57/60] cpufreq: Drop forward declaration of __cpufreq_boost_trigger_state() reproduce: # apt-get install sparse git

[PATCH] can: dev: fix semicolon.cocci warnings

2015-01-16 Thread kbuild test robot
drivers/net/can/dev.c:294:2-3: Unneeded semicolon Removes unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Andri Yngvason andri.yngva...@marel.com Signed-off-by: Fengguang Wu fengguang...@intel.com --- dev.c |2 +- 1 file changed, 1 insertion(+), 1

[PATCH] ASoC: sirf: fix platform_no_drv_owner.cocci warnings

2015-01-15 Thread kbuild test robot
sound/soc/sirf/sirf-atlas7-cs42xx8.c:192:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Yibo Cai yibo@csr.com Signed-off-by: Fengguang Wu

[PATCH] power: max77693: fix simple_return.cocci warnings

2015-01-20 Thread kbuild test robot
drivers/power/max77693_charger.c:615:1-4: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci CC: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by:

[PATCH] power: max77693: fix platform_no_drv_owner.cocci warnings

2015-01-20 Thread kbuild test robot
drivers/power/max77693_charger.c:747:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Fengguang

[PATCH] mmc: sdhci: host: fix odd_ptr_err.cocci warnings

2015-01-21 Thread kbuild test robot
drivers/mmc/host/sdhci_f_sdh30.c:143:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 144 PTR_ERR should access the value just tested by IS_ERR Semantic patch information: There can be false positives in the patch case, where it is the call IS_ERR that is wrong. Generated by:

[drm-intel:drm-intel-nightly 357/550] drivers/gpu/drm/radeon/cik_sdma.c:293:6: sparse: symbol 'cik_sdma_ctx_switch_enable' was not declared. Should it be static?

2015-01-21 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel drm-intel-nightly head: 0e3c37cedf582819b6dbdd0bf0b14a15d3c2e47d commit: d7a60d8ea5cd4560e0496d2683643d2e4930e609 [357/550] drm/radeon: Enable sdma preemption reproduce: # apt-get install sparse git checkout

[PATCH drm-intel] drm/radeon: cik_sdma_ctx_switch_enable() can be static

2015-01-21 Thread kbuild test robot
drivers/gpu/drm/radeon/cik_sdma.c:293:6: sparse: symbol 'cik_sdma_ctx_switch_enable' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- cik_sdma.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/cik_sdma.c

[ext4:crypto 15/21] fs/ext4/crypto_fname.c:322:5: sparse: symbol 'ext4_fname_decrypt' was not declared. Should it be static?

2015-01-15 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git crypto head: e32261a72a3c0c6c59d761820d8ca8b7c90008af commit: 6b8813e5baf3aa99baec11610cc29bc4ed20e671 [15/21] ext4 crypto: filename encryption facilities reproduce: # apt-get install sparse git checkout

[PATCH ext4] ext4 crypto: ext4_fname_decrypt() can be static

2015-01-15 Thread kbuild test robot
fs/ext4/crypto_fname.c:322:5: sparse: symbol 'ext4_fname_decrypt' was not declared. Should it be static? fs/ext4/crypto_fname.c:380:5: sparse: symbol 'ext4_fname_encode_digest' was not declared. Should it be static? fs/ext4/crypto_fname.c:479:6: sparse: symbol 'ext4_free_fname_crypto_ctx' was

[PATCH next] RDMA/ocrdma: ocrdma_sysfs_rcv_pkts() can be static

2015-02-17 Thread kbuild test robot
drivers/infiniband/hw/ocrdma/ocrdma_stats.c:253:5: sparse: symbol 'ocrdma_sysfs_rcv_pkts' was not declared. Should it be static? drivers/infiniband/hw/ocrdma/ocrdma_stats.c:264:5: sparse: symbol 'ocrdma_sysfs_rcv_data' was not declared. Should it be static?

[next:master 10113/10230] drivers/infiniband/hw/ocrdma/ocrdma_stats.c:253:5: sparse: symbol 'ocrdma_sysfs_rcv_pkts' was not declared. Should it be static?

2015-02-17 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: c26de6d26435059245babb016acb840d9e0e5d12 commit: 8b528884f901757fb21c5900151fc294344d78f6 [10113/10230] RDMA/ocrdma: Add support for IB stack compliant stats in sysfs. reproduce: # apt-get install sparse

[next:master 10115/10230] drivers/infiniband/hw/ocrdma/ocrdma_hw.c:1510:6: sparse: symbol 'ocrdma_free_pd_pool' was not declared. Should it be static?

2015-02-17 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: c26de6d26435059245babb016acb840d9e0e5d12 commit: 72278f474221abd5c09af5d3a4dff39f9d10948f [10115/10230] RDMA/ocrdma: Move PD resource management to driver. reproduce: # apt-get install sparse git checkout

[PATCH next] RDMA/ocrdma: ocrdma_free_pd_pool() can be static

2015-02-17 Thread kbuild test robot
drivers/infiniband/hw/ocrdma/ocrdma_hw.c:1510:6: sparse: symbol 'ocrdma_free_pd_pool' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- ocrdma_hw.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH aa] userfaultfd: double_down_read() can be static

2015-02-12 Thread kbuild test robot
mm/userfaultfd.c:48:6: sparse: symbol 'double_down_read' was not declared. Should it be static? mm/userfaultfd.c:67:6: sparse: symbol 'double_up_read' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- userfaultfd.c |4 ++-- 1 file changed, 2

[aa:userfault 17/19] mm/userfaultfd.c:48:6: sparse: symbol 'double_down_read' was not declared. Should it be static?

2015-02-12 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/andrea/aa.git userfault head: 9866337e3999d167b77303ad9e57fd20919893e3 commit: e2ccdb8c9f49438f9c8910f2f93c7e5ee35d8644 [17/19] userfaultfd: add new syscall to provide memory externalization reproduce: # apt-get install sparse git

[PATCH] fix platform_no_drv_owner.cocci warnings

2015-02-12 Thread kbuild test robot
drivers/clk/qcom/clk-rpm.c:262:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Fengguang Wu fengguang...@intel.com --- clk-rpm.c |1 - 1

[PATCH] x86/intel/quark: fix ptr_ret.cocci warnings

2015-02-19 Thread kbuild test robot
arch/x86/platform/intel-quark/imr.c:280:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci CC: Bryan O'Donoghue pure.lo...@nexus-software.ie Signed-off-by: Fengguang Wu fengguang...@intel.com

[PATCH] x86/intel/quark: fix simple_return.cocci warnings

2015-02-19 Thread kbuild test robot
arch/x86/platform/intel-quark/imr.c:129:1-4: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci CC: Bryan O'Donoghue pure.lo...@nexus-software.ie

[PATCH] IB/mad: fix ifnullfree.cocci warnings

2015-01-27 Thread kbuild test robot
drivers/infiniband/core/mad.c:2088:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not

[PATCH] clk: qcom: fix platform_no_drv_owner.cocci warnings

2015-01-28 Thread kbuild test robot
drivers/clk/qcom/lcc-msm8960.c:577:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Stephen Boyd sb...@codeaurora.org Signed-off-by: Fengguang Wu

[PATCH] clk: qcom: fix platform_no_drv_owner.cocci warnings

2015-01-28 Thread kbuild test robot
drivers/clk/qcom/lcc-ipq806x.c:465:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Rajendra Nayak rna...@codeaurora.org Signed-off-by: Fengguang Wu

[PATCH] drm/nouveau/bar: fix simple_return.cocci warnings

2015-01-24 Thread kbuild test robot
drivers/gpu/drm/nouveau/core/subdev/bar/base.c:132:5-8: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci Signed-off-by: Fengguang Wu fengguang...@intel.com

[PATCH] drm/nouveau/subdev: fix simple_return.cocci warnings

2015-01-24 Thread kbuild test robot
drivers/gpu/drm/nouveau/core/subdev/fuse/gm107.c:50:5-8: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci CC: Martin Peres martin.pe...@free.fr

[PATCH] drm/nouveau/i2c: fix semicolon.cocci warnings

2015-01-24 Thread kbuild test robot
drivers/gpu/drm/nouveau/core/subdev/i2c/padnv94.c:74:26-27: Unneeded semicolon Removes unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Signed-off-by: Fengguang Wu fengguang...@intel.com --- padnv94.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---

[PATCH char-misc] Drivers: hv: vmbus: hv_process_timer_expiration() can be static

2015-01-25 Thread kbuild test robot
drivers/hv/vmbus_drv.c:582:6: sparse: symbol 'hv_process_timer_expiration' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- vmbus_drv.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hv/vmbus_drv.c

[char-misc:char-misc-testing 54/73] drivers/hv/vmbus_drv.c:582:6: sparse: symbol 'hv_process_timer_expiration' was not declared. Should it be static?

2015-01-25 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-testing head: 930c796ad9a62bdc8384cbb71d5af332d9ec92f7 commit: 71123d54fb2346c7652d8d05dac2cee28cd69954 [54/73] Drivers: hv: vmbus: Implement a clockevent device reproduce: # apt-get install sparse git

[PATCH ext4] ext4 crypto: ext4_find_dest_de_crypt() can be static

2015-01-23 Thread kbuild test robot
fs/ext4/namei.c:2056:5: sparse: symbol 'ext4_find_dest_de_crypt' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- namei.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 0bd6758..7bbf0f9

[ext4:crypto 17/19] fs/ext4/namei.c:2056:5: sparse: symbol 'ext4_find_dest_de_crypt' was not declared. Should it be static?

2015-01-23 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git crypto head: dfc8aa97bd527d156f6e7ee3f0286af2229be45d commit: 2842df91db1447a594331116ee48fbf4647b3dd0 [17/19] ext4 crypto: filename encryption modifications reproduce: # apt-get install sparse git checkout

[PATCH clk] sched: __pcpu_scope_sd_pack_buddy can be static

2015-01-23 Thread kbuild test robot
kernel/sched/fair.c:199:1: sparse: symbol '__pcpu_scope_sd_pack_buddy' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- fair.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index

[clk:test-sched-packing-tasks-freq 10820/10847] kernel/sched/fair.c:199:1: sparse: symbol '__pcpu_scope_sd_pack_buddy' was not declared. Should it be static?

2015-01-23 Thread kbuild test robot
tree: https://git.linaro.org/people/mturquette/linux.git test-sched-packing-tasks-freq head: 3add111981928a9ce810cd1b1956dc39e6c2445f commit: 9cb183281a03911e724a648832d9f096c09197fe [10820/10847] sched: packing tasks reproduce: # apt-get install sparse git checkout

[PATCH tip] hrtimer: __hrtimer_get_next_event() can be static

2015-01-23 Thread kbuild test robot
kernel/time/hrtimer.c:444:9: sparse: symbol '__hrtimer_get_next_event' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- hrtimer.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c

[tip:timers/core 2/2] kernel/time/hrtimer.c:444:9: sparse: symbol '__hrtimer_get_next_event' was not declared. Should it be static?

2015-01-23 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers/core head: 9bc7491906b4113b4c5ae442157c7dfc4e10cd14 commit: 9bc7491906b4113b4c5ae442157c7dfc4e10cd14 [2/2] hrtimer: Prevent stale expiry time in hrtimer_interrupt() reproduce: # apt-get install sparse git checkout

[target:for-next 16/21] drivers/vhost/scsi.c:1081:5: sparse: symbol 'vhost_skip_iovec_bytes' was not declared. Should it be static?

2015-02-01 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next head: 2936f1d4f3e8247bd519feba7892371d5e4c6603 commit: 105acf608f25d5e0d9fef669299a5438b7b114ee [16/21] vhost/scsi: Add ANY_LAYOUT vhost_skip_iovec_bytes helper reproduce: # apt-get install sparse git

[PATCH target] vhost/scsi: vhost_skip_iovec_bytes() can be static

2015-02-01 Thread kbuild test robot
drivers/vhost/scsi.c:1081:5: sparse: symbol 'vhost_skip_iovec_bytes' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- scsi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index

[PATCH dgc-xfs] xfs: xfs_ioctl_setattr_check_extsize can be static

2015-02-01 Thread kbuild test robot
fs/xfs/xfs_ioctl.c:1102:1: sparse: symbol 'xfs_ioctl_setattr_check_extsize' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- xfs_ioctl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c

[dgc-xfs:xfs-ioctl-setattr-cleanup 10/12] fs/xfs/xfs_ioctl.c:1102:1: sparse: symbol 'xfs_ioctl_setattr_check_extsize' was not declared. Should it be static?

2015-02-01 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/dgc/linux-xfs xfs-ioctl-setattr-cleanup head: 9b94fcc39822b450af823b3d8cbef6b53ce87ed9 commit: d4388d3c0988ec00787ad1f8e63b5e2a6abef1dc [10/12] xfs: factor extsize hint checking out of xfs_ioctl_setattr reproduce: # apt-get install sparse

[dgc-xfs:xfs-ioctl-setattr-cleanup 11/12] fs/xfs/xfs_ioctl.c:1146:1: sparse: symbol 'xfs_ioctl_setattr_check_projid' was not declared. Should it be static?

2015-02-01 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/dgc/linux-xfs xfs-ioctl-setattr-cleanup head: 9b94fcc39822b450af823b3d8cbef6b53ce87ed9 commit: 23bd0735cfdf5322170a9ef48c7d47c2e6567ba8 [11/12] xfs: factor projid hint checking out of xfs_ioctl_setattr reproduce: # apt-get install sparse

[PATCH dgc-xfs] xfs: xfs_ioctl_setattr_check_projid can be static

2015-02-01 Thread kbuild test robot
fs/xfs/xfs_ioctl.c:1146:1: sparse: symbol 'xfs_ioctl_setattr_check_projid' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- xfs_ioctl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c

[hch-scsi-queue:scsi-for-3.20 39/42] drivers/scsi/megaraid/megaraid_sas_base.c:1701:6: sparse: symbol 'megasas_complete_outstanding_ioctls' was not declared. Should it be static?

2015-01-09 Thread kbuild test robot
tree: git://git.infradead.org/users/hch/scsi-queue.git scsi-for-3.20 head: 0128d5cf8f85c93b3c70ff03299c2839f3e6d21e commit: c8dd61eff2780c481fcf919c1572e16e397c714e [39/42] megaraid_sas: complete outstanding IOCTLs before killing adapter reproduce: # apt-get install sparse git checkout

[PATCH hch-scsi-queue] megaraid_sas: megasas_complete_outstanding_ioctls() can be static

2015-01-09 Thread kbuild test robot
drivers/scsi/megaraid/megaraid_sas_base.c:1701:6: sparse: symbol 'megasas_complete_outstanding_ioctls' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- megaraid_sas_base.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[net-next:master 62/63] drivers/scsi/csiostor/csio_hw.c:2012:5: sparse: symbol 'csio_hw_prep_fw' was not declared. Should it be static?

2015-01-08 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: fb57720daf6e56ba453414b5e8dd9cb3c0c80257 commit: f40e74ffa3de44f7ef4c09653b070dd115ab7fbe [62/63] csiostor:firmware upgrade fix reproduce: # apt-get install sparse git checkout

[target:nvme_of 3/3] drivers/target/nvme_of/nvme_of_configfs.c:25:31: sparse: symbol 'nvme_of_fabric_configfs' was not declared. Should it be static?

2015-01-06 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git nvme_of head: 40d8c11927282d59855d645b35798edd97828da5 commit: 40d8c11927282d59855d645b35798edd97828da5 [3/3] nvme_of: Initial skeleton commit reproduce: # apt-get install sparse git checkout

[PATCH target] nvme_of: nvme_of_fabric_configfs can be static

2015-01-06 Thread kbuild test robot
drivers/target/nvme_of/nvme_of_configfs.c:25:31: sparse: symbol 'nvme_of_fabric_configfs' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- nvme_of_configfs.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] writeback: fix simple_return.cocci warnings

2015-01-06 Thread kbuild test robot
mm/backing-dev.c:513:1-4: WARNING: end returns can be simpified and declaration on line 502 can be dropped Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci Signed-off-by: Fengguang Wu

[next:master 2818/3104] drivers/usb/gadget/function/f_uvc.c:816:41: sparse: incorrect type in assignment (different base types)

2015-01-13 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 8fb4ab29bd8400e0060662208573d26b9d91656d commit: 46919a23ee87bbc4eeb6d958471174e26836f0e1 [2818/3104] usb: gadget: uvc: configfs support in uvc function reproduce: # apt-get install sparse git checkout

[PATCH next] usb: gadget: uvc: to_uvcg_control_header() can be static

2015-01-13 Thread kbuild test robot
drivers/usb/gadget/function/uvc_configfs.c:46:28: sparse: symbol 'to_uvcg_control_header' was not declared. Should it be static? drivers/usb/gadget/function/uvc_configfs.c:138:25: sparse: symbol 'uvcg_control_header_type' was not declared. Should it be static?

[drm-intel:drm-intel-next-queued 161/168] drivers/gpu/drm/i915/intel_ringbuffer.c:505:6: sparse: symbol 'intel_ring_setup_status_page' was not declared. Should it be static?

2015-02-11 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued head: db275e69533f74b3d5cf2884cb8bba9d7640724d commit: 64a008c61c4615ba0fffd1cdae7d39b4246048f8 [161/168] drm/i915: Make intel_ring_setup_status_page() static reproduce: # apt-get install sparse git checkout

  1   2   3   4   5   6   7   8   9   10   >